tomcat7.0
15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49991
markt [Tue, 19 Oct 2010 20:27:39 +0000 (20:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49991
Ensure servlet request listeners are fired for the login and error pages during FORM authentication.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024397 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factor ServletRequestListener events with an eye to https://issues.apache.org...
markt [Tue, 19 Oct 2010 19:52:28 +0000 (19:52 +0000)]
Re-factor ServletRequestListener events with an eye to https://issues.apache.org/bugzilla/show_bug.cgi?id=49991 and any possible future changes in the Servlet spec

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024381 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMinor clean-up
markt [Tue, 19 Oct 2010 18:51:44 +0000 (18:51 +0000)]
Minor clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024355 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
markt [Tue, 19 Oct 2010 14:50:14 +0000 (14:50 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50084
Handle the case where the PID file is readable/writeable but the directory is not

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024251 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix indents
markt [Tue, 19 Oct 2010 14:46:02 +0000 (14:46 +0000)]
Fix indents

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024250 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49297
markt [Tue, 19 Oct 2010 13:21:05 +0000 (13:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49297
Enforce the rules in the JSP specification for parsing the attributes of custom and standard actions that require that the attribute names are unique within an element and that there is whitespace before the attribute name. The whitespace test can be disabled by setting the system property <code>org.apache.jasper.compiler.Parser.STRICT_WHITESPACE</code> to <code>false</code>

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024229 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50107
markt [Tue, 19 Oct 2010 13:14:13 +0000 (13:14 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50107
When removing a Host via JMX, do not attempt to destroy the host's pipeline twice.
Patch provided by Eiji Takahashi.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024228 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake private
markt [Tue, 19 Oct 2010 13:08:05 +0000 (13:08 +0000)]
Make private

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024227 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused imports
markt [Tue, 19 Oct 2010 13:06:59 +0000 (13:06 +0000)]
Remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024226 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50105
markt [Tue, 19 Oct 2010 13:03:01 +0000 (13:03 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50105
Use Enum.name() rather than Enum.toString() in composite expressions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1024224 13f79535-47bb-0310-9956-ffa450edef68

15 years agoComment typo
markt [Mon, 18 Oct 2010 07:53:04 +0000 (07:53 +0000)]
Comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1023678 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=22965
markt [Sat, 16 Oct 2010 20:21:36 +0000 (20:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=22965
Typos, formatting, etc
Based on a patch by Yann Cébron

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1023373 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate
markt [Sat, 16 Oct 2010 19:55:25 +0000 (19:55 +0000)]
Update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1023368 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMessages displayed to the user in the Host Manager (text and HTML) should be based...
markt [Sat, 16 Oct 2010 19:54:44 +0000 (19:54 +0000)]
Messages displayed to the user in the Host Manager (text and HTML) should be based on the Locale of the user, not the server

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1023366 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate
markt [Sat, 16 Oct 2010 19:38:58 +0000 (19:38 +0000)]
Update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1023363 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49426
markt [Sat, 16 Oct 2010 19:31:37 +0000 (19:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49426
Messages displayed to the user in the Manager (text and HTML) should be based on the Locale of the user, not the server

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1023361 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Javadoc warnings
markt [Thu, 14 Oct 2010 20:33:14 +0000 (20:33 +0000)]
Fix Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022695 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBump version
markt [Thu, 14 Oct 2010 20:28:50 +0000 (20:28 +0000)]
Bump version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022694 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate
markt [Thu, 14 Oct 2010 17:41:26 +0000 (17:41 +0000)]
Update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022626 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEnhance fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50078
markt [Thu, 14 Oct 2010 17:37:20 +0000 (17:37 +0000)]
Enhance fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50078
Make cache sizes configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022623 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50078
markt [Thu, 14 Oct 2010 16:36:20 +0000 (16:36 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50078
Thread safety in EL caches. Patch provided by  Takayoshi Kimura

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022606 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50087
markt [Thu, 14 Oct 2010 16:05:55 +0000 (16:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50087
Catch ClassFormatErrors when scanning for annotations.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022593 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid NPE triggered when running TCK tests
markt [Thu, 14 Oct 2010 12:11:51 +0000 (12:11 +0000)]
Avoid NPE triggered when running TCK tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022478 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTypo
markt [Thu, 14 Oct 2010 10:46:47 +0000 (10:46 +0000)]
Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022462 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd some more info on CSRF protection for the manager and host manager applications
markt [Thu, 14 Oct 2010 09:22:54 +0000 (09:22 +0000)]
Add some more info on CSRF protection for the manager and host manager applications

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022441 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove recycling of processors in Http11NioProtocol
kkolinko [Thu, 14 Oct 2010 08:32:59 +0000 (08:32 +0000)]
Improve recycling of processors in Http11NioProtocol

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022415 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFollowup to r946230
kkolinko [Thu, 14 Oct 2010 07:06:01 +0000 (07:06 +0000)]
Followup to r946230
Do not fine-format integer values in debug output.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022389 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFollowup to r1022303
kkolinko [Wed, 13 Oct 2010 23:25:47 +0000 (23:25 +0000)]
Followup to r1022303
I think that releasing the socket should be done before passing it away to a poller.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022323 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix warnings
markt [Wed, 13 Oct 2010 22:03:42 +0000 (22:03 +0000)]
Fix warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022307 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTesting in 6.0.x confirmed this is the same issue.
markt [Wed, 13 Oct 2010 21:57:46 +0000 (21:57 +0000)]
Testing in 6.0.x confirmed this is the same issue.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022304 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter clean-up.
markt [Wed, 13 Oct 2010 21:54:28 +0000 (21:54 +0000)]
Better clean-up.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022303 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate change-log
markt [Wed, 13 Oct 2010 21:19:17 +0000 (21:19 +0000)]
Update change-log

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022294 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix reading the request line via NIO for slow clients (such as me typing via telnet...
markt [Wed, 13 Oct 2010 21:16:33 +0000 (21:16 +0000)]
Fix reading the request line via NIO for slow clients (such as me typing via telnet). Need to treat each section of the request line (text or space) as a separate phase.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022293 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd changelog entry for r1022120
kkolinko [Wed, 13 Oct 2010 15:30:39 +0000 (15:30 +0000)]
Add changelog entry for r1022120

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022143 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid unnecessary cast
markt [Wed, 13 Oct 2010 15:16:35 +0000 (15:16 +0000)]
Avoid unnecessary cast

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022134 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTypo
markt [Wed, 13 Oct 2010 15:02:32 +0000 (15:02 +0000)]
Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022125 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-implement the fix for
kkolinko [Wed, 13 Oct 2010 14:55:27 +0000 (14:55 +0000)]
Re-implement the fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022120 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r964780 that was a fix for
kkolinko [Wed, 13 Oct 2010 14:03:23 +0000 (14:03 +0000)]
Revert r964780 that was a fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428

See Re:r964780 thread on dev@ or TC 6.0 STATUS file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022109 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49922
markt [Wed, 13 Oct 2010 11:10:30 +0000 (11:10 +0000)]
Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49922
Revert my approach and go with patch suggested by heyoulin.
Extend test cases

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1022068 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRestore credits removed by r1003846
kkolinko [Tue, 12 Oct 2010 14:57:12 +0000 (14:57 +0000)]
Restore credits removed by r1003846

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1021788 13f79535-47bb-0310-9956-ffa450edef68

15 years agoStop async requests hanging - side effect of r1006358
markt [Tue, 12 Oct 2010 14:09:59 +0000 (14:09 +0000)]
Stop async requests hanging - side effect of r1006358

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1021780 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50044 for NIO connector
markt [Tue, 12 Oct 2010 12:10:43 +0000 (12:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50044 for NIO connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1021753 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50044 for APR connector
markt [Sun, 10 Oct 2010 22:10:27 +0000 (22:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50044 for APR connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006358 13f79535-47bb-0310-9956-ffa450edef68

15 years agoOnly call asyncPostProcess for async requests
markt [Sun, 10 Oct 2010 19:14:13 +0000 (19:14 +0000)]
Only call asyncPostProcess for async requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006341 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50066
markt [Sun, 10 Oct 2010 18:16:00 +0000 (18:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50066
Fix building of recursive tag files when the file depends on a JAR file. Patch provided by Sylvain Laurent.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006330 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove error handling in TLD processing and handle the case when there is no web.xml
markt [Sun, 10 Oct 2010 18:09:43 +0000 (18:09 +0000)]
Improve error handling in TLD processing and handle the case when there is no web.xml

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006329 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50063
markt [Sun, 10 Oct 2010 09:58:24 +0000 (09:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50063
Fix apps with meta-data complete returning 404s

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006265 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50027
markt [Fri, 8 Oct 2010 21:46:05 +0000 (21:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50027
Avoid NPE on start when a Context is defined in server.xml with one or more JNDI resources.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006037 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50059
markt [Fri, 8 Oct 2010 21:37:19 +0000 (21:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50059
Always make JAR resources available

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1006033 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50017
markt [Fri, 8 Oct 2010 14:16:23 +0000 (14:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50017
Code clean-up. No functional change.
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005837 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50016
markt [Fri, 8 Oct 2010 14:02:05 +0000 (14:02 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50016
Re-factor isUserInRole() and login() / logout() methods to support JACC implementations and to improve encapsulation.
Patch provided by David Jencks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005834 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50015
markt [Fri, 8 Oct 2010 13:22:04 +0000 (13:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50015
Re-factor dynamic servlet security implementation to make extensions, such as JACC implementations, simpler. Patch provided by David Jencks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005811 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48716
markt [Fri, 8 Oct 2010 12:21:55 +0000 (12:21 +0000)]
Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48716
Don't call reset if the default LngManager is in use

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005802 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50013
markt [Fri, 8 Oct 2010 12:10:28 +0000 (12:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50013
Correctly package classes from org.apache.tomcat.util.file and add the tomcat-util.jar to the class path for the Ant tasks. Based on a patch provided by Sylvain Laurent.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005795 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate change log
markt [Fri, 8 Oct 2010 11:59:22 +0000 (11:59 +0000)]
Update change log

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005792 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd test cases for:
markt [Fri, 8 Oct 2010 11:57:57 +0000 (11:57 +0000)]
Add test cases for:
- https://issues.apache.org/bugzilla/show_bug.cgi?id=49994
- https://issues.apache.org/bugzilla/show_bug.cgi?id=23950
Based on the original test case for bug 23950 provided by Eli Miller

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005790 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49994
markt [Fri, 8 Oct 2010 11:57:04 +0000 (11:57 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49994
Lookup of JNDI references should return a new object instance each time

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005789 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMinor fixes to DefaultServlet docs
timw [Fri, 8 Oct 2010 08:11:24 +0000 (08:11 +0000)]
Minor fixes to DefaultServlet docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005722 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
markt [Thu, 7 Oct 2010 21:53:55 +0000 (21:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
Fix thread safety issue with population of servlet context initialization parameters.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005647 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some failing tests. No regression in Tomcat/Jasper, just need to take account...
markt [Thu, 7 Oct 2010 15:33:46 +0000 (15:33 +0000)]
Fix some failing tests. No regression in Tomcat/Jasper, just need to take account of changes in test framework.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005493 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some failing tests. No regression in Tomcat/Jasper, just need to take account...
markt [Thu, 7 Oct 2010 15:12:21 +0000 (15:12 +0000)]
Fix some failing tests. No regression in Tomcat/Jasper, just need to take account of changes in test framework.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005486 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd latest fix
markt [Thu, 7 Oct 2010 14:35:27 +0000 (14:35 +0000)]
Add latest fix

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005468 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49986
markt [Thu, 7 Oct 2010 14:34:29 +0000 (14:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49986
Thread safety issues in JSP reload process. (timw)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005467 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix warnings
markt [Thu, 7 Oct 2010 14:32:29 +0000 (14:32 +0000)]
Fix warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005465 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd bug reference - looks like this one was reported and fixed independently.
markt [Thu, 7 Oct 2010 14:25:43 +0000 (14:25 +0000)]
Add bug reference - looks like this one was reported and fixed independently.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005461 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCouple of updates.
markt [Thu, 7 Oct 2010 14:21:55 +0000 (14:21 +0000)]
Couple of updates.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005459 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix import order
markt [Thu, 7 Oct 2010 14:21:11 +0000 (14:21 +0000)]
Fix import order

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005458 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49978
markt [Thu, 7 Oct 2010 14:13:44 +0000 (14:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49978
Don't try to create directories that already exist

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005457 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
markt [Thu, 7 Oct 2010 14:05:51 +0000 (14:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49972
Address potential thread safety issues.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005452 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSet not maxThreads but minSpareThreads to corePoolSize, if AbstractEndpoint.setMinSp...
kfujino [Thu, 7 Oct 2010 09:19:00 +0000 (09:19 +0000)]
Set not maxThreads  but minSpareThreads to corePoolSize, if AbstractEndpoint.setMinSpareThreads is called.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005379 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50054
kfujino [Thu, 7 Oct 2010 08:54:51 +0000 (08:54 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50054
Correctly handle the setting of minSpareThreads in AJP connector.
Other attributes (acceptorThreadCount etc.) are correctly set by this fix.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005367 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSetting native line encoding.
timw [Thu, 7 Oct 2010 00:53:21 +0000 (00:53 +0000)]
Setting native line encoding.
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005309 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdding license headers.
timw [Thu, 7 Oct 2010 00:50:28 +0000 (00:50 +0000)]
Adding license headers.
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005308 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49957
markt [Wed, 6 Oct 2010 22:54:13 +0000 (22:54 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49957
Correct regression due to Lifecycle re-factoring that cleared all work directories (with compiled JSPs and persisted sessions) when Tomcat was stopped.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005284 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49956
markt [Wed, 6 Oct 2010 21:58:37 +0000 (21:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49956
Handle case when @Resource annotation uses the full JNDI name for a resource.
Based on a patch by Gurkan Erdogdu.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005271 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix indent
markt [Wed, 6 Oct 2010 21:51:27 +0000 (21:51 +0000)]
Fix indent

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005269 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWhitespace police
markt [Wed, 6 Oct 2010 21:50:10 +0000 (21:50 +0000)]
Whitespace police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005267 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix comment typo
markt [Wed, 6 Oct 2010 21:47:27 +0000 (21:47 +0000)]
Fix comment typo
Better error message when a SCL can not be added since the listeners have already been called.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005266 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49952
markt [Wed, 6 Oct 2010 21:46:43 +0000 (21:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49952
Allow ServletContainerInitializers to add listeners to a web application.
Patch provided by David Jencks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005265 13f79535-47bb-0310-9956-ffa450edef68

15 years ago7.0.3 not released. Missing license header in src file.
markt [Wed, 6 Oct 2010 21:25:23 +0000 (21:25 +0000)]
7.0.3 not released. Missing license header in src file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005259 13f79535-47bb-0310-9956-ffa450edef68

15 years agoColleague at $work reported issues path parameters and extension mapping so add some...
markt [Wed, 6 Oct 2010 15:09:37 +0000 (15:09 +0000)]
Colleague at $work reported issues path parameters and extension mapping so add some tests. Looks OK.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1005076 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdding unit tests for DefaultServlet and WebdavServlet to test basic serving/mounting...
timw [Wed, 6 Oct 2010 08:37:56 +0000 (08:37 +0000)]
Adding unit tests for DefaultServlet and WebdavServlet to test basic serving/mounting behaviour and protection of special paths

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004928 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMaking TomcatBaseTest.getUrl() work for get requests that return 404 responses
timw [Wed, 6 Oct 2010 08:36:20 +0000 (08:36 +0000)]
Making TomcatBaseTest.getUrl() work for get requests that return 404 responses

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004927 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrecting JavaDoc for HTTP methods.
timw [Wed, 6 Oct 2010 07:24:46 +0000 (07:24 +0000)]
Correcting JavaDoc for HTTP methods.
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004914 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=50026
timw [Wed, 6 Oct 2010 07:22:46 +0000 (07:22 +0000)]
More fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=50026
Calculating complete resource path when accessed via RequestDispatcher.include()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004912 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove @SuppressWarnings that is no more needed
kkolinko [Wed, 6 Oct 2010 01:06:27 +0000 (01:06 +0000)]
Remove @SuppressWarnings that is no more needed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004869 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAmending the fix for
kkolinko [Wed, 6 Oct 2010 01:03:29 +0000 (01:03 +0000)]
Amending the fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49669
Do not depend on the deprecated class. Use reflection instead.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004868 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTurn the commented out test code into a unit test.
markt [Tue, 5 Oct 2010 15:32:41 +0000 (15:32 +0000)]
Turn the commented out test code into a unit test.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004671 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSimplify. Path is stored in MapElement.name
markt [Tue, 5 Oct 2010 14:43:26 +0000 (14:43 +0000)]
Simplify. Path is stored in MapElement.name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004657 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake sure copyright year is replaced for root webapp
markt [Tue, 5 Oct 2010 08:00:08 +0000 (08:00 +0000)]
Make sure copyright year is replaced for root webapp

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004564 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake sure copyright year is replaced for root webapp
markt [Tue, 5 Oct 2010 07:55:04 +0000 (07:55 +0000)]
Make sure copyright year is replaced for root webapp

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004562 13f79535-47bb-0310-9956-ffa450edef68

15 years agotypo
markt [Tue, 5 Oct 2010 07:45:04 +0000 (07:45 +0000)]
typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004555 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect fix fot 49669
markt [Tue, 5 Oct 2010 07:30:54 +0000 (07:30 +0000)]
Correct fix fot 49669

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004550 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdating changelog with fix for https://issues.apache.org/bugzilla/show_bug.cgi?id...
timw [Tue, 5 Oct 2010 02:57:25 +0000 (02:57 +0000)]
Updating changelog with fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50026

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004513 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd missing AL2 header
markt [Mon, 4 Oct 2010 22:00:38 +0000 (22:00 +0000)]
Add missing AL2 header

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004449 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49945
markt [Mon, 4 Oct 2010 21:24:55 +0000 (21:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49945
More JMX improvements.
Patch provided by Chamith Buddhika.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004437 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=50026
timw [Mon, 4 Oct 2010 20:37:11 +0000 (20:37 +0000)]
More fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=50026
Calculating path prefix used in listings correctly so links in listings produced by WebdavServlet mounted to a subpath are correct.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004415 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 for WebdavServlet
timw [Mon, 4 Oct 2010 20:33:57 +0000 (20:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 for WebdavServlet
Factored checking of special WEB-INF and META-INF paths into service to trap requests for GET methods handled by DefaultServlet (which does not check access).
Retained checking of special paths in handlers for copy, delete, move (copy + delete), and in enumeration of resources (propfind).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004409 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50026
timw [Mon, 4 Oct 2010 20:19:09 +0000 (20:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50026
Always calculate path of resource to be served relative to the context root.
This invokes the standard protection of WEB-INF and META-INF directories.
This is a breaking change for the unofficial use of DefaultServlet to remount the webapp base under a new path.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004393 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReduce code duplication. Convert file names to a context path in a single method.
markt [Mon, 4 Oct 2010 14:50:41 +0000 (14:50 +0000)]
Reduce code duplication. Convert file names to a context path in a single method.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1004269 13f79535-47bb-0310-9956-ffa450edef68