tomcat7.0
15 years agoMark 'basePackage' as final, to allow string concatenation to be done at compile...
kkolinko [Sun, 5 Dec 2010 18:22:25 +0000 (18:22 +0000)]
Mark 'basePackage' as final, to allow string concatenation to be done at compile time.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042395 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIgnore all .* files rather than adding them one by one as they appear
markt [Sun, 5 Dec 2010 12:51:46 +0000 (12:51 +0000)]
Ignore all .* files rather than adding them one by one as they appear

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042339 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove file accidentally added in r1042029
markt [Sun, 5 Dec 2010 12:49:22 +0000 (12:49 +0000)]
Remove file accidentally added in r1042029

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042337 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 50282 : Load javax.security.auth.login.Configuration with JreMemoryLeakPrevention...
slaurent [Fri, 3 Dec 2010 22:19:11 +0000 (22:19 +0000)]
bug 50282 : Load javax.security.auth.login.Configuration with JreMemoryLeakPreventionListener to avoid memory leak when stopping a webapp that would use JAAS.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042029 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 48973 (enhancement): Don't create SESSIONS.ser when no session exists
slaurent [Fri, 3 Dec 2010 22:00:58 +0000 (22:00 +0000)]
bug 48973 (enhancement): Don't create SESSIONS.ser when no session exists
https://issues.apache.org/bugzilla/show_bug.cgi?id=48973

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042022 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50408
markt [Fri, 3 Dec 2010 21:49:54 +0000 (21:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50408
Fix <code>NoSuchMethodException</code> when using scoped variables with EL method invocation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042021 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNeed at least one test per class dummy test for unit tests to pass
markt [Fri, 3 Dec 2010 20:23:43 +0000 (20:23 +0000)]
Need at least one test per class dummy test for unit tests to pass

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041978 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r1041120 but disable rather than delete new test
markt [Fri, 3 Dec 2010 18:07:52 +0000 (18:07 +0000)]
Revert r1041120 but disable rather than delete new test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041940 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFixed bug 48692: Provide option to parse application/x-www-form-urlencoded PUT requests
schultz [Fri, 3 Dec 2010 16:07:50 +0000 (16:07 +0000)]
Fixed bug 48692: Provide option to parse application/x-www-form-urlencoded PUT requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041892 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBump versions ready for next release
markt [Thu, 2 Dec 2010 22:37:53 +0000 (22:37 +0000)]
Bump versions ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041621 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=8705
markt [Thu, 2 Dec 2010 20:48:41 +0000 (20:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=8705
org.apache.catalina.SessionListener should extend java.util.EventListener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041578 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd an embedded distribution to the release build
markt [Thu, 2 Dec 2010 20:35:15 +0000 (20:35 +0000)]
Add an embedded distribution to the release build

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041573 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Javadoc warning
markt [Thu, 2 Dec 2010 20:03:22 +0000 (20:03 +0000)]
Fix Javadoc warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041558 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReplace use of inefficient constructors
markt [Thu, 2 Dec 2010 18:17:55 +0000 (18:17 +0000)]
Replace use of inefficient constructors
Reported by FindBugs. Not all fixed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041511 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unnecessary code
markt [Thu, 2 Dec 2010 17:25:45 +0000 (17:25 +0000)]
Remove unnecessary code
Identified by FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041475 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't pass null to log messages.
markt [Thu, 2 Dec 2010 17:15:08 +0000 (17:15 +0000)]
Don't pass null to log messages.
Found by FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041469 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProtect against unlikely NPE
markt [Thu, 2 Dec 2010 17:07:07 +0000 (17:07 +0000)]
Protect against unlikely NPE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041458 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect removal of LifeCycleListenters from Containers via JMX.
markt [Thu, 2 Dec 2010 16:51:08 +0000 (16:51 +0000)]
Correct removal of LifeCycleListenters from Containers via JMX.
Found with FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041448 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter test case
markt [Thu, 2 Dec 2010 16:09:45 +0000 (16:09 +0000)]
Better test case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041427 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix error in r1041356
markt [Thu, 2 Dec 2010 16:07:10 +0000 (16:07 +0000)]
Fix error in r1041356

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041425 13f79535-47bb-0310-9956-ffa450edef68

15 years agoHostConfig passed a context name to ContextName(String) - ensure that this is correct...
markt [Thu, 2 Dec 2010 12:56:56 +0000 (12:56 +0000)]
HostConfig passed a context name to ContextName(String) - ensure that this is correctly parsed. ContextName(String) now accepts all variations of Context name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041356 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake constants static
markt [Thu, 2 Dec 2010 10:30:17 +0000 (10:30 +0000)]
Make constants static

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041324 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMove changelog comment for BZ 50228 from Catalina to Jasper.
kkolinko [Thu, 2 Dec 2010 01:40:55 +0000 (01:40 +0000)]
Move changelog comment for BZ 50228 from Catalina to Jasper.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041248 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert part of r1039051
markt [Wed, 1 Dec 2010 19:00:53 +0000 (19:00 +0000)]
Revert part of r1039051
Current node is not included in cluster.getMmebers() so previous test was correct

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041133 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 1 Dec 2010 18:37:29 +0000 (18:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Bind/release socket on start()/stop()
Register/deregister MBeans on init()/destroy()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041120 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police
markt [Wed, 1 Dec 2010 17:43:25 +0000 (17:43 +0000)]
Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041101 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo (syntax error) in changelog.
rjung [Wed, 1 Dec 2010 16:25:34 +0000 (16:25 +0000)]
Fix typo (syntax error) in changelog.
Should also fix recent buildbot failure.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041074 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't put anything in current dev since it will be picked up in the tag and could...
markt [Wed, 1 Dec 2010 15:41:45 +0000 (15:41 +0000)]
Don't put anything in current dev since it will be picked up in the tag and could cause confusion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041061 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate release dates
markt [Wed, 1 Dec 2010 15:41:01 +0000 (15:41 +0000)]
Update release dates

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041060 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't set property that doesn't exist on any ProtocolHandler or Endpoint
markt [Tue, 30 Nov 2010 17:55:38 +0000 (17:55 +0000)]
Don't set property that doesn't exist on any ProtocolHandler or Endpoint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040656 13f79535-47bb-0310-9956-ffa450edef68

15 years agoContext name rather than Context path is passed in so construct ContextName object...
markt [Tue, 30 Nov 2010 17:42:01 +0000 (17:42 +0000)]
Context name rather than Context path is passed in so construct ContextName object correctly.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040652 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSwitch MapperListener to the new Lifecycle
markt [Tue, 30 Nov 2010 16:11:23 +0000 (16:11 +0000)]
Switch MapperListener to the new Lifecycle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040609 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo in script comment.
rjung [Tue, 30 Nov 2010 14:58:07 +0000 (14:58 +0000)]
Fix typo in script comment.
BZ 50383, addition to r1040546.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040553 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50383
markt [Tue, 30 Nov 2010 14:47:34 +0000 (14:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50383
Comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040546 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlign tests with new ManagerBase code
markt [Tue, 30 Nov 2010 13:41:09 +0000 (13:41 +0000)]
Align tests with new ManagerBase code
Update OSX figures - now comparable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040516 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove direct support for reading random bytes from a file
markt [Tue, 30 Nov 2010 13:15:51 +0000 (13:15 +0000)]
Remove direct support for reading random bytes from a file
Add support for specifying SecureRandom algorithm and provider

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040511 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdated Windows results (removal of digest)
markt [Tue, 30 Nov 2010 10:19:38 +0000 (10:19 +0000)]
Updated Windows results (removal of digest)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040456 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSecureRandom implementations are self-seeding so simplify code.
markt [Tue, 30 Nov 2010 10:18:41 +0000 (10:18 +0000)]
SecureRandom implementations are self-seeding so simplify code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040455 13f79535-47bb-0310-9956-ffa450edef68

15 years agorandomClass -> secureRandomClass
markt [Tue, 30 Nov 2010 10:02:33 +0000 (10:02 +0000)]
randomClass -> secureRandomClass
Align (and tidy up) mbean descriptor

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040453 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNeed required attribute or docs don't display correctly
markt [Tue, 30 Nov 2010 10:00:37 +0000 (10:00 +0000)]
Need required attribute or docs don't display correctly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040452 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Javadoc warnings
markt [Tue, 30 Nov 2010 09:35:01 +0000 (09:35 +0000)]
Fix Javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040450 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd css to text file list.
rjung [Mon, 29 Nov 2010 17:32:21 +0000 (17:32 +0000)]
Add css to text file list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040199 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSet svn properties.
rjung [Mon, 29 Nov 2010 17:31:18 +0000 (17:31 +0000)]
Set svn properties.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040198 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect method names in log messages
markt [Mon, 29 Nov 2010 17:23:55 +0000 (17:23 +0000)]
Correct method names in log messages

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040196 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=50352
markt [Mon, 29 Nov 2010 16:58:31 +0000 (16:58 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=50352

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040190 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50352
markt [Mon, 29 Nov 2010 16:58:05 +0000 (16:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50352
Ensure that AsyncListener.onComplete() is fired when AsyncContext.complete() is called.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040189 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect method name in log message
markt [Mon, 29 Nov 2010 15:46:13 +0000 (15:46 +0000)]
Correct method name in log message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040161 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=50351
markt [Mon, 29 Nov 2010 15:40:11 +0000 (15:40 +0000)]
Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=50351

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040158 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50351
markt [Mon, 29 Nov 2010 15:39:50 +0000 (15:39 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50351
Fix the regression that broke BeanFactory resources caused by the previous fix for 50159

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040157 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50358
markt [Mon, 29 Nov 2010 13:41:07 +0000 (13:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50358
Set correct state when stopping

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040111 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSecureRandom is self-seeding
markt [Sun, 28 Nov 2010 13:31:39 +0000 (13:31 +0000)]
SecureRandom is self-seeding

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039882 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake SecureRandom the fall-back and use SecureRandom throughout rather than Random
markt [Sat, 27 Nov 2010 17:05:27 +0000 (17:05 +0000)]
Make SecureRandom the fall-back and use SecureRandom throughout rather than Random

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039707 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a /dev/urandom vs SecureRandom benchmark
markt [Sat, 27 Nov 2010 14:50:37 +0000 (14:50 +0000)]
Add a /dev/urandom vs SecureRandom benchmark

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039692 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate so this will run
markt [Sat, 27 Nov 2010 13:52:13 +0000 (13:52 +0000)]
Update so this will run

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039683 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove attributes from PersistentManager too
markt [Sat, 27 Nov 2010 13:47:03 +0000 (13:47 +0000)]
Remove attributes from PersistentManager too

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039680 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDrop the entropy attribute. SecureRandom has a sufficiently secure self-seeding mecha...
markt [Sat, 27 Nov 2010 11:41:10 +0000 (11:41 +0000)]
Drop the entropy attribute. SecureRandom has a sufficiently secure self-seeding mechanism.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039657 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUsing SecureRandom makes digesting the ID unnecessary. Dropping the digest gives...
markt [Sat, 27 Nov 2010 10:41:26 +0000 (10:41 +0000)]
Using SecureRandom makes digesting the ID unnecessary. Dropping the digest gives ~20% performance gain on ID generation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039648 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake method name consistent with class name
markt [Thu, 25 Nov 2010 14:21:52 +0000 (14:21 +0000)]
Make method name consistent with class name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039056 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix a couple of clustering issues:
markt [Thu, 25 Nov 2010 14:12:24 +0000 (14:12 +0000)]
Fix a couple of clustering issues:
 - Don't try and obtain session data from the cluster if the current node is the only node in the cluster.
 - Log requesting session data as INFO rather than WARNING.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1039051 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrectly validate context path so sessions can be viewed for ROOT webapp
markt [Thu, 25 Nov 2010 10:19:33 +0000 (10:19 +0000)]
Correctly validate context path so sessions can be viewed for ROOT webapp

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038981 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate changelog
markt [Thu, 25 Nov 2010 10:10:31 +0000 (10:10 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038978 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't use pid file. It is not removed on service stop and prevents the next service...
markt [Thu, 25 Nov 2010 10:05:02 +0000 (10:05 +0000)]
Don't use pid file. It is not removed on service stop and prevents the next service start.
https://issues.apache.org/jira/browse/DAEMON-188 has been raised for this issue.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038975 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49142
markt [Wed, 24 Nov 2010 22:08:38 +0000 (22:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49142
Add missing serialVersionUIDs using Eclipse's auto correct and a little manual formatting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038846 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48837
markt [Wed, 24 Nov 2010 21:28:33 +0000 (21:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48837
Extend thread local memory leak detection to include classes loaded by subordinate class loaders to the web application's class loader such as the Jasper class loader.
Based on a patch by Sylvain Laurent.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038831 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMove to Catalina section
markt [Wed, 24 Nov 2010 20:55:02 +0000 (20:55 +0000)]
Move to Catalina section

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038811 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50106
markt [Wed, 24 Nov 2010 20:54:21 +0000 (20:54 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50106
Correct several MBean descriptors.
Patch provided by Eiji Takahashi.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038810 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49650
markt [Wed, 24 Nov 2010 20:33:49 +0000 (20:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49650
Remove unnecessary entries package.access property defined in catalina.properties.
Patch provided by Owen Farrell.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038803 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50108
markt [Wed, 24 Nov 2010 20:16:32 +0000 (20:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50108
Add get/set methods for Connector property minSpareThreads.
Patch provided by Eiji Takahashi.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038799 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd additional trace level logging to Tribes to assist with fault diagnosis.
markt [Wed, 24 Nov 2010 20:09:26 +0000 (20:09 +0000)]
Add additional trace level logging to Tribes to assist with fault diagnosis.
Based on a patch by Ariel.
Fix Eclipse warnings in file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038795 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50294
markt [Wed, 24 Nov 2010 19:59:19 +0000 (19:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50294
Add more information to documentation regarding format of configuration files. Patch provided by Luke Meyer.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038789 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIncrement version number ready for next release
markt [Wed, 24 Nov 2010 18:52:34 +0000 (18:52 +0000)]
Increment version number ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038762 13f79535-47bb-0310-9956-ffa450edef68

15 years agohost.removeChild() already calls context.destroy(). Don't call it twice.
markt [Wed, 24 Nov 2010 17:36:28 +0000 (17:36 +0000)]
host.removeChild() already calls context.destroy(). Don't call it twice.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038713 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
markt [Wed, 24 Nov 2010 17:28:55 +0000 (17:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
Track changes that require an update to the default access log.
It isn't perfect but should cover normal usage

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038711 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't swallow error
markt [Wed, 24 Nov 2010 15:58:46 +0000 (15:58 +0000)]
Don't swallow error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038656 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNoOp logger is only used in StandardEngine so move it there
markt [Tue, 23 Nov 2010 22:48:21 +0000 (22:48 +0000)]
NoOp logger is only used in StandardEngine so move it there
Only log to containers that are available

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038369 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMove configuration of trailer header size limit to the connector
markt [Tue, 23 Nov 2010 21:45:56 +0000 (21:45 +0000)]
Move configuration of trailer header size limit to the connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038351 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a test case for bug50015
markt [Tue, 23 Nov 2010 19:21:09 +0000 (19:21 +0000)]
Add a test case for bug50015

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038290 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRoles are supported
markt [Tue, 23 Nov 2010 19:20:42 +0000 (19:20 +0000)]
Roles are supported

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038289 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50318
markt [Tue, 23 Nov 2010 17:59:49 +0000 (17:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50318
Avoid NPE when viewing session detail for expired sessions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038235 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50207
markt [Tue, 23 Nov 2010 16:57:47 +0000 (16:57 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50207

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038202 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake memory leak prevention code that clears ThreadLocal instances more robust agains...
markt [Tue, 23 Nov 2010 10:38:40 +0000 (10:38 +0000)]
Make memory leak prevention code that clears ThreadLocal instances more robust against objects with toString() methods that throw exceptions.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1038041 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove border-radius.htc until issue with this file is clarified.
kkolinko [Mon, 22 Nov 2010 22:54:51 +0000 (22:54 +0000)]
Remove border-radius.htc until issue with this file is clarified.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037929 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImpose a limit on the total length of the trailing headers.
kkolinko [Mon, 22 Nov 2010 22:43:51 +0000 (22:43 +0000)]
Impose a limit on the total length of the trailing headers.
Otherwise the ByteChunk buffer in the ChunkedInputFilter might grow unlimitedly.

Implemented as a system property. It might be better to implement it as an attribute of a connector (like maxPostSize and maxSavePostSize attributes are), but I am not sure that it is worth the effort.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037924 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50316
kkolinko [Mon, 22 Nov 2010 20:59:20 +0000 (20:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50316
Fix display of negative values

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037887 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50228
kkolinko [Mon, 22 Nov 2010 17:40:09 +0000 (17:40 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50228
Improve recycling of BodyContentImpl.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037794 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix CVE-2010-4172. Multiple XSS in Manager web application
markt [Mon, 22 Nov 2010 17:19:07 +0000 (17:19 +0000)]
Fix CVE-2010-4172. Multiple XSS in Manager web application

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037778 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50308
markt [Mon, 22 Nov 2010 14:35:51 +0000 (14:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50308
Allow asynchronous request processing to call AsyncContext.dispatch() once the asynchronous request has timed out.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037735 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional info for https://issues.apache.org/bugzilla/show_bug.cgi?id=50273
markt [Mon, 22 Nov 2010 14:12:05 +0000 (14:12 +0000)]
Additional info for https://issues.apache.org/bugzilla/show_bug.cgi?id=50273
Add the error number to the message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037728 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50273
markt [Mon, 22 Nov 2010 13:42:01 +0000 (13:42 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50273
Provide a workaround for an HP-UX issue that can result in large numbers of SEVERE log messages appearing in the logs as a result of normal operation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037715 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50310
markt [Mon, 22 Nov 2010 11:49:05 +0000 (11:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50310
Ensure Servlet info is displayed in Manager application

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037683 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate docs to new MBean names
markt [Mon, 22 Nov 2010 11:46:46 +0000 (11:46 +0000)]
Update docs to new MBean names

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037682 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse correct MBean name for Mangers
markt [Mon, 22 Nov 2010 11:45:57 +0000 (11:45 +0000)]
Use correct MBean name for Mangers
Fix Eclipse niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037681 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEnsure MBean names are correct generated for version ROOT web applications.
markt [Mon, 22 Nov 2010 11:41:34 +0000 (11:41 +0000)]
Ensure MBean names are correct generated for version ROOT web applications.
Fix ContextResource case that was using old path=... rather than new context=...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037677 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd recent HTML manager app fixes
markt [Mon, 22 Nov 2010 11:05:28 +0000 (11:05 +0000)]
Add recent HTML manager app fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037669 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix manager app - attribute removed message was not being displayed
markt [Mon, 22 Nov 2010 10:32:12 +0000 (10:32 +0000)]
Fix manager app - attribute removed message was not being displayed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037663 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix primary sessions not always treated as such by Manager app.
markt [Mon, 22 Nov 2010 10:30:05 +0000 (10:30 +0000)]
Fix primary sessions not always treated as such by Manager app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037661 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSimplify escapeXml(Object)
markt [Mon, 22 Nov 2010 10:18:17 +0000 (10:18 +0000)]
Simplify escapeXml(Object)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037659 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix ordering functionality for Manager app
markt [Mon, 22 Nov 2010 10:16:37 +0000 (10:16 +0000)]
Fix ordering functionality for Manager app

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037658 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r1032232
kkolinko [Mon, 22 Nov 2010 03:05:44 +0000 (03:05 +0000)]
Revert r1032232
It broke evaluation of <c:set var="v">value<c:set>
https://issues.apache.org/bugzilla/show_bug.cgi?id=50228#c3

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037594 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse image with tm (the same as tomcat.gif logo)
mturk [Sat, 20 Nov 2010 17:34:56 +0000 (17:34 +0000)]
Use image with tm (the same as tomcat.gif logo)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1037277 13f79535-47bb-0310-9956-ffa450edef68