tomcat7.0
15 years agoRevert r966596 - pollTime is in microseconds, wait is in milliseconds
markt [Sat, 31 Jul 2010 14:02:29 +0000 (14:02 +0000)]
Revert r966596 - pollTime is in microseconds, wait is in milliseconds
Add an additional wait that prevents a JVM crash on shutdown detected in TestAsyncContextImpl tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@981061 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix possible threading issue in unit tests. Adding some Thread.sleep() calls in the...
markt [Sat, 31 Jul 2010 09:58:17 +0000 (09:58 +0000)]
Fix possible threading issue in unit tests. Adding some Thread.sleep() calls in the right place can cause the tests to fail. This is probably one of the causes of the current Gump failures.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@981027 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd optional support to the HTML Manager application to display Proxy sessions. It...
markt [Thu, 29 Jul 2010 20:53:26 +0000 (20:53 +0000)]
Add optional support to the HTML Manager application to display Proxy sessions. It is disabled by default.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980567 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49407
markt [Thu, 29 Jul 2010 18:32:58 +0000 (18:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49407
Make BackupManager and DeltaManager handle primary and backup sessions consistently

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980535 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEnable the HTML Manager application to differentiate between primary & backup sessions.
markt [Thu, 29 Jul 2010 18:17:15 +0000 (18:17 +0000)]
Enable the HTML Manager application to differentiate between primary & backup sessions.
Both can be invalidated
Attributes can be viewed in both
Attributes can only be removed from primary sessions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980532 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate the changelog with a note on the session manager refactoring
markt [Thu, 29 Jul 2010 12:34:59 +0000 (12:34 +0000)]
Update the changelog with a note on the session manager refactoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980425 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFollow on to r980418
markt [Thu, 29 Jul 2010 12:28:40 +0000 (12:28 +0000)]
Follow on to r980418
Need to move registration with context to ManagerBase too

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980424 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRefactoring
markt [Thu, 29 Jul 2010 12:22:27 +0000 (12:22 +0000)]
Refactoring
Change BackupManager to extend ClusterManagerBase rather than StandardManager
- The functionality being inherited from StandardManager (persistence over restart) was being bypassed
- Further reduces code duplication, mainly in BackupManager

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980421 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRefactoring
markt [Thu, 29 Jul 2010 12:10:51 +0000 (12:10 +0000)]
Refactoring
Move propertyChange() implementation to ManagerBase to reduce code duplication

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980418 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRefactoring - reduce duplication
markt [Thu, 29 Jul 2010 11:49:47 +0000 (11:49 +0000)]
Refactoring - reduce duplication
Handle maxActiveSessions, rejectedSessions and processingTime in ManagerBase

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980411 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert part of r980399 - attribute is present and used in ManagerBase so will be...
markt [Thu, 29 Jul 2010 11:26:02 +0000 (11:26 +0000)]
Revert part of r980399 - attribute is present and used in ManagerBase so will be inherited

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980408 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix an Eclipse nag
markt [Thu, 29 Jul 2010 11:24:45 +0000 (11:24 +0000)]
Fix an Eclipse nag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980407 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove deprecated method
markt [Thu, 29 Jul 2010 11:16:29 +0000 (11:16 +0000)]
Remove deprecated method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980404 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRejected session count should not be writable
markt [Thu, 29 Jul 2010 11:10:00 +0000 (11:10 +0000)]
Rejected session count should not be writable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980401 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused property
markt [Thu, 29 Jul 2010 11:03:32 +0000 (11:03 +0000)]
Remove unused property

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980399 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove deprecated defaultMode attribute
markt [Thu, 29 Jul 2010 09:45:32 +0000 (09:45 +0000)]
Remove deprecated defaultMode attribute
Clarify current behaviour of maxActiveSessions
Clean-up cluster-manager docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980378 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused SimpleTcpReplicationManager and associated ReplicatedSession
markt [Thu, 29 Jul 2010 08:11:52 +0000 (08:11 +0000)]
Remove unused SimpleTcpReplicationManager and associated ReplicatedSession

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980355 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix copy/paste typo
markt [Thu, 29 Jul 2010 07:52:07 +0000 (07:52 +0000)]
Fix copy/paste typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980347 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake life easier when debugging failing tests
markt [Wed, 28 Jul 2010 23:03:40 +0000 (23:03 +0000)]
Make life easier when debugging failing tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980262 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix a failing test with the APR connector. Handle async requests that timeout.
markt [Wed, 28 Jul 2010 22:55:08 +0000 (22:55 +0000)]
Fix a failing test with the APR connector. Handle async requests that timeout.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980260 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReduce log level for debug messages from error to debug
markt [Wed, 28 Jul 2010 16:14:03 +0000 (16:14 +0000)]
Reduce log level for debug messages from error to debug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980111 13f79535-47bb-0310-9956-ffa450edef68

15 years agoOnly download Checkstyle if it is going to be used
markt [Wed, 28 Jul 2010 15:58:30 +0000 (15:58 +0000)]
Only download Checkstyle if it is going to be used
Add note the Checkstyle is LGPL
Add option (off by default) to fail test target as soon as one test fails.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980106 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore unit test fixes - better handling when APR/native connector is not started
markt [Tue, 27 Jul 2010 22:36:06 +0000 (22:36 +0000)]
More unit test fixes - better handling when APR/native connector is not started

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979896 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up
markt [Tue, 27 Jul 2010 21:05:16 +0000 (21:05 +0000)]
Code clean-up
Remove deps on o.a.catalina
Fix a couple of Eclipse nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979872 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix unit test failure. Ignore exceptions when destroying APR connector if APR was...
markt [Tue, 27 Jul 2010 20:56:10 +0000 (20:56 +0000)]
Fix unit test failure. Ignore exceptions when destroying APR connector if APR was never initialised.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979865 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix unit test failure with APR. SSL renegotiation will not work by default for this...
markt [Tue, 27 Jul 2010 20:28:38 +0000 (20:28 +0000)]
Fix unit test failure with APR. SSL renegotiation will not work by default for this connector.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979854 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix unit test failure with APR connector. Make sure MBeans are de-registered when...
markt [Tue, 27 Jul 2010 20:27:56 +0000 (20:27 +0000)]
Fix unit test failure with APR connector. Make sure MBeans are de-registered when connector stops.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979853 13f79535-47bb-0310-9956-ffa450edef68

15 years agoOnly need to wait a single pollTime, not one pollTime for each poller.
markt [Tue, 27 Jul 2010 20:27:16 +0000 (20:27 +0000)]
Only need to wait a single pollTime, not one pollTime for each poller.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979852 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPrevent JVM crashes caused by shutting down the APR library too early.
markt [Tue, 27 Jul 2010 20:26:14 +0000 (20:26 +0000)]
Prevent JVM crashes caused by shutting down the APR library too early.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979850 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProvide control over which connectors are used to run tests - helpful when (as now...
markt [Tue, 27 Jul 2010 20:25:35 +0000 (20:25 +0000)]
Provide control over which connectors are used to run tests - helpful when (as now) only one of the connectors has issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979849 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate changelog
markt [Tue, 27 Jul 2010 20:24:11 +0000 (20:24 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979844 13f79535-47bb-0310-9956-ffa450edef68

15 years agoreverting, since 1.8 requires an indirect
billbarker [Mon, 26 Jul 2010 03:27:37 +0000 (03:27 +0000)]
reverting, since 1.8 requires an indirect

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979143 13f79535-47bb-0310-9956-ffa450edef68

15 years agono reason to do indirect here
billbarker [Mon, 26 Jul 2010 03:00:08 +0000 (03:00 +0000)]
no reason to do indirect here

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@979138 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd additional tests known to pass - list provided by Marc Guillemot.
markt [Sun, 25 Jul 2010 00:12:02 +0000 (00:12 +0000)]
Add additional tests known to pass - list provided by Marc Guillemot.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978952 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemainder of tabs to spaces changes
markt [Sat, 24 Jul 2010 13:03:11 +0000 (13:03 +0000)]
Remainder of tabs to spaces changes
Enable check in checkstyle config

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978865 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIgnore config for checkstyle Eclipse plugin
markt [Sat, 24 Jul 2010 12:25:40 +0000 (12:25 +0000)]
Ignore config for checkstyle Eclipse plugin

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978862 13f79535-47bb-0310-9956-ffa450edef68

15 years agoExtend checks to webapps
markt [Sat, 24 Jul 2010 12:23:44 +0000 (12:23 +0000)]
Extend checks to webapps
Tab police for /test and /webapps

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978861 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCheck the tests too.
markt [Sat, 24 Jul 2010 11:10:48 +0000 (11:10 +0000)]
Check the tests too.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978847 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore tab police
markt [Sat, 24 Jul 2010 11:03:00 +0000 (11:03 +0000)]
More tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978845 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police in org.apache.catalina
markt [Sat, 24 Jul 2010 10:17:45 +0000 (10:17 +0000)]
Tab police in org.apache.catalina

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978840 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to require Ant 1.8.x+ to take advantage of the new property expansion for...
markt [Sat, 24 Jul 2010 08:37:48 +0000 (08:37 +0000)]
Update to require Ant 1.8.x+ to take advantage of the new property expansion for if/unless and then use it control if the validate code is executed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@978826 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore tab police - misc packages
markt [Fri, 23 Jul 2010 22:04:32 +0000 (22:04 +0000)]
More tab police - misc packages

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967284 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore tab police - javax.servlet.jsp
markt [Fri, 23 Jul 2010 21:47:39 +0000 (21:47 +0000)]
More tab police - javax.servlet.jsp

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967277 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police: javax.servlet.http
markt [Fri, 23 Jul 2010 16:03:25 +0000 (16:03 +0000)]
Tab police: javax.servlet.http
Thanks to Checkstyle and Eclipse source formatting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967146 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police: javax.servlet (remainder - not sub-packages)
markt [Fri, 23 Jul 2010 15:48:53 +0000 (15:48 +0000)]
Tab police: javax.servlet (remainder - not sub-packages)
Thanks to Checkstyle and Eclipse source formatting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967140 13f79535-47bb-0310-9956-ffa450edef68

15 years agoHandle the edge cases where resources packaged in JARs have names that start with...
markt [Fri, 23 Jul 2010 14:30:26 +0000 (14:30 +0000)]
Handle the edge cases where resources packaged in JARs have names that start with a single quote character or a double quote character.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967107 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix the paths used for JAR resources
markt [Fri, 23 Jul 2010 12:37:45 +0000 (12:37 +0000)]
Fix the paths used for JAR resources

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967073 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert part of previous clean-up. Jar needs to remain open
markt [Fri, 23 Jul 2010 10:35:20 +0000 (10:35 +0000)]
Revert part of previous clean-up. Jar needs to remain open

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967026 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCode clean-up. Fix Eclipse warnings. Implement TODOs.
markt [Fri, 23 Jul 2010 10:19:32 +0000 (10:19 +0000)]
Code clean-up. Fix Eclipse warnings. Implement TODOs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@967021 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police: javax.servlet (partial)
markt [Thu, 22 Jul 2010 22:48:18 +0000 (22:48 +0000)]
Tab police: javax.servlet (partial)
Thanks to Checkstyle and Eclipse source formatting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966888 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police: javax.el
markt [Thu, 22 Jul 2010 22:35:32 +0000 (22:35 +0000)]
Tab police: javax.el
Thanks to Checkstyle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966883 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
markt [Thu, 22 Jul 2010 22:31:30 +0000 (22:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49268
Add necessary plumbing to enable Checkstyle
The config file is deliberately empty. The check will be uncommented once the source code has been fixed (~200 files contain tabs).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966882 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse specific imports
markt [Thu, 22 Jul 2010 21:36:55 +0000 (21:36 +0000)]
Use specific imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966864 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix regression in previous fix for https://issues.apache.org/bugzilla/show_bug.cgi...
markt [Thu, 22 Jul 2010 21:36:11 +0000 (21:36 +0000)]
Fix regression in previous fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Use TCCL to load webapp classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966863 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix copy/paste error
markt [Thu, 22 Jul 2010 21:29:42 +0000 (21:29 +0000)]
Fix copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966862 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some Eclipse warnings, remove some implemented TODOs
markt [Thu, 22 Jul 2010 16:58:26 +0000 (16:58 +0000)]
Fix some Eclipse warnings, remove some implemented TODOs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966745 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImplement some Servlet 3 TODOs
markt [Thu, 22 Jul 2010 16:56:32 +0000 (16:56 +0000)]
Implement some Servlet 3 TODOs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966744 13f79535-47bb-0310-9956-ffa450edef68

15 years agoExtend Lifecycle state machine so global listeners can start before everything else...
markt [Thu, 22 Jul 2010 16:32:11 +0000 (16:32 +0000)]
Extend Lifecycle state machine so global listeners can start before everything else without impacting the context and TLD config listeners

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966735 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49613
markt [Thu, 22 Jul 2010 14:36:15 +0000 (14:36 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49613
Improve performance for multiple calls to Request.getAttributeNames() when using SSL. Patch provided by Sampo Savolainen.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966692 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove some TODOs that have been implemented
markt [Thu, 22 Jul 2010 14:27:20 +0000 (14:27 +0000)]
Remove some TODOs that have been implemented

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966684 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRun all unit tests will all connectors
markt [Thu, 22 Jul 2010 12:18:59 +0000 (12:18 +0000)]
Run all unit tests will all connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966613 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPoll time and wait are both in milliseconds
markt [Thu, 22 Jul 2010 11:51:00 +0000 (11:51 +0000)]
Poll time and wait are both in milliseconds

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966596 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix possible NPE
markt [Thu, 22 Jul 2010 10:43:43 +0000 (10:43 +0000)]
Fix possible NPE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966570 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49567
markt [Thu, 22 Jul 2010 09:12:18 +0000 (09:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49567
Better handling of calls to complete() from a separate thread.
There are still a handful of TODOs around this which will follow shortly but I'm committing this since it passes the unit tests and the Servlet TCK (with BIO)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966548 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49600
markt [Wed, 21 Jul 2010 20:31:30 +0000 (20:31 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49600
Based on a patch by Marc Guillemot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966405 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49600
markt [Wed, 21 Jul 2010 20:30:53 +0000 (20:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49600
Return a consistent exception for 'Not Found' resources.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966404 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49617
markt [Wed, 21 Jul 2010 16:37:58 +0000 (16:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49617
Correct the ExpiresFilter documentation after changes to the submitted patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966304 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReturn copies of the URL array rather than the original. This facilitated CVE-2010...
markt [Wed, 21 Jul 2010 16:09:41 +0000 (16:09 +0000)]
Return copies of the URL array rather than the original. This facilitated CVE-2010-1622 although the root cause was in the Spring Framework. Returning a copy in this case seems like a good idea.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966292 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect explanation. mapSendOptions=6 is synchronous, not asynchronous.
markt [Wed, 21 Jul 2010 10:59:31 +0000 (10:59 +0000)]
Correct explanation. mapSendOptions=6 is synchronous, not asynchronous.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966178 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd note about message processing order.
markt [Wed, 21 Jul 2010 10:58:56 +0000 (10:58 +0000)]
Add note about message processing order.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966177 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEclipse sample files need to have correct (platform specific) line endings in src...
markt [Wed, 21 Jul 2010 08:12:37 +0000 (08:12 +0000)]
Eclipse sample files need to have correct (platform specific) line endings in src distributions.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@966131 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRestore pero's timeout fix for the BIO connector. Add configuration of the timeout.
markt [Sat, 17 Jul 2010 23:57:23 +0000 (23:57 +0000)]
Restore pero's timeout fix for the BIO connector. Add configuration of the timeout.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965150 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTrivial - align comment
markt [Sat, 17 Jul 2010 20:40:51 +0000 (20:40 +0000)]
Trivial - align comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965130 13f79535-47bb-0310-9956-ffa450edef68

15 years agoExpose executor.
markt [Sat, 17 Jul 2010 18:24:01 +0000 (18:24 +0000)]
Expose executor.
Required so Servlet 3 Async implementation can use the container thread pool when a new thread needs to be dispatched. (e.g. from AsyncContext.start(Runnable)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965123 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean-up. No functional change.
markt [Sat, 17 Jul 2010 18:20:11 +0000 (18:20 +0000)]
Clean-up. No functional change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965122 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code
markt [Sat, 17 Jul 2010 18:13:21 +0000 (18:13 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@965118 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake the bean Serializable so I can use the example to test/demo session persistence...
markt [Fri, 16 Jul 2010 14:55:01 +0000 (14:55 +0000)]
Make the bean Serializable so I can use the example to test/demo session persistence on restart
Add required getters/setters
Indent using 4 spaces
Fix FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964816 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
markt [Fri, 16 Jul 2010 11:59:57 +0000 (11:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49428
Add a work-around for the known namespace issues for some Microsoft WebDAV clients. Patch provided by Panagiotis Astithas.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964780 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAs suggested on the users list, add redirects to the HTML interface to the root of...
markt [Fri, 16 Jul 2010 09:09:44 +0000 (09:09 +0000)]
As suggested on the users list, add redirects to the HTML interface to the root of the host-manager and manager applications

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964722 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
markt [Thu, 15 Jul 2010 21:37:41 +0000 (21:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
When updating the session cookie header, actually update it rather than adding a new header without a name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964614 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
markt [Thu, 15 Jul 2010 21:32:35 +0000 (21:32 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49598
Multiple invalid session cookies

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964611 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove the ExpiresActive option. Just comment it out if you don't want to use it.
markt [Wed, 14 Jul 2010 22:15:50 +0000 (22:15 +0000)]
Remove the ExpiresActive option. Just comment it out if you don't want to use it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964222 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
markt [Wed, 14 Jul 2010 22:11:30 +0000 (22:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
Add the ExpiresFilter, a port of mod_expires
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964219 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49127
markt [Wed, 14 Jul 2010 21:39:40 +0000 (21:39 +0000)]
Fxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49127
Don't swallow exceptions unnecessarily

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964216 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49128
markt [Wed, 14 Jul 2010 21:35:37 +0000 (21:35 +0000)]
Fxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49128
Don't swallow exceptions unnecessarily

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964215 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49130
markt [Wed, 14 Jul 2010 21:29:44 +0000 (21:29 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49130
Better describe the core package
Patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964211 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49182
markt [Wed, 14 Jul 2010 21:24:45 +0000 (21:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49182
Align setclasspath comments with reality.
Based on a patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964208 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd myself to the list.
kkolinko [Wed, 14 Jul 2010 13:54:43 +0000 (13:54 +0000)]
Add myself to the list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964049 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48960
markt [Tue, 13 Jul 2010 21:35:39 +0000 (21:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48960
Disable exec by default in SSI and provide an option to enable it for both  Servlet and Filter

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963868 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSign the pom.
markt [Tue, 13 Jul 2010 16:02:09 +0000 (16:02 +0000)]
Sign the pom.
Make sure source jar signature doesn't overwrite the non-source jar signature.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963776 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid NullPointerException, when copyXML=true and META-INF/context.xml does not exist.
kfujino [Tue, 13 Jul 2010 04:44:25 +0000 (04:44 +0000)]
Avoid NullPointerException, when copyXML=true and META-INF/context.xml does not exist.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963599 13f79535-47bb-0310-9956-ffa450edef68

15 years agoHard code the snapshot version for 7.0.
markt [Mon, 12 Jul 2010 13:17:01 +0000 (13:17 +0000)]
Hard code the snapshot version for 7.0.
7.0-SNAPSHOT will always point to the latest snapshot.
I'll clean out the snapshot repo before I do the next update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963275 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPrepare for the next release
markt [Mon, 12 Jul 2010 13:02:30 +0000 (13:02 +0000)]
Prepare for the next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963273 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake the fix for bug 49555 more robust
markt [Sun, 11 Jul 2010 16:37:32 +0000 (16:37 +0000)]
Make the fix for bug 49555 more robust

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963106 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unnecessary code since Class.getCanonicalName() is available
markt [Sun, 11 Jul 2010 16:29:25 +0000 (16:29 +0000)]
Remove unnecessary code since Class.getCanonicalName() is available

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963103 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEclipse warnings for annotations
markt [Sat, 10 Jul 2010 21:43:02 +0000 (21:43 +0000)]
Eclipse warnings for annotations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962923 13f79535-47bb-0310-9956-ffa450edef68

15 years agojavax.mail is a dummy implementation - mark it as such to stop Eclipse complaining...
markt [Sat, 10 Jul 2010 21:39:58 +0000 (21:39 +0000)]
javax.mail is a dummy implementation - mark it as such to stop Eclipse complaining about empty methods and unused parameters

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962922 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTrivial cleanup no functional change
markt [Sat, 10 Jul 2010 21:33:16 +0000 (21:33 +0000)]
Trivial cleanup no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962921 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49442
markt [Sat, 10 Jul 2010 21:22:12 +0000 (21:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49442
Trivial code clean-up. No functional change.
Based on a patch provided by Sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962919 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478
markt [Sat, 10 Jul 2010 21:13:23 +0000 (21:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478
Add support for user specified character sets to the AddDefaultCharsetFilter. Based on a patch by Felix Schumacher.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962917 13f79535-47bb-0310-9956-ffa450edef68