tomcat7.0
14 years agoReview from kkolinko
markt [Sun, 6 Feb 2011 21:00:52 +0000 (21:00 +0000)]
Review from kkolinko
1. Matcher not thread safe
2. >1 UA header -> not a bot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067759 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIt isn't working. Add some debug logging.
markt [Sun, 6 Feb 2011 20:30:38 +0000 (20:30 +0000)]
It isn't working. Add some debug logging.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067747 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix the expiration logic
markt [Sun, 6 Feb 2011 20:17:58 +0000 (20:17 +0000)]
Fix the expiration logic

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067743 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFirst attempt at a valve to limit session creation by web crawlers.
markt [Sun, 6 Feb 2011 19:28:48 +0000 (19:28 +0000)]
First attempt at a valve to limit session creation by web crawlers.
Docs etc to follow once it is confirmed working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067734 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTweak defaults. Document.
markt [Sun, 6 Feb 2011 19:08:13 +0000 (19:08 +0000)]
Tweak defaults. Document.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067732 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove attribute name definitions to AccessLog interface
markt [Sun, 6 Feb 2011 18:46:42 +0000 (18:46 +0000)]
Move attribute name definitions to AccessLog interface
AccessLog implementations need to be aware of attributes since they aren't always set (e.g. if request is rejected early in the connector)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067725 13f79535-47bb-0310-9956-ffa450edef68

14 years agoInitial attempt to fix RemoteIp issues observed with ASF Jira
markt [Sun, 6 Feb 2011 18:11:52 +0000 (18:11 +0000)]
Initial attempt to fix RemoteIp issues observed with ASF Jira
Docs, filter and changelog commits to follow once it works

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067718 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBump version
markt [Fri, 4 Feb 2011 12:46:06 +0000 (12:46 +0000)]
Bump version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067170 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix hanging Servlet 3 asynchronous requests when using the APR based AJP connector.
markt [Fri, 4 Feb 2011 12:18:00 +0000 (12:18 +0000)]
Fix hanging Servlet 3 asynchronous requests when using the APR based AJP connector.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067161 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDo not send flush packet if explicit is false
mturk [Fri, 4 Feb 2011 11:16:14 +0000 (11:16 +0000)]
Do not send flush packet if explicit is false

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067151 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix security exception when running under a SecurityManager
markt [Fri, 4 Feb 2011 11:07:18 +0000 (11:07 +0000)]
Fix security exception when running under a SecurityManager

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067147 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollow up to r1067039
markt [Fri, 4 Feb 2011 10:38:09 +0000 (10:38 +0000)]
Follow up to r1067039

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067139 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50709
markt [Fri, 4 Feb 2011 10:30:36 +0000 (10:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50709
Make ApplicationContextFacade non-final to enable extension.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067134 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog
markt [Fri, 4 Feb 2011 10:02:38 +0000 (10:02 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067127 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign server.xml installed by the Windows installer with the one bundled in zip/tar...
kkolinko [Fri, 4 Feb 2011 03:22:53 +0000 (03:22 +0000)]
Align server.xml installed by the Windows installer with the one bundled in zip/tar.gz files.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067075 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix NPE in CoyoteAdapter when postParseRequest() call fails.
kkolinko [Fri, 4 Feb 2011 03:07:37 +0000 (03:07 +0000)]
Fix NPE in CoyoteAdapter when postParseRequest() call fails.

That was caused by mappingData.context being null.
This NPE occurence in 7.0.7 was reported on the users list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067072 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReduce severity level. The ASF Jira instance logs were filling with these
markt [Thu, 3 Feb 2011 23:56:55 +0000 (23:56 +0000)]
Reduce severity level. The ASF Jira instance logs were filling with these

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1067039 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBump version number
markt [Thu, 3 Feb 2011 10:35:53 +0000 (10:35 +0000)]
Bump version number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066774 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake sure flush packet is not send after END_RESPONSE packet. Should handle BZ49929
mturk [Thu, 3 Feb 2011 10:23:20 +0000 (10:23 +0000)]
Make sure flush packet is not send after END_RESPONSE packet. Should handle BZ49929

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066772 13f79535-47bb-0310-9956-ffa450edef68

14 years agoHmm. Can't see a way (without changing the connector code) to test SSL renegotiation...
markt [Thu, 3 Feb 2011 09:20:34 +0000 (09:20 +0000)]
Hmm. Can't see a way (without changing the connector code) to test SSL renegotiation failure if the JVM supports RFC5746. Need to think about this some more. In the meantime, get the tests working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066766 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFactor out support code prior to splitting up the TestSsl class
markt [Thu, 3 Feb 2011 08:44:37 +0000 (08:44 +0000)]
Factor out support code prior to splitting up the TestSsl class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066759 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove/rename to better location
markt [Thu, 3 Feb 2011 08:36:03 +0000 (08:36 +0000)]
Move/rename to better location

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066756 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Wed, 2 Feb 2011 18:35:29 +0000 (18:35 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066571 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix javadoc niggle
markt [Wed, 2 Feb 2011 18:33:06 +0000 (18:33 +0000)]
Fix javadoc niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066569 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMissed one place where socket needed to replace socket wrapper in r1063774
markt [Wed, 2 Feb 2011 18:29:26 +0000 (18:29 +0000)]
Missed one place where socket needed to replace socket wrapper in r1063774

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066568 13f79535-47bb-0310-9956-ffa450edef68

14 years agoClarify
markt [Wed, 2 Feb 2011 14:55:36 +0000 (14:55 +0000)]
Clarify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066489 13f79535-47bb-0310-9956-ffa450edef68

14 years agor1057694 broke display of ROOT/index.jsp in MSIE.
kkolinko [Wed, 2 Feb 2011 06:13:26 +0000 (06:13 +0000)]
r1057694 broke display of ROOT/index.jsp in MSIE.
Use JSP comments in the license instead of HTML comments,
like we already do elsewhere.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066338 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect documentation for the PersistentManager class:
kkolinko [Wed, 2 Feb 2011 05:37:52 +0000 (05:37 +0000)]
Correct documentation for the PersistentManager class:
there is no "randomClass" attribute, but several others were added.
Move attributes defined in the Manager interface into the Common Attributes section.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066329 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1066310.
kkolinko [Wed, 2 Feb 2011 03:45:05 +0000 (03:45 +0000)]
Followup to r1066310.
Simplify: call stopAwait() unconditionally.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066321 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1066310. Simplify.
kkolinko [Wed, 2 Feb 2011 03:24:50 +0000 (03:24 +0000)]
Followup to r1066310. Simplify.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066320 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix http://issues.apache.org/bugzilla/show_bug.cgi?id=50673
kkolinko [Wed, 2 Feb 2011 02:45:46 +0000 (02:45 +0000)]
Fix issues.apache.org/bugzilla/show_bug.cgi?id=50673
Improve Catalina shutdown when running as a service. Do not call System.exit().

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066310 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove HTTP specification compliance
kkolinko [Tue, 1 Feb 2011 22:12:18 +0000 (22:12 +0000)]
Improve HTTP specification compliance

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1066244 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50631
kkolinko [Tue, 1 Feb 2011 07:55:45 +0000 (07:55 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50631
InternalNioInputBuffer should honor maxHttpHeadSize

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065939 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50325
markt [Mon, 31 Jan 2011 23:43:38 +0000 (23:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50325
Use JVM provided solutions to CVE-2009-3555 if available (i.e. RFC 5746 support)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065859 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1065089. Make the field final.
kkolinko [Mon, 31 Jan 2011 11:09:07 +0000 (11:09 +0000)]
Followup to r1065089. Make the field final.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065556 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd bug number to an already fixed issue. Arrange issues in ascending numeric order.
kkolinko [Sat, 29 Jan 2011 21:57:32 +0000 (21:57 +0000)]
Add bug number to an already fixed issue. Arrange issues in ascending numeric order.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065120 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix breaking tests after recent comet fixes
markt [Sat, 29 Jan 2011 19:27:07 +0000 (19:27 +0000)]
Fix breaking tests after recent comet fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065091 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImplement debug logging in InternalNioInputBuffer. Log what we got with the first...
kkolinko [Sat, 29 Jan 2011 18:23:12 +0000 (18:23 +0000)]
Implement debug logging in InternalNioInputBuffer. Log what we got with the first read.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065089 13f79535-47bb-0310-9956-ffa450edef68

14 years agoWhen running the tests use log configuration specified by conf/logging.properties
kkolinko [Sat, 29 Jan 2011 18:08:37 +0000 (18:08 +0000)]
When running the tests use log configuration specified by conf/logging.properties

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1065087 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50683
markt [Sat, 29 Jan 2011 00:15:34 +0000 (00:15 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50683
Scan annotations when unpackWars=false

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064934 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRe-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49978
markt [Sat, 29 Jan 2011 00:00:50 +0000 (00:00 +0000)]
Re-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49978
Pre-existing dir should not break deployment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064932 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46819
markt [Fri, 28 Jan 2011 23:24:23 +0000 (23:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46819
Remove redundant object instantiations in JspRuntimeLibrary.
Patch provided by Anthony Whitford.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064929 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused file
markt [Fri, 28 Jan 2011 21:41:02 +0000 (21:41 +0000)]
Remove unused file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064897 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove whitespace
markt [Fri, 28 Jan 2011 21:31:48 +0000 (21:31 +0000)]
Remove whitespace

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064893 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50680
markt [Fri, 28 Jan 2011 21:21:02 +0000 (21:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50680
Prevent an NPE when using tag files from an exploded JAR file, e.g. from within an IDE.
Patch provided by Larry Isaacs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064890 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50679
markt [Fri, 28 Jan 2011 21:04:55 +0000 (21:04 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50679
Update the FarmWarDeployer to support parallel deployment. This deliberately breaks the API since the meaning of a number of method parameters has changed (context path -> context name).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064881 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDon't need an INFO log message every 30s when the FarmWarDeployer is running
markt [Fri, 28 Jan 2011 17:41:45 +0000 (17:41 +0000)]
Don't need an INFO log message every 30s when the FarmWarDeployer is running

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064791 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNot sure which recent Comet change fixed this but one of them did.
markt [Fri, 28 Jan 2011 15:57:32 +0000 (15:57 +0000)]
Not sure which recent Comet change fixed this but one of them did.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064747 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50642
markt [Fri, 28 Jan 2011 13:03:57 +0000 (13:03 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50642
Better fix for HttpClient keep-alive thread triggered memory leaks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064652 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTypo
markt [Thu, 27 Jan 2011 19:43:23 +0000 (19:43 +0000)]
Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1064275 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50646
markt [Wed, 26 Jan 2011 18:28:31 +0000 (18:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50646
Ensure larger Tribes messages are fully read.
Patch provided by Olivier Costet.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063816 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50648
markt [Wed, 26 Jan 2011 16:53:23 +0000 (16:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50648
Correctly set the interrupt status if a thread using RpcChannel is interrupted waiting for a message reply.
Based on a patch by Olivier Costet.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063791 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect some old typo in context docs:
kkolinko [Wed, 26 Jan 2011 16:35:48 +0000 (16:35 +0000)]
Correct some old typo in context docs:
move comment about docBase bahaviour with symlinks to where it belongs.
No need to update 5.5 ones: they are OK already.
CTR: docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063782 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDon't assume servlet 3+ async when processing long poll connections (it might be...
markt [Wed, 26 Jan 2011 16:11:46 +0000 (16:11 +0000)]
Don't assume servlet 3+ async when processing long poll connections (it might be comet)
Use socket rather than socket wrapper as key in connection list else comet sockets may be lost

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063774 13f79535-47bb-0310-9956-ffa450edef68

14 years agoThis change also fixed an open bug
markt [Tue, 25 Jan 2011 17:33:45 +0000 (17:33 +0000)]
This change also fixed an open bug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063372 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix various odd behaviours seen with a debugger. Observed both multiple and zero...
markt [Tue, 25 Jan 2011 17:20:20 +0000 (17:20 +0000)]
Fix various odd behaviours seen with a debugger. Observed both multiple and zero (rather than 1) selection events for a single data receive event

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063366 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnsure correct cycling if input filters
markt [Tue, 25 Jan 2011 17:15:33 +0000 (17:15 +0000)]
Ensure correct cycling if input filters

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063364 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent multiple Comet END events
markt [Tue, 25 Jan 2011 17:12:22 +0000 (17:12 +0000)]
Prevent multiple Comet END events

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063362 13f79535-47bb-0310-9956-ffa450edef68

14 years agoClarify what the units are when setting sessionIdLength property of a Manager. It...
kkolinko [Tue, 25 Jan 2011 12:40:38 +0000 (12:40 +0000)]
Clarify what the units are when setting sessionIdLength property of a Manager. It was asked on users@
CTR: docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063257 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove old, commented out code
markt [Tue, 25 Jan 2011 12:05:14 +0000 (12:05 +0000)]
Remove old, commented out code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1063244 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSmall simplification
markt [Mon, 24 Jan 2011 20:06:12 +0000 (20:06 +0000)]
Small simplification

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1062955 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused import
markt [Mon, 24 Jan 2011 17:18:40 +0000 (17:18 +0000)]
Remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1062886 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse getName() instead of logName() in error messages in StandardContext.
kkolinko [Sun, 23 Jan 2011 14:37:10 +0000 (14:37 +0000)]
Use getName() instead of logName() in error messages in StandardContext.

Hex sequences in LocalStrings_es.properties are converted to lowercase. Sorry for the noise.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1062431 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFormatting - followup to r1061953
kkolinko [Sun, 23 Jan 2011 12:48:02 +0000 (12:48 +0000)]
Formatting - followup to r1061953

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1062418 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBe consistent with locks on sessionCreationTiming, sessionExpirationTiming in DeltaMa...
kkolinko [Sun, 23 Jan 2011 12:01:29 +0000 (12:01 +0000)]
Be consistent with locks on sessionCreationTiming, sessionExpirationTiming in DeltaManager.resetStatistics():
use the same lock as elsewhere.
Corrected a pair of typos in changelog as well.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1062398 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFixed typo.
schultz [Fri, 21 Jan 2011 18:38:28 +0000 (18:38 +0000)]
Fixed typo.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061960 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemoved debug logging added with r1061929.
schultz [Fri, 21 Jan 2011 18:36:53 +0000 (18:36 +0000)]
Removed debug logging added with r1061929.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061957 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRe-fixed bug #49711: HttpServletRequest#getParts() does not work in a Filter
schultz [Fri, 21 Jan 2011 18:32:39 +0000 (18:32 +0000)]
Re-fixed bug #49711: HttpServletRequest#getParts() does not work in a Filter
- Moved allowCasualMultipartParsing setting from <Connector> to <Context>

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061953 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReverted inadvertently-committed files from r1061929.
schultz [Fri, 21 Jan 2011 18:04:38 +0000 (18:04 +0000)]
Reverted inadvertently-committed files from r1061929.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061940 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFixed bug #49711: HttpServletRequest#getParts() does not work in a Filter
schultz [Fri, 21 Jan 2011 17:46:03 +0000 (17:46 +0000)]
Fixed bug #49711: HttpServletRequest#getParts() does not work in a Filter
- Added <Connector> attribute allowCasualMultipartParsing (default false)
- Requests that contain multipart/form-data will be parsed in the absence of @MultipartConfig when the above attribute is set to "true"

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061929 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix possible thread exhaustion
markt [Fri, 21 Jan 2011 16:49:02 +0000 (16:49 +0000)]
Fix possible thread exhaustion
With a breakpoint in the servlet handling the timeout event, I was seeing a new thread being allocated from the poll every second or so

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061900 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50629
markt [Fri, 21 Jan 2011 13:17:12 +0000 (13:17 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50629
Make StandardContext.bindThread() and StandardContext.unbindThread() protected to allow use by sub-classes.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061797 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove error message & use i18n
markt [Fri, 21 Jan 2011 12:39:15 +0000 (12:39 +0000)]
Improve error message & use i18n

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061787 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd missing entry
markt [Thu, 20 Jan 2011 21:34:19 +0000 (21:34 +0000)]
Add missing entry

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061530 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd textual description to the attributes supported by DataSourceLinkFactory
kkolinko [Thu, 20 Jan 2011 21:00:10 +0000 (21:00 +0000)]
Add textual description to the attributes supported by DataSourceLinkFactory
Correct a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061511 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50441
markt [Thu, 20 Jan 2011 20:43:12 +0000 (20:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50441
Clarify when docBase can be set

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061503 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50526
markt [Thu, 20 Jan 2011 19:05:38 +0000 (19:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50526
Additional JavaMail docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061461 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix copy/paste snafu
markt [Thu, 20 Jan 2011 18:40:23 +0000 (18:40 +0000)]
Fix copy/paste snafu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061446 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50620
markt [Thu, 20 Jan 2011 18:34:18 +0000 (18:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50620
Exceptions calling session.endAccess should not prevent recycle() from completing normally

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061442 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate info - should probably just delete all these
markt [Thu, 20 Jan 2011 18:27:02 +0000 (18:27 +0000)]
Update info - should probably just delete all these

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061438 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix http://issues.apache.org/bugzilla/show_bug.cgi?id=50606
kkolinko [Thu, 20 Jan 2011 17:43:35 +0000 (17:43 +0000)]
Fix issues.apache.org/bugzilla/show_bug.cgi?id=50606
Improve CGIServlet: Provide support for specifying empty value for the executable init-param. Provide support for explicit additional arguments for the executable. Those were broken when implementing fix for bug 49657

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061412 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse the new release(s,p) method introduced in r1050249
kkolinko [Thu, 20 Jan 2011 17:09:26 +0000 (17:09 +0000)]
Use the new release(s,p) method introduced in r1050249

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061397 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50535
markt [Thu, 20 Jan 2011 16:35:55 +0000 (16:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50535
Provid an option (disabled by default) to serve resources from /WEB-INF/classes/META-INF/resources

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061376 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert r1060927. It changed the API (which would have been fine if it the eventual...
markt [Wed, 19 Jan 2011 22:51:59 +0000 (22:51 +0000)]
Revert r1060927. It changed the API (which would have been fine if it the eventual solution needed it but it doesn't)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061047 13f79535-47bb-0310-9956-ffa450edef68

14 years agoupdate version
fhanik [Wed, 19 Jan 2011 21:54:08 +0000 (21:54 +0000)]
update version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061023 13f79535-47bb-0310-9956-ffa450edef68

14 years agodoco update
fhanik [Wed, 19 Jan 2011 21:45:20 +0000 (21:45 +0000)]
doco update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1061017 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=50613
fhanik [Wed, 19 Jan 2011 21:25:08 +0000 (21:25 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50613
Fix concurrency bug around size calculation for the pool

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060998 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRename in preparation for https://issues.apache.org/bugzilla/show_bug.cgi?id=50535
markt [Wed, 19 Jan 2011 19:36:58 +0000 (19:36 +0000)]
Rename in preparation for https://issues.apache.org/bugzilla/show_bug.cgi?id=50535

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060927 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50601
markt [Wed, 19 Jan 2011 19:08:36 +0000 (19:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50601
Code clean-up
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060907 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate the ipv4 loopback regex to cover 127.0.0.1/8. Fortunately, ipv6 only has a...
markt [Wed, 19 Jan 2011 19:02:22 +0000 (19:02 +0000)]
Update the ipv4 loopback regex to cover 127.0.0.1/8. Fortunately, ipv6 only has a single explicit loopback address.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060901 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove reflection part of stack trace when Catalina throws an Exception - makes it...
markt [Wed, 19 Jan 2011 18:14:51 +0000 (18:14 +0000)]
Remove reflection part of stack trace when Catalina throws an Exception - makes it easier to see what went wrong

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060891 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFindbugs
markt [Wed, 19 Jan 2011 11:39:06 +0000 (11:39 +0000)]
Findbugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060772 13f79535-47bb-0310-9956-ffa450edef68

14 years agoExpand the non-Tomcat settings section
markt [Wed, 19 Jan 2011 01:01:42 +0000 (01:01 +0000)]
Expand the non-Tomcat settings section

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060643 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=22278
markt [Wed, 19 Jan 2011 00:00:59 +0000 (00:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=22278
Add a commented out RemoteAddrValve that limits access to the Manager and Host Manager applications to localhost.
Based on a patch by Yann Cébron.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060627 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Findbugs and Eclipse warnings
markt [Tue, 18 Jan 2011 21:33:14 +0000 (21:33 +0000)]
Fix Findbugs and Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060586 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix the last of the high priority FindBugs warnings
markt [Tue, 18 Jan 2011 18:57:45 +0000 (18:57 +0000)]
Fix the last of the high priority FindBugs warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060538 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect a typo in documentation
kkolinko [Tue, 18 Jan 2011 18:38:02 +0000 (18:38 +0000)]
Correct a typo in documentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060524 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDocumentation fixes:
kkolinko [Tue, 18 Jan 2011 17:30:24 +0000 (17:30 +0000)]
Documentation fixes:
1) role name: s/manager/manager-script/ (BZ 50599),
s/manager-script/admin-script/ on 401/403 pages of host-manager webapp (a typo)
2) there is no property "debug" on the Context, nor on several other classes (realms, authenticators)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060486 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect a pair of typos in documentation
kkolinko [Tue, 18 Jan 2011 07:46:18 +0000 (07:46 +0000)]
Correct a pair of typos in documentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060226 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50599
markt [Mon, 17 Jan 2011 17:31:45 +0000 (17:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50599
Use correct names of security roles for Manager app

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1060015 13f79535-47bb-0310-9956-ffa450edef68