tomcat7.0
16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=47330
markt [Thu, 5 Nov 2009 02:03:12 +0000 (02:03 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=47330
Add RemoteIpValve
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832974 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse Eclipse quick fix to remove unused imports
markt [Thu, 5 Nov 2009 01:30:02 +0000 (01:30 +0000)]
Use Eclipse quick fix to remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832963 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd other @Override annotations identified by Eclipse
markt [Thu, 5 Nov 2009 01:28:51 +0000 (01:28 +0000)]
Add other @Override annotations identified by Eclipse

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832961 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:22:13 +0000 (01:22 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb
This is the final patch for this bug fix.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832957 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:21:11 +0000 (01:21 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832956 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:19:20 +0000 (01:19 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832955 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:18:05 +0000 (01:18 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832954 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:16:53 +0000 (01:16 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832953 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:14:16 +0000 (01:14 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832951 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:13:12 +0000 (01:13 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb with some additional issues reported by Eclispe

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832950 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a few annotations missed by recent patches
markt [Thu, 5 Nov 2009 01:09:39 +0000 (01:09 +0000)]
Add a few annotations missed by recent patches

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832949 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 00:58:58 +0000 (00:58 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832945 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48131
markt [Thu, 5 Nov 2009 00:46:07 +0000 (00:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48131
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832938 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48123
markt [Thu, 5 Nov 2009 00:34:33 +0000 (00:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48123
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832931 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48121
markt [Thu, 5 Nov 2009 00:30:25 +0000 (00:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48121
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832928 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48120
markt [Thu, 5 Nov 2009 00:28:09 +0000 (00:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48120
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832927 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48117
markt [Thu, 5 Nov 2009 00:26:28 +0000 (00:26 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48117
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832926 13f79535-47bb-0310-9956-ffa450edef68

16 years agorevert based on https://issues.apache.org/bugzilla/show_bug.cgi?id=47512#c4
funkman [Wed, 4 Nov 2009 16:40:16 +0000 (16:40 +0000)]
revert based on https://issues.apache.org/bugzilla/show_bug.cgi?id=47512#c4

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832792 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBugfix typos from 48119
idarwin [Wed, 4 Nov 2009 13:26:33 +0000 (13:26 +0000)]
Bugfix typos from 48119

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832734 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBugfix typos from 48118
idarwin [Wed, 4 Nov 2009 13:13:41 +0000 (13:13 +0000)]
Bugfix typos from 48118

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832733 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a comment
kkolinko [Wed, 4 Nov 2009 10:16:36 +0000 (10:16 +0000)]
Add a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832697 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBinding java.lang.reflect.Proxy to JNDI directory raises java.lang.ClassCastException
funkman [Wed, 4 Nov 2009 01:18:08 +0000 (01:18 +0000)]
Binding java.lang.reflect.Proxy to JNDI directory raises java.lang.ClassCastException
https://issues.apache.org/bugzilla/show_bug.cgi?id=47512

Also acts as dead code removal

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832638 13f79535-47bb-0310-9956-ffa450edef68

16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=46947
funkman [Wed, 4 Nov 2009 00:54:02 +0000 (00:54 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=46947

Code cleanup patch that removes some obsolete null checks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832636 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unnecessary argument
kkolinko [Tue, 3 Nov 2009 03:04:17 +0000 (03:04 +0000)]
Remove unnecessary argument

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832284 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48066
markt [Tue, 3 Nov 2009 00:25:54 +0000 (00:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48066
Be explicit about including Ant on the compilation classpath

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832221 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47918
markt [Tue, 3 Nov 2009 00:20:18 +0000 (00:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47918
Fix copy and paste descriptions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832218 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48102 and https://issues.apach...
markt [Tue, 3 Nov 2009 00:16:42 +0000 (00:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48102 and https://issues.apache.org/bugzilla/show_bug.cgi?id=48103
Typos in Javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832216 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48104
markt [Tue, 3 Nov 2009 00:14:11 +0000 (00:14 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48104
Align Javadoc, usage message and code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832214 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPort r671153 and r671459 from tcnative branch 1.1.x
rjung [Tue, 3 Nov 2009 00:00:18 +0000 (00:00 +0000)]
Port r671153 and r671459 from tcnative branch 1.1.x
to Tomcat trunk:

Log the exception when the file we dlopen exists.
Otherwise errors like:
+++
java.lang.UnsatisfiedLinkError: /home/jfclere/jbossweb_trunk/output/build/bin/META-INF/lib/linux2/x64/libaprutil-1.so.0.2.8: libpq.so.3: cannot open shared object file: No such file or directory
+++
Can't be traced.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832211 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTrivial typo fix in comment.
rjung [Mon, 2 Nov 2009 23:34:48 +0000 (23:34 +0000)]
Trivial typo fix in comment.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832198 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove Thread class from jni.
rjung [Mon, 2 Nov 2009 22:34:45 +0000 (22:34 +0000)]
Remove Thread class from jni.
It does not exist in TC 6 and is neither used
not especially functional..
We keep it in TC 5.5 though.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832165 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove Buffer class from jni.
rjung [Mon, 2 Nov 2009 22:15:34 +0000 (22:15 +0000)]
Remove Buffer class from jni.
It does not exist in TC 6 and is not used.
We keep it in TC 5.5 though.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832139 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.tomcat
markt [Mon, 2 Nov 2009 18:56:52 +0000 (18:56 +0000)]
StringBuffer -> StringBuilder for o.a.tomcat

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832050 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for tomcat-lite module
markt [Mon, 2 Nov 2009 18:52:31 +0000 (18:52 +0000)]
StringBuffer -> StringBuilder for tomcat-lite module

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832046 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for jdbc-pool module
markt [Mon, 2 Nov 2009 18:51:40 +0000 (18:51 +0000)]
StringBuffer -> StringBuilder for jdbc-pool module

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832045 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for bayeux module
markt [Mon, 2 Nov 2009 18:51:17 +0000 (18:51 +0000)]
StringBuffer -> StringBuilder for bayeux module

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832044 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for unit tests
markt [Mon, 2 Nov 2009 18:48:19 +0000 (18:48 +0000)]
StringBuffer -> StringBuilder for unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832041 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for webapps
markt [Mon, 2 Nov 2009 18:47:14 +0000 (18:47 +0000)]
StringBuffer -> StringBuilder for webapps

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832040 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.naming
markt [Mon, 2 Nov 2009 18:46:21 +0000 (18:46 +0000)]
StringBuffer -> StringBuilder for o.a.naming

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832039 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.juli
markt [Mon, 2 Nov 2009 18:45:45 +0000 (18:45 +0000)]
StringBuffer -> StringBuilder for o.a.juli

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832037 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.jasper
markt [Mon, 2 Nov 2009 18:45:17 +0000 (18:45 +0000)]
StringBuffer -> StringBuilder for o.a.jasper

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832036 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.el
markt [Mon, 2 Nov 2009 18:42:21 +0000 (18:42 +0000)]
StringBuffer -> StringBuilder for o.a.el

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832031 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.coyote
markt [Mon, 2 Nov 2009 18:41:20 +0000 (18:41 +0000)]
StringBuffer -> StringBuilder for o.a.coyote

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832028 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c
markt [Mon, 2 Nov 2009 18:39:56 +0000 (18:39 +0000)]
StringBuffer -> StringBuilder for o.a.c

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832026 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.valves
markt [Mon, 2 Nov 2009 18:39:31 +0000 (18:39 +0000)]
StringBuffer -> StringBuilder for o.a.c.valves

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832025 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.util
markt [Mon, 2 Nov 2009 18:38:47 +0000 (18:38 +0000)]
StringBuffer -> StringBuilder for o.a.c.util

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832023 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.users
markt [Mon, 2 Nov 2009 18:38:00 +0000 (18:38 +0000)]
StringBuffer -> StringBuilder for o.a.c.users

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832022 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.tribes
markt [Mon, 2 Nov 2009 18:37:26 +0000 (18:37 +0000)]
StringBuffer -> StringBuilder for o.a.c.tribes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832021 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.startup
markt [Mon, 2 Nov 2009 18:36:23 +0000 (18:36 +0000)]
StringBuffer -> StringBuilder for o.a.c.startup

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832020 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.ssi
markt [Mon, 2 Nov 2009 18:35:52 +0000 (18:35 +0000)]
StringBuffer -> StringBuilder for o.a.c.ssi

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832019 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.session
markt [Mon, 2 Nov 2009 18:34:13 +0000 (18:34 +0000)]
StringBuffer -> StringBuilder for o.a.c.session

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832018 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.servlets
markt [Mon, 2 Nov 2009 18:33:41 +0000 (18:33 +0000)]
StringBuffer -> StringBuilder for o.a.c.servlets

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832017 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.realm
markt [Mon, 2 Nov 2009 18:33:01 +0000 (18:33 +0000)]
StringBuffer -> StringBuilder for o.a.c.realm

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832015 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.mbeans
markt [Mon, 2 Nov 2009 18:32:29 +0000 (18:32 +0000)]
StringBuffer -> StringBuilder for o.a.c.mbeans

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832014 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.manager
markt [Mon, 2 Nov 2009 18:32:07 +0000 (18:32 +0000)]
StringBuffer -> StringBuilder for o.a.c.manager

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832013 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.loader
markt [Mon, 2 Nov 2009 18:31:26 +0000 (18:31 +0000)]
StringBuffer -> StringBuilder for o.a.c.loader

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832011 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.ha
markt [Mon, 2 Nov 2009 18:30:21 +0000 (18:30 +0000)]
StringBuffer -> StringBuilder for o.a.c.ha

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832007 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.filters
markt [Mon, 2 Nov 2009 18:29:13 +0000 (18:29 +0000)]
StringBuffer -> StringBuilder for o.a.c.filters

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832005 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.deploy
markt [Mon, 2 Nov 2009 18:28:37 +0000 (18:28 +0000)]
StringBuffer -> StringBuilder for o.a.c.deploy

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832004 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.core
markt [Mon, 2 Nov 2009 18:27:32 +0000 (18:27 +0000)]
StringBuffer -> StringBuilder for o.a.c.core

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832003 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.connector
markt [Mon, 2 Nov 2009 18:25:58 +0000 (18:25 +0000)]
StringBuffer -> StringBuilder for o.a.c.connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832002 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.authenticator
markt [Mon, 2 Nov 2009 18:25:32 +0000 (18:25 +0000)]
StringBuffer -> StringBuilder for o.a.c.authenticator

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832000 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for o.a.c.ant
markt [Mon, 2 Nov 2009 18:24:49 +0000 (18:24 +0000)]
StringBuffer -> StringBuilder for o.a.c.ant

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831999 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringBuffer -> StringBuilder for javax.servlet
markt [Mon, 2 Nov 2009 18:16:36 +0000 (18:16 +0000)]
StringBuffer -> StringBuilder for javax.servlet

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831997 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47881
kkolinko [Mon, 2 Nov 2009 11:00:01 +0000 (11:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47881
Fix processing of "startd" and "stopd" arguments, when they are not alone.
Patch by Qingyang Xu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831860 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMark JspCompilationContext#removed as volatile,
kkolinko [Mon, 2 Nov 2009 10:30:49 +0000 (10:30 +0000)]
Mark JspCompilationContext#removed as volatile,
because JspCompilationContext#isRemoved() is called from JspServletWrapper#service,
and that access is not synchronized.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831850 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48097
kkolinko [Mon, 2 Nov 2009 09:12:10 +0000 (09:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48097
Make SecurityClassLoad to preload o.a.c.loader.ResourceEntry class

It is port of a patch from tc6.0.
I have not really tested it in trunk, though, because running TC 7 with SecurityManager currently fails because of other issues.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831830 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake WebappClassLoader to do not swallow AccessControlException
kkolinko [Mon, 2 Nov 2009 09:03:13 +0000 (09:03 +0000)]
Make WebappClassLoader to do not swallow AccessControlException
See https://issues.apache.org/bugzilla/show_bug.cgi?id=48097

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831828 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPack servlet 3.0 classes into servlet-api.jar
kkolinko [Mon, 2 Nov 2009 08:55:33 +0000 (08:55 +0000)]
Pack servlet 3.0 classes into servlet-api.jar

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831822 13f79535-47bb-0310-9956-ffa450edef68

16 years agoInclude root cause exception into the one produced by ApplicationContextFacade#doPriv...
kkolinko [Mon, 2 Nov 2009 08:37:41 +0000 (08:37 +0000)]
Include root cause exception into the one produced by ApplicationContextFacade#doPrivileged()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831819 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47331
markt [Mon, 2 Nov 2009 00:30:55 +0000 (00:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47331
Uninterpreted tags are essentially template text so apply the rules of JSp.2.2 there too.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831785 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAs per Remy's feedback, auto-switching cookie version is OK and we should also do...
markt [Sun, 1 Nov 2009 23:22:18 +0000 (23:22 +0000)]
As per Remy's feedback, auto-switching cookie version is OK and we should also do it if a comment is specified

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831782 13f79535-47bb-0310-9956-ffa450edef68

16 years agoOpps. Missed this file in cookie name/null/length patch
markt [Sun, 1 Nov 2009 23:20:53 +0000 (23:20 +0000)]
Opps. Missed this file in cookie name/null/length patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831781 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd unit tests for blank/null cookie names
markt [Sun, 1 Nov 2009 23:05:26 +0000 (23:05 +0000)]
Add unit tests for blank/null cookie names

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831780 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDon't allow null or zero length cookie names.
markt [Sun, 1 Nov 2009 23:04:33 +0000 (23:04 +0000)]
Don't allow null or zero length cookie names.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831779 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47451
markt [Sun, 1 Nov 2009 22:53:29 +0000 (22:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47451
Don't trigger an NPE if headers with null or zero length name or set or if a null value is specified. Silently ignore any such calls in the same way the calls are ignored if the response has already been committed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831774 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTrying to merge filter maps is a bad idea.
markt [Sun, 1 Nov 2009 21:46:09 +0000 (21:46 +0000)]
Trying to merge filter maps is a bad idea.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831764 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix bug in display name merge
markt [Sun, 1 Nov 2009 19:58:24 +0000 (19:58 +0000)]
Fix bug in display name merge

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831751 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
markt [Sun, 1 Nov 2009 18:35:02 +0000 (18:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
Document that HttpServletRequest.getAttributeNames() does not return the names of all attributes (internal Tomcat attributes are excluded)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831722 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix ReplicationValve crossContext support
pero [Sun, 1 Nov 2009 18:29:14 +0000 (18:29 +0000)]
Fix ReplicationValve crossContext support

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831718 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd another feature to the Tomcat based unit tests.
markt [Sun, 1 Nov 2009 18:16:57 +0000 (18:16 +0000)]
Add another feature to the Tomcat based unit tests.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831716 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a new new cookie option to allow the use of equals signs in cookies. Includes...
markt [Sat, 31 Oct 2009 14:09:02 +0000 (14:09 +0000)]
Add a new new cookie option to allow the use of equals signs in cookies. Includes test cases and docs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831544 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd an explicit configuration option for cookie version switching and update test...
markt [Sat, 31 Oct 2009 12:59:51 +0000 (12:59 +0000)]
Add an explicit configuration option for cookie version switching and update test cases and docs to include it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831536 13f79535-47bb-0310-9956-ffa450edef68

16 years agoNew cookie unit tests and associated refactoring to get ant test target working.
markt [Sat, 31 Oct 2009 11:46:50 +0000 (11:46 +0000)]
New cookie unit tests and associated refactoring to get ant test target working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831533 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefactoring to allow easier re-use.
markt [Sat, 31 Oct 2009 11:01:48 +0000 (11:01 +0000)]
Refactoring to allow easier re-use.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831530 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRe-add code that was incorrectly removed in recent changes
markt [Fri, 30 Oct 2009 16:02:40 +0000 (16:02 +0000)]
Re-add code that was incorrectly removed in recent changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831361 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix a documentation bug:
kkolinko [Fri, 30 Oct 2009 06:37:47 +0000 (06:37 +0000)]
Fix a documentation bug:
To enable SSL in TC 6.0 and later you set SSLEnabled=true, not secure=true as it was in TC 5.5.

Also added a phrase about secure and schema attributes. The text is nearly identical to the one in the SSLEnabled attribute description above on the same page. If anyone has a better phrase, you are welcome.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831212 13f79535-47bb-0310-9956-ffa450edef68

16 years agoApply Konstantin's review comments
markt [Thu, 29 Oct 2009 22:14:26 +0000 (22:14 +0000)]
Apply Konstantin's review comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831116 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSSL should be based on SSLEnabled, not secure flag
fhanik [Thu, 29 Oct 2009 21:48:04 +0000 (21:48 +0000)]
SSL should be based on SSLEnabled, not secure flag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831106 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd an option to strictly enforce cookie naming rules.
markt [Thu, 29 Oct 2009 19:26:52 +0000 (19:26 +0000)]
Add an option to strictly enforce cookie naming rules.
I'm not wild about the implementation but since we can't change the API, this was the best I could come up with. Suggestions for improvements welcome.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831069 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd system property to control treatment of / as a separator when processing cookies
markt [Thu, 29 Oct 2009 18:36:49 +0000 (18:36 +0000)]
Add system property to control treatment of / as a separator when processing cookies
Modify ALWAYS_ADD_EXPIRES so STRICT_SERVLET_COMPLIANCE changes the default to a strict interpretation of the specs

Note: I'll refactor the common code into a Constants class once I am finished but I'm doing that last as the refactoring won't be proposed for back-port to 6.0.x/5.5.x

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831059 13f79535-47bb-0310-9956-ffa450edef68

16 years agoThe single quote character ' is not a separator so it is allowed in unquoted values.
markt [Thu, 29 Oct 2009 15:27:58 +0000 (15:27 +0000)]
The single quote character ' is not a separator so it is allowed in unquoted values.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830999 13f79535-47bb-0310-9956-ffa450edef68

16 years agoNo longer required since all connectors now use acceptors
markt [Thu, 29 Oct 2009 14:39:38 +0000 (14:39 +0000)]
No longer required since all connectors now use acceptors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830965 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake leak prevention listener more configurable
markt [Thu, 29 Oct 2009 12:03:48 +0000 (12:03 +0000)]
Make leak prevention listener more configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830908 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClean-up - no functional change
markt [Thu, 29 Oct 2009 10:58:49 +0000 (10:58 +0000)]
Clean-up - no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830890 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a workaround for a common cause of locked files.
markt [Wed, 28 Oct 2009 19:25:31 +0000 (19:25 +0000)]
Add a workaround for a common cause of locked files.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830736 13f79535-47bb-0310-9956-ffa450edef68

16 years agoEnsure thread ratio calc is valid
markt [Wed, 28 Oct 2009 15:30:49 +0000 (15:30 +0000)]
Ensure thread ratio calc is valid

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830589 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd FilterMaps to the web.xml file merge process
markt [Wed, 28 Oct 2009 12:27:42 +0000 (12:27 +0000)]
Add FilterMaps to the web.xml file merge process

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830514 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd some test cases for ordering.
markt [Wed, 28 Oct 2009 11:49:48 +0000 (11:49 +0000)]
Add some test cases for ordering.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830508 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRe-factoring to make testing easier
markt [Wed, 28 Oct 2009 11:48:50 +0000 (11:48 +0000)]
Re-factoring to make testing easier

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830506 13f79535-47bb-0310-9956-ffa450edef68