tomcat7.0
14 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
markt [Tue, 4 Jan 2011 18:28:23 +0000 (18:28 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49000
Consistently handle name only cookies (which are not spec complaint)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055132 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRe-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49372
markt [Tue, 4 Jan 2011 17:57:16 +0000 (17:57 +0000)]
Re-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49372
Don't throw an LifecycleException for an invalid transition if a connector fails to start.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055121 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50541
markt [Tue, 4 Jan 2011 17:35:06 +0000 (17:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50541
Add support for sizeLimit and timeLimit on the JNDIRealm

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055115 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo
markt [Tue, 4 Jan 2011 17:09:48 +0000 (17:09 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055103 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50488
markt [Tue, 4 Jan 2011 16:56:58 +0000 (16:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50488
Update classpath required when using jsvc and add a note regarding server VMs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055101 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a test case of no user name change
fhanik [Tue, 4 Jan 2011 15:55:18 +0000 (15:55 +0000)]
Add a test case of no user name change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055085 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50500
markt [Tue, 4 Jan 2011 14:22:52 +0000 (14:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50500
Use correct coercions (as per the EL spec) for arithmetic operations involving string values containing '.', 'e' or 'E'. Based on a patch by Brian Weisleder.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1055055 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused imports
markt [Tue, 4 Jan 2011 11:53:32 +0000 (11:53 +0000)]
Remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054987 13f79535-47bb-0310-9956-ffa450edef68

14 years agoone 0 too many on username test
fhanik [Mon, 3 Jan 2011 23:28:42 +0000 (23:28 +0000)]
one 0 too many on username test
make sure the driver correctly checks url

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054824 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUp the number of iterations the test runs
fhanik [Mon, 3 Jan 2011 22:33:06 +0000 (22:33 +0000)]
Up the number of iterations the test runs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054812 13f79535-47bb-0310-9956-ffa450edef68

14 years agoversion
fhanik [Mon, 3 Jan 2011 22:18:11 +0000 (22:18 +0000)]
version

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054804 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIncrement version number
fhanik [Mon, 3 Jan 2011 22:15:35 +0000 (22:15 +0000)]
Increment version number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054803 13f79535-47bb-0310-9956-ffa450edef68

14 years agoadd in ability to pass through credentials
fhanik [Mon, 3 Jan 2011 22:14:21 +0000 (22:14 +0000)]
add in ability to pass through credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=50025

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054801 13f79535-47bb-0310-9956-ffa450edef68

14 years agobetter count check
fhanik [Mon, 3 Jan 2011 20:11:50 +0000 (20:11 +0000)]
better count check

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054730 13f79535-47bb-0310-9956-ffa450edef68

14 years agoupdate link
fhanik [Mon, 3 Jan 2011 20:08:47 +0000 (20:08 +0000)]
update link

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054729 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate Copyright year.
rjung [Mon, 3 Jan 2011 14:00:29 +0000 (14:00 +0000)]
Update Copyright year.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1054620 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove documentation of database connection factory.
rjung [Wed, 29 Dec 2010 20:42:04 +0000 (20:42 +0000)]
Improve documentation of database connection factory.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1053727 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 49159: Improve ThreadLocal memory leak clean-up
slaurent [Tue, 21 Dec 2010 22:26:55 +0000 (22:26 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159

- merged LocalStrings.properties file from package o.a.t.u.threads to o.a.t.u.threads.res
- removed 3 i18n keys that are no longer used by tc7. They were used by the old ThreadPool implementation of tc6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051682 13f79535-47bb-0310-9956-ffa450edef68

14 years agorefactor latch usage, since its shared by all connectors
fhanik [Tue, 21 Dec 2010 17:40:57 +0000 (17:40 +0000)]
refactor latch usage, since its shared by all connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051578 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix classpath
fhanik [Tue, 21 Dec 2010 17:40:34 +0000 (17:40 +0000)]
Fix classpath

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051577 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAllow to set log formatter when running Junit tests
fhanik [Tue, 21 Dec 2010 17:39:11 +0000 (17:39 +0000)]
Allow to set log formatter when running Junit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051576 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAllow to specify the test on the command line
fhanik [Tue, 21 Dec 2010 16:15:16 +0000 (16:15 +0000)]
Allow to specify the test on the command line
ant -Dtest.name=**/TestMax** test
Without the parameter, the default is all tests as specified before

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051540 13f79535-47bb-0310-9956-ffa450edef68

14 years agomake shared variable volatile
fhanik [Tue, 21 Dec 2010 16:14:24 +0000 (16:14 +0000)]
make shared variable volatile

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051539 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix webappClassLoader.clearJbdc message key and message in LocalStrings.properties.
kfujino [Tue, 21 Dec 2010 09:47:15 +0000 (09:47 +0000)]
Fix webappClassLoader.clearJbdc message key and message in LocalStrings.properties.
Jbdc is corrected to jdbc.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051433 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50503.
kfujino [Tue, 21 Dec 2010 06:56:09 +0000 (06:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50503.
When web application has a version, Engine level Clustering works correctly.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051392 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Checkstyle / Eclipse nags
markt [Tue, 21 Dec 2010 01:57:50 +0000 (01:57 +0000)]
Fix Checkstyle / Eclipse nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051358 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRestore file accidently removed in r1044731
markt [Tue, 21 Dec 2010 01:56:04 +0000 (01:56 +0000)]
Restore file accidently removed in r1044731

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051357 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Checkstyle / Eclipse nags
markt [Tue, 21 Dec 2010 01:53:34 +0000 (01:53 +0000)]
Fix Checkstyle / Eclipse nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051356 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd in a default that doesnt throw a ClassNotFoundException that is simply ignored...
fhanik [Tue, 21 Dec 2010 00:32:25 +0000 (00:32 +0000)]
Add in a default that doesnt throw a ClassNotFoundException that is simply ignored, and allow a fast way to change the console formatter through a system property when no config file is used.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051342 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTest can piggy back on the 'ant test' auto switch between connectors
fhanik [Tue, 21 Dec 2010 00:24:24 +0000 (00:24 +0000)]
Test can piggy back on the 'ant test' auto switch between connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051335 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImplement maxConnections for NIO connector
fhanik [Mon, 20 Dec 2010 21:01:37 +0000 (21:01 +0000)]
Implement maxConnections for NIO connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051291 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImplement a maxConnection threshold for the JIoEndpoint, to be able to constraint...
fhanik [Mon, 20 Dec 2010 16:42:13 +0000 (16:42 +0000)]
Implement a maxConnection threshold for the JIoEndpoint, to be able to constraint how many connections the connector will accept

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051202 13f79535-47bb-0310-9956-ffa450edef68

14 years agoVersion numbers are defined in the properties file
markt [Mon, 20 Dec 2010 13:58:07 +0000 (13:58 +0000)]
Version numbers are defined in the properties file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1051106 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix unlikely FindBugs warning
markt [Sat, 18 Dec 2010 17:44:07 +0000 (17:44 +0000)]
Fix unlikely FindBugs warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050684 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Sat, 18 Dec 2010 17:43:41 +0000 (17:43 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050683 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSimplify based on StringManager changes
markt [Sat, 18 Dec 2010 17:43:01 +0000 (17:43 +0000)]
Simplify based on StringManager changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050682 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTypos. Sorry for the noise
markt [Sat, 18 Dec 2010 17:26:52 +0000 (17:26 +0000)]
Typos. Sorry for the noise

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050680 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warning in o.a.el.lang package
markt [Sat, 18 Dec 2010 17:19:50 +0000 (17:19 +0000)]
Fix remaining warning in o.a.el.lang package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050679 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix most of the Java, Findbugs and unused code warnings in this package
markt [Sat, 18 Dec 2010 16:23:09 +0000 (16:23 +0000)]
Fix most of the Java, Findbugs and unused code warnings in this package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050660 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Eclipse warnings
markt [Sat, 18 Dec 2010 15:52:07 +0000 (15:52 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050653 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining Eclipse warnings in o.a.juli
markt [Fri, 17 Dec 2010 22:09:28 +0000 (22:09 +0000)]
Fix remaining Eclipse warnings in o.a.juli

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050504 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining Eclipse warnings in o.a.coyote
markt [Fri, 17 Dec 2010 22:06:33 +0000 (22:06 +0000)]
Fix remaining Eclipse warnings in o.a.coyote

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050502 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warnings in unit tests (with recently documented settings)
markt [Fri, 17 Dec 2010 22:01:59 +0000 (22:01 +0000)]
Fix remaining warnings in unit tests (with recently documented settings)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050500 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warnings in webapps (with recently documented settings)
markt [Fri, 17 Dec 2010 21:51:11 +0000 (21:51 +0000)]
Fix remaining warnings in webapps (with recently documented settings)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050499 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix remaining warnings in javax package (with recently documented settings)
markt [Fri, 17 Dec 2010 21:49:54 +0000 (21:49 +0000)]
Fix remaining warnings in javax package (with recently documented settings)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050498 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDocument the Eclipse compiler errors/warnings settings I am using
markt [Fri, 17 Dec 2010 21:47:52 +0000 (21:47 +0000)]
Document the Eclipse compiler errors/warnings settings I am using

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050497 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid a possible NPE that in turn was masking the root cause from JspC
markt [Fri, 17 Dec 2010 13:52:22 +0000 (13:52 +0000)]
Avoid a possible NPE that in turn was masking the root cause from JspC

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050384 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix massive memory leak in NIO connector. Http11NioProcessor objects were not being...
markt [Fri, 17 Dec 2010 00:17:18 +0000 (00:17 +0000)]
Fix massive memory leak in NIO connector. Http11NioProcessor objects were not being recycled.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050249 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=13731
markt [Thu, 16 Dec 2010 23:35:17 +0000 (23:35 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=13731
Make variables in <code>_jspService()</code> method final where possible.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050229 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStarting to work on maxConnections attribute for BIO/NIO connectors to allow administ...
fhanik [Thu, 16 Dec 2010 21:09:49 +0000 (21:09 +0000)]
Starting to work on maxConnections attribute for BIO/NIO connectors to allow administrators to throttle how accepting
connections is handled. Implement a CounterLatch to keep track of the
connection count while also allowing the acceptor
thread block while the max has been reached

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050161 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 48822: Include contest name in reload and stop log statements
slaurent [Thu, 16 Dec 2010 21:07:55 +0000 (21:07 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822

changelog + proposed for tomcat 6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050160 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 48822: Include contest name in reload and stop log statements
slaurent [Thu, 16 Dec 2010 20:40:36 +0000 (20:40 +0000)]
bug 48822: Include contest name in reload and stop log statements
https://issues.apache.org/bugzilla/show_bug.cgi?id=48822

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050150 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Findbugs issues / Eclipse warnings.
markt [Thu, 16 Dec 2010 19:39:58 +0000 (19:39 +0000)]
Fix Findbugs issues / Eclipse warnings.
Some genuine issues
Some changes to make code easier to read (for humans and analysis tools)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1050117 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix a FindBugs nag in the unit tests
markt [Thu, 16 Dec 2010 15:04:56 +0000 (15:04 +0000)]
Fix a FindBugs nag in the unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049997 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=10972
markt [Wed, 15 Dec 2010 17:58:05 +0000 (17:58 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=10972
Improve error message if the className attribute is missing on an element in server.xml where it is required.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049654 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=10526
markt [Wed, 15 Dec 2010 16:41:31 +0000 (16:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=10526
Add alwaysUseSession option to authenticators

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049638 13f79535-47bb-0310-9956-ffa450edef68

14 years agoWhilst I am thinking about excluding stuff from FindBugs - add some exceptions for...
markt [Wed, 15 Dec 2010 14:54:23 +0000 (14:54 +0000)]
Whilst I am thinking about excluding stuff from FindBugs - add some exceptions for the generated code with issues and fix the remaining issues in the same package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049572 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a FindBugs filter config for known false positives
markt [Wed, 15 Dec 2010 14:35:22 +0000 (14:35 +0000)]
Add a FindBugs filter config for known false positives

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049564 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix various warnings (FindBugs, Eclipse etc.)
markt [Wed, 15 Dec 2010 14:34:32 +0000 (14:34 +0000)]
Fix various warnings (FindBugs, Eclipse etc.)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049563 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix another FindBugs niggle
markt [Wed, 15 Dec 2010 13:53:22 +0000 (13:53 +0000)]
Fix another FindBugs niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049553 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary override
markt [Wed, 15 Dec 2010 13:31:28 +0000 (13:31 +0000)]
Remove unnecessary override

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049544 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix my stupid mistake.
markt [Wed, 15 Dec 2010 10:46:23 +0000 (10:46 +0000)]
Fix my stupid mistake.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049484 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix a typo
markt [Wed, 15 Dec 2010 00:57:58 +0000 (00:57 +0000)]
Fix a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049372 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdded documentation to parseBodyMethods and parseBodyMethodSet members.
schultz [Tue, 14 Dec 2010 20:53:07 +0000 (20:53 +0000)]
Added documentation to parseBodyMethods and parseBodyMethodSet members.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049264 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFixed bug #49125: toString on byte[] array probably is not correct
schultz [Tue, 14 Dec 2010 20:49:28 +0000 (20:49 +0000)]
Fixed bug #49125: toString on byte[] array probably is not correct
- Added HexUtils.toHexString method
- Wrapped output of byte[] objects with a call to HexUtils.toHexString

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049263 13f79535-47bb-0310-9956-ffa450edef68

14 years agoLog mis-configuration in context.xml
markt [Mon, 13 Dec 2010 15:57:54 +0000 (15:57 +0000)]
Log mis-configuration in context.xml

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1045201 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAliases were broken if the context was reloaded
markt [Mon, 13 Dec 2010 15:06:13 +0000 (15:06 +0000)]
Aliases were broken if the context was reloaded

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1045162 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix various FindBugs and Eclipse warnings
markt [Mon, 13 Dec 2010 14:50:17 +0000 (14:50 +0000)]
Fix various FindBugs and Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1045156 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUsing abstract classes means impl isn't clear in the startup log. Modify name so...
markt [Mon, 13 Dec 2010 12:47:04 +0000 (12:47 +0000)]
Using abstract classes means impl isn't clear in the startup log. Modify name so it is clear.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1045099 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
kkolinko [Mon, 13 Dec 2010 02:09:32 +0000 (02:09 +0000)]
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
- Use AtomicReference to guard against possible duplicate registration of
  listeners when logAccess() is called by several threads at the same time.
- Added install() and uninstall() method to AccessLogListener
  to help register/unregister the listeners.
- When defaultAccessLog is nulled, always unregister the listener as well.
  The listener does not need to be reused, because now we do create a listener
  when there is no log and it will take care of things.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1045003 13f79535-47bb-0310-9956-ffa450edef68

14 years agochangelog for r1044987
kkolinko [Mon, 13 Dec 2010 01:21:58 +0000 (01:21 +0000)]
changelog for r1044987

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044994 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
kkolinko [Mon, 13 Dec 2010 00:58:11 +0000 (00:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
Avoid leak caused by using a cached exception instance

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044987 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse i18n for the messages
kkolinko [Sun, 12 Dec 2010 22:33:09 +0000 (22:33 +0000)]
Use i18n for the messages
It is followup to r1042022 which was a fix for BZ 48973

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044944 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd some tests for bug50449 but haven't reproduced it yet
markt [Sun, 12 Dec 2010 19:50:45 +0000 (19:50 +0000)]
Add some tests for bug50449 but haven't reproduced it yet

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044898 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix FindBugs issues in this class
markt [Sun, 12 Dec 2010 19:35:56 +0000 (19:35 +0000)]
Fix FindBugs issues in this class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044896 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix FindBugs issues in this class
markt [Sun, 12 Dec 2010 19:27:13 +0000 (19:27 +0000)]
Fix FindBugs issues in this class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044895 13f79535-47bb-0310-9956-ffa450edef68

14 years agoi18n changes for r1044874
markt [Sun, 12 Dec 2010 18:55:52 +0000 (18:55 +0000)]
i18n changes for r1044874

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044881 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse the newly refactored session id generator when generating sso session IDs
markt [Sun, 12 Dec 2010 18:47:10 +0000 (18:47 +0000)]
Use the newly refactored session id generator when generating sso session IDs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044879 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRe-factor session ID generation into a separate class so it can be re-used for SSO...
markt [Sun, 12 Dec 2010 18:30:03 +0000 (18:30 +0000)]
Re-factor session ID generation into a separate class so it can be re-used for SSO (patch for that to follow)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044874 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix FindBugs issues in this class
markt [Sun, 12 Dec 2010 17:24:47 +0000 (17:24 +0000)]
Fix FindBugs issues in this class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044858 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and...
slaurent [Sun, 12 Dec 2010 00:16:33 +0000 (00:16 +0000)]
bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459

Fixed incorrect comment in code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044747 13f79535-47bb-0310-9956-ffa450edef68

14 years agobug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and...
slaurent [Sun, 12 Dec 2010 00:10:39 +0000 (00:10 +0000)]
bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459

This fixes the bug that was introduced by http://svn.apache.org/viewvc?rev=1044145&view=rev (introduced a dedicated thread when starting and stopping web applications to avoid mem leak)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044746 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTRy and sync up the deps in the POMs with what Checkstyle validates
markt [Sat, 11 Dec 2010 22:21:02 +0000 (22:21 +0000)]
TRy and sync up the deps in the POMs with what Checkstyle validates

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044731 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTribes should only depend on JULI
markt [Sat, 11 Dec 2010 22:20:10 +0000 (22:20 +0000)]
Tribes should only depend on JULI

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044730 13f79535-47bb-0310-9956-ffa450edef68

14 years agoo.a.tomcat.jni should not have any external dependencies
markt [Sat, 11 Dec 2010 21:48:22 +0000 (21:48 +0000)]
o.a.tomcat.jni should not have any external dependencies
OK for o.a.naming to have dependencies

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044729 13f79535-47bb-0310-9956-ffa450edef68

14 years agoo.a.tomcat.util.net should not depend on o.a.coyote
markt [Sat, 11 Dec 2010 21:35:18 +0000 (21:35 +0000)]
o.a.tomcat.util.net should not depend on o.a.coyote

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044727 13f79535-47bb-0310-9956-ffa450edef68

14 years agoo.a.tomcat.util.net should not depend on o.a.catalina
markt [Sat, 11 Dec 2010 21:14:45 +0000 (21:14 +0000)]
o.a.tomcat.util.net should not depend on o.a.catalina

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044723 13f79535-47bb-0310-9956-ffa450edef68

14 years agoGet the checkstyle configs to play nicely with Ant and the Eclipse plug-in
markt [Sat, 11 Dec 2010 20:58:28 +0000 (20:58 +0000)]
Get the checkstyle configs to play nicely with Ant and the Eclipse plug-in

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044716 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd import-control checks to Checkstyle (these found the recent dependency issues)
markt [Sat, 11 Dec 2010 20:38:42 +0000 (20:38 +0000)]
Add import-control checks to Checkstyle (these found the recent dependency issues)
Move checkstyle config to res/checkstyle to stop it cluttering up the root

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044710 13f79535-47bb-0310-9956-ffa450edef68

14 years agojavax.el should not depend on javax.servlet.jsp.el
markt [Sat, 11 Dec 2010 20:36:29 +0000 (20:36 +0000)]
javax.el should not depend on javax.servlet.jsp.el

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044708 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCoyote should not depend on Catalina
markt [Sat, 11 Dec 2010 18:27:15 +0000 (18:27 +0000)]
Coyote should not depend on Catalina

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044692 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50448
markt [Fri, 10 Dec 2010 13:54:16 +0000 (13:54 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50448
Regression caused by http://svn.apache.org/viewvc?view=revision&revision=1036281

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044359 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid duplicate constant definition.
markt [Fri, 10 Dec 2010 12:28:20 +0000 (12:28 +0000)]
Avoid duplicate constant definition.
Use Constants defined by the Servlet/JSP specs where appropriate
Use Constants in preference to local Strings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044326 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413
markt [Fri, 10 Dec 2010 10:11:38 +0000 (10:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413
Ensure 304s are not returned when using static files as error pages

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044266 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMissed file in r1044255
markt [Fri, 10 Dec 2010 10:06:44 +0000 (10:06 +0000)]
Missed file in r1044255

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044264 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix FindBugs / unused code warnings
markt [Fri, 10 Dec 2010 09:47:05 +0000 (09:47 +0000)]
Fix FindBugs / unused code warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044255 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Eclipse warnings in package
markt [Thu, 9 Dec 2010 23:58:20 +0000 (23:58 +0000)]
Fix Eclipse warnings in package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044178 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Eclipse warnings in package
markt [Thu, 9 Dec 2010 23:54:21 +0000 (23:54 +0000)]
Fix Eclipse warnings in package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044175 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove redundant interface definitions and fix other warnings (missing @Overrides...
markt [Thu, 9 Dec 2010 23:47:57 +0000 (23:47 +0000)]
Remove redundant interface definitions and fix other warnings (missing @Overrides) in same files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044171 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGrrr. Missed a couple of @Override markers
markt [Thu, 9 Dec 2010 23:30:15 +0000 (23:30 +0000)]
Grrr. Missed a couple of @Override markers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044164 13f79535-47bb-0310-9956-ffa450edef68