tomcat7.0
14 years agoAdd flags that indicate optional feature support
markt [Sun, 19 Jun 2011 21:23:14 +0000 (21:23 +0000)]
Add flags that indicate optional feature support

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137449 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReset sendfile data in recycle method so prepareRequest can be pulled up
markt [Sun, 19 Jun 2011 21:15:22 +0000 (21:15 +0000)]
Reset sendfile data in recycle method so prepareRequest can be pulled up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137440 13f79535-47bb-0310-9956-ffa450edef68

14 years agoExtend margin lese tests fail on Linux VM
markt [Sun, 19 Jun 2011 19:21:34 +0000 (19:21 +0000)]
Extend margin lese tests fail on Linux VM

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137417 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd an additional error margin to avoid false test failures
markt [Sun, 19 Jun 2011 17:28:26 +0000 (17:28 +0000)]
Add an additional error margin to avoid false test failures

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137391 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd missing sync that triggered test failures on Linux VM post re-factoring
markt [Sun, 19 Jun 2011 17:08:59 +0000 (17:08 +0000)]
Add missing sync that triggered test failures on Linux VM post re-factoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137390 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign with JIoEndpoint
markt [Sun, 19 Jun 2011 17:08:11 +0000 (17:08 +0000)]
Align with JIoEndpoint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137389 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up getBody message
markt [Sun, 19 Jun 2011 16:30:26 +0000 (16:30 +0000)]
Pull up getBody message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137385 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up common code
markt [Sun, 19 Jun 2011 15:56:22 +0000 (15:56 +0000)]
Pull up common code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137382 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up more common code in Processor constructors
markt [Sun, 19 Jun 2011 15:50:17 +0000 (15:50 +0000)]
Pull up more common code in Processor constructors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137381 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up common endpoint code in Processor constructors
markt [Sun, 19 Jun 2011 15:00:40 +0000 (15:00 +0000)]
Pull up common endpoint code in Processor constructors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137375 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNo need to for addToPoller in APR HTTP.
rjung [Sun, 19 Jun 2011 14:27:52 +0000 (14:27 +0000)]
No need to for addToPoller in APR HTTP.

When returning SocketState.OPEN the socket is
always added to the poller.

Fixes some crashes due to putting the same socket
twice in the poller.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137372 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd new timestamp formatting info to AccessLogValve
rjung [Sun, 19 Jun 2011 11:22:20 +0000 (11:22 +0000)]
Add new timestamp formatting info to AccessLogValve
docs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137338 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBZ 49165 and more:
rjung [Sun, 19 Jun 2011 10:58:02 +0000 (10:58 +0000)]
BZ 49165 and more:
- Allow any time stamp formats supported
  by SimpleDateFormat in AccessLogValve.
- Support logging begin and/or end of request.

Docs to follow.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137336 13f79535-47bb-0310-9956-ffa450edef68

14 years agoStart to pull up common code from constructors
markt [Sun, 19 Jun 2011 10:53:00 +0000 (10:53 +0000)]
Start to pull up common code from constructors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137335 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up definition of standard messages
markt [Sun, 19 Jun 2011 10:07:22 +0000 (10:07 +0000)]
Pull up definition of standard messages

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137329 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMore refactoring since last release
markt [Sun, 19 Jun 2011 09:50:17 +0000 (09:50 +0000)]
More refactoring since last release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137324 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse static final instead of volatile in
rjung [Sun, 19 Jun 2011 09:47:32 +0000 (09:47 +0000)]
Use static final instead of volatile in
AccessLogValve.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137323 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDon't use println to write output since os differences will result in different numbe...
markt [Sun, 19 Jun 2011 09:46:36 +0000 (09:46 +0000)]
Don't use println to write output since os differences will result in different numbers of bytes output

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137322 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Sat, 18 Jun 2011 13:41:17 +0000 (13:41 +0000)]
Connector re-factoring
Align APR with BIO/NIO

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137184 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Sat, 18 Jun 2011 13:03:50 +0000 (13:03 +0000)]
Connector re-factoring
Start to align APR with BIO/NIO

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137181 13f79535-47bb-0310-9956-ffa450edef68

14 years agoGump is failing. Re-order tests to try and figure out why.
markt [Sat, 18 Jun 2011 11:49:14 +0000 (11:49 +0000)]
Gump is failing. Re-order tests to try and figure out why.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137175 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSpeed up test
markt [Fri, 17 Jun 2011 22:46:12 +0000 (22:46 +0000)]
Speed up test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137062 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Fri, 17 Jun 2011 22:37:53 +0000 (22:37 +0000)]
Connector re-factoring
Broadly align NIO Handler.process with BIO Handler.process
Remove event() method from NIO handler

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137059 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Fri, 17 Jun 2011 22:16:26 +0000 (22:16 +0000)]
Connector re-factoring
Remove the need to track isAsync in the SocketWrapper

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137052 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSocketState.ASYNC_END should no longer reach BIO endpoint
markt [Fri, 17 Jun 2011 22:03:10 +0000 (22:03 +0000)]
SocketState.ASYNC_END should no longer reach BIO endpoint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137049 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Fri, 17 Jun 2011 22:01:35 +0000 (22:01 +0000)]
Connector re-factoring
Align Ajp impl with Http impl for BIO

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137048 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Fri, 17 Jun 2011 21:56:58 +0000 (21:56 +0000)]
Connector re-factoring
First step towards removing SocketState.ASYNC_END from the endpoint
Also a few percent faster, at least running the Async unit tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137047 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector refactoring
markt [Fri, 17 Jun 2011 21:41:32 +0000 (21:41 +0000)]
Connector refactoring
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137044 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector refactoring
markt [Fri, 17 Jun 2011 21:35:59 +0000 (21:35 +0000)]
Connector refactoring
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1137041 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConnector re-factoring
markt [Fri, 17 Jun 2011 16:17:21 +0000 (16:17 +0000)]
Connector re-factoring
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136923 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIgnore Eclipse files
markt [Fri, 17 Jun 2011 14:56:05 +0000 (14:56 +0000)]
Ignore Eclipse files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136902 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a simple Comet test case
markt [Fri, 17 Jun 2011 13:03:30 +0000 (13:03 +0000)]
Add a simple Comet test case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136867 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove empty dir
markt [Fri, 17 Jun 2011 12:12:46 +0000 (12:12 +0000)]
Remove empty dir

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136857 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove empty dir
markt [Fri, 17 Jun 2011 12:11:16 +0000 (12:11 +0000)]
Remove empty dir

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136855 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAligning code between connectors
markt [Fri, 17 Jun 2011 08:54:28 +0000 (08:54 +0000)]
Aligning code between connectors
Remove extra method from JIoEndpoint.Handler

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136812 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd missing transition
markt [Fri, 17 Jun 2011 08:33:23 +0000 (08:33 +0000)]
Add missing transition

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136806 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTomorrow is the 17th
markt [Thu, 16 Jun 2011 17:26:15 +0000 (17:26 +0000)]
Tomorrow is the 17th

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136552 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRelease tomorrow. Mirrors should have sync'd by then.
markt [Thu, 16 Jun 2011 17:25:50 +0000 (17:25 +0000)]
Release tomorrow. Mirrors should have sync'd by then.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136551 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51386
markt [Thu, 16 Jun 2011 17:24:03 +0000 (17:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51386
Correct code for processing @HandlesTypes annotations so only types of interest are reported to a ServletContainerInitializer.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136550 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign SSI regexp handling with htttpd
markt [Thu, 16 Jun 2011 12:28:01 +0000 (12:28 +0000)]
Align SSI regexp handling with htttpd

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136399 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd session="false" directive to the index page of the ROOT web application.
kkolinko [Thu, 16 Jun 2011 08:18:44 +0000 (08:18 +0000)]
Add session="false" directive to the index page of the ROOT web application.
There is no need to create a session when accessing this page.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136318 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48956
markt [Wed, 15 Jun 2011 22:44:00 +0000 (22:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48956
Implement regular expression support for SSI

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136231 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=43538
markt [Wed, 15 Jun 2011 21:58:00 +0000 (21:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43538
Add host name and IP address to the HTML Manager application.
Patch by Dennis Lundberg.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136216 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51376
markt [Wed, 15 Jun 2011 20:32:14 +0000 (20:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51376
Complete fix. Ensure Servlet.destroy() is only called if Servlet.init() was called.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136179 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up asyncDispatch()
markt [Wed, 15 Jun 2011 16:24:42 +0000 (16:24 +0000)]
Pull up asyncDispatch()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136108 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign code between connectors in preparation for pulling code up to the superclass
markt [Wed, 15 Jun 2011 16:19:06 +0000 (16:19 +0000)]
Align code between connectors in preparation for pulling code up to the superclass
No need to close the AJP connection if there was no error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136106 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign code between connectors in preparation for pulling code up to the superclass
markt [Wed, 15 Jun 2011 15:56:59 +0000 (15:56 +0000)]
Align code between connectors in preparation for pulling code up to the superclass
When returning SocketState.CLOSED, recycle is always called

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136099 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign code between connectors in preparation for pulling code up to the superclass
markt [Wed, 15 Jun 2011 15:46:54 +0000 (15:46 +0000)]
Align code between connectors in preparation for pulling code up to the superclass

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136091 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign code between connectors in preparation for pulling code up to the superclass
markt [Wed, 15 Jun 2011 15:43:53 +0000 (15:43 +0000)]
Align code between connectors in preparation for pulling code up to the superclass
No need to pass the socket into the asyncDispatch() call. It will always have been set beforehand.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136090 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd to the logging.properties file a sample configuration setting
kkolinko [Wed, 15 Jun 2011 14:48:11 +0000 (14:48 +0000)]
Add to the logging.properties file a sample configuration setting
for enabling debug messages in TldLocationsCache.
Slightly improve the messages printed by TldLocationsCache.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136073 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd sunmscapi.jar to jarsToSkip
kkolinko [Wed, 15 Jun 2011 14:32:08 +0000 (14:32 +0000)]
Add sunmscapi.jar to jarsToSkip
I found it in version 6u25 of Oracle JDK and JRE on Windows 32-bit.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136070 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50677
kkolinko [Wed, 15 Jun 2011 13:51:03 +0000 (13:51 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50677
Allow ANT style variables in the common.loader and other *.loader properties in conf/catalina.properties

I do not implement the substitution for any property as suggested by BZ 50677,
but only for the class loader ones. I think this is sufficient for the use case
and does not break backwards compatibility.
Most of the code is copied from ClassLoaderLogManager.replace().

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136043 13f79535-47bb-0310-9956-ffa450edef68

14 years agogit-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136028 13f79535-47bb-0310...
markt [Wed, 15 Jun 2011 13:21:16 +0000 (13:21 +0000)]
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136028 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix typo reported by @earthgecko
markt [Wed, 15 Jun 2011 12:55:24 +0000 (12:55 +0000)]
Fix typo reported by @earthgecko

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1136017 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix crash observed during pausing the connector when using APR.
rjung [Mon, 13 Jun 2011 18:14:46 +0000 (18:14 +0000)]
Fix crash observed during pausing the connector when using APR.

Only add socket to poller if we are sure we don't close it later.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1135208 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix copy&paste error in comment.
rjung [Mon, 13 Jun 2011 14:40:18 +0000 (14:40 +0000)]
Fix copy&paste error in comment.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1135115 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove superfluous quotes from thread names for
rjung [Mon, 13 Jun 2011 11:19:23 +0000 (11:19 +0000)]
Remove superfluous quotes from thread names for
connection pools.

Example broken thread name: "http-apr-8001"-exec-2
(including leading and intermediate quotes).

Since we never use the names as a full ObjectName,
only as a part of an ObjectName, it is safe to
remove the surrounding quotes from the Protocol name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1135088 13f79535-47bb-0310-9956-ffa450edef68

14 years agocorrect changelog.
kfujino [Mon, 13 Jun 2011 09:57:27 +0000 (09:57 +0000)]
correct changelog.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1135071 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51306.
kfujino [Mon, 13 Jun 2011 09:44:33 +0000 (09:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51306.
Avoid NPE when handleSESSION_EXPIRED is processed while handleSESSION_CREATED is being processed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1135069 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate the Maven repo info
markt [Sun, 12 Jun 2011 19:28:17 +0000 (19:28 +0000)]
Update the Maven repo info

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134965 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix unit test for bindOnInit.
rjung [Sun, 12 Jun 2011 15:47:53 +0000 (15:47 +0000)]
Fix unit test for bindOnInit.

Test failed when Java was binding sockets using
IPv4 and APR using IPv6. Since the connector
uses APR, and the test socket Java, both could bind
at the same time.

Observed on Solaris 10 Sparc.

Fixed by also uding APR to bind the test socket.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134938 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate ready for next release
markt [Sat, 11 Jun 2011 10:31:58 +0000 (10:31 +0000)]
Update ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134563 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd bug number for r1134048
kkolinko [Fri, 10 Jun 2011 08:15:16 +0000 (08:15 +0000)]
Add bug number for r1134048

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134227 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDocument the state transition diagram
markt [Thu, 9 Jun 2011 20:10:23 +0000 (20:10 +0000)]
Document the state transition diagram

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134063 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Javadoc error
markt [Thu, 9 Jun 2011 20:06:46 +0000 (20:06 +0000)]
Fix Javadoc error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134061 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrevent possible NPE when processing WebDAV locks.
markt [Thu, 9 Jun 2011 19:15:40 +0000 (19:15 +0000)]
Prevent possible NPE when processing WebDAV locks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134048 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51344
markt [Thu, 9 Jun 2011 19:04:37 +0000 (19:04 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51344
Fix problem with Lifecycle re-factoring for deprecated embedded class that prevented events being triggered.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1134042 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=51249
kkolinko [Thu, 9 Jun 2011 13:20:09 +0000 (13:20 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=51249
Reimplement system properties replacement code in ClassLoaderLogManager of JULI
1. Do not use recursion.
2. Do not stop on the first unrecognized property, but continue with the rest of the string.
3. Do not call System.getProperty() on an empty key, because it throws IllegalArgumentException. Threat "${}" as unrecognized property.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133857 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1133816
kkolinko [Thu, 9 Jun 2011 12:26:10 +0000 (12:26 +0000)]
Followup to r1133816
Remove properties that TortoiseSVN added to the new subdirectory.
It propagates those from the parent directory.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133824 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTests for ClassLoaderLogManager#replace()
kkolinko [Thu, 9 Jun 2011 12:03:25 +0000 (12:03 +0000)]
Tests for ClassLoaderLogManager#replace()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133816 13f79535-47bb-0310-9956-ffa450edef68

14 years agotypos
kkolinko [Thu, 9 Jun 2011 07:55:43 +0000 (07:55 +0000)]
typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133701 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRefactoring triggered security exception when running TCKs
markt [Wed, 8 Jun 2011 22:20:22 +0000 (22:20 +0000)]
Refactoring triggered security exception when running TCKs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133586 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51340
markt [Wed, 8 Jun 2011 15:52:26 +0000 (15:52 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51340
Fix thread-safety issue when parsing multiple web.xml files in parallel. Apache Tomcat does not do this but products that embed it may.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133446 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAvoid possible NPE
markt [Wed, 8 Jun 2011 13:52:50 +0000 (13:52 +0000)]
Avoid possible NPE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133401 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1133134.
kfujino [Wed, 8 Jun 2011 08:45:41 +0000 (08:45 +0000)]
Followup to r1133134.
I think better not dataSource but dataSourceName.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133288 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix regression in welcome file processing
markt [Wed, 8 Jun 2011 00:44:14 +0000 (00:44 +0000)]
Fix regression in welcome file processing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133221 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSimplify as per kkolinko's review
markt [Tue, 7 Jun 2011 23:56:14 +0000 (23:56 +0000)]
Simplify as per kkolinko's review

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133204 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog post valve changes
markt [Tue, 7 Jun 2011 23:50:55 +0000 (23:50 +0000)]
Update changelog post valve changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133202 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect a regression in the fix for bug 51278 that prevented any web application...
markt [Tue, 7 Jun 2011 23:48:17 +0000 (23:48 +0000)]
Correct a regression in the fix for bug 51278 that prevented any web application from being marked as distributable. (kfujino)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133201 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests.
markt [Tue, 7 Jun 2011 23:47:16 +0000 (23:47 +0000)]
Enable for async requests.
Looking for stuck threads - no special async support required here.
When the asycn timeout is infinite requests may get stuck but that'll need a different detection mechanism.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133200 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests.
markt [Tue, 7 Jun 2011 23:43:31 +0000 (23:43 +0000)]
Enable for async requests.
Async requests should appear as serial requests when requiring multiple internal requests so concurrency should behave as expected.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133199 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests.
markt [Tue, 7 Jun 2011 23:37:29 +0000 (23:37 +0000)]
Enable for async requests.
Depending on how async is used, may see multiple replication requests for a single async request.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133197 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests
markt [Tue, 7 Jun 2011 23:12:18 +0000 (23:12 +0000)]
Enable for async requests
Don't persist the session if processing an async request. Note: There may be some async states where the session could be safely persisted.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133193 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSimplify markup: remove <br/>s from the end of lines. They are not needed inside...
kkolinko [Tue, 7 Jun 2011 22:40:56 +0000 (22:40 +0000)]
Simplify markup: remove <br/>s from the end of lines. They are not needed inside the <source> tag.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133185 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign log4j configuration example with log4j documentation: start property names...
kkolinko [Tue, 7 Jun 2011 22:28:45 +0000 (22:28 +0000)]
Align log4j configuration example with log4j documentation: start property names with an uppercase character.
It is just a question of style: it should work either way.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133182 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests
markt [Tue, 7 Jun 2011 22:14:52 +0000 (22:14 +0000)]
Enable for async requests
Only look for a change on non-async requests. There will always be one of these before any async processing on a request so no need to check if the current request is in the middle of async processing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133177 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests (invoke just passes the request through so no issues with...
markt [Tue, 7 Jun 2011 22:05:31 +0000 (22:05 +0000)]
Enable for async requests (invoke just passes the request through so no issues with async)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133173 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnable for async requests
markt [Tue, 7 Jun 2011 22:04:44 +0000 (22:04 +0000)]
Enable for async requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133172 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1133122
kkolinko [Tue, 7 Jun 2011 21:56:16 +0000 (21:56 +0000)]
Followup to r1133122
if(flag) set flag:=false

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133170 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51264
markt [Tue, 7 Jun 2011 19:28:42 +0000 (19:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51264
Improve fix to return connections to the pool when not in use.
Patch provided by Felix Schumacher.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133134 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDon't use a single quote in the message
markt [Tue, 7 Jun 2011 19:04:41 +0000 (19:04 +0000)]
Don't use a single quote in the message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133131 13f79535-47bb-0310-9956-ffa450edef68

14 years ago7.0.15 was broken
markt [Tue, 7 Jun 2011 18:43:03 +0000 (18:43 +0000)]
7.0.15 was broken

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133128 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPrep for 7.0.16 tag
markt [Tue, 7 Jun 2011 18:42:36 +0000 (18:42 +0000)]
Prep for 7.0.16 tag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133127 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDon't overwhelm logs with TLD scanning messages but make users aware there is room...
markt [Tue, 7 Jun 2011 18:18:06 +0000 (18:18 +0000)]
Don't overwhelm logs with TLD scanning messages but make users aware there is room for improvement and tell them how to get at the detail.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133122 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a few more exclusions
markt [Tue, 7 Jun 2011 17:51:43 +0000 (17:51 +0000)]
Add a few more exclusions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133112 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51324
markt [Tue, 7 Jun 2011 14:00:16 +0000 (14:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51324
Improve handling of exceptions when flushing the response buffer to ensure that the doFlush flag does not get stuck in the enabled state.
Patch provided by Jeremy Norris.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1133014 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert r1132367. There is no issue. I got confused between AprEndpoint.SendfileData...
markt [Tue, 7 Jun 2011 09:22:44 +0000 (09:22 +0000)]
Revert r1132367. There is no issue. I got confused between AprEndpoint.SendfileData and NioEndpoint.SendfileData

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1132920 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect doc error reported on users list
markt [Mon, 6 Jun 2011 17:07:49 +0000 (17:07 +0000)]
Correct doc error reported on users list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1132703 13f79535-47bb-0310-9956-ffa450edef68

14 years agoOnly need 1 HexUtils class
markt [Mon, 6 Jun 2011 16:53:58 +0000 (16:53 +0000)]
Only need 1 HexUtils class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1132702 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert r1132487 and use Konstantin's suggested fix.
markt [Mon, 6 Jun 2011 16:53:37 +0000 (16:53 +0000)]
Revert r1132487 and use Konstantin's suggested fix.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1132700 13f79535-47bb-0310-9956-ffa450edef68