horde.git
14 years agoRemaining PHP5 code changes, Horde 4 style for kronolith
Michael J. Rubinsky [Wed, 26 Jan 2011 18:57:50 +0000 (13:57 -0500)]
Remaining PHP5 code changes, Horde 4 style for kronolith

14 years agoTweak some Test.php files.
Michael J. Rubinsky [Wed, 26 Jan 2011 17:14:02 +0000 (12:14 -0500)]
Tweak some Test.php files.

Remove redundant checks, update message for PDO to reflect current
state of Horde_Db driver support.

14 years agoremove PEAR::pushErrorHandling() call
Michael J. Rubinsky [Wed, 26 Jan 2011 16:59:40 +0000 (11:59 -0500)]
remove PEAR::pushErrorHandling() call

14 years agocatch exceptions
Michael J. Rubinsky [Wed, 26 Jan 2011 16:51:41 +0000 (11:51 -0500)]
catch exceptions

14 years agotypehinting, phpdoc, make Kronolith_FreeBusy_View abstract
Michael J. Rubinsky [Wed, 26 Jan 2011 16:36:23 +0000 (11:36 -0500)]
typehinting, phpdoc, make Kronolith_FreeBusy_View abstract

14 years agoHorde 4 CS, PHP5 for Kronolith_FreeBusy_*
Michael J. Rubinsky [Wed, 26 Jan 2011 16:22:57 +0000 (11:22 -0500)]
Horde 4 CS, PHP5 for Kronolith_FreeBusy_*

14 years agoFirst crack at converting Horde_History to Horde_Db. Tests pass; library has been...
Chuck Hagenbuch [Tue, 25 Jan 2011 14:39:59 +0000 (09:39 -0500)]
First crack at converting Horde_History to Horde_Db. Tests pass; library has been updated to only throw Horde_History exceptions so that we don't break encapsulation.

14 years agoDon't consider the connection active if the connection object is missing/false, and...
Chuck Hagenbuch [Tue, 25 Jan 2011 14:04:59 +0000 (09:04 -0500)]
Don't consider the connection active if the connection object is missing/false, and try reconnecting if the connection isn't active when execute() is called

14 years agoMerge branch 'db-migrate-for-framework'
Jan Schneider [Wed, 26 Jan 2011 17:52:25 +0000 (18:52 +0100)]
Merge branch 'db-migrate-for-framework'

Conflicts:
kronolith/scripts/upgrades/convert_datatree_shares_to_sql.php
kronolith/scripts/upgrades/convert_sql_shares_to_sqlng.php

14 years agoFix migration installation path.
Jan Schneider [Wed, 26 Jan 2011 17:50:22 +0000 (18:50 +0100)]
Fix migration installation path.

14 years agoFix installation path.
Jan Schneider [Wed, 26 Jan 2011 17:46:22 +0000 (18:46 +0100)]
Fix installation path.

14 years agoFix default value.
Jan Schneider [Wed, 26 Jan 2011 17:45:58 +0000 (18:45 +0100)]
Fix default value.

14 years agoExtend migration script to be more flexible.
Jan Schneider [Wed, 26 Jan 2011 17:45:41 +0000 (18:45 +0100)]
Extend migration script to be more flexible.

1) Run with directory name instead of application name to run all migrations in
that directory.
2) Run without any parameter to migrate all installed applications, all
installed PEAR packages, and all framework packages from a local checkout.

14 years agoremove old lowercase filename versions - artifact from case insensitive filesystem
Michael J. Rubinsky [Wed, 26 Jan 2011 17:39:58 +0000 (12:39 -0500)]
remove old lowercase filename versions - artifact from case insensitive filesystem

14 years agoDon't simply sort migration scripts by name, this is going to break when we
Jan Schneider [Wed, 26 Jan 2011 16:56:25 +0000 (17:56 +0100)]
Don't simply sort migration scripts by name, this is going to break when we
have schema versions with several digits.

14 years agoThe horde-db-migrate scripts requires the Autoloader.
Jan Schneider [Wed, 26 Jan 2011 16:43:07 +0000 (17:43 +0100)]
The horde-db-migrate scripts requires the Autoloader.

14 years agoAdd script to run any migration scripts from arbitrary directories.
Jan Schneider [Wed, 26 Jan 2011 16:41:55 +0000 (17:41 +0100)]
Add script to run any migration scripts from arbitrary directories.

14 years agoSearch all migration/ subdirectories for migration files. Now that's a piece of
Jan Schneider [Wed, 26 Jan 2011 16:40:27 +0000 (17:40 +0100)]
Search all migration/ subdirectories for migration files. Now that's a piece of
PHP5 code!

14 years agofix find/replace error
Michael J. Rubinsky [Wed, 26 Jan 2011 16:14:57 +0000 (11:14 -0500)]
fix find/replace error

14 years agoshare_parents field migration for sql and sqlng share drivers
Michael J. Rubinsky [Wed, 26 Jan 2011 15:22:29 +0000 (10:22 -0500)]
share_parents field migration for sql and sqlng share drivers

14 years agoRequires the Lock library.
Gunnar Wrobel [Wed, 26 Jan 2011 16:01:49 +0000 (17:01 +0100)]
Requires the Lock library.

14 years agoRequires the History package.
Gunnar Wrobel [Wed, 26 Jan 2011 15:48:45 +0000 (16:48 +0100)]
Requires the History package.

14 years agoDB is not optional. If it is required by an application there'll be a hard error.
Gunnar Wrobel [Wed, 26 Jan 2011 15:45:55 +0000 (16:45 +0100)]
DB is not optional. If it is required by an application there'll be a hard error.

14 years agoRequires Date_Parser.
Gunnar Wrobel [Wed, 26 Jan 2011 15:31:46 +0000 (16:31 +0100)]
Requires Date_Parser.

14 years agoPackage was removed a while ago.
Gunnar Wrobel [Wed, 26 Jan 2011 15:02:27 +0000 (16:02 +0100)]
Package was removed a while ago.

14 years agoRequires the Data package.
Gunnar Wrobel [Wed, 26 Jan 2011 14:47:46 +0000 (15:47 +0100)]
Requires the Data package.

14 years agoFix package name.
Gunnar Wrobel [Wed, 26 Jan 2011 11:01:06 +0000 (12:01 +0100)]
Fix package name.

14 years agoCore requires the Share system.
Gunnar Wrobel [Wed, 26 Jan 2011 10:28:11 +0000 (11:28 +0100)]
Core requires the Share system.

14 years agoFixed omission of "content/". The lib part of "content" needs to be role "horde"...
Gunnar Wrobel [Wed, 26 Jan 2011 10:08:53 +0000 (11:08 +0100)]
Fixed omission of "content/". The lib part of "content" needs to be role "horde" as well.

I need a different way of managing applications within components.

14 years agoRemove Horde_ from package name.
Gunnar Wrobel [Wed, 26 Jan 2011 09:49:18 +0000 (10:49 +0100)]
Remove Horde_ from package name.

14 years agoSupport the content package and add a package.xml for it.
Gunnar Wrobel [Wed, 26 Jan 2011 09:34:12 +0000 (10:34 +0100)]
Support the content package and add a package.xml for it.

14 years agoAlter prefs UI based on prefs displayed on page, rather than the pref group
Michael M Slusarz [Tue, 25 Jan 2011 23:30:07 +0000 (16:30 -0700)]
Alter prefs UI based on prefs displayed on page, rather than the pref group

14 years agoDon't process group if it is suppressed
Michael M Slusarz [Wed, 26 Jan 2011 00:27:44 +0000 (17:27 -0700)]
Don't process group if it is suppressed

14 years agoAdd the 'container' type to the prefs.php config file
Michael M Slusarz [Tue, 25 Jan 2011 22:55:51 +0000 (15:55 -0700)]
Add the 'container' type to the prefs.php config file

Only way I can think of at the moment to indicate to admins that these
prefs MUST be displayed on the same page (for UI reasons).

14 years agogetChangeablePrefs() defaults to the current prefs UI group
Michael M Slusarz [Tue, 25 Jan 2011 22:38:35 +0000 (15:38 -0700)]
getChangeablePrefs() defaults to the current prefs UI group

14 years agoRevert "Bug #9539: Correct translations for application names"
Michael M Slusarz [Tue, 25 Jan 2011 21:51:45 +0000 (14:51 -0700)]
Revert "Bug #9539: Correct translations for application names"

This reverts commit 9514d8c72c0ccda884094e3bdecfa2a6911d0264.

14 years agoMore correct way to report chora errors
Michael M Slusarz [Tue, 25 Jan 2011 21:47:19 +0000 (14:47 -0700)]
More correct way to report chora errors

Can't call Chora::fatal() from init() since it may be called during
Horde initialization.

14 years agoRevert "On chora init error, use Chora::fatal()"
Michael M Slusarz [Tue, 25 Jan 2011 21:38:06 +0000 (14:38 -0700)]
Revert "On chora init error, use Chora::fatal()"

This reverts commit f0224f9d168e52a6b84d4e725ec7db626f82d55c.

Conflicts:

chora/lib/Application.php

14 years agoUse POST, not GET, so URL form variables are available
Michael M Slusarz [Tue, 25 Jan 2011 19:47:05 +0000 (12:47 -0700)]
Use POST, not GET, so URL form variables are available

14 years agoClean up determination of current sourceroot
Michael M Slusarz [Tue, 25 Jan 2011 19:43:48 +0000 (12:43 -0700)]
Clean up determination of current sourceroot

14 years agoOn chora init error, use Chora::fatal()
Michael M Slusarz [Tue, 25 Jan 2011 19:25:43 +0000 (12:25 -0700)]
On chora init error, use Chora::fatal()

14 years agoFix variable name
Michael M Slusarz [Tue, 25 Jan 2011 19:19:31 +0000 (12:19 -0700)]
Fix variable name

14 years agoAdd more MIME address encoding tests
Michael M Slusarz [Tue, 25 Jan 2011 19:19:17 +0000 (12:19 -0700)]
Add more MIME address encoding tests

14 years agoBug #9532: Don't MIME encode maildrop autoresponse file
Michael M Slusarz [Tue, 25 Jan 2011 17:49:37 +0000 (10:49 -0700)]
Bug #9532: Don't MIME encode maildrop autoresponse file

14 years agoBug #9539: Correct translations for application names
Michael M Slusarz [Tue, 25 Jan 2011 17:25:41 +0000 (10:25 -0700)]
Bug #9539: Correct translations for application names

14 years agoadd mime decode unit test
Michael M Slusarz [Tue, 25 Jan 2011 17:23:21 +0000 (10:23 -0700)]
add mime decode unit test

14 years agoBug #9529: fix decode() call
Michael M Slusarz [Tue, 25 Jan 2011 17:04:38 +0000 (10:04 -0700)]
Bug #9529: fix decode() call

14 years agoBug #9529: Fix undefined error
Michael M Slusarz [Tue, 25 Jan 2011 09:52:54 +0000 (02:52 -0700)]
Bug #9529: Fix undefined error

14 years agoMake sure there is always logout reason set on validation failure
Michael M Slusarz [Tue, 25 Jan 2011 08:34:27 +0000 (01:34 -0700)]
Make sure there is always logout reason set on validation failure

14 years agoLogging/error message if shibboleth auth fails validation
Michael M Slusarz [Tue, 25 Jan 2011 08:32:27 +0000 (01:32 -0700)]
Logging/error message if shibboleth auth fails validation

14 years agoRemove stray file.
Gunnar Wrobel [Tue, 25 Jan 2011 09:24:50 +0000 (10:24 +0100)]
Remove stray file.

14 years agoMFB
Jan Schneider [Mon, 24 Jan 2011 20:23:50 +0000 (21:23 +0100)]
MFB

14 years agoMore user_uid column fixes.
Jan Schneider [Mon, 24 Jan 2011 17:58:58 +0000 (18:58 +0100)]
More user_uid column fixes.

14 years agoAdd a first version of the package.xml files for our groupware apps.
Gunnar Wrobel [Tue, 25 Jan 2011 09:10:40 +0000 (10:10 +0100)]
Add a first version of the package.xml files for our groupware apps.

14 years agoSupport generating package.xml files for our groupware applications.
Gunnar Wrobel [Tue, 25 Jan 2011 09:10:07 +0000 (10:10 +0100)]
Support generating package.xml files for our groupware applications.

14 years agoFix shibboleth authentication checking
Michael M Slusarz [Tue, 25 Jan 2011 07:07:00 +0000 (00:07 -0700)]
Fix shibboleth authentication checking

Need to check shibboleth auth username to the original auth username,
not the Horde username (since the Horde username may have been altered
post-login by a hook).

14 years agoBug #9325: Upgrade serialized prefs from Horde 3
Michael M Slusarz [Tue, 25 Jan 2011 06:16:37 +0000 (23:16 -0700)]
Bug #9325: Upgrade serialized prefs from Horde 3

14 years agophpdoc
Michael M Slusarz [Tue, 25 Jan 2011 06:17:47 +0000 (23:17 -0700)]
phpdoc

14 years agoAdd some utility functions to horde/Prefs
Michael M Slusarz [Tue, 25 Jan 2011 05:44:23 +0000 (22:44 -0700)]
Add some utility functions to horde/Prefs

14 years agoBug #9529: Store description internally as UTF-8, not in charset of part
Michael M Slusarz [Tue, 25 Jan 2011 00:55:14 +0000 (17:55 -0700)]
Bug #9529: Store description internally as UTF-8, not in charset of part

14 years agophpdoc
Michael M Slusarz [Tue, 25 Jan 2011 00:53:28 +0000 (17:53 -0700)]
phpdoc

14 years agoAdd header decode test
Michael M Slusarz [Tue, 25 Jan 2011 00:46:31 +0000 (17:46 -0700)]
Add header decode test

14 years agoConvert horde/Template to PHPUnit tests
Michael M Slusarz [Sat, 22 Jan 2011 00:05:30 +0000 (17:05 -0700)]
Convert horde/Template to PHPUnit tests

14 years agophpdoc
Michael M Slusarz [Tue, 25 Jan 2011 00:08:37 +0000 (17:08 -0700)]
phpdoc

14 years agoBetter IMP login logging when not using IMP as authentication method
Michael M Slusarz [Tue, 25 Jan 2011 00:04:27 +0000 (17:04 -0700)]
Better IMP login logging when not using IMP as authentication method

14 years agoFix logging details from IMAP transaction
Michael M Slusarz [Tue, 25 Jan 2011 00:03:19 +0000 (17:03 -0700)]
Fix logging details from IMAP transaction

14 years agoOnly show backtrace if logging at DEBUG level
Michael M Slusarz [Mon, 24 Jan 2011 23:51:55 +0000 (16:51 -0700)]
Only show backtrace if logging at DEBUG level

Otherwise, things like framework libraries that throw exceptions and
provide way of logging exceptions (e.g. Horde_Imap_Client) give
backtraces for items that should not need to be logged (e.g.
authentication failures).

14 years agoBug #9507: Pref language overrides login language
Michael M Slusarz [Mon, 24 Jan 2011 23:44:06 +0000 (16:44 -0700)]
Bug #9507: Pref language overrides login language

14 years agoUpdate package.xml.
Gunnar Wrobel [Mon, 24 Jan 2011 22:20:48 +0000 (23:20 +0100)]
Update package.xml.

14 years agoMake sure to catch any exceptions thrown trying to rollback the transaction. Still...
Chuck Hagenbuch [Mon, 24 Jan 2011 04:03:51 +0000 (23:03 -0500)]
Make sure to catch any exceptions thrown trying to rollback the transaction. Still trying to trace down a "Exception thrown without a stack frame in Unknown on line 0"

14 years agoAlways make sure that we have a logger before using it
Chuck Hagenbuch [Mon, 24 Jan 2011 03:59:37 +0000 (22:59 -0500)]
Always make sure that we have a logger before using it

14 years agoDB may have been closed before write() - reconnect if it's not active
Chuck Hagenbuch [Mon, 24 Jan 2011 03:59:04 +0000 (22:59 -0500)]
DB may have been closed before write() - reconnect if it's not active

14 years agoBug #9282: When creating Horde_Db objects, register them with a child injector before...
Chuck Hagenbuch [Mon, 24 Jan 2011 03:33:15 +0000 (22:33 -0500)]
Bug #9282: When creating Horde_Db objects, register them with a child injector before creating any dependencies that could in turn want a Horde_Db dependency.

14 years agoFix PHPUnit deprecation warnings
Chuck Hagenbuch [Mon, 24 Jan 2011 03:25:14 +0000 (22:25 -0500)]
Fix PHPUnit deprecation warnings

14 years agoRemove logging to a SQL backend - not usually a good use of a relational database...
Chuck Hagenbuch [Mon, 24 Jan 2011 03:21:04 +0000 (22:21 -0500)]
Remove logging to a SQL backend - not usually a good use of a relational database, and could cause circular dependency problems.

14 years agopackage.xml for Horde_PubSub
Chuck Hagenbuch [Mon, 24 Jan 2011 02:52:51 +0000 (21:52 -0500)]
package.xml for Horde_PubSub

14 years agoRemove unnecessary @todos
Chuck Hagenbuch [Mon, 24 Jan 2011 01:03:00 +0000 (20:03 -0500)]
Remove unnecessary @todos

14 years agoFix form name
Michael J. Rubinsky [Sun, 23 Jan 2011 22:18:09 +0000 (17:18 -0500)]
Fix form name

14 years agoFix tree graphics in the bookmark folder tree
Chuck Hagenbuch [Sun, 23 Jan 2011 21:56:38 +0000 (16:56 -0500)]
Fix tree graphics in the bookmark folder tree

14 years agouser_id is NOT NULL
Jan Schneider [Sun, 23 Jan 2011 21:36:28 +0000 (22:36 +0100)]
user_id is NOT NULL

14 years agoRevert commenting out cache code.
Jan Schneider [Sun, 23 Jan 2011 21:35:50 +0000 (22:35 +0100)]
Revert commenting out cache code.

14 years agoOne more place we need ids instead of names.
Michael J. Rubinsky [Sun, 23 Jan 2011 18:42:47 +0000 (13:42 -0500)]
One more place we need ids instead of names.

Add a utility function to act as callback to array_map, still need
to audit code for all places to use it.

14 years agoAdd test to ensure listShares results are keyed by name
Michael J. Rubinsky [Sun, 23 Jan 2011 18:25:33 +0000 (13:25 -0500)]
Add test to ensure listShares results are keyed by name

14 years agoHorde_Share::listShares() returns a hash keyed by name, not id.
Michael J. Rubinsky [Sun, 23 Jan 2011 18:15:30 +0000 (13:15 -0500)]
Horde_Share::listShares() returns a hash keyed by name, not id.

14 years agoCall alarmInit() (Bug #9519).
Jan Schneider [Sat, 22 Jan 2011 17:31:39 +0000 (18:31 +0100)]
Call alarmInit() (Bug #9519).

14 years agoRemove accidentally added file.
Jan Schneider [Sat, 22 Jan 2011 12:25:50 +0000 (13:25 +0100)]
Remove accidentally added file.

14 years agoThe rest of the places we need full urls for stylesheets
Michael J. Rubinsky [Sat, 22 Jan 2011 06:25:29 +0000 (01:25 -0500)]
The rest of the places we need full urls for stylesheets

14 years agoAnother try at serving css for API rendered views
Michael J. Rubinsky [Sat, 22 Jan 2011 06:20:52 +0000 (01:20 -0500)]
Another try at serving css for API rendered views

14 years agoHorde_Share_Datatree needs _idExists() also.
Michael J. Rubinsky [Sat, 22 Jan 2011 06:02:22 +0000 (01:02 -0500)]
Horde_Share_Datatree needs _idExists() also.

Probably a more effecient way to check this, but this driver is
deprecated. This is just to satisfy implementing the abstract method.

14 years agoMake getBody() repeatable
Chuck Hagenbuch [Sat, 22 Jan 2011 03:36:57 +0000 (22:36 -0500)]
Make getBody() repeatable

14 years agoNeed to remove the old-style named index incase this is an upgrade from h3
Michael J Rubinsky [Sat, 22 Jan 2011 02:28:40 +0000 (21:28 -0500)]
Need to remove the old-style named index incase this is an upgrade from h3

14 years agoCatch error if index doesn't exist
Michael J. Rubinsky [Sat, 22 Jan 2011 02:18:55 +0000 (21:18 -0500)]
Catch error if index doesn't exist

14 years agoRemove hierarchical driver, update package.xml
Michael J. Rubinsky [Sat, 22 Jan 2011 02:12:31 +0000 (21:12 -0500)]
Remove hierarchical driver, update package.xml

14 years agoSqlHierarchical driver is no more
Michael J. Rubinsky [Sat, 22 Jan 2011 02:08:42 +0000 (21:08 -0500)]
SqlHierarchical driver is no more

14 years agoMove hierarchical functionality into The Sql and Sqlng share drivers.
Michael J. Rubinsky [Sat, 22 Jan 2011 02:03:01 +0000 (21:03 -0500)]
Move hierarchical functionality into The Sql and Sqlng share drivers.

Ansel is refactored to use the Sql driver for now. More refactoring is needed
before it can be switched back and forth between any drivers. (Need to compose
Horde_Share_Object with Ansel_Gallery instead of Ansel_Gallery extending the
share object).

Squashed commit of the following:

commit ed76634819d4e6c1737366d5ffafbfcc0630d12c
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:59:26 2011 -0500

    Need to check against share ids in Ansel, not share_names

commit eb742b3414c3f27978beaa3c933f65f0e243efb2
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:38:09 2011 -0500

    Cleanup/small refactoring for merged hierarchical driver

commit b3e50233d7288f3007ddea45cb35e0724c664aed
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:28:16 2011 -0500

    extend Horde_Share_Object_Sql for now.

    Need to refactor so Ansel_Gallery is composed with Horde_Share_Object instead
    of extending it.

commit bb79f1f43aa7374cee325a70fd6849f52086ec75
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:23:56 2011 -0500

    Simplify

commit 76ae1f5d2bb28a9267e336d912f4bd2cc49a4894
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 16:37:14 2011 -0500

    Merge hierarchical functionality into base sql and sqlng drivers.

14 years agoConvert horde/Serialize to PHPUnit
Michael M Slusarz [Fri, 21 Jan 2011 23:40:41 +0000 (16:40 -0700)]
Convert horde/Serialize to PHPUnit

14 years agojson_decode() returns null on error, not false
Michael M Slusarz [Fri, 21 Jan 2011 23:39:48 +0000 (16:39 -0700)]
json_decode() returns null on error, not false

14 years agooveride the next-gen driver's default table name so the stress-test can run
Michael J. Rubinsky [Fri, 21 Jan 2011 20:53:50 +0000 (15:53 -0500)]
overide the next-gen driver's default table name so the stress-test can run
with the same migrations used in the unit tests.

14 years agoAnd still more configuration checks.
Jan Schneider [Fri, 21 Jan 2011 20:07:46 +0000 (21:07 +0100)]
And still more configuration checks.

14 years agoAnother unnecessary loop.
Jan Schneider [Fri, 21 Jan 2011 19:14:42 +0000 (20:14 +0100)]
Another unnecessary loop.