tomcat7.0
14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51509
markt [Tue, 19 Jul 2011 18:20:23 +0000 (18:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51509
Fix potential concurrency issue in CSRF prevention filter that may lead to some requests failing that should not.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148471 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd info on which connectors these fixes apply to.
markt [Tue, 19 Jul 2011 13:51:42 +0000 (13:51 +0000)]
Add info on which connectors these fixes apply to.
Correct order.
Add periods to the end of the sentences.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148321 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd changelog for 1148254 and 1148216
jfclere [Tue, 19 Jul 2011 12:11:18 +0000 (12:11 +0000)]
Add changelog for 1148254 and 1148216

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148288 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51518
markt [Tue, 19 Jul 2011 11:41:08 +0000 (11:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51518
Correct error in web.xml parsing rules for the <others/> tag when using absolute ordering.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148277 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix for PR50394
jfclere [Tue, 19 Jul 2011 09:36:08 +0000 (09:36 +0000)]
Fix for PR50394

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148254 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd release date for 7.0.19
markt [Tue, 19 Jul 2011 09:22:22 +0000 (09:22 +0000)]
Add release date for 7.0.19

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148249 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd test cases for syntax checking of jarsToSkip.
rjung [Tue, 19 Jul 2011 09:14:09 +0000 (09:14 +0000)]
Add test cases for syntax checking of jarsToSkip.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148245 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd section title
markt [Tue, 19 Jul 2011 09:03:41 +0000 (09:03 +0000)]
Add section title

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148242 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix for PR49595
jfclere [Tue, 19 Jul 2011 08:06:46 +0000 (08:06 +0000)]
Fix for PR49595

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148216 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51503
markt [Mon, 18 Jul 2011 16:18:54 +0000 (16:18 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51503
Add additional validation to Windows installer and Tomcat start for connector port numbers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147949 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCleaner code
markt [Mon, 18 Jul 2011 15:15:26 +0000 (15:15 +0000)]
Cleaner code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147925 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate to changelog
markt [Mon, 18 Jul 2011 15:12:48 +0000 (15:12 +0000)]
Update to changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147923 13f79535-47bb-0310-9956-ffa450edef68

14 years agoOnly test for timeouts if timeout is greater than zero (aligns with BIO and APR)
markt [Mon, 18 Jul 2011 15:10:29 +0000 (15:10 +0000)]
Only test for timeouts if timeout is greater than zero (aligns with BIO and APR)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147921 13f79535-47bb-0310-9956-ffa450edef68

14 years agoModify the test to ensure that the default connection timeout (-1) is used and so...
markt [Mon, 18 Jul 2011 15:09:43 +0000 (15:09 +0000)]
Modify the test to ensure that the default connection timeout (-1) is used and so that pipe-lining doesn't trigger false positive results

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147920 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMinor improvement to javadoc
markt [Mon, 18 Jul 2011 15:01:41 +0000 (15:01 +0000)]
Minor improvement to javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147915 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd some units info to the Javadocs
markt [Fri, 15 Jul 2011 17:51:10 +0000 (17:51 +0000)]
Add some units info to the Javadocs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147263 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMissing svn:eol-style.
rjung [Fri, 15 Jul 2011 07:48:27 +0000 (07:48 +0000)]
Missing svn:eol-style.

Please fix your svn config. Thanks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146994 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property
kkolinko [Thu, 14 Jul 2011 09:58:31 +0000 (09:58 +0000)]
Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146623 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate ready for next release
markt [Wed, 13 Jul 2011 22:31:04 +0000 (22:31 +0000)]
Update ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146505 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCATALINA_BASE is always set, so simplify
markt [Wed, 13 Jul 2011 15:20:43 +0000 (15:20 +0000)]
CATALINA_BASE is always set, so simplify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146096 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCATALINA_BASE is always set, so simplify
markt [Wed, 13 Jul 2011 14:47:32 +0000 (14:47 +0000)]
CATALINA_BASE is always set, so simplify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146069 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd CVE reference for sendfile issues
markt [Wed, 13 Jul 2011 13:36:44 +0000 (13:36 +0000)]
Add CVE reference for sendfile issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146010 13f79535-47bb-0310-9956-ffa450edef68

14 years agoWhen running under a security manager and using sendfile, validate sendfile attribute...
markt [Wed, 13 Jul 2011 13:28:24 +0000 (13:28 +0000)]
When running under a security manager and using sendfile, validate sendfile attributes to prevent sendfile being used to bypass the security manager.
Part of the fix for CVE-2011-2526

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146005 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNo need to include class in message, results in "classclass"
markt [Wed, 13 Jul 2011 12:45:57 +0000 (12:45 +0000)]
No need to include class in message, results in "classclass"

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145981 13f79535-47bb-0310-9956-ffa450edef68

14 years agoProtect against crashes in the HTTP APR connector if sendfile is configured to send...
markt [Tue, 12 Jul 2011 17:50:11 +0000 (17:50 +0000)]
Protect against crashes in the HTTP APR connector if sendfile is configured to send more data than is available in the file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145694 13f79535-47bb-0310-9956-ffa450edef68

14 years agogit-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145627 13f79535-47bb-0310...
markt [Tue, 12 Jul 2011 15:14:27 +0000 (15:14 +0000)]
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145627 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSocket has been closed, return false so an attempt is not made to re-use the socket
markt [Tue, 12 Jul 2011 12:51:35 +0000 (12:51 +0000)]
Socket has been closed, return false so an attempt is not made to re-use the socket

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145571 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect a comment
markt [Tue, 12 Jul 2011 08:34:20 +0000 (08:34 +0000)]
Correct a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145489 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMaybe someone wants to realize that change.
rjung [Mon, 11 Jul 2011 22:33:54 +0000 (22:33 +0000)]
Maybe someone wants to realize that change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145388 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNever compare docs and code:
rjung [Mon, 11 Jul 2011 22:30:45 +0000 (22:30 +0000)]
Never compare docs and code:

- enableLookups for connector was
  "false" by default at least the last 5 years.

- resolveHosts for normal and extended
  access log valve wasn't functional in
  the last 4 years (see e.g. r494191) and
  IMHO since noone complaint switching
  enableLookups to "true" instead is an
  appropriate alternative. So document
  that "resolveHosts" is no longer supported.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145387 13f79535-47bb-0310-9956-ffa450edef68

14 years agoProtect against infinite loops in the HTTP NIO connector if sendfile is configured...
markt [Mon, 11 Jul 2011 22:27:06 +0000 (22:27 +0000)]
Protect against infinite loops in the HTTP NIO connector if sendfile is configured to send more data than is available in the file. (markt)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145383 13f79535-47bb-0310-9956-ffa450edef68

14 years agoA little bit of docs is better than nothing ...
rjung [Mon, 11 Jul 2011 22:08:30 +0000 (22:08 +0000)]
A little bit of docs is better than nothing ...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145381 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused attribute
markt [Mon, 11 Jul 2011 22:08:06 +0000 (22:08 +0000)]
Remove unused attribute

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145380 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused import
markt [Mon, 11 Jul 2011 21:10:08 +0000 (21:10 +0000)]
Remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145355 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse en_US as locale for creationdate in WebdavServlet.
rjung [Mon, 11 Jul 2011 19:06:15 +0000 (19:06 +0000)]
Use en_US as locale for creationdate in WebdavServlet.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145296 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1145209
kkolinko [Mon, 11 Jul 2011 18:40:48 +0000 (18:40 +0000)]
Followup to r1145209
Do not expose TCN_FULL_VERSION as a public constant, but calculate it when needed.
Using this way it will be easier to throw away the code in AprEndpoint when it becomes unneeded.
I do not mind reintroducing the constant if it were used in two or more places.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145285 13f79535-47bb-0310-9956-ffa450edef68

14 years agoExpose recently added "encoding" and "locale" options of AccessLogValve through JMX.
kkolinko [Mon, 11 Jul 2011 18:10:11 +0000 (18:10 +0000)]
Expose recently added "encoding" and "locale" options of AccessLogValve through JMX.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145268 13f79535-47bb-0310-9956-ffa450edef68

14 years ago- Remove unused code:
rjung [Mon, 11 Jul 2011 17:13:06 +0000 (17:13 +0000)]
- Remove unused code:
  Cookie dates are formatted elsewhere.
  This class used a very strange format:
  " EEEE, dd-MMM-yy kk:mm:ss zz"
- Add log.isDebugEnabled()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145246 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlways use en_US as locale for timestamps in
rjung [Mon, 11 Jul 2011 16:51:54 +0000 (16:51 +0000)]
Always use en_US as locale for timestamps in
ExtendedAccessLogValve.

The format is specified in

http://www.w3.org/TR/WD-logfile.html

and states that the supported timestamps
"yyyy-MM-dd" and "HH:mm:ss" are defined with
ascii digits and GMT.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145238 13f79535-47bb-0310-9956-ffa450edef68

14 years ago* JULI FileHandler, AccessLogValve:
kkolinko [Mon, 11 Jul 2011 16:46:28 +0000 (16:46 +0000)]
* JULI FileHandler, AccessLogValve:
Create a directory automatically when it is specified as a part of the file name, e.g. in the prefix attribute. Earlier this happened only if it was specified with the directory attribute.
* AccessLogValve:
Log a failure if access log file cannot be opened.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145237 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert unintended commit
markt [Mon, 11 Jul 2011 16:10:15 +0000 (16:10 +0000)]
Revert unintended commit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145225 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove logging of error conditions
markt [Mon, 11 Jul 2011 16:08:23 +0000 (16:08 +0000)]
Improve logging of error conditions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145224 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBZ 51477: Support all SSL protocol combinations in the
rjung [Mon, 11 Jul 2011 15:44:10 +0000 (15:44 +0000)]
BZ 51477: Support all SSL protocol combinations in the
APR/native connector.

This only works when using the native library
version 1.1.21 or later which is not yet released.

Older tcnative versions will use an unchanged
config parser. Otherwise non-supported protocol
combinations would be unnoticed.

For easier review of the changes in AprEndpoint
use "svn -x -w" to ignore white space.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145209 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46252
kkolinko [Mon, 11 Jul 2011 15:13:13 +0000 (15:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46252
Allow to specify character set to be used to write the access log in AccessLogValve.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145200 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix javadoc.
rjung [Mon, 11 Jul 2011 14:18:32 +0000 (14:18 +0000)]
Fix javadoc.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145186 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAllow choosing a locale for timestamp formatting
rjung [Mon, 11 Jul 2011 13:17:09 +0000 (13:17 +0000)]
Allow choosing a locale for timestamp formatting
in AccessLogValve. Only relevant to timestamps
explicitely given by SimpleDateFormat syntax.

Also: use Locale.US for CLF and for timestamps
that are part of the access log file name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145166 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIgnore doc copied in during build process
markt [Mon, 11 Jul 2011 13:16:29 +0000 (13:16 +0000)]
Ignore doc copied in during build process

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145165 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51494
markt [Mon, 11 Jul 2011 13:05:30 +0000 (13:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51494
Prevent an NPE when a long running request completes if the associated web application was destroyed while the request was processing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145160 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReplace <tt> by <code> in docs.
rjung [Mon, 11 Jul 2011 12:16:36 +0000 (12:16 +0000)]
Replace <tt> by <code> in docs.
The physical markup <tt> was only
used in few places. Mostly we use
the logical markup <code>.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145137 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog for bz51490 fixes
markt [Mon, 11 Jul 2011 09:37:58 +0000 (09:37 +0000)]
Update changelog for bz51490 fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145093 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix broken HTML
markt [Mon, 11 Jul 2011 09:32:32 +0000 (09:32 +0000)]
Fix broken HTML

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145088 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix broken HTML
markt [Mon, 11 Jul 2011 09:31:09 +0000 (09:31 +0000)]
Fix broken HTML

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145086 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReduce variable scope to reduce testing issues
markt [Mon, 11 Jul 2011 09:29:28 +0000 (09:29 +0000)]
Reduce variable scope to reduce testing issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145084 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnsure it is clear when tag isn't working
markt [Mon, 11 Jul 2011 09:28:25 +0000 (09:28 +0000)]
Ensure it is clear when tag isn't working

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145083 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix broken HTML
markt [Mon, 11 Jul 2011 09:19:59 +0000 (09:19 +0000)]
Fix broken HTML

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145081 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd a simple AJP test.
markt [Sun, 10 Jul 2011 22:05:01 +0000 (22:05 +0000)]
Add a simple AJP test.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144976 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake it easier to test that the right response was returned
markt [Sun, 10 Jul 2011 21:59:51 +0000 (21:59 +0000)]
Make it easier to test that the right response was returned

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144972 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSet includeantruntime in jdbc-pool javac
rjung [Sun, 10 Jul 2011 21:24:15 +0000 (21:24 +0000)]
Set includeantruntime in jdbc-pool javac
build tasks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144966 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix version pattern in jdbc-pool manifest.
rjung [Sun, 10 Jul 2011 21:23:33 +0000 (21:23 +0000)]
Fix version pattern in jdbc-pool manifest.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144964 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd jdbc-pool to jarsToSkip.
rjung [Sun, 10 Jul 2011 20:29:30 +0000 (20:29 +0000)]
Add jdbc-pool to jarsToSkip.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144955 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReorganize jdbc-pool inclusion in releases.
rjung [Sun, 10 Jul 2011 20:08:26 +0000 (20:08 +0000)]
Reorganize jdbc-pool inclusion in releases.

Split build (code and docs) from clean.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144951 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd changelog entry for Filip's inclusion
rjung [Sun, 10 Jul 2011 20:07:26 +0000 (20:07 +0000)]
Add changelog entry for Filip's inclusion
of jdbc-pool in releases.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144950 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMove new changelog entries to correct subsection.
rjung [Sun, 10 Jul 2011 20:04:28 +0000 (20:04 +0000)]
Move new changelog entries to correct subsection.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144948 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake it easier for tests to override the protocol (e.g. to test AJP)
markt [Sun, 10 Jul 2011 14:40:00 +0000 (14:40 +0000)]
Make it easier for tests to override the protocol (e.g. to test AJP)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144868 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd missing thread name in RequestProcessor when Servlet 3 Async
rjung [Sun, 10 Jul 2011 14:33:12 +0000 (14:33 +0000)]
Add missing thread name in RequestProcessor when Servlet 3 Async
is used.

Fixes null thread name in access log and probably JMX MBean.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144865 13f79535-47bb-0310-9956-ffa450edef68

14 years agoDisable one test validation in TestAsyncContextImpl
rjung [Sun, 10 Jul 2011 13:03:49 +0000 (13:03 +0000)]
Disable one test validation in TestAsyncContextImpl
if an AccessLogValve has been activated.

The test relies on receiving data via
StandardEngine.logAccess() which is already
handled by the other AccessLog.

By default no AccessLogValve is activated, so the
validation is still done.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144854 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAnother regression in 7.0.18: year number formatting
rjung [Sun, 10 Jul 2011 11:22:40 +0000 (11:22 +0000)]
Another regression in 7.0.18: year number formatting
in AccessLogValve is broken due to type "yyy" instead of "yyyy".

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144833 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code.
markt [Sun, 10 Jul 2011 11:02:22 +0000 (11:02 +0000)]
Remove unused code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144823 13f79535-47bb-0310-9956-ffa450edef68

14 years ago7.0.18 not released
markt [Sun, 10 Jul 2011 10:59:45 +0000 (10:59 +0000)]
7.0.18 not released

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144818 13f79535-47bb-0310-9956-ffa450edef68

14 years ago7.0.18 not released
markt [Sun, 10 Jul 2011 10:53:51 +0000 (10:53 +0000)]
7.0.18 not released

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144817 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd option test.accesslog to activate AccessLog
rjung [Sun, 10 Jul 2011 10:10:33 +0000 (10:10 +0000)]
Add option test.accesslog to activate AccessLog
for unit tests.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144802 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix regression producing invalid MBean names when using IPV6
rjung [Sun, 10 Jul 2011 06:53:36 +0000 (06:53 +0000)]
Fix regression producing invalid MBean names when using IPV6
addresses for connectors.

- revert r1135088

- remove the surrounding quotes only when
  passing the name to the endpoint, so they
  don't end up in the middle of thread names.
  The thread names are used as MBean attribute
  values, but not in MBean names.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144785 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate to Eclipse JDT Compiler 3.7
markt [Sat, 9 Jul 2011 16:56:49 +0000 (16:56 +0000)]
Update to Eclipse JDT Compiler 3.7

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144706 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate to Commons Daemon 1.0.6
markt [Sat, 9 Jul 2011 16:38:39 +0000 (16:38 +0000)]
Update to Commons Daemon 1.0.6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144701 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove some more unnecessary code
markt [Sat, 9 Jul 2011 16:05:42 +0000 (16:05 +0000)]
Remove some more unnecessary code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144690 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd regression fix to changelog
markt [Sat, 9 Jul 2011 15:21:46 +0000 (15:21 +0000)]
Add regression fix to changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144682 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix Comet with HTTP/APR connector
markt [Sat, 9 Jul 2011 00:28:44 +0000 (00:28 +0000)]
Fix Comet with HTTP/APR connector
r1144391 switched the key for the processor map for this connector from the socket to the socket wrapper. That prevented Comet from being able to retrieve the processor from the map when processing a comet event.
This commit changes all the connectors to map the socket (or rather whatever the SocketWrapper wraps) to the processor rather than the SocketWrapper.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144557 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up Handler.process
markt [Fri, 8 Jul 2011 18:01:30 +0000 (18:01 +0000)]
Pull up Handler.process

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144405 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign AJP and HTTP prior to pulling up Handler.process
markt [Fri, 8 Jul 2011 17:28:25 +0000 (17:28 +0000)]
Align AJP and HTTP prior to pulling up Handler.process

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144393 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up Handler.process for the Http11 connectors.
markt [Fri, 8 Jul 2011 17:19:38 +0000 (17:19 +0000)]
Pull up Handler.process for the Http11 connectors.
Note that this is an intermediate step. The aim is to pull this up to AbstractProtocol

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144391 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up Handler.process for the Ajp Connectors.
markt [Fri, 8 Jul 2011 17:19:19 +0000 (17:19 +0000)]
Pull up Handler.process for the Ajp Connectors.
Note that this is an intermediate step. The aim is to pull this up to AbstractProtocol

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144390 13f79535-47bb-0310-9956-ffa450edef68

14 years agoYet more protocol alignment (with an eye to aligning with AJP)
markt [Fri, 8 Jul 2011 16:19:28 +0000 (16:19 +0000)]
Yet more protocol alignment (with an eye to aligning with AJP)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144375 13f79535-47bb-0310-9956-ffa450edef68

14 years agoChange eol-style and add link to jdbc-pool on the documentation home page
fhanik [Fri, 8 Jul 2011 15:34:18 +0000 (15:34 +0000)]
Change eol-style and add link to jdbc-pool on the documentation home page

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144358 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMore protocol alignment (with an eye to aligning with AJP)
markt [Fri, 8 Jul 2011 15:10:01 +0000 (15:10 +0000)]
More protocol alignment (with an eye to aligning with AJP)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144354 13f79535-47bb-0310-9956-ffa450edef68

14 years agoProtocol will call recycle
markt [Fri, 8 Jul 2011 14:59:43 +0000 (14:59 +0000)]
Protocol will call recycle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144349 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBring the Http11 protocol implementations closer together.
markt [Fri, 8 Jul 2011 14:04:08 +0000 (14:04 +0000)]
Bring the Http11 protocol implementations closer together.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144317 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCompletely align process methods
markt [Fri, 8 Jul 2011 11:56:33 +0000 (11:56 +0000)]
Completely align process methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144276 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign the process methods some more.
markt [Fri, 8 Jul 2011 11:49:50 +0000 (11:49 +0000)]
Align the process methods some more.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144272 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlign the process methods some more.
markt [Fri, 8 Jul 2011 11:40:36 +0000 (11:40 +0000)]
Align the process methods some more.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144271 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary call. Socket can't be in connections at this point.
markt [Fri, 8 Jul 2011 11:21:37 +0000 (11:21 +0000)]
Remove unnecessary call. Socket can't be in connections at this point.
Leave currently unused socket parameter in method - plan to use it in later re-factoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144266 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove comments
markt [Fri, 8 Jul 2011 11:19:32 +0000 (11:19 +0000)]
Improve comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144264 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix regression in connector re-factoring that was too aggressive cleaning up AJP...
markt [Fri, 8 Jul 2011 10:45:19 +0000 (10:45 +0000)]
Fix regression in connector re-factoring that was too aggressive cleaning up AJP/BIO between requests triggering 400 entries in the access log

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144246 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix indentation
markt [Fri, 8 Jul 2011 09:50:02 +0000 (09:50 +0000)]
Fix indentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144225 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up reset for remoteHost etc. to a common location
markt [Thu, 7 Jul 2011 22:14:07 +0000 (22:14 +0000)]
Pull up reset for remoteHost etc. to a common location

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144077 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove pointless code (see finally block just above)
markt [Thu, 7 Jul 2011 21:58:51 +0000 (21:58 +0000)]
Remove pointless code (see finally block just above)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144069 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPull up asyncDispatch()
markt [Thu, 7 Jul 2011 21:57:13 +0000 (21:57 +0000)]
Pull up asyncDispatch()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144067 13f79535-47bb-0310-9956-ffa450edef68

14 years agoInclude jdbc-pool into tomcat release.
fhanik [Thu, 7 Jul 2011 21:40:05 +0000 (21:40 +0000)]
Include jdbc-pool into tomcat release.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144061 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNo functional change - make it the same as BIO & APR
markt [Thu, 7 Jul 2011 21:23:42 +0000 (21:23 +0000)]
No functional change - make it the same as BIO & APR

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144050 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMissed a reference to comet which will always be false in asyncDispatch
markt [Thu, 7 Jul 2011 21:22:43 +0000 (21:22 +0000)]
Missed a reference to comet which will always be false in asyncDispatch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144049 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unnecessary throws
markt [Thu, 7 Jul 2011 21:22:01 +0000 (21:22 +0000)]
Remove unnecessary throws
Move timeout lookups to where the timeouts are reset (in preparation for this being in a separate method)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1144048 13f79535-47bb-0310-9956-ffa450edef68