jfclere [Wed, 27 Aug 2008 07:23:40 +0000 (07:23 +0000)]
Fix for PR#44809
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@689395
13f79535-47bb-0310-9956-
ffa450edef68
rjung [Mon, 25 Aug 2008 20:08:05 +0000 (20:08 +0000)]
Remove recycle of B2CConverter when used for URI conversion.
Recycle was an empty method until recently. It now eats up
all bytes in the ByteChunk underlying the B2CConverter in
order to fix BZ44494. That's fine and necessary for the
B2CConverter use in InputBuffer at the end of request handling,
but here, in the case of URI conversion, the associated
ByteChunk comes from a convert call of a previous request
and we will destroy a ByteChunk we still need to use outside of the
B2CConverter.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@688857
13f79535-47bb-0310-9956-
ffa450edef68
jfclere [Thu, 21 Aug 2008 13:34:40 +0000 (13:34 +0000)]
JAVA part of the #43327 fix.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@687755
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 21 Aug 2008 09:15:55 +0000 (09:15 +0000)]
There is no admin app in TC6
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@687660
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 21 Aug 2008 08:36:43 +0000 (08:36 +0000)]
Update patch for 45528
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@687645
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 20 Aug 2008 23:36:36 +0000 (23:36 +0000)]
Remove unnecessary casts. Reported by Jens Kapitza in https://issues.apache.org/bugzilla/show_bug.cgi?id=45655
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@687508
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 20 Aug 2008 23:20:42 +0000 (23:20 +0000)]
Improved fix for 45528 (invalid SSL config).
It is a variation on the previous patch that:
- does the check earlier
- uses an unbound socket so there is no possibility of a client connection
- uses the String manager for the error message
Note: I gave up on the alterntaive javax.crypto.Cipher suggestion as the cipher names are different and there is no easy conversion.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@687503
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 14 Aug 2008 18:11:28 +0000 (18:11 +0000)]
Revert the previous fix. Filip has suggested an alternative approach that should address the various objections. New patch will follow in the next few days.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@685981
13f79535-47bb-0310-9956-
ffa450edef68
funkman [Wed, 13 Aug 2008 12:58:47 +0000 (12:58 +0000)]
Let the user know why errorReportValveClass was not loaded. Since it could
be ClassNotFound, invalid class version, (or other)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@685530
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 12 Aug 2008 15:10:23 +0000 (15:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45608
Use AtomicInteger for countAllocated to prevent race conditions.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@685177
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 11 Aug 2008 20:57:16 +0000 (20:57 +0000)]
Correct SSL docs as to the list of ciphers used by default. Add note about export grade ciphers. Add note (already in TC4) about cipher naming.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684922
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 10 Aug 2008 17:24:51 +0000 (17:24 +0000)]
Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45528. Test the SSL socket before returning it to make sure the specified certificate will work with the specified ciphers.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684559
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Aug 2008 14:32:47 +0000 (14:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41407
Add support for CLIENT-CERT authentication to JAAS realm.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684270
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 9 Aug 2008 12:10:34 +0000 (12:10 +0000)]
Fix bug https://issues.apache.org/bugzilla/show_bug.cgi?id=45576
Get the JAASRealm working with DIGEST authentication.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684234
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Aug 2008 20:27:52 +0000 (20:27 +0000)]
Modify JAASMemoryLoginModule so it conforms to the contract with the JAASRealm regarding the representation of roles.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684081
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Aug 2008 17:55:24 +0000 (17:55 +0000)]
Fix doc typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684029
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Aug 2008 15:49:24 +0000 (15:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45585 using a suggestion from Ian Ward Comfort
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@684001
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Aug 2008 14:31:20 +0000 (14:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45591 - NPE on start-up failure in some cases
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@683982
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 8 Aug 2008 14:08:21 +0000 (14:08 +0000)]
When a JSP file is deleted, return a 404 for the next request rather than serving the next request as if the file still existed and then returning 404s for the second and subsequent requests.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@683969
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 4 Aug 2008 22:00:38 +0000 (22:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45532
Doc typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@682525
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 3 Aug 2008 17:54:23 +0000 (17:54 +0000)]
Remove some unused code.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@682197
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Aug 2008 19:25:41 +0000 (19:25 +0000)]
The surprisingly small update to the auto generate code to go with the update to the jjtree file
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@681792
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Aug 2008 19:23:25 +0000 (19:23 +0000)]
Needed to look ahead one more token to differentiate between a function call and an identifier.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@681789
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Aug 2008 16:20:14 +0000 (16:20 +0000)]
Update auto-generated code after recent jjt changes.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@681737
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Aug 2008 16:11:14 +0000 (16:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42565
This patch:
- limits the regexp for namespace to what is in the spec
- removes the namespace token since the maximal munch rule means that there is a risk the second and third parts of a ternary expression would, incorrectly, be interpreted as a fucntion call.
- modifies the lookahead for function to be more explicit about what to look for
My set of weird and wonderful test cases (mixing ternary, fucntion and empty) now all work.
Updated generated files will follow.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@681736
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Aug 2008 16:05:47 +0000 (16:05 +0000)]
Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=42565 since it caused https://issues.apache.org/bugzilla/show_bug.cgi?id=45511
A better fix for 42565 will follow
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@681735
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 30 Jul 2008 22:37:11 +0000 (22:37 +0000)]
Fix 45509 - typos
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@681233
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 29 Jul 2008 16:28:59 +0000 (16:28 +0000)]
Port svn.apache.org/viewvc?rev=678137&view=rev (additional normalization check) to trunk
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@680759
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 29 Jul 2008 14:58:05 +0000 (14:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45453
Add yet more synchronisation to JDBCRealm.
Based on a patch provided by Santtu Hyrkk.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@680725
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 29 Jul 2008 14:29:27 +0000 (14:29 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45459
Provide info on possible cause of exception.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@680710
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 27 Jul 2008 13:20:07 +0000 (13:20 +0000)]
Fix error in JAAS realm doc reported on users list.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@680101
13f79535-47bb-0310-9956-
ffa450edef68
costin [Fri, 18 Jul 2008 14:11:03 +0000 (14:11 +0000)]
This was discussed a month ago - didn't hear any objections. It uses the 'platform' mbean server instead of a new one if none
was explicitely created. This allows using jconsole without any flags - without the change it would only show platform mbeans,
now it has tomcat mbeans as well.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@677910
13f79535-47bb-0310-9956-
ffa450edef68
jfclere [Fri, 18 Jul 2008 06:39:45 +0000 (06:39 +0000)]
Grammar + typos: Fix PR#45422
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@677836
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 17 Jul 2008 23:12:03 +0000 (23:12 +0000)]
Remove pre-loading of inner class that was removed as part of r605000.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@677773
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 17 Jul 2008 22:09:18 +0000 (22:09 +0000)]
Fix bug 42727. Handle request lines that are exact multiples of 4096 in length.
Patch provided by Will Pugh.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@677759
13f79535-47bb-0310-9956-
ffa450edef68
costin [Thu, 17 Jul 2008 17:14:47 +0000 (17:14 +0000)]
Add a non-config starter for tomcat. All you need is the classpath including tomcat and the servlets - no config file.
There is a requirement for a temp directory - the spec requires that webapps are provided with one I believe.
It is possible to remove this or do it lazily or have some default in /tmp, if anyone wants to.
Also adding a context requires some base dir ( can be an empty one ) - so the default servlets points to something.
This can also be eliminated by setting a different default servlet - needs to be done if wanted.
It is also pretty fast - the unit tests show startup + first request in ~1 sec.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@677640
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 17 Jul 2008 00:13:37 +0000 (00:13 +0000)]
first chunk - make sure END gets called properly, if the event was closed
second chunk - if the POST body is x-www-form-urlencoded, request.getAvailable() returns 0 for IdentityInputFilter
so we still need to invoke READ event if there is a body, and it hasn't been processes by the servlet
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@677473
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 15 Jul 2008 15:51:44 +0000 (15:51 +0000)]
As Remy pointed out, this really should be in the finally block.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@676944
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 15 Jul 2008 09:14:21 +0000 (09:14 +0000)]
Revert changes as root cause of issue appears to be strangeness in my build environment.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@676843
13f79535-47bb-0310-9956-
ffa450edef68
mturk [Mon, 14 Jul 2008 08:36:41 +0000 (08:36 +0000)]
Use tomcat native from ASF repository instead downloading at install time from tomcat.heanet.ie
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@676510
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 13 Jul 2008 18:30:19 +0000 (18:30 +0000)]
Previous patch didn't go far enough. No need to pre-load StandardWrapper.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@676395
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 23:00:31 +0000 (23:00 +0000)]
Startup fails with security enabled
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675796
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 21:11:16 +0000 (21:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42722
Possible NPE in CGIServlet.java
Patch provided by Nils Hammar
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675751
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 21:05:35 +0000 (21:05 +0000)]
Auto-generated changes as a result of svn.apache.org/viewvc?rev=675726&view=rev
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675739
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 20:53:24 +0000 (20:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42565
el ternary expression without space before colon now works
Patch provided by Lucas Galfaso
This is just the jjt patch. The resulting changes to the generated code will follow.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675726
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 18:34:22 +0000 (18:34 +0000)]
Go back to the original patch. The better one didn't pan out. Sorry for the noise.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675667
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 18:20:18 +0000 (18:20 +0000)]
Revert previous patch prior to applying a better one
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675664
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 10 Jul 2008 17:01:23 +0000 (17:01 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42678
Only ignore docBase it it really is a subdir of appBase
Patch provided by juergen
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675650
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 9 Jul 2008 20:50:18 +0000 (20:50 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
Should look for annotations all the way up the class hierarchy
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@675340
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Jul 2008 20:02:06 +0000 (20:02 +0000)]
Fix bug 45323. Add note that context.xml files can only contain a single Context.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@674339
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Jul 2008 19:31:20 +0000 (19:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45332
Specify the correct encoding (the current windows code page) rather than assuming UTF-8 when creating tomcat-users.xml
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@674335
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 6 Jul 2008 16:14:01 +0000 (16:14 +0000)]
Port windows installer changes from 6.0.x to trunk
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@674311
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Fri, 4 Jul 2008 21:30:31 +0000 (21:30 +0000)]
Add in startup options to the cluster channel.
Document the multicast recovery options
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@674125
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 4 Jul 2008 07:52:17 +0000 (07:52 +0000)]
Fix 45310, 45308 and a couple of additional typos. Also use OpenSSL consistently and fix a very long line.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@673943
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Jul 2008 21:26:13 +0000 (21:26 +0000)]
Extract the query string before we try to normalise the URI
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@673820
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 3 Jul 2008 20:52:42 +0000 (20:52 +0000)]
Make filtering of /r and /n in headers consistent for all connectors.
Make handling of 404s consistent across components.
Provide option to include custom status message in headers. SRV.5.3 suggests custom messages are intended for the body of the response, not the status line.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@673796
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 2 Jul 2008 20:41:10 +0000 (20:41 +0000)]
Fix for bug 45317, document and properly output the session timeout time
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@673487
13f79535-47bb-0310-9956-
ffa450edef68
jfclere [Wed, 2 Jul 2008 08:44:37 +0000 (08:44 +0000)]
typo: 45309
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@673317
13f79535-47bb-0310-9956-
ffa450edef68
jfclere [Tue, 1 Jul 2008 11:34:06 +0000 (11:34 +0000)]
Add some extra info on keystore type.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@673061
13f79535-47bb-0310-9956-
ffa450edef68
billbarker [Sat, 28 Jun 2008 02:11:48 +0000 (02:11 +0000)]
port fix for BZ 36155 from the JK Connector
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@672454
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 27 Jun 2008 21:48:41 +0000 (21:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45277
Correct typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@672399
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 27 Jun 2008 21:39:27 +0000 (21:39 +0000)]
Fix for part 3 of https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
This isn't perfect but it narrows the window for the race condition significantly. A perfect fix would require syncing most (all?) of allocate() which is on the critical path.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@672397
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 26 Jun 2008 18:25:30 +0000 (18:25 +0000)]
doco update for fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45272
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@671975
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 26 Jun 2008 18:24:18 +0000 (18:24 +0000)]
work around for IE not being RFC compliant, IE doesn't like quotes around the path value, even though a slash is considered a header delimiter and must be quoted, fix for bug https://issues.apache.org/bugzilla/show_bug.cgi?id=45272
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@671973
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 25 Jun 2008 20:46:02 +0000 (20:46 +0000)]
update changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@671652
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 25 Jun 2008 20:44:48 +0000 (20:44 +0000)]
fix for bug 45279, close multicast socket on close
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@671650
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 20 Jun 2008 21:34:09 +0000 (21:34 +0000)]
Provide an option to disable the fix for 45015 that raised an error if attributes were not correctly quoted.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@670074
13f79535-47bb-0310-9956-
ffa450edef68
jfclere [Wed, 18 Jun 2008 09:08:14 +0000 (09:08 +0000)]
Use localhost instead of 127.0.0.1
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@669119
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 17 Jun 2008 22:13:00 +0000 (22:13 +0000)]
Additional check related to bug 45195.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@668854
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 17 Jun 2008 22:04:50 +0000 (22:04 +0000)]
Apply Filip's better patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=45212
Map.entrySet() should return entries, not values
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@668849
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 17 Jun 2008 22:01:01 +0000 (22:01 +0000)]
Revert previous fix after veto.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@668847
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 16 Jun 2008 17:22:36 +0000 (17:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45212
Map.entrySet() should return entries, not values
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@668249
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 13 Jun 2008 20:40:27 +0000 (20:40 +0000)]
Another fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
There was a short period where the context didn't appear in the mapper that resulted in some more 404s.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@667644
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 13 Jun 2008 17:43:51 +0000 (17:43 +0000)]
Fix bug 45195. NPE when calling getAttribute(null).
The spec is unclear but this is a regression from 5.0.x
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@667604
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 10 Jun 2008 17:44:24 +0000 (17:44 +0000)]
update changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@666233
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Tue, 10 Jun 2008 17:43:28 +0000 (17:43 +0000)]
prevent NPE during shutdown where the logger has been shutdown and delayed resources still trying to log
java.lang.NullPointerException
at org.apache.juli.FileHandler.publish(FileHandler.java:136)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@666232
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 9 Jun 2008 16:41:58 +0000 (16:41 +0000)]
Make forced coercion of null and "" to zero optional. It is enabled by default, as per the spec.
Patch by Nils Eckert.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@665756
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 8 Jun 2008 11:30:44 +0000 (11:30 +0000)]
Add an additional layer of protection in case app fails to protect against an XSS.
Copied filter code to jasper module so no new dependency is created.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@664483
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 7 Jun 2008 14:34:36 +0000 (14:34 +0000)]
Add a new valve that works-around the broken MS WedDAV client.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@664345
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 2 Jun 2008 21:41:28 +0000 (21:41 +0000)]
Fix potential XSS in host-manager.
This is CVE-2008-1947.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@662582
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 29 May 2008 21:32:02 +0000 (21:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45101
Format dates for header value from DirContextURLConnection using HTTP format.
Patch provided by Chris Hubick.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@661488
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 28 May 2008 20:42:22 +0000 (20:42 +0000)]
Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43683
If the context is reloaded, the classloader will have changed so need to reset it
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@661074
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 22 May 2008 19:17:38 +0000 (19:17 +0000)]
Revert changes for 42747 whilst I work on a better fix.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@659215
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 19 May 2008 21:47:19 +0000 (21:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747.
Actually fixes a number of related bugs:
- For a new WAR, use META-INF/context.xml for first initiation rather than copying it then using it on next start
- For a new dir, use META-INF/context.xml for first initiation
- For a new dir, copy any META-INF/context.xml to $CATALINA_BASE/[engine]/[host]/contextPath.xml
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657995
13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 19 May 2008 20:07:20 +0000 (20:07 +0000)]
Note: This patch is on the critical path.
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42750
Making parsing of the request line tolerant of multiple SP and/or HT rather than requiring single SP characters.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657954
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 17 May 2008 19:55:55 +0000 (19:55 +0000)]
Additional patch from https://issues.apache.org/bugzilla/show_bug.cgi?id=43094
Make SSL providers configurable.
Based on a patch by Bruno Harbulot.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657449
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 17 May 2008 19:39:14 +0000 (19:39 +0000)]
Code clean-up. No functional change.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657439
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 17 May 2008 18:52:23 +0000 (18:52 +0000)]
Fix some Eclipse warnings in the examples webapp.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657429
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 17 May 2008 18:41:07 +0000 (18:41 +0000)]
Fix as many Eclipse warnings as I can in the unit tests.
Add some missing svn properties
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657428
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 17 May 2008 17:33:43 +0000 (17:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44994
Correct BNF grammar so ${0 lt a ? 1 lt a ? "many": "one": "none"} does not throw an exception
The patch is bigger than I would like due to the code generation tools used
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657404
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 16 May 2008 22:28:09 +0000 (22:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
You can't use an unescaped quote in an attribute value if you have quoted the value using that quote character
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657231
13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 16 May 2008 17:46:34 +0000 (17:46 +0000)]
Fix NPE reported on the dev list. The other toUpperCase() calls should be safe since the String will be non-null when the method is called.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@657149
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 15 May 2008 17:07:31 +0000 (17:07 +0000)]
Improved fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44968 as a single patch
Provide more information when keystore load fails
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656739
13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 15 May 2008 17:01:47 +0000 (17:01 +0000)]
Revert previous 3 commits to create clean patch for 6.0.x
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656738
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 15 May 2008 17:01:07 +0000 (17:01 +0000)]
update docs
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656737
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Thu, 15 May 2008 02:53:51 +0000 (02:53 +0000)]
fix broken build
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656494
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 14 May 2008 07:17:46 +0000 (07:17 +0000)]
Improve logging messages associated with previous commit in response to Filip's veto
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656124
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 14 May 2008 02:29:56 +0000 (02:29 +0000)]
tab police
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656089
13f79535-47bb-0310-9956-
ffa450edef68
fhanik [Wed, 14 May 2008 01:58:27 +0000 (01:58 +0000)]
save a few cpu cycles to avoid exceptions being thrown when a key is invalid
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656084
13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 13 May 2008 22:32:17 +0000 (22:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44968
Provide more information when keystore load fails
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@656035
13f79535-47bb-0310-9956-
ffa450edef68