tomcat7.0
15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Thu, 9 Dec 2010 19:02:01 +0000 (19:02 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Log the right message at the right point

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044091 13f79535-47bb-0310-9956-ffa450edef68

15 years agoignore work and logs directories as discussed on dev list
slaurent [Thu, 9 Dec 2010 18:59:14 +0000 (18:59 +0000)]
ignore work and logs directories as discussed on dev list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044088 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 49159: Improve ThreadLocal memory leak clean-up
slaurent [Thu, 9 Dec 2010 18:55:04 +0000 (18:55 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159

some formatting after discussion over the list (operator at the end of line, unnecessary cast)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044083 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Thu, 9 Dec 2010 18:10:38 +0000 (18:10 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Move ad-hoc attribute handling from the ProtocolHandler to the Endpoint and expose the Endpoint to ServerSocketFactory objects so they can retrieve additional configuration if required. All default components now use explicit configuration rather than relying on the ad-hoc mechanism.
Ensure the hooks for alternative SSL implementations are in place (were partially removed).
Remove the hooks for alternative ServerSocketFactory implementations (had been hard-coded / half implemented for some time).
Make the sslEnabledProtocols attribute work with BIO as well.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1044058 13f79535-47bb-0310-9956-ffa450edef68

15 years ago- Fixed brace and paren placement
schultz [Thu, 9 Dec 2010 14:35:28 +0000 (14:35 +0000)]
- Fixed brace and paren placement
- Changed Connector.isParseBodyMethod from public -> protected
- Relaxed language claiming that use of parseBodyMethods may "violate" the servlet spec
- Moved error message to LocalStrings.properties (Translations requested)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043983 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemoved a little more unused code
markt [Wed, 8 Dec 2010 22:25:04 +0000 (22:25 +0000)]
Removed a little more unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043734 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 17:15:50 +0000 (17:15 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
ProtocolHandler should register itself with MBean server rather than have the connector do it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043531 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove some unused code
markt [Wed, 8 Dec 2010 15:07:20 +0000 (15:07 +0000)]
Remove some unused code
Fix some FindBugs niggles

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043444 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 14:51:10 +0000 (14:51 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up start()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043441 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 14:36:26 +0000 (14:36 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Move MBean registration from start() to init(). More MBean refactoring expected

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043437 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix copy/paste error
markt [Wed, 8 Dec 2010 14:33:51 +0000 (14:33 +0000)]
Fix copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043433 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 14:19:23 +0000 (14:19 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up init()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043429 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlign BIO+JSSE with NIO+JSSE
markt [Wed, 8 Dec 2010 14:09:26 +0000 (14:09 +0000)]
Align BIO+JSSE with NIO+JSSE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043425 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix indents
markt [Wed, 8 Dec 2010 13:52:06 +0000 (13:52 +0000)]
Fix indents

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043421 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJSSE will always be available in Tomcat 7
markt [Wed, 8 Dec 2010 13:51:42 +0000 (13:51 +0000)]
JSSE will always be available in Tomcat 7

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043420 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 13:37:11 +0000 (13:37 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Align the init() methods (JSSE still to go)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043410 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNice idea, but need i18n for the actions so each needs its own string
markt [Wed, 8 Dec 2010 13:10:34 +0000 (13:10 +0000)]
Nice idea, but need i18n for the actions so each needs its own string

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043402 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 13:06:46 +0000 (13:06 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up stop()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043399 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 8 Dec 2010 12:57:54 +0000 (12:57 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up pause() and resume() methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043395 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused welcome file handling code
markt [Wed, 8 Dec 2010 11:36:49 +0000 (11:36 +0000)]
Remove unused welcome file handling code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043364 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code
markt [Wed, 8 Dec 2010 01:31:51 +0000 (01:31 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043272 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code
markt [Wed, 8 Dec 2010 01:21:12 +0000 (01:21 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043269 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code.
markt [Wed, 8 Dec 2010 01:14:43 +0000 (01:14 +0000)]
Remove unused code.
Make spacing consistent.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043265 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJasper should not depend on Catalina
markt [Wed, 8 Dec 2010 01:12:03 +0000 (01:12 +0000)]
Jasper should not depend on Catalina
Re-use constants where possible
Fix a FindBugs niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043263 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAnother Findbugs niggle
markt [Wed, 8 Dec 2010 01:01:56 +0000 (01:01 +0000)]
Another Findbugs niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043260 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some FindBugs warnings - all unclosed streams. These could potentially lead to...
markt [Tue, 7 Dec 2010 18:36:39 +0000 (18:36 +0000)]
Fix some FindBugs warnings - all unclosed streams. These could potentially lead to locked files and maybe memory leaks.
Fix some other simple FindBugs/Eclipse warnings in affected files.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043157 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix a couple of 'high priority' FindBugs warnings
markt [Tue, 7 Dec 2010 18:05:31 +0000 (18:05 +0000)]
Fix a couple of 'high priority' FindBugs warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043153 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd checkstyle rule for modifier order and fix remaining issues in current code base
markt [Tue, 7 Dec 2010 15:43:37 +0000 (15:43 +0000)]
Add checkstyle rule for modifier order and fix remaining issues in current code base

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043106 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix modifier order in org.apache.catalina.*
markt [Tue, 7 Dec 2010 15:42:32 +0000 (15:42 +0000)]
Fix modifier order in org.apache.catalina.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043105 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix modifier order in org.apache.naming.*
markt [Tue, 7 Dec 2010 15:40:49 +0000 (15:40 +0000)]
Fix modifier order in org.apache.naming.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043104 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix modifier order in org.apache.tomcat.*
markt [Tue, 7 Dec 2010 15:40:06 +0000 (15:40 +0000)]
Fix modifier order in org.apache.tomcat.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043103 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix modifier order in org.apache.jasper.*
markt [Tue, 7 Dec 2010 15:39:09 +0000 (15:39 +0000)]
Fix modifier order in org.apache.jasper.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043101 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix modifier order in org.apache.el.*
markt [Tue, 7 Dec 2010 15:38:06 +0000 (15:38 +0000)]
Fix modifier order in org.apache.el.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043099 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix modifier order in javax.*
markt [Tue, 7 Dec 2010 15:36:36 +0000 (15:36 +0000)]
Fix modifier order in javax.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043098 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAnother day, another check
markt [Tue, 7 Dec 2010 14:01:21 +0000 (14:01 +0000)]
Another day, another check

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043051 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTypo
markt [Tue, 7 Dec 2010 14:00:42 +0000 (14:00 +0000)]
Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1043050 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Tue, 7 Dec 2010 00:08:38 +0000 (00:08 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up the concrete destroy() method - required a fair bit of refactoring
Pull up the abstract init() method()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042873 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 23:22:44 +0000 (23:22 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Add the necessary plumbing for the AbstractProtocolHandler to perform the JMX registration

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042850 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix auto-completion snafu
markt [Mon, 6 Dec 2010 22:19:35 +0000 (22:19 +0000)]
Fix auto-completion snafu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042816 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 22:06:52 +0000 (22:06 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up JMX related methods
Tidy up the remaining protocol specific methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042814 13f79535-47bb-0310-9956-ffa450edef68

15 years agoInclude root cause in LifecycleException stack traces
markt [Mon, 6 Dec 2010 21:25:07 +0000 (21:25 +0000)]
Include root cause in LifecycleException stack traces

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042798 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 49159: Improve ThreadLocal memory leak clean-up
slaurent [Mon, 6 Dec 2010 20:49:14 +0000 (20:49 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159

Various fixes after review by markt : formatting, use string manager, svn props...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042786 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect a typo
kkolinko [Mon, 6 Dec 2010 20:19:03 +0000 (20:19 +0000)]
Correct a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042775 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet the tests running again on the command line
markt [Mon, 6 Dec 2010 19:20:57 +0000 (19:20 +0000)]
Get the tests running again on the command line

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042761 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 17:16:53 +0000 (17:16 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up timeout getters/setters.
Use -1 consistently for the default value of keepAliveTimeout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042726 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSince the address is exposed to sub-components, expose the port as well.
markt [Mon, 6 Dec 2010 16:41:06 +0000 (16:41 +0000)]
Since the address is exposed to sub-components, expose the port as well.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042716 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix another mix-up of connectionUploadTimeout and connectionTimeout
markt [Mon, 6 Dec 2010 16:37:16 +0000 (16:37 +0000)]
Fix another mix-up of connectionUploadTimeout and connectionTimeout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042713 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert svn-ignore property changes made in r1042482
markt [Mon, 6 Dec 2010 16:29:25 +0000 (16:29 +0000)]
Revert svn-ignore property changes made in r1042482

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042708 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix mix-up of connectionUploadTimeout and connectionTimeout
markt [Mon, 6 Dec 2010 16:26:17 +0000 (16:26 +0000)]
Fix mix-up of connectionUploadTimeout and connectionTimeout
Use connectionUploadTimeout consistently as attribute name
Document connectionUploadTimeout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042706 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code
markt [Mon, 6 Dec 2010 16:04:33 +0000 (16:04 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042696 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 15:43:52 +0000 (15:43 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Pull up more getters/setters.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042681 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 15:01:34 +0000 (15:01 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Start to pull more getters/setters and the generic attribute handling. Note that the comments around generic attribute handling are aspirational in some cases but subsequent commits should align the behaviour to the comments.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042670 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code
markt [Mon, 6 Dec 2010 14:09:14 +0000 (14:09 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042651 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 14:02:19 +0000 (14:02 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Start to pull stuff up into the base class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042648 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Mon, 6 Dec 2010 13:36:48 +0000 (13:36 +0000)]
Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Implement a common base class for ProtocolHandler implementations that will handle life-cycle/mbean issues (once more re-factoring has been completed)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042639 13f79535-47bb-0310-9956-ffa450edef68

15 years agoLine-length
markt [Mon, 6 Dec 2010 00:17:43 +0000 (00:17 +0000)]
Line-length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042495 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo
markt [Mon, 6 Dec 2010 00:15:45 +0000 (00:15 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042494 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 49159: Improve ThreadLocal memory leak clean-up
slaurent [Sun, 5 Dec 2010 22:54:05 +0000 (22:54 +0000)]
bug 49159: Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159
Renewing threads of the pool when a webapp is stopped

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042482 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50411
markt [Sun, 5 Dec 2010 22:50:56 +0000 (22:50 +0000)]
Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50411

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042480 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 50282 / fixed line length
slaurent [Sun, 5 Dec 2010 21:26:22 +0000 (21:26 +0000)]
bug 50282 / fixed line length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042452 13f79535-47bb-0310-9956-ffa450edef68

15 years agosort entries by ascending BZ number
slaurent [Sun, 5 Dec 2010 21:07:49 +0000 (21:07 +0000)]
sort entries by ascending BZ number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042448 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 50282 / fixed some typos in documentation
slaurent [Sun, 5 Dec 2010 21:06:25 +0000 (21:06 +0000)]
bug 50282 / fixed some typos in documentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042447 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50411
markt [Sun, 5 Dec 2010 19:32:00 +0000 (19:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50411
Ensure sessions are removed from the Store associated with a PersistentManager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042427 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAddress some review comments:
markt [Sun, 5 Dec 2010 19:16:07 +0000 (19:16 +0000)]
Address some review comments:
1. Avoid possible NPEs by using a local variable for the newDefaultAccessLog
2. PropertyChangeListener should be added to the Engine
3. Add the listener when the Noop logger is used so changes can be detected that could cause a different logger to be used.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042413 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMark 'basePackage' as final, to allow string concatenation to be done at compile...
kkolinko [Sun, 5 Dec 2010 18:22:25 +0000 (18:22 +0000)]
Mark 'basePackage' as final, to allow string concatenation to be done at compile time.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042395 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIgnore all .* files rather than adding them one by one as they appear
markt [Sun, 5 Dec 2010 12:51:46 +0000 (12:51 +0000)]
Ignore all .* files rather than adding them one by one as they appear

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042339 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove file accidentally added in r1042029
markt [Sun, 5 Dec 2010 12:49:22 +0000 (12:49 +0000)]
Remove file accidentally added in r1042029

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042337 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 50282 : Load javax.security.auth.login.Configuration with JreMemoryLeakPrevention...
slaurent [Fri, 3 Dec 2010 22:19:11 +0000 (22:19 +0000)]
bug 50282 : Load javax.security.auth.login.Configuration with JreMemoryLeakPreventionListener to avoid memory leak when stopping a webapp that would use JAAS.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042029 13f79535-47bb-0310-9956-ffa450edef68

15 years agobug 48973 (enhancement): Don't create SESSIONS.ser when no session exists
slaurent [Fri, 3 Dec 2010 22:00:58 +0000 (22:00 +0000)]
bug 48973 (enhancement): Don't create SESSIONS.ser when no session exists
https://issues.apache.org/bugzilla/show_bug.cgi?id=48973

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042022 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50408
markt [Fri, 3 Dec 2010 21:49:54 +0000 (21:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50408
Fix <code>NoSuchMethodException</code> when using scoped variables with EL method invocation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1042021 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNeed at least one test per class dummy test for unit tests to pass
markt [Fri, 3 Dec 2010 20:23:43 +0000 (20:23 +0000)]
Need at least one test per class dummy test for unit tests to pass

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041978 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r1041120 but disable rather than delete new test
markt [Fri, 3 Dec 2010 18:07:52 +0000 (18:07 +0000)]
Revert r1041120 but disable rather than delete new test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041940 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFixed bug 48692: Provide option to parse application/x-www-form-urlencoded PUT requests
schultz [Fri, 3 Dec 2010 16:07:50 +0000 (16:07 +0000)]
Fixed bug 48692: Provide option to parse application/x-www-form-urlencoded PUT requests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041892 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBump versions ready for next release
markt [Thu, 2 Dec 2010 22:37:53 +0000 (22:37 +0000)]
Bump versions ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041621 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=8705
markt [Thu, 2 Dec 2010 20:48:41 +0000 (20:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=8705
org.apache.catalina.SessionListener should extend java.util.EventListener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041578 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd an embedded distribution to the release build
markt [Thu, 2 Dec 2010 20:35:15 +0000 (20:35 +0000)]
Add an embedded distribution to the release build

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041573 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Javadoc warning
markt [Thu, 2 Dec 2010 20:03:22 +0000 (20:03 +0000)]
Fix Javadoc warning

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041558 13f79535-47bb-0310-9956-ffa450edef68

15 years agoReplace use of inefficient constructors
markt [Thu, 2 Dec 2010 18:17:55 +0000 (18:17 +0000)]
Replace use of inefficient constructors
Reported by FindBugs. Not all fixed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041511 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unnecessary code
markt [Thu, 2 Dec 2010 17:25:45 +0000 (17:25 +0000)]
Remove unnecessary code
Identified by FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041475 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't pass null to log messages.
markt [Thu, 2 Dec 2010 17:15:08 +0000 (17:15 +0000)]
Don't pass null to log messages.
Found by FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041469 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProtect against unlikely NPE
markt [Thu, 2 Dec 2010 17:07:07 +0000 (17:07 +0000)]
Protect against unlikely NPE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041458 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect removal of LifeCycleListenters from Containers via JMX.
markt [Thu, 2 Dec 2010 16:51:08 +0000 (16:51 +0000)]
Correct removal of LifeCycleListenters from Containers via JMX.
Found with FindBugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041448 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter test case
markt [Thu, 2 Dec 2010 16:09:45 +0000 (16:09 +0000)]
Better test case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041427 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix error in r1041356
markt [Thu, 2 Dec 2010 16:07:10 +0000 (16:07 +0000)]
Fix error in r1041356

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041425 13f79535-47bb-0310-9956-ffa450edef68

15 years agoHostConfig passed a context name to ContextName(String) - ensure that this is correct...
markt [Thu, 2 Dec 2010 12:56:56 +0000 (12:56 +0000)]
HostConfig passed a context name to ContextName(String) - ensure that this is correctly parsed. ContextName(String) now accepts all variations of Context name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041356 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake constants static
markt [Thu, 2 Dec 2010 10:30:17 +0000 (10:30 +0000)]
Make constants static

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041324 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMove changelog comment for BZ 50228 from Catalina to Jasper.
kkolinko [Thu, 2 Dec 2010 01:40:55 +0000 (01:40 +0000)]
Move changelog comment for BZ 50228 from Catalina to Jasper.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041248 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert part of r1039051
markt [Wed, 1 Dec 2010 19:00:53 +0000 (19:00 +0000)]
Revert part of r1039051
Current node is not included in cluster.getMmebers() so previous test was correct

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041133 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
markt [Wed, 1 Dec 2010 18:37:29 +0000 (18:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Bind/release socket on start()/stop()
Register/deregister MBeans on init()/destroy()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041120 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police
markt [Wed, 1 Dec 2010 17:43:25 +0000 (17:43 +0000)]
Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041101 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo (syntax error) in changelog.
rjung [Wed, 1 Dec 2010 16:25:34 +0000 (16:25 +0000)]
Fix typo (syntax error) in changelog.
Should also fix recent buildbot failure.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041074 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't put anything in current dev since it will be picked up in the tag and could...
markt [Wed, 1 Dec 2010 15:41:45 +0000 (15:41 +0000)]
Don't put anything in current dev since it will be picked up in the tag and could cause confusion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041061 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate release dates
markt [Wed, 1 Dec 2010 15:41:01 +0000 (15:41 +0000)]
Update release dates

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1041060 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't set property that doesn't exist on any ProtocolHandler or Endpoint
markt [Tue, 30 Nov 2010 17:55:38 +0000 (17:55 +0000)]
Don't set property that doesn't exist on any ProtocolHandler or Endpoint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040656 13f79535-47bb-0310-9956-ffa450edef68

15 years agoContext name rather than Context path is passed in so construct ContextName object...
markt [Tue, 30 Nov 2010 17:42:01 +0000 (17:42 +0000)]
Context name rather than Context path is passed in so construct ContextName object correctly.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040652 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSwitch MapperListener to the new Lifecycle
markt [Tue, 30 Nov 2010 16:11:23 +0000 (16:11 +0000)]
Switch MapperListener to the new Lifecycle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040609 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo in script comment.
rjung [Tue, 30 Nov 2010 14:58:07 +0000 (14:58 +0000)]
Fix typo in script comment.
BZ 50383, addition to r1040546.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040553 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=50383
markt [Tue, 30 Nov 2010 14:47:34 +0000 (14:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50383
Comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040546 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlign tests with new ManagerBase code
markt [Tue, 30 Nov 2010 13:41:09 +0000 (13:41 +0000)]
Align tests with new ManagerBase code
Update OSX figures - now comparable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040516 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove direct support for reading random bytes from a file
markt [Tue, 30 Nov 2010 13:15:51 +0000 (13:15 +0000)]
Remove direct support for reading random bytes from a file
Add support for specifying SecureRandom algorithm and provider

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1040511 13f79535-47bb-0310-9956-ffa450edef68