horde.git
15 years agoFix function signature
Michael M Slusarz [Tue, 7 Sep 2010 21:10:54 +0000 (15:10 -0600)]
Fix function signature

15 years agoShort circuit if indices list is empty
Michael M Slusarz [Tue, 7 Sep 2010 21:09:32 +0000 (15:09 -0600)]
Short circuit if indices list is empty

15 years agoGet down to a 23-char id. Discard the more_entropy from uniqid since it just comes...
Chuck Hagenbuch [Tue, 7 Sep 2010 21:20:53 +0000 (17:20 -0400)]
Get down to a 23-char id. Discard the more_entropy from uniqid since it just comes from the LCG; use mt_rand() instead. In addition, add some bits based on the hostname to help with uniqueness across hosts.

15 years agoBug #9233: Menu goto js was triggering for any calendar click
Michael M Slusarz [Tue, 7 Sep 2010 19:41:13 +0000 (13:41 -0600)]
Bug #9233: Menu goto js was triggering for any calendar click

15 years agoFix typo
Michael M Slusarz [Tue, 7 Sep 2010 19:29:43 +0000 (13:29 -0600)]
Fix typo

15 years agoDIMP.baseWindow might be undefined.
Michael M Slusarz [Tue, 7 Sep 2010 18:39:45 +0000 (12:39 -0600)]
DIMP.baseWindow might be undefined.

15 years agoMake this load on dom:loaded like everything else.
Michael M Slusarz [Tue, 7 Sep 2010 18:38:56 +0000 (12:38 -0600)]
Make this load on dom:loaded like everything else.

15 years agoBug #9236: Honor disable option
Michael M Slusarz [Tue, 7 Sep 2010 18:27:56 +0000 (12:27 -0600)]
Bug #9236: Honor disable option

15 years agoBug #9234: Remove bad semicolon
Michael M Slusarz [Tue, 7 Sep 2010 18:13:24 +0000 (12:13 -0600)]
Bug #9234: Remove bad semicolon

15 years agoTicket #7422: Test out session close/reopen for potentially long operations
Michael M Slusarz [Tue, 7 Sep 2010 08:26:38 +0000 (02:26 -0600)]
Ticket #7422: Test out session close/reopen for potentially long operations

15 years agostyle
Michael M Slusarz [Tue, 7 Sep 2010 08:26:15 +0000 (02:26 -0600)]
style

15 years agoBug #8695: Fix broken internal anchors in HTML data in Mozilla
Michael M Slusarz [Tue, 7 Sep 2010 08:15:30 +0000 (02:15 -0600)]
Bug #8695: Fix broken internal anchors in HTML data in Mozilla

15 years agoFix typo
Michael M Slusarz [Tue, 7 Sep 2010 08:05:54 +0000 (02:05 -0600)]
Fix typo

15 years agoMore appropriate exception
Michael M Slusarz [Tue, 7 Sep 2010 07:28:27 +0000 (01:28 -0600)]
More appropriate exception

15 years agoOnly save the IMAP object once per session
Michael M Slusarz [Tue, 7 Sep 2010 07:24:58 +0000 (01:24 -0600)]
Only save the IMAP object once per session

15 years agoBetter logging framework for imap client lib
Michael M Slusarz [Tue, 7 Sep 2010 06:50:14 +0000 (00:50 -0600)]
Better logging framework for imap client lib

Instead of using static variable, define a logger for each client object
instance, and ensure that this logger will survive serialization.

15 years agoBetter way of handling encryption key in imap client lib
Michael M Slusarz [Tue, 7 Sep 2010 06:30:36 +0000 (00:30 -0600)]
Better way of handling encryption key in imap client lib

This method doesn't require us to explicitly set encryption key when
unserializing the object.

15 years agostyle
Michael M Slusarz [Tue, 7 Sep 2010 06:14:29 +0000 (00:14 -0600)]
style

15 years agoCatch IMAP caching init errors
Michael M Slusarz [Tue, 7 Sep 2010 06:12:16 +0000 (00:12 -0600)]
Catch IMAP caching init errors

15 years agoClean up handling default parameters
Michael M Slusarz [Tue, 7 Sep 2010 06:10:10 +0000 (00:10 -0600)]
Clean up handling default parameters

15 years agoDon't do isOpen check when collapsing
Michael M Slusarz [Tue, 7 Sep 2010 05:43:11 +0000 (23:43 -0600)]
Don't do isOpen check when collapsing

15 years agoFix showing unsubscribed folders in dimp.
Michael M Slusarz [Tue, 7 Sep 2010 05:41:29 +0000 (23:41 -0600)]
Fix showing unsubscribed folders in dimp.

15 years agoFix Bug #9041
Michael M Slusarz [Tue, 7 Sep 2010 05:04:40 +0000 (23:04 -0600)]
Fix Bug #9041

Correctly determine folder diff when folder contains unsubscribed
mailboxes, which are not visible in the current mode.

15 years agoFix renaming mailboxes
Michael M Slusarz [Tue, 7 Sep 2010 03:44:01 +0000 (21:44 -0600)]
Fix renaming mailboxes

15 years agoFix undefined object error.
Michael M Slusarz [Tue, 7 Sep 2010 03:43:28 +0000 (21:43 -0600)]
Fix undefined object error.

15 years agoDon't toggle nodes with no children.
Michael M Slusarz [Tue, 7 Sep 2010 03:43:12 +0000 (21:43 -0600)]
Don't toggle nodes with no children.

15 years agoBug #9224: Don't output two slashes in a row
Michael M Slusarz [Tue, 7 Sep 2010 03:12:07 +0000 (21:12 -0600)]
Bug #9224: Don't output two slashes in a row

15 years agoFix javascript vars on login page.
Michael M Slusarz [Mon, 6 Sep 2010 23:53:19 +0000 (17:53 -0600)]
Fix javascript vars on login page.

15 years agoEncapsulate all search data within IMP_Search
Michael M Slusarz [Mon, 6 Sep 2010 23:33:52 +0000 (17:33 -0600)]
Encapsulate all search data within IMP_Search

15 years agoDon't use static variable for virtual folder list
Michael M Slusarz [Mon, 6 Sep 2010 22:29:08 +0000 (16:29 -0600)]
Don't use static variable for virtual folder list

15 years agoNo need for these variables to be member variables.
Michael M Slusarz [Mon, 6 Sep 2010 22:08:12 +0000 (16:08 -0600)]
No need for these variables to be member variables.

Saves a bit of space in a serialized representation.

15 years agoMore places to use Horde_Support_Randomid
Michael M Slusarz [Mon, 6 Sep 2010 22:01:40 +0000 (16:01 -0600)]
More places to use Horde_Support_Randomid

15 years agoIf we don't want to explicitly add prototype if other scripts are
Michael J. Rubinsky [Tue, 7 Sep 2010 00:08:09 +0000 (20:08 -0400)]
If we don't want to explicitly add prototype if other scripts are
added, then we need to assume that if the other script is requesting
a full url, then prototype should be a full url as well.

15 years agoFix parse error
Michael J. Rubinsky [Mon, 6 Sep 2010 23:35:05 +0000 (19:35 -0400)]
Fix parse error

Bug: 9230

15 years agocs, some leftover php4 -> php5 conversion
Michael J. Rubinsky [Mon, 6 Sep 2010 18:54:36 +0000 (14:54 -0400)]
cs, some leftover php4 -> php5 conversion

15 years agoHave Horde_Log_Logger implement Serializable
Michael M Slusarz [Mon, 6 Sep 2010 20:31:02 +0000 (14:31 -0600)]
Have Horde_Log_Logger implement Serializable

15 years agoHave Horde_Memcache implement Serializable
Michael M Slusarz [Mon, 6 Sep 2010 20:17:06 +0000 (14:17 -0600)]
Have Horde_Memcache implement Serializable

15 years agoH4 phpdoc and formatting cleanups
Michael M Slusarz [Mon, 6 Sep 2010 19:36:52 +0000 (13:36 -0600)]
H4 phpdoc and formatting cleanups

15 years agoImplement Serializable for Horde_Imap_Client_DateTime
Michael M Slusarz [Mon, 6 Sep 2010 03:01:44 +0000 (21:01 -0600)]
Implement Serializable for Horde_Imap_Client_DateTime

15 years agoMake encryptKey a object parameter, not a globally static property
Michael M Slusarz [Sat, 4 Sep 2010 08:19:37 +0000 (02:19 -0600)]
Make encryptKey a object parameter, not a globally static property

15 years agoCatch bad Imap client unserializations
Michael M Slusarz [Sat, 4 Sep 2010 08:16:28 +0000 (02:16 -0600)]
Catch bad Imap client unserializations

15 years agoThis is a programming error, not a run-time error
Michael M Slusarz [Sat, 4 Sep 2010 08:16:03 +0000 (02:16 -0600)]
This is a programming error, not a run-time error

15 years agoHave Horde_Imap_Client_Base implement Serializable
Michael M Slusarz [Sat, 4 Sep 2010 08:03:57 +0000 (02:03 -0600)]
Have Horde_Imap_Client_Base implement Serializable

Provides a more compact way of storing serialized data.
Reduces complexity as child functions do not need to extend the
serialization-related methods.
Implement versioning in order to invalidate cache when upgrading in
future.

15 years agoRemove token data from memory when finished with it
Michael M Slusarz [Sat, 4 Sep 2010 07:33:53 +0000 (01:33 -0600)]
Remove token data from memory when finished with it

15 years agoAlways leave password encrypted in Imap object
Michael M Slusarz [Sat, 4 Sep 2010 07:16:59 +0000 (01:16 -0600)]
Always leave password encrypted in Imap object

15 years agoHave IMP_Imap_Tree implement Serializable
Michael M Slusarz [Sat, 4 Sep 2010 07:06:34 +0000 (01:06 -0600)]
Have IMP_Imap_Tree implement Serializable

Slightly more compact way of storing serialized data.  Also, implement
versioning in order to invalidate cache when upgrading in future.

15 years agoCode cleanups/phpdoc
Michael M Slusarz [Sat, 4 Sep 2010 06:35:21 +0000 (00:35 -0600)]
Code cleanups/phpdoc

15 years agoDon't show global options item if editing horde options
Michael M Slusarz [Sat, 4 Sep 2010 06:24:11 +0000 (00:24 -0600)]
Don't show global options item if editing horde options

15 years agoFix constant name
Michael M Slusarz [Sat, 4 Sep 2010 06:20:17 +0000 (00:20 -0600)]
Fix constant name

15 years agoMake tests run
Michael M Slusarz [Sat, 4 Sep 2010 06:11:42 +0000 (00:11 -0600)]
Make tests run

15 years agoUse Horde::addInlineJsVars()
Michael M Slusarz [Fri, 3 Sep 2010 23:19:00 +0000 (17:19 -0600)]
Use Horde::addInlineJsVars()

15 years agoAdd Horde::addInlineJsVars().
Michael M Slusarz [Fri, 3 Sep 2010 23:18:36 +0000 (17:18 -0600)]
Add Horde::addInlineJsVars().

15 years agoSome Horde:: -> self:: conversions.
Michael M Slusarz [Fri, 3 Sep 2010 23:01:31 +0000 (17:01 -0600)]
Some Horde:: -> self:: conversions.

15 years agoFix gettext string
Michael M Slusarz [Fri, 3 Sep 2010 22:44:45 +0000 (16:44 -0600)]
Fix gettext string

15 years agoNo need to add prototype.js if at least 1 other script file is added
Michael M Slusarz [Fri, 3 Sep 2010 22:02:42 +0000 (16:02 -0600)]
No need to add prototype.js if at least 1 other script file is added

15 years agoTooltips tweaks.
Michael M Slusarz [Fri, 3 Sep 2010 21:56:23 +0000 (15:56 -0600)]
Tooltips tweaks.

Automatically add JS file when calling linkTooltip().
Move tooltips JS file to horde/Core.

15 years agoIMP search fixes.
Michael M Slusarz [Fri, 3 Sep 2010 21:45:11 +0000 (15:45 -0600)]
IMP search fixes.

Fix basic search.
Fix since/equals/before searching.

15 years agophpdoc
Michael J. Rubinsky [Mon, 6 Sep 2010 18:29:30 +0000 (14:29 -0400)]
phpdoc

15 years agoEnsure this value is a string.
Michael J. Rubinsky [Mon, 6 Sep 2010 18:28:26 +0000 (14:28 -0400)]
Ensure this value is a string.

The tagger needs the local id as a string or it assumes it's a
rampage object id (which it will never be here).

15 years agocs
Michael J. Rubinsky [Mon, 6 Sep 2010 18:11:00 +0000 (14:11 -0400)]
cs

Looks like this file got ran through some formatting filter or something at some point.

15 years agoUse IPTC caption property if it's available.
Michael J. Rubinsky [Mon, 6 Sep 2010 17:23:58 +0000 (13:23 -0400)]
Use IPTC caption property if it's available.

15 years agofix parse error
Michael J. Rubinsky [Mon, 6 Sep 2010 15:10:56 +0000 (11:10 -0400)]
fix parse error

15 years agoFix unit testing.
Gunnar Wrobel [Mon, 6 Sep 2010 10:41:15 +0000 (12:41 +0200)]
Fix unit testing.

15 years agoStart using dependency injection.
Gunnar Wrobel [Mon, 6 Sep 2010 08:04:39 +0000 (10:04 +0200)]
Start using dependency injection.

15 years agoElement -> Components for the different classes.
Gunnar Wrobel [Mon, 6 Sep 2010 06:38:58 +0000 (08:38 +0200)]
Element -> Components for the different classes.

15 years agoRenamed Element to Components within the package.
Gunnar Wrobel [Mon, 6 Sep 2010 03:38:50 +0000 (05:38 +0200)]
Renamed Element to Components within the package.

15 years agoRenamed Horde_Element to components.
Gunnar Wrobel [Mon, 6 Sep 2010 02:57:26 +0000 (04:57 +0200)]
Renamed Horde_Element to components.

15 years agoUnless I'm missing something, packing the mt_rand() result as an unsigned int
Chuck Hagenbuch [Mon, 6 Sep 2010 04:53:14 +0000 (00:53 -0400)]
Unless I'm missing something, packing the mt_rand() result as an unsigned int
doesn't lose any data but takes up predictably less space, letting us say that
this is always a 24-char random id.

Also, rather than giving up randomness, use url-safe base64 encoding.

15 years agoMerge changes from Aperture exporter
Michael J. Rubinsky [Sun, 5 Sep 2010 21:50:17 +0000 (17:50 -0400)]
Merge changes from Aperture exporter

15 years agoWork around some issues when listImages returns <= 1 image.
Michael J. Rubinsky [Sun, 5 Sep 2010 21:46:22 +0000 (17:46 -0400)]
Work around some issues when listImages returns <= 1 image.

15 years agoEnsure these are integers
Michael J. Rubinsky [Sun, 5 Sep 2010 20:32:35 +0000 (16:32 -0400)]
Ensure these are integers

Bug: 9217

15 years agoNo reason to have the filebased state driver as an option in Horde now
Michael J. Rubinsky [Sun, 5 Sep 2010 18:09:25 +0000 (14:09 -0400)]
No reason to have the filebased state driver as an option in Horde now
that we have a fully functional history driver.

15 years agoFix some phpdoc, get rid of some lingering PEAR_Error usage
Michael J. Rubinsky [Sun, 5 Sep 2010 17:29:40 +0000 (13:29 -0400)]
Fix some phpdoc, get rid of some lingering PEAR_Error usage

15 years agoRemove deprecated method parameters.
Michael J. Rubinsky [Sun, 5 Sep 2010 15:23:03 +0000 (11:23 -0400)]
Remove deprecated method parameters.

Bug: 9227

15 years agofix parse error
Michael J. Rubinsky [Sun, 5 Sep 2010 15:18:48 +0000 (11:18 -0400)]
fix parse error

Bug: 9226

15 years agoThese may not always be set
Michael J. Rubinsky [Sun, 5 Sep 2010 05:08:13 +0000 (01:08 -0400)]
These may not always be set

15 years agoFix method name, existence checking
Michael J. Rubinsky [Sun, 5 Sep 2010 04:51:23 +0000 (00:51 -0400)]
Fix method name, existence checking

15 years agoThis isn't currently used in ActiveSync
Michael J. Rubinsky [Sun, 5 Sep 2010 02:42:49 +0000 (22:42 -0400)]
This isn't currently used in ActiveSync

15 years agoEnsure 'path' exists before accessing it.
Michael J. Rubinsky [Sun, 5 Sep 2010 02:31:49 +0000 (22:31 -0400)]
Ensure 'path' exists before accessing it.

$puri might not contain 'path', in fact it might not contain *any* keys if
$uri that is passed into the function is '#'

15 years agoPartially revert ed6f463144b70b05304a: application blocks are not currently autoloadable.
Michael J. Rubinsky [Sat, 4 Sep 2010 16:34:43 +0000 (12:34 -0400)]
Partially revert ed6f463144b70b05304a: application blocks are not currently autoloadable.

15 years agoAdd versioning and display on plugin sheet
Michael J. Rubinsky [Fri, 3 Sep 2010 22:45:27 +0000 (18:45 -0400)]
Add versioning and display on plugin sheet

15 years agoAdd versioning and display it on plugin panel
Michael J. Rubinsky [Fri, 3 Sep 2010 21:44:26 +0000 (17:44 -0400)]
Add versioning and display it on plugin panel

15 years agoBug #9216: Fix header encoding on compose
Michael M Slusarz [Fri, 3 Sep 2010 20:07:45 +0000 (14:07 -0600)]
Bug #9216: Fix header encoding on compose

Overzealous optimization - there is no away around the fact that we need
to call parseAddressList() twice due to the fact that the first use
needs to be done before we encode/validate the email string.

15 years agoDon't remember why we don't want targets with hash fragments to open in new target...
Michael M Slusarz [Fri, 3 Sep 2010 19:55:37 +0000 (13:55 -0600)]
Don't remember why we don't want targets with hash fragments to open in new target, but it doesn't make sense (and breaks things)

15 years agoIMP_Imap_Tree should always be cached.
Michael M Slusarz [Fri, 3 Sep 2010 18:44:24 +0000 (12:44 -0600)]
IMP_Imap_Tree should always be cached.

Since IMAP tree generation is so expensive/time-consuming, fallback to
storing in the session even if no permanent cache backend is setup.

15 years agoAdd Horde_Cache factory object
Michael M Slusarz [Fri, 3 Sep 2010 18:41:04 +0000 (12:41 -0600)]
Add Horde_Cache factory object

Provides a way to default to the Session cache driver, instead of the
Null driver.

15 years agoAdd Horde_Cache_Session::.
Michael M Slusarz [Fri, 3 Sep 2010 18:26:36 +0000 (12:26 -0600)]
Add Horde_Cache_Session::.

15 years agoUse ondemand injector binding throughout Horde
Michael M Slusarz [Fri, 3 Sep 2010 17:53:40 +0000 (11:53 -0600)]
Use ondemand injector binding throughout Horde

15 years agoAdd ondemand injector binders.
Michael M Slusarz [Fri, 3 Sep 2010 17:23:06 +0000 (11:23 -0600)]
Add ondemand injector binders.

Idea: Instead of instantiating a bunch of classes (which also requires,
at least with autoloading, the corresponding file lookup/read) with no
guarantee we will use a binder during a page access, create the binder
from a static (string) class name when it is first requested.

15 years agophpdoc
Michael M Slusarz [Fri, 3 Sep 2010 17:01:14 +0000 (11:01 -0600)]
phpdoc

15 years agoMore thorough checks for a base window
Michael M Slusarz [Fri, 3 Sep 2010 06:53:46 +0000 (00:53 -0600)]
More thorough checks for a base window

15 years agochanges
Michael J. Rubinsky [Fri, 3 Sep 2010 19:37:39 +0000 (15:37 -0400)]
changes

15 years agoRemove UI elements for unused feature
Michael J. Rubinsky [Fri, 3 Sep 2010 19:36:22 +0000 (15:36 -0400)]
Remove UI elements for unused feature

15 years agoSupport Ansel's version 2 API
Michael J. Rubinsky [Fri, 3 Sep 2010 19:31:37 +0000 (15:31 -0400)]
Support Ansel's version 2 API

15 years agoFix memory management issue
Michael J. Rubinsky [Fri, 3 Sep 2010 19:19:47 +0000 (15:19 -0400)]
Fix memory management issue

15 years agoAdd Resume Draft icon to preview pane
Michael M Slusarz [Fri, 3 Sep 2010 06:46:10 +0000 (00:46 -0600)]
Add Resume Draft icon to preview pane

15 years agoImprovements to draft reconstitution
Michael M Slusarz [Fri, 3 Sep 2010 06:32:27 +0000 (00:32 -0600)]
Improvements to draft reconstitution

15 years agoLink e-mail addresses in HTML compose data
Michael M Slusarz [Thu, 2 Sep 2010 21:27:45 +0000 (15:27 -0600)]
Link e-mail addresses in HTML compose data

15 years agoUse alternate text part to generate reply/forward text when switching compose modes...
Michael M Slusarz [Thu, 2 Sep 2010 20:35:27 +0000 (14:35 -0600)]
Use alternate text part to generate reply/forward text when switching compose modes if user has not altered message text (DIMP)

This does a much better job of trying to conserve format (especially
from HTML -> Text) since the alternative display part should
(theoretically) be a better representation of the original data than
message text created via our Text -> HTML or HTML -> Text conversion.

15 years agoAdd query string to URL, if it exists
Michael M Slusarz [Thu, 2 Sep 2010 18:26:10 +0000 (12:26 -0600)]
Add query string to URL, if it exists