tomcat7.0
15 years agoAdditional test for BZ 48616
kkolinko [Tue, 16 Feb 2010 04:52:38 +0000 (04:52 +0000)]
Additional test for BZ 48616

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910395 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWorkaround Java 6/7 bug described in https://issues.apache.org/bugzilla/show_bug...
markt [Tue, 16 Feb 2010 00:46:07 +0000 (00:46 +0000)]
Workaround Java 6/7 bug described in https://issues.apache.org/bugzilla/show_bug.cgi?id=48498
Avoid the ArrayIndexOutOfBoundsException

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910370 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48545
markt [Mon, 15 Feb 2010 17:14:27 +0000 (17:14 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48545
Truststores don't have to have passwords
Based on a patch by 'smmwpf54'

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910266 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSpacing
markt [Mon, 15 Feb 2010 08:09:39 +0000 (08:09 +0000)]
Spacing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910172 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to dbcp 1.4 release that supports JDBC4 and compiles on Java 6
markt [Mon, 15 Feb 2010 08:09:05 +0000 (08:09 +0000)]
Update to dbcp 1.4 release that supports JDBC4 and compiles on Java 6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910171 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse the Context interface rather than StandardEngine
markt [Mon, 15 Feb 2010 00:06:05 +0000 (00:06 +0000)]
Use the Context interface rather than StandardEngine

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910134 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse the Context interface rather than StandardContext
markt [Sun, 14 Feb 2010 23:54:52 +0000 (23:54 +0000)]
Use the Context interface rather than StandardContext

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910125 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse interfaces in o.a.c.startup.Tomcat and update tests as appropriate
markt [Sun, 14 Feb 2010 23:45:18 +0000 (23:45 +0000)]
Use interfaces in o.a.c.startup.Tomcat and update tests as appropriate

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910123 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd missing test
markt [Sun, 14 Feb 2010 23:44:20 +0000 (23:44 +0000)]
Add missing test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910122 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48384
markt [Sat, 13 Feb 2010 20:12:11 +0000 (20:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48384
Add a per context xslt option for directory listings
Make the fallback options work as described in the docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909887 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAddress review comments
markt [Sat, 13 Feb 2010 19:22:02 +0000 (19:22 +0000)]
Address review comments
Don't use toString() to try and co-erce any old object to an Enum - the spec only mentions String

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909875 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48371
markt [Sat, 13 Feb 2010 18:25:07 +0000 (18:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48371
Skip comments when working out where to insert generated servlets and associated mappings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909869 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavaDoc correction
kkolinko [Sat, 13 Feb 2010 18:14:32 +0000 (18:14 +0000)]
JavaDoc correction

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909866 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavaDoc correction
kkolinko [Sat, 13 Feb 2010 18:04:52 +0000 (18:04 +0000)]
JavaDoc correction

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909865 13f79535-47bb-0310-9956-ffa450edef68

15 years agoreverted Filip's r909673
kkolinko [Sat, 13 Feb 2010 16:37:49 +0000 (16:37 +0000)]
reverted Filip's r909673

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909845 13f79535-47bb-0310-9956-ffa450edef68

15 years agoChange a few variable names to reduce potential confusion - no functional change
markt [Sat, 13 Feb 2010 11:02:23 +0000 (11:02 +0000)]
Change a few variable names to reduce potential confusion - no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909789 13f79535-47bb-0310-9956-ffa450edef68

15 years agofix compilation error
fhanik [Sat, 13 Feb 2010 00:51:47 +0000 (00:51 +0000)]
fix compilation error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909673 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48318
markt [Fri, 12 Feb 2010 22:12:48 +0000 (22:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48318
Handle case where WebDAV resource is in directory listing but is not accessible

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909636 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate for new Eclipse lib
markt [Fri, 12 Feb 2010 21:34:20 +0000 (21:34 +0000)]
Update for new Eclipse lib
Align with new trunk build script

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909613 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd listener before child is added else listener won't get called on first load
markt [Fri, 12 Feb 2010 19:15:32 +0000 (19:15 +0000)]
Add listener before child is added else listener won't get called on first load

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909563 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDocument new findleaks command
markt [Fri, 12 Feb 2010 18:03:48 +0000 (18:03 +0000)]
Document new findleaks command

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909542 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a find leaks option - with a suitable warning to the manager app (html & text)
markt [Fri, 12 Feb 2010 17:51:06 +0000 (17:51 +0000)]
Add a find leaks option - with a suitable warning to the manager app (html & text)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909528 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake class loader registration more robust
markt [Fri, 12 Feb 2010 17:50:22 +0000 (17:50 +0000)]
Make class loader registration more robust

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909526 13f79535-47bb-0310-9956-ffa450edef68

15 years agoLooks like the ResourceBundle leaks are triggered by a GC bug - only seems to affect...
markt [Fri, 12 Feb 2010 17:49:49 +0000 (17:49 +0000)]
Looks like the ResourceBundle leaks are triggered by a GC bug - only seems to affect Sun JVMs.
The fix is also Sun specific so only log a debug message if the internal field can't be found on a non-Sun JVM (it isn't there for IBM for example)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909525 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove quotes from example - they break it
markt [Fri, 12 Feb 2010 09:58:13 +0000 (09:58 +0000)]
Remove quotes from example - they break it

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909321 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWhen the key is null (i.e., a stale entry), it cannot be removed with an explicit...
kkolinko [Fri, 12 Feb 2010 03:19:31 +0000 (03:19 +0000)]
When the key is null (i.e., a stale entry), it cannot be removed with an explicit remove(key) call: you'll get an NPE. Those can be removed with expungeStaleEntries() call.
Also, simplified the code: Reference.referent can be accessed by calling get() - no need to use reflection for that.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909212 13f79535-47bb-0310-9956-ffa450edef68

15 years agofollowup to r908002
kkolinko [Fri, 12 Feb 2010 02:22:23 +0000 (02:22 +0000)]
followup to r908002
Use the debug message (added in r908002) for debug output

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909206 13f79535-47bb-0310-9956-ffa450edef68

15 years agofollowup to r909134:
kkolinko [Fri, 12 Feb 2010 02:01:41 +0000 (02:01 +0000)]
followup to r909134:
correct a misprint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909204 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd rudimentary detection for PermGen memory leaks on web application reload. Only...
markt [Thu, 11 Feb 2010 20:32:09 +0000 (20:32 +0000)]
Add rudimentary detection for PermGen memory leaks on web application reload. Only available via JMX for now. Next step is to add it to the manager app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909134 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImproved memory leak prevention for resource ResourceBundle
markt [Thu, 11 Feb 2010 18:09:08 +0000 (18:09 +0000)]
Improved memory leak prevention for resource ResourceBundle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909097 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert simple ResourceBundle fix
markt [Thu, 11 Feb 2010 16:55:26 +0000 (16:55 +0000)]
Revert simple ResourceBundle fix
On reflection (no pun intended) a reflection based will be better since
- it can be implemented at a single point
- it can easily be ported to Tomcat 6
- it will be able to handle any exotic class loader structures created by apps

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909072 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore memory leak prevention - ResourceBundle
markt [Thu, 11 Feb 2010 15:14:55 +0000 (15:14 +0000)]
More memory leak prevention - ResourceBundle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909017 13f79535-47bb-0310-9956-ffa450edef68

15 years agoConvert my ApacheCon securing Tomcat presentation to a how to
markt [Thu, 11 Feb 2010 13:17:05 +0000 (13:17 +0000)]
Convert my ApacheCon securing Tomcat presentation to a how to

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908955 13f79535-47bb-0310-9956-ffa450edef68

15 years agoThis is no longer security related as unsafe usage is blocked
markt [Thu, 11 Feb 2010 12:23:36 +0000 (12:23 +0000)]
This is no longer security related as unsafe usage is blocked

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908942 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48726
markt [Wed, 10 Feb 2010 23:47:11 +0000 (23:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48726
Prevent OOME when uploading large files with the deployer
Patch provided by 'adam'

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908759 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48716
markt [Wed, 10 Feb 2010 23:36:51 +0000 (23:36 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48716
Provide an undocumented 'shoot yourself in the foot' option to disable the JULI logging reset

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908754 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate logging docs
markt [Wed, 10 Feb 2010 22:55:58 +0000 (22:55 +0000)]
Update logging docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908721 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPart of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 that is...
markt [Wed, 10 Feb 2010 22:41:55 +0000 (22:41 +0000)]
Part of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 that is not in trunk

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908701 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAnother copy/paste error
markt [Wed, 10 Feb 2010 22:40:14 +0000 (22:40 +0000)]
Another copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908697 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean-up
markt [Wed, 10 Feb 2010 22:39:35 +0000 (22:39 +0000)]
Clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908696 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavadoc police
markt [Wed, 10 Feb 2010 19:37:13 +0000 (19:37 +0000)]
Javadoc police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908645 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprovements for building jasper-jdt.jar:
kkolinko [Wed, 10 Feb 2010 13:10:51 +0000 (13:10 +0000)]
Improvements for building jasper-jdt.jar:
- Rebuild jasper-jdt.jar if jdt.jar was updated or redownloaded, or the build file was updated
- Purge target directory before unjarring, to avoid repacking stale files
- Clean unjarred files after the build as they are not needed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908484 13f79535-47bb-0310-9956-ffa450edef68

15 years ago- Update JDT compiler to version 3.5.1
kkolinko [Wed, 10 Feb 2010 00:50:40 +0000 (00:50 +0000)]
- Update JDT compiler to version 3.5.1
- Use JDT Core Batch Compiler download instead of JDT SDK download. It lessens the download size from 40 MB down to 1.6 MB.
- Implement support for two alternative download locations of a file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908300 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to latest version of JDT compiler
markt [Tue, 9 Feb 2010 11:51:30 +0000 (11:51 +0000)]
Update to latest version of JDT compiler

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908009 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIf the ThreadLocal is set to null, there won't be a memory leak but GC is required...
markt [Tue, 9 Feb 2010 11:17:05 +0000 (11:17 +0000)]
If the ThreadLocal is set to null, there won't be a memory leak but GC is required to clean up the keys. Continue to remove the keys if found to reduce the volume of data that has to be looked at when tracing memory leaks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908002 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSplit out the download target so only dependencies for the current target are downloa...
markt [Tue, 9 Feb 2010 10:24:37 +0000 (10:24 +0000)]
Split out the download target so only dependencies for the current target are downloaded rather than everything
Move the bayeux download to the bayeux build file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907991 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSpeed up a clean build slightly and provide Eclipse with a permanent location for...
markt [Tue, 9 Feb 2010 09:25:35 +0000 (09:25 +0000)]
Speed up a clean build slightly and provide Eclipse with a permanent location for the web services libraries

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907983 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix parsing bug spotted when reviewing r907538
kkolinko [Tue, 9 Feb 2010 01:06:01 +0000 (01:06 +0000)]
Fix parsing bug spotted when reviewing r907538
Allowing #{} expressions to be parsed even when they are disabled breaks ${} expressions if they are intermixed with them. See the testcase added in r907860, r907862.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907864 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional test from review of r907538
kkolinko [Tue, 9 Feb 2010 01:02:12 +0000 (01:02 +0000)]
Additional test from review of r907538

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907862 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional test from review of r907538
kkolinko [Tue, 9 Feb 2010 01:01:23 +0000 (01:01 +0000)]
Additional test from review of r907538

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907860 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170
markt [Mon, 8 Feb 2010 22:20:55 +0000 (22:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170
Remove unnecessary syncs that cause issues under heavy load

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907825 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police and line length
markt [Mon, 8 Feb 2010 22:15:36 +0000 (22:15 +0000)]
Tab police and line length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907824 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48109
markt [Mon, 8 Feb 2010 22:07:24 +0000 (22:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48109
Extent try catch block (diff is a lot simpler if you ignore whitespace) to ensure InputStream is closed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907819 13f79535-47bb-0310-9956-ffa450edef68

15 years agoLog when a valid shutdown command is received. This may help in tracking down "Tomcat...
markt [Mon, 8 Feb 2010 19:29:53 +0000 (19:29 +0000)]
Log when a valid shutdown command is received. This may help in tracking down "Tomcat just stops" style reports.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907768 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAllow the global naming context to be reset. Useful when running multiple embedded...
markt [Mon, 8 Feb 2010 17:07:28 +0000 (17:07 +0000)]
Allow the global naming context to be reset. Useful when running multiple embedded instances in series since it allows each instance to configure its own global naming context.
Doesn't help with multiple instances in parallel - but that was broken anyway.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907727 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet logic right way around
markt [Mon, 8 Feb 2010 16:47:47 +0000 (16:47 +0000)]
Get logic right way around

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907721 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid adding the package twice
markt [Mon, 8 Feb 2010 16:45:08 +0000 (16:45 +0000)]
Avoid adding the package twice

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907720 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEnsure appBase is valid. Prevents spurious stacktraces in tests
markt [Mon, 8 Feb 2010 16:25:13 +0000 (16:25 +0000)]
Ensure appBase is valid. Prevents spurious stacktraces in tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907717 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake the tesst easier to debug
markt [Mon, 8 Feb 2010 16:13:21 +0000 (16:13 +0000)]
Make the tesst easier to debug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907713 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore memory leak protection on reload.
markt [Mon, 8 Feb 2010 13:29:13 +0000 (13:29 +0000)]
More memory leak protection on reload.
Use of java.util.Timer

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907652 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProtect against NPE whilst running the test
markt [Mon, 8 Feb 2010 13:27:45 +0000 (13:27 +0000)]
Protect against NPE whilst running the test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907651 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a test case for TimerThread thread/memory leaks on reload as I have some ideas...
markt [Mon, 8 Feb 2010 12:57:08 +0000 (12:57 +0000)]
Add a test case for TimerThread thread/memory leaks on reload as I have some ideas on how to safely terminate those threads

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907646 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48660
markt [Mon, 8 Feb 2010 02:27:43 +0000 (02:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48660
Compression should add to Vary header rather than over-write it

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907544 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48665
markt [Mon, 8 Feb 2010 02:06:49 +0000 (02:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48665
Correct package in Javadoc
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907541 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668
markt [Mon, 8 Feb 2010 02:00:58 +0000 (02:00 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668
Don't look for EL matches (which swallow the EL match string) if EL is not enabled

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907538 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate with recently added tests
markt [Mon, 8 Feb 2010 01:59:35 +0000 (01:59 +0000)]
Update with recently added tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907537 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd test cases for bug 48668
markt [Mon, 8 Feb 2010 01:58:06 +0000 (01:58 +0000)]
Add test cases for bug 48668

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907534 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAs pointed out by bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48672, the...
markt [Sun, 7 Feb 2010 23:30:45 +0000 (23:30 +0000)]
As pointed out by bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48672, the host-manager application docs do not exist. Make this clear.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907513 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48643
markt [Sun, 7 Feb 2010 22:16:40 +0000 (22:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48643
Clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907502 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid NPEs
markt [Sun, 7 Feb 2010 21:26:28 +0000 (21:26 +0000)]
Avoid NPEs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907497 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet URI and location the right way around
markt [Sun, 7 Feb 2010 21:21:39 +0000 (21:21 +0000)]
Get URI and location the right way around

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907496 13f79535-47bb-0310-9956-ffa450edef68

15 years agoActually used the new jspConfigDescriptor
markt [Sun, 7 Feb 2010 21:20:00 +0000 (21:20 +0000)]
Actually used the new jspConfigDescriptor

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907495 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSkip null publicIds
markt [Sun, 7 Feb 2010 21:17:02 +0000 (21:17 +0000)]
Skip null publicIds

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907494 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet javax.servlet.http passing TCK API check
markt [Sun, 7 Feb 2010 21:12:03 +0000 (21:12 +0000)]
Get javax.servlet.http passing TCK API check
Removing use of @Deprecated
Use better comment for this in java.servlet

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907493 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet javax.servlet passing TCK API check
markt [Sun, 7 Feb 2010 21:02:03 +0000 (21:02 +0000)]
Get javax.servlet passing TCK API check
Mainly removing generics and @Deprecated

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907490 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRestore the JSP mappings
markt [Sun, 7 Feb 2010 20:18:26 +0000 (20:18 +0000)]
Restore the JSP mappings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907469 13f79535-47bb-0310-9956-ffa450edef68

15 years agoServlet 3.0
markt [Sun, 7 Feb 2010 20:08:54 +0000 (20:08 +0000)]
Servlet 3.0
Remainder of ServletContext plumbing
Plenty of scope to clean this up
Only lightly tested so far

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907468 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFollowup to r907355. Correct a misprint
kkolinko [Sun, 7 Feb 2010 02:17:43 +0000 (02:17 +0000)]
Followup to r907355. Correct a misprint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907367 13f79535-47bb-0310-9956-ffa450edef68

15 years agoOops, changed the wrong one
billbarker [Sun, 7 Feb 2010 00:56:56 +0000 (00:56 +0000)]
Oops, changed the wrong one

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907355 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove hard coded dll paths that Gump doesn't like
billbarker [Sun, 7 Feb 2010 00:10:25 +0000 (00:10 +0000)]
Remove hard coded dll paths that Gump doesn't like

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907346 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCosmetic changes
markt [Sat, 6 Feb 2010 21:56:30 +0000 (21:56 +0000)]
Cosmetic changes
 - fix eclipse warnings
 - tabs to spaces

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907317 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48678
markt [Sat, 6 Feb 2010 21:34:12 +0000 (21:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48678
StandardService already defines server. Having two in the type hierarchy just causes confusion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907311 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48658
markt [Sat, 6 Feb 2010 20:19:27 +0000 (20:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48658
Save test output in files; allow single test to be run
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907291 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemainder of Pipeline clean up. The Pipeline interface is now used in place of Standa...
markt [Fri, 5 Feb 2010 17:53:29 +0000 (17:53 +0000)]
Remainder of Pipeline clean up. The Pipeline interface is now used in place of StandardPipeline throughout the code base.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907018 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove the Pipeline interface from ContainerBase
markt [Thu, 4 Feb 2010 23:22:24 +0000 (23:22 +0000)]
Remove the Pipeline interface from ContainerBase
Access valves via getPipeline() rather than directly on ContainerBase

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906727 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet global naming resources working if naming is enabled
markt [Thu, 4 Feb 2010 23:19:41 +0000 (23:19 +0000)]
Get global naming resources working if naming is enabled

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906725 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a test case for global naming resources with embedded
markt [Thu, 4 Feb 2010 23:18:12 +0000 (23:18 +0000)]
Add a test case for global naming resources with embedded

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906723 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMove firing the events to StandardPipeline. This way calls to container.addValve...
markt [Thu, 4 Feb 2010 22:09:18 +0000 (22:09 +0000)]
Move firing the events to StandardPipeline. This way calls to container.addValve() and container.getPipeline().addValve() will both trigger the event.
Custom pipelines (unlikely but possible) would not trigger the event. The javadocs for Pipeline will be updated to note that they should in a following commit.
Part of removing the Pipeline interface from ContainerBase

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906680 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPrep for removing Pipeline interface from ContainerBase
markt [Thu, 4 Feb 2010 21:53:06 +0000 (21:53 +0000)]
Prep for removing Pipeline interface from ContainerBase

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906675 13f79535-47bb-0310-9956-ffa450edef68

15 years agoInvert the logic for building dbcp/jdt
markt [Thu, 4 Feb 2010 21:26:41 +0000 (21:26 +0000)]
Invert the logic for building dbcp/jdt
a) makes more sense
b) should keep gump happy

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906654 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClarify that the exe is for 32 and 64 bit
markt [Thu, 4 Feb 2010 18:34:47 +0000 (18:34 +0000)]
Clarify that the exe is for 32 and 64 bit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906597 13f79535-47bb-0310-9956-ffa450edef68

15 years agoremove a println call
kkolinko [Thu, 4 Feb 2010 17:02:15 +0000 (17:02 +0000)]
remove a println call

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906566 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix for a bug with processing of double quotes in AttributeParser#parseEL()
kkolinko [Thu, 4 Feb 2010 12:18:28 +0000 (12:18 +0000)]
Fix for a bug with processing of double quotes in AttributeParser#parseEL()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906465 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest for a bug with processing of double quotes in AttributeParser#parseEL
kkolinko [Thu, 4 Feb 2010 12:16:51 +0000 (12:16 +0000)]
Test for a bug with processing of double quotes in AttributeParser#parseEL

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906464 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBe a bit more specific in our tests:
kkolinko [Thu, 4 Feb 2010 11:24:07 +0000 (11:24 +0000)]
Be a bit more specific in our tests:
check for <p></p> surrounding the printed text

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906453 13f79535-47bb-0310-9956-ffa450edef68

15 years agoServlet 3.0
markt [Wed, 3 Feb 2010 19:10:48 +0000 (19:10 +0000)]
Servlet 3.0
Effective major/minor version support

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906183 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRefactor
markt [Wed, 3 Feb 2010 17:55:20 +0000 (17:55 +0000)]
Refactor

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@906153 13f79535-47bb-0310-9956-ffa450edef68

15 years agoServlet 3.0 plumbing
markt [Wed, 3 Feb 2010 06:31:38 +0000 (06:31 +0000)]
Servlet 3.0 plumbing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@905911 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore servlet 3.0 plumbing
markt [Wed, 3 Feb 2010 06:27:46 +0000 (06:27 +0000)]
More servlet 3.0 plumbing
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@905910 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDon't build dbcp or jdt unless we have to. This allows adding download as a dep to...
markt [Tue, 2 Feb 2010 21:01:45 +0000 (21:01 +0000)]
Don't build dbcp or jdt unless we have to. This allows adding download as a dep to compile. You can now do:
svn co...
ant release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@905793 13f79535-47bb-0310-9956-ffa450edef68