Michael M Slusarz [Mon, 19 Oct 2009 18:50:52 +0000 (12:50 -0600)]
Update to new SpellChecker js code
Michael M Slusarz [Mon, 19 Oct 2009 16:09:57 +0000 (10:09 -0600)]
Bug #8652: Fix method call
Michael M Slusarz [Mon, 19 Oct 2009 15:57:01 +0000 (09:57 -0600)]
Bug #8651: Fix class name
Jan Schneider [Mon, 19 Oct 2009 08:22:06 +0000 (10:22 +0200)]
Use Horde_String.
Michael M Slusarz [Mon, 19 Oct 2009 03:33:55 +0000 (21:33 -0600)]
Add all script to the same onload block, if possible
Chuck Hagenbuch [Mon, 19 Oct 2009 01:23:23 +0000 (21:23 -0400)]
Tweak a few php 5 things and make sure driver names are ucfirst
Chuck Hagenbuch [Sat, 17 Oct 2009 02:10:05 +0000 (22:10 -0400)]
Ignore '.' in the include_path for the purposes of Horde_Autoloader.
Chuck Hagenbuch [Fri, 16 Oct 2009 22:22:46 +0000 (18:22 -0400)]
A few style/spelling tweaks
Michael M Slusarz [Fri, 16 Oct 2009 11:54:15 +0000 (05:54 -0600)]
Add missing array key
Michael M Slusarz [Fri, 16 Oct 2009 09:21:54 +0000 (03:21 -0600)]
Logout on read error
Michael M Slusarz [Fri, 16 Oct 2009 09:08:25 +0000 (03:08 -0600)]
Silence errors on bad stream
Chuck Hagenbuch [Thu, 15 Oct 2009 17:59:58 +0000 (13:59 -0400)]
Don't include files using a relative path; always run through the include_path
explicitly trying absolute paths.
This avoids PHP checking the local directory for a file even if '.' isn't in the
include_path. Also, we now use realpath() directly instead of
Horde_Util::realPath(). This both reduces dependencies, and it removes invalid
paths from the include_path. The generic realPath() has its use, but here we're
dealing with real files on the filesystem.
Michael M Slusarz [Thu, 15 Oct 2009 12:29:53 +0000 (06:29 -0600)]
XSS filter: support multiple CDATA blocks
Michael M Slusarz [Thu, 15 Oct 2009 11:37:58 +0000 (05:37 -0600)]
Horde_Auth_Application improvements.
Add getCredential().
Pass auth instance to application's transparent handler.
Jan Schneider [Thu, 15 Oct 2009 11:54:33 +0000 (13:54 +0200)]
Load all required classes.
Jan Schneider [Sun, 11 Oct 2009 16:37:26 +0000 (18:37 +0200)]
MFB: Fix tests.
Michael M Slusarz [Thu, 15 Oct 2009 10:12:38 +0000 (04:12 -0600)]
Pass info to preauth hook to indicate the current auth method
Chuck Hagenbuch [Thu, 15 Oct 2009 01:37:43 +0000 (21:37 -0400)]
Fix function name in doc comment
Chuck Hagenbuch [Thu, 15 Oct 2009 01:37:33 +0000 (21:37 -0400)]
Add missing toLabelTag() method
Michael M Slusarz [Wed, 14 Oct 2009 18:14:32 +0000 (12:14 -0600)]
Fix case where caching might not be available
Michael M Slusarz [Wed, 14 Oct 2009 10:44:57 +0000 (04:44 -0600)]
Improvements to Horde_Auth::.
* Replaced Horde_Auth::addHook() and Horde_Auth::removeHook() with
Horde_Auth::convertUsername().
* Add ability to retrieve app-specific credentials via
Horde_Auth::getCredential().
* Add Horde_Auth::getOriginalAuth().
Michael M Slusarz [Tue, 13 Oct 2009 16:44:36 +0000 (10:44 -0600)]
Csstidy fixes
Most important, allow multiple declarations of a property within a
single CSS declaration. Allows us to take advantage of CSS hacks
without splitting CSS files into 8 different versions based on browser
type.
While here, start cleaning these files up (i.e. disable
logging, since it is not used anywhere and is just wasting memory).
This can be cleaned up more - there are definitely things going on in
here that are eating up memory, for example.
Michael M Slusarz [Tue, 13 Oct 2009 15:46:58 +0000 (09:46 -0600)]
Correctly deal with CSS strings that begin with '-'.
Michael M Slusarz [Tue, 13 Oct 2009 12:00:17 +0000 (06:00 -0600)]
Optimize these assignments (saves 12K in code)
Chuck Hagenbuch [Tue, 13 Oct 2009 03:05:28 +0000 (23:05 -0400)]
One take on a simple module implementation. Not sure I'm sticking with this yet.
Chuck Hagenbuch [Tue, 13 Oct 2009 03:04:14 +0000 (23:04 -0400)]
Verify in a test that StringStream doesn't duplicate the string being streamed in memory.
Michael M Slusarz [Tue, 13 Oct 2009 00:45:50 +0000 (18:45 -0600)]
Bug #4299: Fix dimming signatures when mixed with quoted text
Michael M Slusarz [Tue, 13 Oct 2009 00:45:15 +0000 (18:45 -0600)]
Re-add missing quantifier limiter.
Michael M Slusarz [Mon, 12 Oct 2009 15:19:08 +0000 (09:19 -0600)]
This becomes much more useful when you assign it to something
Michael M Slusarz [Thu, 8 Oct 2009 22:23:15 +0000 (16:23 -0600)]
The write/close should be done in the destructor
Michael M Slusarz [Thu, 8 Oct 2009 21:41:24 +0000 (15:41 -0600)]
Destructor fixes.
Destructors have no access to the session - need to do these tasks in a
function registered via register_shutdown_function().
Michael M Slusarz [Thu, 8 Oct 2009 21:44:29 +0000 (15:44 -0600)]
Fix potential session writing issue
This allegedly was needed as of 5.0.5, but I first started to see the
undesirable behavior as of 5.2.10/5.3.
Michael M Slusarz [Thu, 8 Oct 2009 19:53:52 +0000 (13:53 -0600)]
Fix ignoring CDATA when doing regexp searching
Strip out the CDATA, store it, and replace it when finished with the
various preg_match() calls.
Michael M Slusarz [Thu, 8 Oct 2009 16:41:52 +0000 (10:41 -0600)]
Bug #8555: Linewrap q-p data
Michael M Slusarz [Wed, 7 Oct 2009 18:30:02 +0000 (12:30 -0600)]
Regex tweak
Michael M Slusarz [Wed, 7 Oct 2009 17:51:57 +0000 (11:51 -0600)]
For base (ID = 0) parts, any subpart is a body part
Michael J. Rubinsky [Wed, 7 Oct 2009 13:30:44 +0000 (09:30 -0400)]
Need to group this expression to avoid undefined index warnings.
Michael M Slusarz [Wed, 7 Oct 2009 04:17:40 +0000 (22:17 -0600)]
Better error handling for S/MIME certs
Michael M Slusarz [Wed, 7 Oct 2009 03:21:09 +0000 (21:21 -0600)]
Don't double encode ampersands
Michael M Slusarz [Tue, 6 Oct 2009 22:13:10 +0000 (16:13 -0600)]
Bug #8626: Fix updating memcache tracking info on session destroy
Michael M Slusarz [Tue, 6 Oct 2009 18:53:40 +0000 (12:53 -0600)]
Revise Horde::addScriptFile() API
Move addExternalScriptFile() into this function - no reason to have a
separate function for this.
Direct loading should be the default. Loading through javascript.php is
deprecated and any remaining scripts that contain PHP code should be
rewritten ASAP.
Fix javascript loading for fckeditor - use addScriptFile() instead of
the deprecated javascript notification handler.
Jan Schneider [Mon, 5 Oct 2009 17:17:42 +0000 (19:17 +0200)]
Fix browsing and GET.
Jan Schneider [Mon, 5 Oct 2009 16:37:35 +0000 (18:37 +0200)]
Make this actually work again; fix Horde_Xml_Element usage and more.
Jan Schneider [Mon, 5 Oct 2009 16:35:16 +0000 (18:35 +0200)]
We have to use the full tag name (including namespace) when calling
createElementNS() or setAttributeNS().
Jan Schneider [Mon, 5 Oct 2009 16:34:03 +0000 (18:34 +0200)]
Add test for unsetting namespaced attributes.
Jan Schneider [Mon, 5 Oct 2009 16:20:14 +0000 (18:20 +0200)]
Fix variable name.
Jan Schneider [Mon, 5 Oct 2009 16:19:31 +0000 (18:19 +0200)]
Change method names to reflect what the actually test.
Add tests for element setter/getter.
Fix order of assertEquals() arguments.
Chuck Hagenbuch [Sun, 4 Oct 2009 03:10:49 +0000 (23:10 -0400)]
Remove references, consolidate includes
Chuck Hagenbuch [Sun, 4 Oct 2009 02:57:40 +0000 (22:57 -0400)]
Stub out gettext functions if they don't exist to avoid fatal errors in tests.
Chuck Hagenbuch [Sun, 4 Oct 2009 02:56:57 +0000 (22:56 -0400)]
Remove a bunch of references, a little PHP 5 style, mark tests skipped that
currently throw errors.
Chuck Hagenbuch [Sun, 4 Oct 2009 01:32:09 +0000 (21:32 -0400)]
skip tests that don't work because $world['auth'] doesn't exist yet
Gunnar Wrobel [Fri, 2 Oct 2009 19:17:05 +0000 (21:17 +0200)]
Declare static public.
Gunnar Wrobel [Fri, 2 Oct 2009 19:16:08 +0000 (21:16 +0200)]
Hotfix structure class construction. A real fix will come later.
Gunnar Wrobel [Fri, 2 Oct 2009 18:59:29 +0000 (20:59 +0200)]
Fix the Kolab_Server factory. Accepting arbitrary class names in the factory is not required.
Gunnar Wrobel [Fri, 2 Oct 2009 18:47:32 +0000 (20:47 +0200)]
Fix more errors when running tests in strict mode.
Gunnar Wrobel [Fri, 2 Oct 2009 13:41:12 +0000 (15:41 +0200)]
Add a text that gives some background on dependency injection and provides a few examples.
Gunnar Wrobel [Fri, 2 Oct 2009 13:40:33 +0000 (15:40 +0200)]
Some example of how to use Horde_Injector.
Gunnar Wrobel [Fri, 2 Oct 2009 13:40:09 +0000 (15:40 +0200)]
Phpdoc.
Gunnar Wrobel [Fri, 2 Oct 2009 09:38:47 +0000 (11:38 +0200)]
Fix more referencing problems for the strict tests.
Chuck Hagenbuch [Fri, 2 Oct 2009 03:00:54 +0000 (23:00 -0400)]
test_framework now takes all PHPUnit command line arguments
Chuck Hagenbuch [Fri, 2 Oct 2009 02:41:17 +0000 (22:41 -0400)]
initialize $changes array
Chuck Hagenbuch [Fri, 2 Oct 2009 02:40:03 +0000 (22:40 -0400)]
There is no $new_info variable in this function - $info looks like the only alternative.
Chuck Hagenbuch [Fri, 2 Oct 2009 02:39:55 +0000 (22:39 -0400)]
whitespace
Chuck Hagenbuch [Fri, 2 Oct 2009 02:12:15 +0000 (22:12 -0400)]
remove more references
Chuck Hagenbuch [Fri, 2 Oct 2009 02:11:37 +0000 (22:11 -0400)]
Avoid "only variables should be passed by reference" warnings
Chuck Hagenbuch [Fri, 2 Oct 2009 00:59:09 +0000 (20:59 -0400)]
Remove unnecessary references
Chuck Hagenbuch [Fri, 2 Oct 2009 00:45:36 +0000 (20:45 -0400)]
whitespace
Chuck Hagenbuch [Fri, 2 Oct 2009 00:45:17 +0000 (20:45 -0400)]
split() is deprecated; use explode()
Chuck Hagenbuch [Fri, 2 Oct 2009 00:42:43 +0000 (20:42 -0400)]
Don't throw notices if the log event doesn't have a field that the filter has a
constraint for.
Chuck Hagenbuch [Fri, 2 Oct 2009 00:42:11 +0000 (20:42 -0400)]
Avoid calling set_magic_quotes_runtime if magic_quotes_runtime wasn't on.
Chuck Hagenbuch [Thu, 1 Oct 2009 22:36:12 +0000 (18:36 -0400)]
remove references that cause "only variables should assgned by reference" errors
Chuck Hagenbuch [Thu, 1 Oct 2009 20:38:55 +0000 (16:38 -0400)]
fix variable name typo
Michael J. Rubinsky [Fri, 2 Oct 2009 00:56:58 +0000 (20:56 -0400)]
Actually, use the 'headers' option to add the headers, to make it
clearer why they can't be set before setOptions()
Michael J. Rubinsky [Fri, 2 Oct 2009 00:48:37 +0000 (20:48 -0400)]
Add headers after other values are set, otherwise they get overwritten.
Michael J. Rubinsky [Tue, 29 Sep 2009 19:40:42 +0000 (15:40 -0400)]
Remove @since
Michael M Slusarz [Thu, 1 Oct 2009 19:27:19 +0000 (13:27 -0600)]
Preserve entities in HTML output
Chuck Hagenbuch [Thu, 1 Oct 2009 18:42:58 +0000 (14:42 -0400)]
- make constructors consistent across Request types
- consistently try to set proxy settings across Request types
- condense code in Curl and Peclhttp requests for translating between our constants and theirs
Chuck Hagenbuch [Thu, 1 Oct 2009 17:42:53 +0000 (13:42 -0400)]
Add HTTP auth support. All adapters support BASIC; Curl and Peclhttp support a bunch more.
Jan Schneider [Thu, 1 Oct 2009 13:37:37 +0000 (15:37 +0200)]
Add getIPAddress() (Bug #8620).
Jan Schneider [Mon, 28 Sep 2009 13:20:07 +0000 (15:20 +0200)]
Fix ngettext() calls, use date format parameter, use time format parameter.
Chuck Hagenbuch [Wed, 30 Sep 2009 04:15:39 +0000 (00:15 -0400)]
refactor Horde_Feed tests for recent changes
Chuck Hagenbuch [Wed, 30 Sep 2009 04:14:38 +0000 (00:14 -0400)]
Refactor Horde_Feed to remove the static HTTP client, and to inject it
instead. Also use the method override support in the HTTP client instead of
hardcoding it at the feed level.
Chuck Hagenbuch [Wed, 30 Sep 2009 04:12:48 +0000 (00:12 -0400)]
Add support for http method overriding to the HTTP client. possibly should go in
a subclass or decorator instead.
/**
+ * Use POST instead of PUT and DELETE, sending X-HTTP-Method-Override with
+ * the intended method name instead.
+ *
+ * @var boolean
+ */
+ protected $_httpMethodOverride = false;
+
+ /**
* Horde_Http_Client constructor.
*
* @param array $args Any Http_Client settings to initialize in the
* constructor. Available settings are:
+ * client.httpMethodOverride
* client.proxyServer
* client.proxyUser
* client.proxyPass
@@ -62,7 +71,12 @@ class Horde_Http_Client
foreach ($args as $key => $val) {
list($object, $objectkey) = explode('.', $key, 2);
- $this->$object->$objectkey = $val;
+ if ($object == 'request') {
+ $this->$object->$objectkey = $val;
+ } elseif ($object == 'client') {
+ $objectKey = '_' . $objectKey;
+ $this->$objectKey = $val;
+ }
}
}
@@ -93,7 +107,11 @@ class Horde_Http_Client
*/
public function put($uri = null, $data = null, $headers = array())
{
- /* @TODO suport method override (X-Method-Override: PUT). */
+ if ($this->_httpMethodOverride) {
+ $headers = array_merge(array('X-HTTP-Method-Override' => 'PUT'), $headers);
+ return $this->post($uri, $data, $headers);
+ }
+
return $this->request('PUT', $uri, $data, $headers);
}
@@ -104,7 +122,11 @@ class Horde_Http_Client
*/
public function delete($uri = null, $headers = array())
{
- /* @TODO suport method override (X-Method-Override: DELETE). */
+ if ($this->_httpMethodOverride) {
+ $headers = array_merge(array('X-HTTP-Method-Override' => 'DELETE'), $headers);
+ return $this->post($uri, null, $headers);
+ }
+
return $this->request('DELETE', $uri, null, $headers);
}
Gunnar Wrobel [Tue, 29 Sep 2009 21:21:46 +0000 (23:21 +0200)]
Merge branch 'framework_history_mock'
Michael M Slusarz [Tue, 29 Sep 2009 19:29:39 +0000 (13:29 -0600)]
Imap Client test fixes
Only do MODSEQ search if CONDSTORE is available.
Make the interval search give a bit more relevant results (small
timestamp could result in same day search, which is not useful for
eyeballing during testing)
Michael M Slusarz [Tue, 29 Sep 2009 19:02:34 +0000 (13:02 -0600)]
In an OR clause, 2nd element must not contain the OR search key
Michael M Slusarz [Tue, 29 Sep 2009 06:27:22 +0000 (00:27 -0600)]
Add a Horde identifier to the generated Message-ID
Gunnar Wrobel [Tue, 29 Sep 2009 17:46:03 +0000 (19:46 +0200)]
Fix signatures for strict mode testing.
Chuck Hagenbuch [Tue, 29 Sep 2009 17:31:05 +0000 (13:31 -0400)]
These test suites need to not throw warnings when autoloading, so use the same
logic we do in Horde_Autoloader. Also include PHPUnit/Framework.php.
Chuck Hagenbuch [Tue, 29 Sep 2009 17:30:24 +0000 (13:30 -0400)]
We never want to autoload the CacheMock class
Chuck Hagenbuch [Tue, 29 Sep 2009 17:24:29 +0000 (13:24 -0400)]
- include PHPUnit/Framework.php
- don't use include_once or silence calls in on-the-fly autoloader
Chuck Hagenbuch [Tue, 29 Sep 2009 17:23:30 +0000 (13:23 -0400)]
This asserting was testing PHPUnit internals unintentionally. Remove it.
Gunnar Wrobel [Tue, 29 Sep 2009 15:53:01 +0000 (17:53 +0200)]
Deactivate the sqlite based testing now and only run the test suite over the mock driver.
Gunnar Wrobel [Tue, 29 Sep 2009 15:43:59 +0000 (17:43 +0200)]
Complete testing.
Gunnar Wrobel [Tue, 29 Sep 2009 15:23:36 +0000 (17:23 +0200)]
The mock driver.
Chuck Hagenbuch [Tue, 29 Sep 2009 14:00:27 +0000 (10:00 -0400)]
Add initial Date helper ported from Mad. Needs translation.
Chuck Hagenbuch [Tue, 29 Sep 2009 13:58:53 +0000 (09:58 -0400)]
Include PHPUnit/Framework.php
Chuck Hagenbuch [Tue, 29 Sep 2009 13:50:37 +0000 (09:50 -0400)]
Add a smart quotes helper to Horde_View_Helper_Text. Probably belongs in Horde_Text_Filter?
Chuck Hagenbuch [Tue, 29 Sep 2009 13:32:35 +0000 (09:32 -0400)]
Require PHPUnit/Framework.php and put autoloading back in its original place
Chuck Hagenbuch [Tue, 29 Sep 2009 13:24:13 +0000 (09:24 -0400)]
Fix MySQL tests to match new primary key definition