tomcat7.0
14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51557
markt [Wed, 27 Jul 2011 09:10:11 +0000 (09:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51557
Ignore HTTP headers that do not comply with RFC 2616 and use header names that are not tokens.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151394 13f79535-47bb-0310-9956-ffa450edef68

14 years agoThis is now available
markt [Wed, 27 Jul 2011 08:55:02 +0000 (08:55 +0000)]
This is now available

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151389 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix SSL unit test failures with APR/native
markt [Tue, 26 Jul 2011 20:56:27 +0000 (20:56 +0000)]
Fix SSL unit test failures with APR/native

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151240 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTests are run with all three HTTP connectors. No need for separate tests.
markt [Tue, 26 Jul 2011 12:28:00 +0000 (12:28 +0000)]
Tests are run with all three HTTP connectors. No need for separate tests.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151074 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate to checkstyle 5.4
kkolinko [Tue, 26 Jul 2011 09:49:26 +0000 (09:49 +0000)]
Update to checkstyle 5.4

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151046 13f79535-47bb-0310-9956-ffa450edef68

14 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=51545
timw [Tue, 26 Jul 2011 09:41:36 +0000 (09:41 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=51545

Adding ability to log current request thread name in ExtendedAccessLogValve using Tomcat specific x-threadname pattern format token.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151043 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51555
markt [Tue, 26 Jul 2011 08:25:46 +0000 (08:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51555
Permit an additional lifecycle transition. Allow destroy() to be called on components that are initialized. This can occur in some start failure scenarios.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1151016 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverting tribes tests to JUnit 4 - done.
kkolinko [Tue, 26 Jul 2011 02:58:29 +0000 (02:58 +0000)]
Converting tribes tests to JUnit 4 - done.
Update changelog.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150975 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted tribes tests to JUnit 4.
kkolinko [Tue, 26 Jul 2011 02:39:35 +0000 (02:39 +0000)]
Converted tribes tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150974 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConversion of TomcatBaseTest classes to JUnit 4 completed.
kkolinko [Mon, 25 Jul 2011 22:20:19 +0000 (22:20 +0000)]
Conversion of TomcatBaseTest classes to JUnit 4 completed.
Rename TomcatBaseTestJUnit4 -> TomcatBaseTest.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150939 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 22:09:37 +0000 (22:09 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150933 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 21:04:30 +0000 (21:04 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150907 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 20:46:11 +0000 (20:46 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150899 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 20:30:58 +0000 (20:30 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150890 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 20:11:41 +0000 (20:11 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150877 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 19:54:21 +0000 (19:54 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150866 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51550
markt [Mon, 25 Jul 2011 19:45:04 +0000 (19:45 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51550
Stop the adaptor swallowing internal errors.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150864 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 19:25:22 +0000 (19:25 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150855 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 18:56:58 +0000 (18:56 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150846 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51544
markt [Mon, 25 Jul 2011 16:23:39 +0000 (16:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51544
Correctly resolve bean methods in EL so accessible methods that are overridden by inaccessible methods do not cause an IllegalAccessException.
Modify test case to catch this problem on Oracle and OpenJDK JREs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150767 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 16:10:50 +0000 (16:10 +0000)]
Converted the tests to JUnit 4.

TomcatBaseTestJUnit4 is a copy of TomcatBaseTest converted to JUnit 4,
to be used until conversion is completed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150764 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 15:57:51 +0000 (15:57 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150761 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 15:22:30 +0000 (15:22 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150747 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted the tests to JUnit 4.
kkolinko [Mon, 25 Jul 2011 14:45:37 +0000 (14:45 +0000)]
Converted the tests to JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150727 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate checkstyle rules to treat imports of "org.junit" as a separate group vs. ...
kkolinko [Mon, 25 Jul 2011 13:18:20 +0000 (13:18 +0000)]
Update checkstyle rules to treat imports of "org.junit" as a separate group vs. "org".

Convert simple tests in the following packages to JUnit 4:
org.apache.catalina.filters.*
org.apache.catalina.ha.session.*

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150690 13f79535-47bb-0310-9956-ffa450edef68

14 years agoConverted tests in org.apache.catalina.deploy to JUnit 4.
kkolinko [Mon, 25 Jul 2011 12:04:32 +0000 (12:04 +0000)]
Converted tests in org.apache.catalina.deploy to JUnit 4.

1) textXXX() -> @Test added
2) protected setUp() -> @Before public setUp()
3) in TestSecurityConstraint: There is no assertEquals(boolean, boolean) method in JUnit 4,
so those calls were replaced with assertTrue() and assertFalse().

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150652 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate checkstyle configuration to allow static imports of org.junit.Assert members.
kkolinko [Mon, 25 Jul 2011 11:54:05 +0000 (11:54 +0000)]
Update checkstyle configuration to allow static imports of org.junit.Assert members.
This is for JUnit 4.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150644 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate project to use JUnit 4 libraries.
kkolinko [Mon, 25 Jul 2011 10:40:03 +0000 (10:40 +0000)]
Update project to use JUnit 4 libraries.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150623 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAnother test case for bug 51544
markt [Sun, 24 Jul 2011 11:12:58 +0000 (11:12 +0000)]
Another test case for bug 51544

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150339 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd tests for bug 51544 (note tests pass - can't reproduce error yet)
markt [Sun, 24 Jul 2011 10:59:10 +0000 (10:59 +0000)]
Add tests for bug 51544 (note tests pass - can't reproduce error yet)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150336 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd tests for bug 51544 (note tests pass - can't reproduce error yet)
markt [Sun, 24 Jul 2011 10:58:36 +0000 (10:58 +0000)]
Add tests for bug 51544 (note tests pass - can't reproduce error yet)
Fix some find bugs issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150335 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMake rules on settng path clearer
markt [Sat, 23 Jul 2011 08:56:10 +0000 (08:56 +0000)]
Make rules on settng path clearer

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1150070 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=41709
markt [Fri, 22 Jul 2011 18:09:54 +0000 (18:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41709
Provide exception messages for ISEs when response is already committed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149678 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=41498
markt [Fri, 22 Jul 2011 12:09:13 +0000 (12:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41498
Add info for allRolesMode

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149582 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAJP NIO is still experimental but is fully functional.
markt [Thu, 21 Jul 2011 18:19:29 +0000 (18:19 +0000)]
AJP NIO is still experimental but is fully functional.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149294 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove i18n support.
markt [Thu, 21 Jul 2011 13:29:01 +0000 (13:29 +0000)]
Improve i18n support.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149172 13f79535-47bb-0310-9956-ffa450edef68

14 years agoPromote the Set Character Encoding filter to the filters package so it is more widely...
markt [Thu, 21 Jul 2011 13:20:40 +0000 (13:20 +0000)]
Promote the Set Character Encoding filter to the filters package so it is more widely available.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149166 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove wording in a message and in one entry in changelog.
kkolinko [Thu, 21 Jul 2011 11:08:23 +0000 (11:08 +0000)]
Improve wording in a message and in one entry in changelog.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149118 13f79535-47bb-0310-9956-ffa450edef68

14 years agoTrivial improvements to access log valve docs. Fix typos noted by André Warnier.
kkolinko [Thu, 21 Jul 2011 10:52:46 +0000 (10:52 +0000)]
Trivial improvements to access log valve docs. Fix typos noted by AndrĂ© Warnier.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149104 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix for 51056. remove SSLv2 from all.
jfclere [Thu, 21 Jul 2011 09:40:03 +0000 (09:40 +0000)]
Fix for 51056. remove SSLv2 from all.
Needs native 1.1.21.
Now to allow SSLv2 you have to use:
SSLProtocol="SSLv2+SSLv3" for example.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1149092 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51532
markt [Wed, 20 Jul 2011 19:41:18 +0000 (19:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51532
JSP files with dependencies in JARs were recompiled on every access leading to poor performance.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148915 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused code
markt [Wed, 20 Jul 2011 15:35:11 +0000 (15:35 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148818 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove fix for PR50394 Requires native 1.1.21
jfclere [Wed, 20 Jul 2011 15:28:05 +0000 (15:28 +0000)]
Improve fix for PR50394 Requires native 1.1.21

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148815 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51516
markt [Tue, 19 Jul 2011 19:19:45 +0000 (19:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51516
Correct property to change SSO session cookie name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148491 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51531
markt [Tue, 19 Jul 2011 18:49:03 +0000 (18:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51531
Update for ecj 3.7

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148483 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51509
markt [Tue, 19 Jul 2011 18:20:23 +0000 (18:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51509
Fix potential concurrency issue in CSRF prevention filter that may lead to some requests failing that should not.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148471 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd info on which connectors these fixes apply to.
markt [Tue, 19 Jul 2011 13:51:42 +0000 (13:51 +0000)]
Add info on which connectors these fixes apply to.
Correct order.
Add periods to the end of the sentences.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148321 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd changelog for 1148254 and 1148216
jfclere [Tue, 19 Jul 2011 12:11:18 +0000 (12:11 +0000)]
Add changelog for 1148254 and 1148216

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148288 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51518
markt [Tue, 19 Jul 2011 11:41:08 +0000 (11:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51518
Correct error in web.xml parsing rules for the <others/> tag when using absolute ordering.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148277 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix for PR50394
jfclere [Tue, 19 Jul 2011 09:36:08 +0000 (09:36 +0000)]
Fix for PR50394

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148254 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd release date for 7.0.19
markt [Tue, 19 Jul 2011 09:22:22 +0000 (09:22 +0000)]
Add release date for 7.0.19

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148249 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd test cases for syntax checking of jarsToSkip.
rjung [Tue, 19 Jul 2011 09:14:09 +0000 (09:14 +0000)]
Add test cases for syntax checking of jarsToSkip.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148245 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd section title
markt [Tue, 19 Jul 2011 09:03:41 +0000 (09:03 +0000)]
Add section title

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148242 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix for PR49595
jfclere [Tue, 19 Jul 2011 08:06:46 +0000 (08:06 +0000)]
Fix for PR49595

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1148216 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51503
markt [Mon, 18 Jul 2011 16:18:54 +0000 (16:18 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51503
Add additional validation to Windows installer and Tomcat start for connector port numbers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147949 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCleaner code
markt [Mon, 18 Jul 2011 15:15:26 +0000 (15:15 +0000)]
Cleaner code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147925 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate to changelog
markt [Mon, 18 Jul 2011 15:12:48 +0000 (15:12 +0000)]
Update to changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147923 13f79535-47bb-0310-9956-ffa450edef68

14 years agoOnly test for timeouts if timeout is greater than zero (aligns with BIO and APR)
markt [Mon, 18 Jul 2011 15:10:29 +0000 (15:10 +0000)]
Only test for timeouts if timeout is greater than zero (aligns with BIO and APR)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147921 13f79535-47bb-0310-9956-ffa450edef68

14 years agoModify the test to ensure that the default connection timeout (-1) is used and so...
markt [Mon, 18 Jul 2011 15:09:43 +0000 (15:09 +0000)]
Modify the test to ensure that the default connection timeout (-1) is used and so that pipe-lining doesn't trigger false positive results

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147920 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMinor improvement to javadoc
markt [Mon, 18 Jul 2011 15:01:41 +0000 (15:01 +0000)]
Minor improvement to javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147915 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd some units info to the Javadocs
markt [Fri, 15 Jul 2011 17:51:10 +0000 (17:51 +0000)]
Add some units info to the Javadocs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1147263 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMissing svn:eol-style.
rjung [Fri, 15 Jul 2011 07:48:27 +0000 (07:48 +0000)]
Missing svn:eol-style.

Please fix your svn config. Thanks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146994 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property
kkolinko [Thu, 14 Jul 2011 09:58:31 +0000 (09:58 +0000)]
Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip property

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146623 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate ready for next release
markt [Wed, 13 Jul 2011 22:31:04 +0000 (22:31 +0000)]
Update ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146505 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCATALINA_BASE is always set, so simplify
markt [Wed, 13 Jul 2011 15:20:43 +0000 (15:20 +0000)]
CATALINA_BASE is always set, so simplify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146096 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCATALINA_BASE is always set, so simplify
markt [Wed, 13 Jul 2011 14:47:32 +0000 (14:47 +0000)]
CATALINA_BASE is always set, so simplify

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146069 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAdd CVE reference for sendfile issues
markt [Wed, 13 Jul 2011 13:36:44 +0000 (13:36 +0000)]
Add CVE reference for sendfile issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146010 13f79535-47bb-0310-9956-ffa450edef68

14 years agoWhen running under a security manager and using sendfile, validate sendfile attribute...
markt [Wed, 13 Jul 2011 13:28:24 +0000 (13:28 +0000)]
When running under a security manager and using sendfile, validate sendfile attributes to prevent sendfile being used to bypass the security manager.
Part of the fix for CVE-2011-2526

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1146005 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNo need to include class in message, results in "classclass"
markt [Wed, 13 Jul 2011 12:45:57 +0000 (12:45 +0000)]
No need to include class in message, results in "classclass"

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145981 13f79535-47bb-0310-9956-ffa450edef68

14 years agoProtect against crashes in the HTTP APR connector if sendfile is configured to send...
markt [Tue, 12 Jul 2011 17:50:11 +0000 (17:50 +0000)]
Protect against crashes in the HTTP APR connector if sendfile is configured to send more data than is available in the file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145694 13f79535-47bb-0310-9956-ffa450edef68

14 years agogit-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145627 13f79535-47bb-0310...
markt [Tue, 12 Jul 2011 15:14:27 +0000 (15:14 +0000)]
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145627 13f79535-47bb-0310-9956-ffa450edef68

14 years agoSocket has been closed, return false so an attempt is not made to re-use the socket
markt [Tue, 12 Jul 2011 12:51:35 +0000 (12:51 +0000)]
Socket has been closed, return false so an attempt is not made to re-use the socket

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145571 13f79535-47bb-0310-9956-ffa450edef68

14 years agoCorrect a comment
markt [Tue, 12 Jul 2011 08:34:20 +0000 (08:34 +0000)]
Correct a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145489 13f79535-47bb-0310-9956-ffa450edef68

14 years agoMaybe someone wants to realize that change.
rjung [Mon, 11 Jul 2011 22:33:54 +0000 (22:33 +0000)]
Maybe someone wants to realize that change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145388 13f79535-47bb-0310-9956-ffa450edef68

14 years agoNever compare docs and code:
rjung [Mon, 11 Jul 2011 22:30:45 +0000 (22:30 +0000)]
Never compare docs and code:

- enableLookups for connector was
  "false" by default at least the last 5 years.

- resolveHosts for normal and extended
  access log valve wasn't functional in
  the last 4 years (see e.g. r494191) and
  IMHO since noone complaint switching
  enableLookups to "true" instead is an
  appropriate alternative. So document
  that "resolveHosts" is no longer supported.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145387 13f79535-47bb-0310-9956-ffa450edef68

14 years agoProtect against infinite loops in the HTTP NIO connector if sendfile is configured...
markt [Mon, 11 Jul 2011 22:27:06 +0000 (22:27 +0000)]
Protect against infinite loops in the HTTP NIO connector if sendfile is configured to send more data than is available in the file. (markt)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145383 13f79535-47bb-0310-9956-ffa450edef68

14 years agoA little bit of docs is better than nothing ...
rjung [Mon, 11 Jul 2011 22:08:30 +0000 (22:08 +0000)]
A little bit of docs is better than nothing ...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145381 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused attribute
markt [Mon, 11 Jul 2011 22:08:06 +0000 (22:08 +0000)]
Remove unused attribute

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145380 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRemove unused import
markt [Mon, 11 Jul 2011 21:10:08 +0000 (21:10 +0000)]
Remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145355 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUse en_US as locale for creationdate in WebdavServlet.
rjung [Mon, 11 Jul 2011 19:06:15 +0000 (19:06 +0000)]
Use en_US as locale for creationdate in WebdavServlet.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145296 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFollowup to r1145209
kkolinko [Mon, 11 Jul 2011 18:40:48 +0000 (18:40 +0000)]
Followup to r1145209
Do not expose TCN_FULL_VERSION as a public constant, but calculate it when needed.
Using this way it will be easier to throw away the code in AprEndpoint when it becomes unneeded.
I do not mind reintroducing the constant if it were used in two or more places.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145285 13f79535-47bb-0310-9956-ffa450edef68

14 years agoExpose recently added "encoding" and "locale" options of AccessLogValve through JMX.
kkolinko [Mon, 11 Jul 2011 18:10:11 +0000 (18:10 +0000)]
Expose recently added "encoding" and "locale" options of AccessLogValve through JMX.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145268 13f79535-47bb-0310-9956-ffa450edef68

14 years ago- Remove unused code:
rjung [Mon, 11 Jul 2011 17:13:06 +0000 (17:13 +0000)]
- Remove unused code:
  Cookie dates are formatted elsewhere.
  This class used a very strange format:
  " EEEE, dd-MMM-yy kk:mm:ss zz"
- Add log.isDebugEnabled()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145246 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAlways use en_US as locale for timestamps in
rjung [Mon, 11 Jul 2011 16:51:54 +0000 (16:51 +0000)]
Always use en_US as locale for timestamps in
ExtendedAccessLogValve.

The format is specified in

http://www.w3.org/TR/WD-logfile.html

and states that the supported timestamps
"yyyy-MM-dd" and "HH:mm:ss" are defined with
ascii digits and GMT.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145238 13f79535-47bb-0310-9956-ffa450edef68

14 years ago* JULI FileHandler, AccessLogValve:
kkolinko [Mon, 11 Jul 2011 16:46:28 +0000 (16:46 +0000)]
* JULI FileHandler, AccessLogValve:
Create a directory automatically when it is specified as a part of the file name, e.g. in the prefix attribute. Earlier this happened only if it was specified with the directory attribute.
* AccessLogValve:
Log a failure if access log file cannot be opened.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145237 13f79535-47bb-0310-9956-ffa450edef68

14 years agoRevert unintended commit
markt [Mon, 11 Jul 2011 16:10:15 +0000 (16:10 +0000)]
Revert unintended commit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145225 13f79535-47bb-0310-9956-ffa450edef68

14 years agoImprove logging of error conditions
markt [Mon, 11 Jul 2011 16:08:23 +0000 (16:08 +0000)]
Improve logging of error conditions

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145224 13f79535-47bb-0310-9956-ffa450edef68

14 years agoBZ 51477: Support all SSL protocol combinations in the
rjung [Mon, 11 Jul 2011 15:44:10 +0000 (15:44 +0000)]
BZ 51477: Support all SSL protocol combinations in the
APR/native connector.

This only works when using the native library
version 1.1.21 or later which is not yet released.

Older tcnative versions will use an unchanged
config parser. Otherwise non-supported protocol
combinations would be unnoticed.

For easier review of the changes in AprEndpoint
use "svn -x -w" to ignore white space.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145209 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46252
kkolinko [Mon, 11 Jul 2011 15:13:13 +0000 (15:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46252
Allow to specify character set to be used to write the access log in AccessLogValve.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145200 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix javadoc.
rjung [Mon, 11 Jul 2011 14:18:32 +0000 (14:18 +0000)]
Fix javadoc.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145186 13f79535-47bb-0310-9956-ffa450edef68

14 years agoAllow choosing a locale for timestamp formatting
rjung [Mon, 11 Jul 2011 13:17:09 +0000 (13:17 +0000)]
Allow choosing a locale for timestamp formatting
in AccessLogValve. Only relevant to timestamps
explicitely given by SimpleDateFormat syntax.

Also: use Locale.US for CLF and for timestamps
that are part of the access log file name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145166 13f79535-47bb-0310-9956-ffa450edef68

14 years agoIgnore doc copied in during build process
markt [Mon, 11 Jul 2011 13:16:29 +0000 (13:16 +0000)]
Ignore doc copied in during build process

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145165 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=51494
markt [Mon, 11 Jul 2011 13:05:30 +0000 (13:05 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51494
Prevent an NPE when a long running request completes if the associated web application was destroyed while the request was processing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145160 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReplace <tt> by <code> in docs.
rjung [Mon, 11 Jul 2011 12:16:36 +0000 (12:16 +0000)]
Replace <tt> by <code> in docs.
The physical markup <tt> was only
used in few places. Mostly we use
the logical markup <code>.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145137 13f79535-47bb-0310-9956-ffa450edef68

14 years agoUpdate changelog for bz51490 fixes
markt [Mon, 11 Jul 2011 09:37:58 +0000 (09:37 +0000)]
Update changelog for bz51490 fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145093 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix broken HTML
markt [Mon, 11 Jul 2011 09:32:32 +0000 (09:32 +0000)]
Fix broken HTML

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145088 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix broken HTML
markt [Mon, 11 Jul 2011 09:31:09 +0000 (09:31 +0000)]
Fix broken HTML

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145086 13f79535-47bb-0310-9956-ffa450edef68

14 years agoReduce variable scope to reduce testing issues
markt [Mon, 11 Jul 2011 09:29:28 +0000 (09:29 +0000)]
Reduce variable scope to reduce testing issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145084 13f79535-47bb-0310-9956-ffa450edef68

14 years agoEnsure it is clear when tag isn't working
markt [Mon, 11 Jul 2011 09:28:25 +0000 (09:28 +0000)]
Ensure it is clear when tag isn't working

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145083 13f79535-47bb-0310-9956-ffa450edef68

14 years agoFix broken HTML
markt [Mon, 11 Jul 2011 09:19:59 +0000 (09:19 +0000)]
Fix broken HTML

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1145081 13f79535-47bb-0310-9956-ffa450edef68