tomcat7.0
16 years agoDon't allow null or zero length cookie names.
markt [Sun, 1 Nov 2009 23:04:33 +0000 (23:04 +0000)]
Don't allow null or zero length cookie names.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831779 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47451
markt [Sun, 1 Nov 2009 22:53:29 +0000 (22:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47451
Don't trigger an NPE if headers with null or zero length name or set or if a null value is specified. Silently ignore any such calls in the same way the calls are ignored if the response has already been committed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831774 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTrying to merge filter maps is a bad idea.
markt [Sun, 1 Nov 2009 21:46:09 +0000 (21:46 +0000)]
Trying to merge filter maps is a bad idea.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831764 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix bug in display name merge
markt [Sun, 1 Nov 2009 19:58:24 +0000 (19:58 +0000)]
Fix bug in display name merge

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831751 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
markt [Sun, 1 Nov 2009 18:35:02 +0000 (18:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
Document that HttpServletRequest.getAttributeNames() does not return the names of all attributes (internal Tomcat attributes are excluded)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831722 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix ReplicationValve crossContext support
pero [Sun, 1 Nov 2009 18:29:14 +0000 (18:29 +0000)]
Fix ReplicationValve crossContext support

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831718 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd another feature to the Tomcat based unit tests.
markt [Sun, 1 Nov 2009 18:16:57 +0000 (18:16 +0000)]
Add another feature to the Tomcat based unit tests.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831716 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a new new cookie option to allow the use of equals signs in cookies. Includes...
markt [Sat, 31 Oct 2009 14:09:02 +0000 (14:09 +0000)]
Add a new new cookie option to allow the use of equals signs in cookies. Includes test cases and docs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831544 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd an explicit configuration option for cookie version switching and update test...
markt [Sat, 31 Oct 2009 12:59:51 +0000 (12:59 +0000)]
Add an explicit configuration option for cookie version switching and update test cases and docs to include it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831536 13f79535-47bb-0310-9956-ffa450edef68

16 years agoNew cookie unit tests and associated refactoring to get ant test target working.
markt [Sat, 31 Oct 2009 11:46:50 +0000 (11:46 +0000)]
New cookie unit tests and associated refactoring to get ant test target working.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831533 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefactoring to allow easier re-use.
markt [Sat, 31 Oct 2009 11:01:48 +0000 (11:01 +0000)]
Refactoring to allow easier re-use.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831530 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRe-add code that was incorrectly removed in recent changes
markt [Fri, 30 Oct 2009 16:02:40 +0000 (16:02 +0000)]
Re-add code that was incorrectly removed in recent changes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831361 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix a documentation bug:
kkolinko [Fri, 30 Oct 2009 06:37:47 +0000 (06:37 +0000)]
Fix a documentation bug:
To enable SSL in TC 6.0 and later you set SSLEnabled=true, not secure=true as it was in TC 5.5.

Also added a phrase about secure and schema attributes. The text is nearly identical to the one in the SSLEnabled attribute description above on the same page. If anyone has a better phrase, you are welcome.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831212 13f79535-47bb-0310-9956-ffa450edef68

16 years agoApply Konstantin's review comments
markt [Thu, 29 Oct 2009 22:14:26 +0000 (22:14 +0000)]
Apply Konstantin's review comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831116 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSSL should be based on SSLEnabled, not secure flag
fhanik [Thu, 29 Oct 2009 21:48:04 +0000 (21:48 +0000)]
SSL should be based on SSLEnabled, not secure flag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831106 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd an option to strictly enforce cookie naming rules.
markt [Thu, 29 Oct 2009 19:26:52 +0000 (19:26 +0000)]
Add an option to strictly enforce cookie naming rules.
I'm not wild about the implementation but since we can't change the API, this was the best I could come up with. Suggestions for improvements welcome.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831069 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd system property to control treatment of / as a separator when processing cookies
markt [Thu, 29 Oct 2009 18:36:49 +0000 (18:36 +0000)]
Add system property to control treatment of / as a separator when processing cookies
Modify ALWAYS_ADD_EXPIRES so STRICT_SERVLET_COMPLIANCE changes the default to a strict interpretation of the specs

Note: I'll refactor the common code into a Constants class once I am finished but I'm doing that last as the refactoring won't be proposed for back-port to 6.0.x/5.5.x

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@831059 13f79535-47bb-0310-9956-ffa450edef68

16 years agoThe single quote character ' is not a separator so it is allowed in unquoted values.
markt [Thu, 29 Oct 2009 15:27:58 +0000 (15:27 +0000)]
The single quote character ' is not a separator so it is allowed in unquoted values.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830999 13f79535-47bb-0310-9956-ffa450edef68

16 years agoNo longer required since all connectors now use acceptors
markt [Thu, 29 Oct 2009 14:39:38 +0000 (14:39 +0000)]
No longer required since all connectors now use acceptors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830965 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake leak prevention listener more configurable
markt [Thu, 29 Oct 2009 12:03:48 +0000 (12:03 +0000)]
Make leak prevention listener more configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830908 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClean-up - no functional change
markt [Thu, 29 Oct 2009 10:58:49 +0000 (10:58 +0000)]
Clean-up - no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830890 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a workaround for a common cause of locked files.
markt [Wed, 28 Oct 2009 19:25:31 +0000 (19:25 +0000)]
Add a workaround for a common cause of locked files.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830736 13f79535-47bb-0310-9956-ffa450edef68

16 years agoEnsure thread ratio calc is valid
markt [Wed, 28 Oct 2009 15:30:49 +0000 (15:30 +0000)]
Ensure thread ratio calc is valid

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830589 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd FilterMaps to the web.xml file merge process
markt [Wed, 28 Oct 2009 12:27:42 +0000 (12:27 +0000)]
Add FilterMaps to the web.xml file merge process

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830514 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd some test cases for ordering.
markt [Wed, 28 Oct 2009 11:49:48 +0000 (11:49 +0000)]
Add some test cases for ordering.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830508 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRe-factoring to make testing easier
markt [Wed, 28 Oct 2009 11:48:50 +0000 (11:48 +0000)]
Re-factoring to make testing easier

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830506 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove empty test class to avoid no tests found errors when running all tests for...
markt [Wed, 28 Oct 2009 11:14:29 +0000 (11:14 +0000)]
Remove empty test class to avoid no tests found errors when running all tests for a package in Eclipse

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830503 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake base class abstract to avoid no tests found errors when running all tests for...
markt [Wed, 28 Oct 2009 11:13:41 +0000 (11:13 +0000)]
Make base class abstract to avoid no tests found errors when running all tests for a package in Eclipse

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830502 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrected a misprint
kkolinko [Wed, 28 Oct 2009 05:40:36 +0000 (05:40 +0000)]
Corrected a misprint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830444 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd leak prevention listener to windows installer
markt [Tue, 27 Oct 2009 22:35:05 +0000 (22:35 +0000)]
Add leak prevention listener to windows installer

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830379 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDocument new listener
markt [Tue, 27 Oct 2009 22:34:04 +0000 (22:34 +0000)]
Document new listener

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830378 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd back the setters for remote host and remote address and provide an implementation...
markt [Tue, 27 Oct 2009 22:16:54 +0000 (22:16 +0000)]
Add back the setters for remote host and remote address and provide an implementation. They will be needed for the mod_remoteip port (bug 47330)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@830368 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate copyright year
markt [Mon, 26 Oct 2009 15:27:12 +0000 (15:27 +0000)]
Update copyright year
Clean up unused elements

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829825 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unnecessary casts
markt [Sat, 24 Oct 2009 21:07:44 +0000 (21:07 +0000)]
Remove unnecessary casts

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829452 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused field
markt [Sat, 24 Oct 2009 21:07:13 +0000 (21:07 +0000)]
Remove unused field

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829451 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused imports and methods
markt [Sat, 24 Oct 2009 21:00:42 +0000 (21:00 +0000)]
Remove unused imports and methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829450 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix Eclipse niggles in the examples
markt [Sat, 24 Oct 2009 20:54:19 +0000 (20:54 +0000)]
Fix Eclipse niggles in the examples

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829449 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMerge code for a few more elements
markt [Sat, 24 Oct 2009 20:52:46 +0000 (20:52 +0000)]
Merge code for a few more elements

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829448 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImplement merge rules for a few more web.xml elements
markt [Sat, 24 Oct 2009 20:07:42 +0000 (20:07 +0000)]
Implement merge rules for a few more web.xml elements
Required some refactoring as some of the rules depend on all fragments and the main web.xml

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829440 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd support for absolute ordering of web fragments and the start of the fragment...
markt [Fri, 23 Oct 2009 16:39:32 +0000 (16:39 +0000)]
Add support for absolute ordering of web fragments and the start of the fragment merge code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829121 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClear the remaining Eclipse warnings in the examples
markt [Fri, 23 Oct 2009 14:00:36 +0000 (14:00 +0000)]
Clear the remaining Eclipse warnings in the examples

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@829067 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987
markt [Thu, 22 Oct 2009 15:44:06 +0000 (15:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987
Limit size of not found resources cache

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828759 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r828212. The cache limit was applied to the wrong field. Thanks to Remy for...
markt [Thu, 22 Oct 2009 15:31:53 +0000 (15:31 +0000)]
Revert r828212. The cache limit was applied to the wrong field. Thanks to Remy for the catch.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828749 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefix https://issues.apache.org/bugzilla/show_bug.cgi?id=37848
markt [Wed, 21 Oct 2009 21:40:21 +0000 (21:40 +0000)]
Refix https://issues.apache.org/bugzilla/show_bug.cgi?id=37848
Don't output info messages if there is no terminal
Patch provided by Eric Herman

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828225 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987
markt [Wed, 21 Oct 2009 20:57:14 +0000 (20:57 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987
Limit size of not found resources cache

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828212 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48009
markt [Wed, 21 Oct 2009 20:53:47 +0000 (20:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48009
Add a check in case the file is in the middle of being renamed. It isn't perfect (it can't be) but this should cover most cases

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828210 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48019
markt [Wed, 21 Oct 2009 20:43:21 +0000 (20:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48019
Be more careful to skip over all of nodes we aren't interested it

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828201 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSomewhat ironically, the call to java.beans.Introspector.flushCaches() that is meant...
markt [Wed, 21 Oct 2009 20:36:23 +0000 (20:36 +0000)]
Somewhat ironically, the call to java.beans.Introspector.flushCaches() that is meant to prevent memory leaks now causes a leak on reload due to a change in 1.6.0_15 onwards.
Add a listener that prevents the leak.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@828196 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate to the latest schemas.
markt [Tue, 20 Oct 2009 14:00:44 +0000 (14:00 +0000)]
Update to the latest schemas.
Note the stated election to use the CDDL

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@827460 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate example for updated Servlet 3.0
markt [Tue, 20 Oct 2009 13:49:15 +0000 (13:49 +0000)]
Update example for updated Servlet 3.0

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@827446 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate spec classes for latest Servlet 3.0 API as of 2009-10-15.
markt [Tue, 20 Oct 2009 13:41:59 +0000 (13:41 +0000)]
Update spec classes for latest Servlet 3.0 API as of 2009-10-15.
Update internals so Tomcat builds with the updated spec. Lots if stubbed impl marked with TODO.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@827435 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix Eclipse warnings
markt [Sat, 17 Oct 2009 19:28:15 +0000 (19:28 +0000)]
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@826296 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPart 2 of CSRF protection for the host manager. Use POST and require valid nonce.
markt [Sat, 17 Oct 2009 19:27:12 +0000 (19:27 +0000)]
Part 2 of CSRF protection for the host manager. Use POST and require valid nonce.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@826295 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPart 1 of CSRF protection for host manager. Move text interface from / to /text,...
markt [Sat, 17 Oct 2009 19:25:11 +0000 (19:25 +0000)]
Part 1 of CSRF protection for host manager. Move text interface from / to /text, add extra role for /text. Port 401.jsp and 404.jsp from manager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@826294 13f79535-47bb-0310-9956-ffa450edef68

16 years agoChange of name for role
markt [Sat, 17 Oct 2009 19:22:16 +0000 (19:22 +0000)]
Change of name for role

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@826293 13f79535-47bb-0310-9956-ffa450edef68

16 years agoChange name of role for scripts
markt [Sat, 17 Oct 2009 19:21:50 +0000 (19:21 +0000)]
Change name of role for scripts

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@826292 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse string manager for i18n.
markt [Sat, 17 Oct 2009 19:21:01 +0000 (19:21 +0000)]
Use string manager for i18n.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@826291 13f79535-47bb-0310-9956-ffa450edef68

16 years agosimplify example
fhanik [Fri, 16 Oct 2009 00:09:48 +0000 (00:09 +0000)]
simplify example

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@825711 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd some modifications to the state machine. Timeout and error are an async dispatch...
fhanik [Fri, 16 Oct 2009 00:06:14 +0000 (00:06 +0000)]
Add some modifications to the state machine. Timeout and error are an async dispatch, and its unclear what the state should be. Since both those actions should stop the event, we set the state to COMPLETING

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@825708 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a simple asynchronous stock ticker.
fhanik [Thu, 15 Oct 2009 01:10:34 +0000 (01:10 +0000)]
Add a simple asynchronous stock ticker.
Some more refactoring around common code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@825366 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTypos
markt [Wed, 14 Oct 2009 16:28:31 +0000 (16:28 +0000)]
Typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@825180 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate copyright
markt [Wed, 14 Oct 2009 05:35:53 +0000 (05:35 +0000)]
Update copyright

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@825011 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix misprint in a comment
kkolinko [Tue, 13 Oct 2009 07:05:53 +0000 (07:05 +0000)]
Fix misprint in a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@824615 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd an explicit test for JSPs. Grails - that is using a variant of this - seems to...
markt [Mon, 12 Oct 2009 17:28:49 +0000 (17:28 +0000)]
Add an explicit test for JSPs. Grails - that is using a variant of this - seems to have issues with JSPs. Looks OK here.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@824432 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReplace StringBuffer with StringBuilder
kkolinko [Sun, 11 Oct 2009 06:55:27 +0000 (06:55 +0000)]
Replace StringBuffer with StringBuilder

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@824032 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSet svn:eol-style = native
kkolinko [Sun, 11 Oct 2009 06:27:32 +0000 (06:27 +0000)]
Set svn:eol-style = native

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@824031 13f79535-47bb-0310-9956-ffa450edef68

16 years agoNo need for sync
markt [Sat, 10 Oct 2009 23:15:44 +0000 (23:15 +0000)]
No need for sync

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823976 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse a nonce to provide CSRF protection
markt [Sat, 10 Oct 2009 23:11:30 +0000 (23:11 +0000)]
Use a nonce to provide CSRF protection

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823975 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=40001
markt [Sat, 10 Oct 2009 21:54:54 +0000 (21:54 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=40001
Use POST rather than GET for all operations that are not idempotent
Partly based on a patch suggested by Daniel Naber
Remove the "Are you sure?", partly due to lack of i18n support and since as (based on my recollection) as many people disliked the feature as liked it.
Provides a (very) small measure of CSRF protection but lays the foundation for using a nonce with POST.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823962 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefactor upload into its own method in preparation for moving some commands from...
markt [Sat, 10 Oct 2009 18:16:51 +0000 (18:16 +0000)]
Refactor upload into its own method in preparation for moving some commands from GET to POST.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823910 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix the Eclipse warnings, add some additional comments.
markt [Sat, 10 Oct 2009 18:11:51 +0000 (18:11 +0000)]
Fix the Eclipse warnings, add some additional comments.
No functional change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823908 13f79535-47bb-0310-9956-ffa450edef68

16 years agoExplicitly mark all our valves so that we can track down which ones we need to fix...
fhanik [Fri, 9 Oct 2009 22:02:35 +0000 (22:02 +0000)]
Explicitly mark all our valves so that we can track down which ones we need to fix and make async aware

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823713 13f79535-47bb-0310-9956-ffa450edef68

16 years agoJust like filters, valves will have to be async aware in order for it to work properly.
fhanik [Fri, 9 Oct 2009 21:52:36 +0000 (21:52 +0000)]
Just like filters, valves will have to be async aware in order for it to work properly.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823710 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd license
fhanik [Fri, 9 Oct 2009 20:54:01 +0000 (20:54 +0000)]
Add license

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823683 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAbstract out code for output buffer, much easier to read
fhanik [Fri, 9 Oct 2009 16:24:43 +0000 (16:24 +0000)]
Abstract out code for output buffer, much easier to read

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823608 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a local bind otherwise for box with multi IP httpd may use the wrong port.
jfclere [Fri, 9 Oct 2009 16:00:20 +0000 (16:00 +0000)]
Add a local bind otherwise for box with multi IP httpd may use the wrong port.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823603 13f79535-47bb-0310-9956-ffa450edef68

16 years agopropset eol-style
fhanik [Fri, 9 Oct 2009 13:43:33 +0000 (13:43 +0000)]
propset eol-style

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823550 13f79535-47bb-0310-9956-ffa450edef68

16 years agoconsolidate two input buffers into one, no functional change, just abstract out exact...
fhanik [Thu, 8 Oct 2009 22:37:52 +0000 (22:37 +0000)]
consolidate two input buffers into one, no functional change, just abstract out exact same code used in two connectors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823351 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefactor the BIO connector to align it better for async support, this means a "poller...
fhanik [Thu, 8 Oct 2009 17:08:20 +0000 (17:08 +0000)]
Refactor the BIO connector to align it better for async support, this means a "poller" style for timeouts etc.
First step is to allow the connector to do keep alive on more connections than we have threads.
More changes to follow, good chance that NIO and BIO can share tons of code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823234 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove not needed entry
fhanik [Thu, 8 Oct 2009 16:40:31 +0000 (16:40 +0000)]
remove not needed entry

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@823225 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove Javadoc for method argument, that was
rjung [Sun, 4 Oct 2009 11:04:37 +0000 (11:04 +0000)]
Remove Javadoc for method argument, that was
erroneously added in r684270.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@821507 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpgrade to pool 1.5.3
markt [Sat, 3 Oct 2009 20:59:45 +0000 (20:59 +0000)]
Upgrade to pool 1.5.3

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@821412 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore docs tweaks based on Rainer's and Konstantin's feedback
markt [Sat, 3 Oct 2009 19:43:34 +0000 (19:43 +0000)]
More docs tweaks based on Rainer's and Konstantin's feedback

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@821400 13f79535-47bb-0310-9956-ffa450edef68

16 years agoIgnore duplicate entries on the classpath.
markt [Sat, 3 Oct 2009 19:36:01 +0000 (19:36 +0000)]
Ignore duplicate entries on the classpath.
Patch could be smaller but change variable name to make new behaviour clear

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@821397 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix BASE/HOME swap and add note re security manager.
markt [Sat, 3 Oct 2009 16:20:49 +0000 (16:20 +0000)]
Fix BASE/HOME swap and add note re security manager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@821353 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate tomcat-docs.xsl
kkolinko [Sat, 3 Oct 2009 02:08:13 +0000 (02:08 +0000)]
Update tomcat-docs.xsl
It is port of rev.821208 from tc6.0.x

1. Properly publish author names in <meta> HTML tag (it has content attribute, not value),
and do not publish e-mails.
2. Added support for "rtext" attribute on <section> tag. I use it to include release dates in changelog.xml.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@821220 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse proper method to construct an URL string.
kkolinko [Fri, 2 Oct 2009 10:39:21 +0000 (10:39 +0000)]
Use proper method to construct an URL string.
File.toURI() takes care of absolute paths, trailing slashes in the names of directories, encoding of special characters such as '%'.
Based on a suggestion by Rainer Jung.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820954 13f79535-47bb-0310-9956-ffa450edef68

16 years agotomcat-coyote.jar (former tomcat-util.jar before rev.389946) is not needed by bootstr...
kkolinko [Fri, 2 Oct 2009 03:16:12 +0000 (03:16 +0000)]
tomcat-coyote.jar (former tomcat-util.jar before rev.389946) is not needed by bootstrap classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820874 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd port in the message.
jfclere [Wed, 30 Sep 2009 09:03:25 +0000 (09:03 +0000)]
Add port in the message.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820220 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDo not reuse sessionsList window to show sessionsDetail.
kkolinko [Wed, 30 Sep 2009 00:01:17 +0000 (00:01 +0000)]
Do not reuse sessionsList window to show sessionsDetail.
It adds more sense to the "Close window" button on that page.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820132 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDo proper nesting of HTML tags and add DOCTYPE declaration.
kkolinko [Tue, 29 Sep 2009 23:23:11 +0000 (23:23 +0000)]
Do proper nesting of HTML tags and add DOCTYPE declaration.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820123 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect wording
kkolinko [Tue, 29 Sep 2009 22:54:17 +0000 (22:54 +0000)]
Correct wording

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820118 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDo not include ASF License comment into generated output
kkolinko [Tue, 29 Sep 2009 22:48:09 +0000 (22:48 +0000)]
Do not include ASF License comment into generated output

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820117 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix display of sessionList and sessionDetail pages in IE 6 and IE 7:
kkolinko [Tue, 29 Sep 2009 22:24:47 +0000 (22:24 +0000)]
Fix display of sessionList and sessionDetail pages in IE 6 and IE 7:
do not include ASF License comment into generated output.

Because of that large comment that precedes other content those browsers try to display these pages as generic XML, and fail.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820110 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect a pair of misprints
kkolinko [Tue, 29 Sep 2009 21:18:09 +0000 (21:18 +0000)]
Correct a pair of misprints

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@820092 13f79535-47bb-0310-9956-ffa450edef68

16 years agotimeout can't be negative...
jfclere [Tue, 29 Sep 2009 12:20:57 +0000 (12:20 +0000)]
timeout can't be negative...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@819899 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47324
markt [Sun, 27 Sep 2009 17:44:26 +0000 (17:44 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47324
Fix submit IRL when behind a reverse proxy
Patch by Maik Jablonski

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@819361 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47320
markt [Sun, 27 Sep 2009 16:48:23 +0000 (16:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47320
Don't rely on the platform default encoding being suitable to parse the session ID

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@819339 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDeltaManager needs to replicate changed attributes even if session
rjung [Wed, 23 Sep 2009 11:28:14 +0000 (11:28 +0000)]
DeltaManager needs to replicate changed attributes even if session
gets invalidated. Otherwise session listeners will not see the right
data on the secondary nodes.

Port of r818061 from TC 5.5.x.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@818062 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47499
markt [Tue, 22 Sep 2009 21:16:54 +0000 (21:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47499
Don't swallow BindException

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@817843 13f79535-47bb-0310-9956-ffa450edef68