tomcat7.0
15 years agoRemove the ExpiresActive option. Just comment it out if you don't want to use it.
markt [Wed, 14 Jul 2010 22:15:50 +0000 (22:15 +0000)]
Remove the ExpiresActive option. Just comment it out if you don't want to use it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964222 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
markt [Wed, 14 Jul 2010 22:11:30 +0000 (22:11 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
Add the ExpiresFilter, a port of mod_expires
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964219 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49127
markt [Wed, 14 Jul 2010 21:39:40 +0000 (21:39 +0000)]
Fxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49127
Don't swallow exceptions unnecessarily

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964216 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49128
markt [Wed, 14 Jul 2010 21:35:37 +0000 (21:35 +0000)]
Fxi https://issues.apache.org/bugzilla/show_bug.cgi?id=49128
Don't swallow exceptions unnecessarily

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964215 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49130
markt [Wed, 14 Jul 2010 21:29:44 +0000 (21:29 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49130
Better describe the core package
Patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964211 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49182
markt [Wed, 14 Jul 2010 21:24:45 +0000 (21:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49182
Align setclasspath comments with reality.
Based on a patch provided by sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964208 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd myself to the list.
kkolinko [Wed, 14 Jul 2010 13:54:43 +0000 (13:54 +0000)]
Add myself to the list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@964049 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48960
markt [Tue, 13 Jul 2010 21:35:39 +0000 (21:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48960
Disable exec by default in SSI and provide an option to enable it for both  Servlet and Filter

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963868 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSign the pom.
markt [Tue, 13 Jul 2010 16:02:09 +0000 (16:02 +0000)]
Sign the pom.
Make sure source jar signature doesn't overwrite the non-source jar signature.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963776 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid NullPointerException, when copyXML=true and META-INF/context.xml does not exist.
kfujino [Tue, 13 Jul 2010 04:44:25 +0000 (04:44 +0000)]
Avoid NullPointerException, when copyXML=true and META-INF/context.xml does not exist.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963599 13f79535-47bb-0310-9956-ffa450edef68

15 years agoHard code the snapshot version for 7.0.
markt [Mon, 12 Jul 2010 13:17:01 +0000 (13:17 +0000)]
Hard code the snapshot version for 7.0.
7.0-SNAPSHOT will always point to the latest snapshot.
I'll clean out the snapshot repo before I do the next update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963275 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPrepare for the next release
markt [Mon, 12 Jul 2010 13:02:30 +0000 (13:02 +0000)]
Prepare for the next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963273 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake the fix for bug 49555 more robust
markt [Sun, 11 Jul 2010 16:37:32 +0000 (16:37 +0000)]
Make the fix for bug 49555 more robust

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963106 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unnecessary code since Class.getCanonicalName() is available
markt [Sun, 11 Jul 2010 16:29:25 +0000 (16:29 +0000)]
Remove unnecessary code since Class.getCanonicalName() is available

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@963103 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEclipse warnings for annotations
markt [Sat, 10 Jul 2010 21:43:02 +0000 (21:43 +0000)]
Eclipse warnings for annotations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962923 13f79535-47bb-0310-9956-ffa450edef68

15 years agojavax.mail is a dummy implementation - mark it as such to stop Eclipse complaining...
markt [Sat, 10 Jul 2010 21:39:58 +0000 (21:39 +0000)]
javax.mail is a dummy implementation - mark it as such to stop Eclipse complaining about empty methods and unused parameters

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962922 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTrivial cleanup no functional change
markt [Sat, 10 Jul 2010 21:33:16 +0000 (21:33 +0000)]
Trivial cleanup no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962921 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49442
markt [Sat, 10 Jul 2010 21:22:12 +0000 (21:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49442
Trivial code clean-up. No functional change.
Based on a patch provided by Sebb.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962919 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478
markt [Sat, 10 Jul 2010 21:13:23 +0000 (21:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478
Add support for user specified character sets to the AddDefaultCharsetFilter. Based on a patch by Felix Schumacher.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962917 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTypo
markt [Sat, 10 Jul 2010 18:33:14 +0000 (18:33 +0000)]
Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962900 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49570
markt [Sat, 10 Jul 2010 17:20:41 +0000 (17:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49570
When using the example compression filter, set the Vary header on compressed responses

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962889 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake the random source used for nonces user configurable
markt [Sat, 10 Jul 2010 16:41:59 +0000 (16:41 +0000)]
Make the random source used for nonces user configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962881 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlign implementation with docs. nonceCacheSize should be configurable
markt [Sat, 10 Jul 2010 16:19:26 +0000 (16:19 +0000)]
Align implementation with docs. nonceCacheSize should be configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962872 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd CVE-2010-2227 test case
markt [Sat, 10 Jul 2010 16:14:42 +0000 (16:14 +0000)]
Add CVE-2010-2227 test case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962871 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove CSRF protection filter by using SecureRandom rather than Random
markt [Sat, 10 Jul 2010 16:10:33 +0000 (16:10 +0000)]
Improve CSRF protection filter by using SecureRandom rather than Random

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962865 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlign docs with reality
markt [Sat, 10 Jul 2010 16:05:52 +0000 (16:05 +0000)]
Align docs with reality

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962864 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd release date
kkolinko [Sat, 10 Jul 2010 15:12:24 +0000 (15:12 +0000)]
Add release date

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962857 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDocumentation improvements:
markt [Fri, 9 Jul 2010 09:41:25 +0000 (09:41 +0000)]
Documentation improvements:
- Explicit version number in <title ../>
- Add version and date to every page
- Remove duplicate "Apache Tomcat 7" and promote real page title
- Automate copyright end date

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@962466 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48297
markt [Thu, 8 Jul 2010 22:22:34 +0000 (22:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48297
Use the HandlerInfo to initialise the HandlerChain, rather than adding to it which clearly isn't correct.
From looking at the javadoc, I believe this is the fix required but I don't have a test case.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961963 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGSOC 2010. Continue work to align MBean descriptors with reality. Patch provided...
markt [Thu, 8 Jul 2010 21:55:46 +0000 (21:55 +0000)]
GSOC 2010. Continue work to align MBean descriptors with reality. Patch provided by Chamith Buddhika.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961956 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
markt [Thu, 8 Jul 2010 21:29:12 +0000 (21:29 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Correctly handle tag libraries that use functions defined in static inner classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961948 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
markt [Thu, 8 Jul 2010 21:28:21 +0000 (21:28 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Fix to follow shortly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961947 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police
markt [Thu, 8 Jul 2010 21:19:39 +0000 (21:19 +0000)]
Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961942 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49503
markt [Thu, 8 Jul 2010 15:48:48 +0000 (15:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49503
Revert the protocol handler component of r940656. Subsequent lifecycle fixes have resolved the issues that required this change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961819 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate post release of 7.0.0 beta
markt [Thu, 8 Jul 2010 09:00:47 +0000 (09:00 +0000)]
Update post release of 7.0.0 beta

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961647 13f79535-47bb-0310-9956-ffa450edef68

15 years agoInclude session ID in error message logged when trying to set an attribute on an...
markt [Thu, 8 Jul 2010 00:05:38 +0000 (00:05 +0000)]
Include session ID in error message logged when trying to set an attribute on an invalid session.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961541 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove logging of unhandled servlet exceptions by including the context name. For...
markt [Wed, 7 Jul 2010 23:33:28 +0000 (23:33 +0000)]
Improve logging of unhandled servlet exceptions by including the context name. For JasperExceptions, the JSP snippet will be logged (if enabled). Previously this was not logged and only displayed in the error page seen by the user.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961535 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some Eclipse warnings
markt [Wed, 7 Jul 2010 22:34:47 +0000 (22:34 +0000)]
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961525 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter error message
markt [Wed, 7 Jul 2010 09:10:38 +0000 (09:10 +0000)]
Better error message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@961313 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
markt [Tue, 6 Jul 2010 16:47:39 +0000 (16:47 +0000)]
Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Make sure identifiers meet the requirements of the JLS

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960942 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSide effect of fixing https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
markt [Tue, 6 Jul 2010 16:45:23 +0000 (16:45 +0000)]
Side effect of fixing https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Make the examples and the unit tests spec compliant

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960940 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
markt [Mon, 5 Jul 2010 21:45:26 +0000 (21:45 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Prevent use of Java keywords in identifiers

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960712 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
markt [Mon, 5 Jul 2010 21:44:29 +0000 (21:44 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960711 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
markt [Mon, 5 Jul 2010 21:07:32 +0000 (21:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49551
Allow default context.xml file to be specified using an absolute path.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960701 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
markt [Mon, 5 Jul 2010 20:58:23 +0000 (20:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49550
Trivial code clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960698 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
markt [Mon, 5 Jul 2010 20:51:21 +0000 (20:51 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
Previous fix was incomplete. Improve test case and fix
TCK and test cases pass with this patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960692 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean up
markt [Sun, 4 Jul 2010 20:48:07 +0000 (20:48 +0000)]
Clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960394 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
markt [Sun, 4 Jul 2010 20:38:41 +0000 (20:38 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
AsyncContext.start() uses an internal dispatch but this should not have the same side-effects as calling dispatch()
TCK and test cases passes with this patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960392 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
markt [Sun, 4 Jul 2010 20:34:02 +0000 (20:34 +0000)]
Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49528

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960391 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove *.rtf from fixcrlf patternset.
rjung [Sun, 4 Jul 2010 16:01:43 +0000 (16:01 +0000)]
Remove *.rtf from fixcrlf patternset.

No need for native line ends in RTF files.
Their spec indicates they should use CRLF.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960350 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r958362, r960083, r958406, r960069. r958362 broke the TCK tests and the other...
markt [Sun, 4 Jul 2010 15:44:45 +0000 (15:44 +0000)]
Revert r958362, r960083, r958406, r960069. r958362 broke the TCK tests and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960348 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r960283, r960316, r960318. r960283 broke the spec and the other commits were...
markt [Sun, 4 Jul 2010 15:38:40 +0000 (15:38 +0000)]
Revert r960283, r960316, r960318. r960283 broke the spec and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960347 13f79535-47bb-0310-9956-ffa450edef68

15 years agono functional change.
pero [Sun, 4 Jul 2010 10:50:53 +0000 (10:50 +0000)]
no functional change.
reformating and fix some checkstyle warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960318 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix indentation...
pero [Sun, 4 Jul 2010 10:47:12 +0000 (10:47 +0000)]
Fix indentation...

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960317 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix NPE and add small test case to check VirtualWebappLoader.
pero [Sat, 3 Jul 2010 23:02:46 +0000 (23:02 +0000)]
Fix NPE and add small test case to check VirtualWebappLoader.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960284 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix Bug 49528 - HttpServletRequest.isAsyncStarted() returns false when a Runnable...
pero [Sat, 3 Jul 2010 22:48:16 +0000 (22:48 +0000)]
Fix Bug 49528 - HttpServletRequest.isAsyncStarted() returns false when a Runnable is started
Add isDebugEnabled statements.

Todo: Why we doesn't start directly a container thread with asyncContext.start()?
Currently we start user runnable as an internal forward.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960283 13f79535-47bb-0310-9956-ffa450edef68

15 years agoA few more FindBugs issues
markt [Fri, 2 Jul 2010 21:13:25 +0000 (21:13 +0000)]
A few more FindBugs issues

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960104 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix FindBugs niggle
markt [Fri, 2 Jul 2010 21:10:35 +0000 (21:10 +0000)]
Fix FindBugs niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960103 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest NIO AsyncListener timeout.
pero [Fri, 2 Jul 2010 18:30:34 +0000 (18:30 +0000)]
Test NIO AsyncListener timeout.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960083 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFurther MBean improvements.
markt [Fri, 2 Jul 2010 18:25:54 +0000 (18:25 +0000)]
Further MBean improvements.
Patch provided by chamith buddhika

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960081 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49530
markt [Fri, 2 Jul 2010 18:04:14 +0000 (18:04 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49530
Make sure children are stopped if they are running when the parent stops.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960076 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake new timeout thread a daemon thread so Tomcat will shutdown properly
markt [Fri, 2 Jul 2010 17:50:56 +0000 (17:50 +0000)]
Make new timeout thread a daemon thread so Tomcat will shutdown properly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@960069 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional debug logging for manager selection
markt [Fri, 2 Jul 2010 10:01:32 +0000 (10:01 +0000)]
Additional debug logging for manager selection

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959931 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49536
markt [Thu, 1 Jul 2010 21:35:19 +0000 (21:35 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49536
Ensure a 404 response for an unmapped request when no ROOT context is deployed.
Most of the change is getting the mapper to use the Host object rather than the ObjectName or an empty string

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959790 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo
markt [Thu, 1 Jul 2010 19:37:40 +0000 (19:37 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959756 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49525
markt [Thu, 1 Jul 2010 19:33:45 +0000 (19:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49525
Cookies for ROOT context need a path of /

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959754 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49522
markt [Thu, 1 Jul 2010 18:06:47 +0000 (18:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49522
Just use host and path in NamingResources MBean name rather than full Context MBean name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959736 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49518
markt [Thu, 1 Jul 2010 11:28:49 +0000 (11:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49518
Correct typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959620 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove default security settings. Enable the LockOutRealm by default.
markt [Thu, 1 Jul 2010 09:57:07 +0000 (09:57 +0000)]
Improve default security settings. Enable the LockOutRealm by default.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959580 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove handling for method invocation in EL, in particular the method used to identi...
markt [Thu, 1 Jul 2010 09:35:23 +0000 (09:35 +0000)]
Improve handling for method invocation in EL, in particular the method used to identify the method to invoke. This reverts r953440 and implements a more comprehensive solution.
The method identification code attempts to mimic how the Java compiler works. In a few cases it finds methods where the Java complier reports an ambiguous method. The EL spec is sufficiently vague on method selection that I don't think this will be an issue.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959568 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-factor to make upcoming changes easier to understand
markt [Wed, 30 Jun 2010 08:46:50 +0000 (08:46 +0000)]
Re-factor to make upcoming changes easier to understand

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959233 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect broken link on the index.html page of the jsp examples.
kkolinko [Tue, 29 Jun 2010 19:06:43 +0000 (19:06 +0000)]
Correct broken link on the index.html page of the jsp examples.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959075 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo
markt [Tue, 29 Jun 2010 16:41:06 +0000 (16:41 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@959023 13f79535-47bb-0310-9956-ffa450edef68

15 years agoArrange filter logic.
jfclere [Tue, 29 Jun 2010 10:13:54 +0000 (10:13 +0000)]
Arrange filter logic.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958911 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImplement support for using *.jar pattern in VirtualWebappLoader to specify all JAR...
kkolinko [Mon, 28 Jun 2010 15:59:12 +0000 (15:59 +0000)]
Implement support for using *.jar pattern in VirtualWebappLoader to specify all JAR files in a certain directory.

This is inspired by Bootstrap.createClassLoader(..) and ClassLoaderFactory.createClassLoader(..).
There is a small difference with regards to ClassLoaderFactory.createClassLoader(..) implementation:
1. I removed the file.canRead() checks as I think that they are not necessary here. I am checking existence and type only.
2. Note that isFile()/isDirectory() are documented to return false if the path does not exist, so using a separate exists() call there is not necessary.

Also three other changes:
1. Added trim() to the tokens.
2. Implemented debug logging.
3. Removed "not for production" warning from the JavaDoc.

An update for the documentation (/config/loader.html) should follow later.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958615 13f79535-47bb-0310-9956-ffa450edef68

15 years agoremove second fix entry. Sorry!
pero [Sun, 27 Jun 2010 18:41:48 +0000 (18:41 +0000)]
remove second fix entry. Sorry!

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958406 13f79535-47bb-0310-9956-ffa450edef68

15 years agoStart JioEndpoint timeout thread, to handle timeout a AsyncListener.
pero [Sun, 27 Jun 2010 11:02:10 +0000 (11:02 +0000)]
Start JioEndpoint timeout thread, to handle timeout a AsyncListener.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958362 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSimplify code
kkolinko [Sat, 26 Jun 2010 21:35:58 +0000 (21:35 +0000)]
Simplify code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958287 13f79535-47bb-0310-9956-ffa450edef68

15 years agoBetter way to keep Eclipse happy
markt [Sat, 26 Jun 2010 13:50:32 +0000 (13:50 +0000)]
Better way to keep Eclipse happy

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958226 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some Eclispe / Findbugs warnings
markt [Sat, 26 Jun 2010 12:17:33 +0000 (12:17 +0000)]
Fix some Eclispe / Findbugs warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958214 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused code
markt [Sat, 26 Jun 2010 12:05:30 +0000 (12:05 +0000)]
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958213 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49414
markt [Sat, 26 Jun 2010 07:04:32 +0000 (07:04 +0000)]
Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49414
Just look for presence of CoyoteAdapter class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@958192 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional fix for
kkolinko [Fri, 25 Jun 2010 14:13:26 +0000 (14:13 +0000)]
Additional fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
When initializing/starting/stopping connectors and one of them fails, do not ignore the others.

These changes are already included in the BZ 49030 patch that I proposed for TC6.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957960 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate changelog
markt [Fri, 25 Jun 2010 09:02:48 +0000 (09:02 +0000)]
Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957853 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a check of the edge cases for bug 49488. As expected, they all pass.
markt [Fri, 25 Jun 2010 07:58:14 +0000 (07:58 +0000)]
Add a check of the edge cases for bug 49488. As expected, they all pass.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957833 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49414
markt [Fri, 25 Jun 2010 07:53:24 +0000 (07:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49414
Try to differentiate between request threads and threads started by applications

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957830 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSwitch the Host Manager app to the generic CSRF protection
markt [Fri, 25 Jun 2010 07:47:31 +0000 (07:47 +0000)]
Switch the Host Manager app to the generic CSRF protection
Don't allow starting of hosts that are started
Don't allow stopping of hosts that are stopped

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957828 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean-up
markt [Thu, 24 Jun 2010 18:54:24 +0000 (18:54 +0000)]
Clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957681 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTypos
markt [Thu, 24 Jun 2010 18:43:38 +0000 (18:43 +0000)]
Typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957675 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix the Eclipse warnings and as a result better handle directory creation failures
markt [Thu, 24 Jun 2010 13:10:41 +0000 (13:10 +0000)]
Fix the Eclipse warnings and as a result better handle directory creation failures

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957539 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unneeded classcasts
kkolinko [Thu, 24 Jun 2010 12:27:35 +0000 (12:27 +0000)]
Remove unneeded classcasts

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957524 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMust get in the habit of updating the 7.0.x changelog
markt [Thu, 24 Jun 2010 10:25:34 +0000 (10:25 +0000)]
Must get in the habit of updating the 7.0.x changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957493 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49476
markt [Thu, 24 Jun 2010 09:57:02 +0000 (09:57 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49476
CSRF protection was preventing access to session expiration features
Also:
- Switch Manager app to generic CSRF protection
- Add support for multiple nonces to CSRF filter
- Improve 403 page
- Don't open JSP pages in session expiration in a new window - makes CSRF prevention a real pain

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957478 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTrim the value before adding to the list
markt [Wed, 23 Jun 2010 08:14:14 +0000 (08:14 +0000)]
Trim the value before adding to the list
Review feedback from kkolinko

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957139 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49230
markt [Wed, 23 Jun 2010 07:40:19 +0000 (07:40 +0000)]
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49230
Don't log an error about loading Sun class on non-Sun JVMs. Use i18n for message.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957130 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some old copy/paste errors
markt [Tue, 22 Jun 2010 21:44:17 +0000 (21:44 +0000)]
Fix some old copy/paste errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@957044 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd fix of 49475
markt [Tue, 22 Jun 2010 19:18:51 +0000 (19:18 +0000)]
Add fix of 49475

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@956984 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49475
markt [Tue, 22 Jun 2010 19:17:08 +0000 (19:17 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49475
Use new role name for manager app access

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@956983 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=49122
markt [Tue, 22 Jun 2010 17:52:40 +0000 (17:52 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122
Update ROOT's index page
Patch provided by pid

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@956964 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate version number
markt [Tue, 22 Jun 2010 17:24:53 +0000 (17:24 +0000)]
Update version number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@956958 13f79535-47bb-0310-9956-ffa450edef68