tomcat7.0
17 years agoAdd asynchronous log handling, feature not yet complete. Need to figure out when...
fhanik [Wed, 29 Oct 2008 21:41:09 +0000 (21:41 +0000)]
Add asynchronous log handling, feature not yet complete. Need to figure out when to stop the logger thread (possible when there are no loggers) and also make sure the thread sleep/wakeup is bullet proof

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@709018 13f79535-47bb-0310-9956-ffa450edef68

17 years agor703017 broke SSL with the JIO connector on Windows (and possibly other platforms...
markt [Wed, 29 Oct 2008 12:35:59 +0000 (12:35 +0000)]
r703017 broke SSL with the JIO connector on Windows (and possibly other platforms). The problem was that some settings don't make sense for an SSL socket so rather than ignoring them a SocketExcpetion is thrown. With this patch, only attributes set by the user are passed to the socket and if setting the attribute throws an exception it is logged as an error.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708892 13f79535-47bb-0310-9956-ffa450edef68

17 years agoadded doc around new flag
fhanik [Wed, 29 Oct 2008 05:19:32 +0000 (05:19 +0000)]
added doc around new flag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708780 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdded in a fairness test to showcase the FairBlockingQueue
fhanik [Wed, 29 Oct 2008 04:34:29 +0000 (04:34 +0000)]
Added in a fairness test to showcase the FairBlockingQueue

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708769 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix the performance issue, don't count down until the lock has been released, this...
fhanik [Wed, 29 Oct 2008 02:15:35 +0000 (02:15 +0000)]
Fix the performance issue, don't count down until the lock has been released, this allows for much more concurrency

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708753 13f79535-47bb-0310-9956-ffa450edef68

17 years agoadd test target
fhanik [Tue, 28 Oct 2008 23:12:39 +0000 (23:12 +0000)]
add test target

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708717 13f79535-47bb-0310-9956-ffa450edef68

17 years agostupid eclipse
fhanik [Tue, 28 Oct 2008 22:26:03 +0000 (22:26 +0000)]
stupid eclipse

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708702 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdjusted the timeout for abandoned, its in seconds
fhanik [Tue, 28 Oct 2008 20:31:00 +0000 (20:31 +0000)]
Adjusted the timeout for abandoned, its in seconds

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708663 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdded a different fairness option, since ArrayBlockingQueue with fair=true is really...
fhanik [Tue, 28 Oct 2008 19:58:43 +0000 (19:58 +0000)]
Added a different fairness option, since ArrayBlockingQueue with fair=true is really bad for performance

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708652 13f79535-47bb-0310-9956-ffa450edef68

17 years agomove over documentation to the module
fhanik [Tue, 28 Oct 2008 19:50:26 +0000 (19:50 +0000)]
move over documentation to the module

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708651 13f79535-47bb-0310-9956-ffa450edef68

17 years agowhen the DB is down, don't wait and try over and over again, simply return the failure
fhanik [Tue, 28 Oct 2008 16:41:36 +0000 (16:41 +0000)]
when the DB is down, don't wait and try over and over again, simply return the failure

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708605 13f79535-47bb-0310-9956-ffa450edef68

17 years agoMake the polling fairness configurable
fhanik [Tue, 28 Oct 2008 15:00:22 +0000 (15:00 +0000)]
Make the polling fairness configurable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708592 13f79535-47bb-0310-9956-ffa450edef68

17 years agothrow an exception instead of timeout when we fail to reconnect
fhanik [Tue, 28 Oct 2008 14:36:30 +0000 (14:36 +0000)]
throw an exception instead of timeout when we fail to reconnect

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708587 13f79535-47bb-0310-9956-ffa450edef68

17 years agoImprove validation ordering, when a connection has been acquired, but validation...
fhanik [Tue, 28 Oct 2008 14:34:28 +0000 (14:34 +0000)]
Improve validation ordering, when a connection has been acquired, but validation failed, don't let the thread go back into polling mode, instead try to reconnect it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708586 13f79535-47bb-0310-9956-ffa450edef68

17 years agoRemove references to DefaultContext from code
markt [Tue, 28 Oct 2008 11:52:12 +0000 (11:52 +0000)]
Remove references to DefaultContext from code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708541 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46106
markt [Tue, 28 Oct 2008 11:50:43 +0000 (11:50 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46106
Remove references to DefaultContext from docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708538 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46067
markt [Mon, 27 Oct 2008 22:48:21 +0000 (22:48 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46067
Correct some typos.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708365 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46075
markt [Mon, 27 Oct 2008 22:40:48 +0000 (22:40 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46075
Don't automatically create the ByteArrayOutputStream with the full threshold - we probably won't need it in most cases.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708361 13f79535-47bb-0310-9956-ffa450edef68

17 years agoImprovements to connection handling
fhanik [Mon, 27 Oct 2008 22:24:26 +0000 (22:24 +0000)]
Improvements to connection handling

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708354 13f79535-47bb-0310-9956-ffa450edef68

17 years agoExpose deferAccept for APR HTTP connector.
markt [Mon, 27 Oct 2008 22:04:51 +0000 (22:04 +0000)]
Expose deferAccept for APR HTTP connector.
I did consider adding this to the AJP connector as well but since this is to work around a buggy client and we control the client in the AJP case, I couldn't see a need for it.
Patch provided by Michael Leinartas.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708344 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46085
markt [Mon, 27 Oct 2008 18:31:50 +0000 (18:31 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46085
Hard to reproduce thread safety issue with session expiration.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708273 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdded couple more tests
fhanik [Mon, 27 Oct 2008 18:21:07 +0000 (18:21 +0000)]
Added couple more tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708263 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=46096
markt [Mon, 27 Oct 2008 17:28:16 +0000 (17:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46096
Allow for running under a security manager when processing annotations.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708243 13f79535-47bb-0310-9956-ffa450edef68

17 years agoLog max threads message at info rather than warn
markt [Mon, 27 Oct 2008 15:46:35 +0000 (15:46 +0000)]
Log max threads message at info rather than warn

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708223 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd warning messages to APR and NIO endpoint to match change to JIO.
markt [Mon, 27 Oct 2008 14:14:14 +0000 (14:14 +0000)]
Add warning messages to APR and NIO endpoint to match change to JIO.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708195 13f79535-47bb-0310-9956-ffa450edef68

17 years agoApply Remy's alternative fix for the String comparison bugs found by Find Bugs. Note...
markt [Mon, 27 Oct 2008 14:04:07 +0000 (14:04 +0000)]
Apply Remy's alternative fix for the String comparison bugs found by Find Bugs. Note FB still complains but it is a false positive.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708185 13f79535-47bb-0310-9956-ffa450edef68

17 years agoPrevious commit undid some of the fixes for bug 45906. Correct that error.
markt [Mon, 27 Oct 2008 11:43:24 +0000 (11:43 +0000)]
Previous commit undid some of the fixes for bug 45906. Correct that error.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@708145 13f79535-47bb-0310-9956-ffa450edef68

17 years agoadded correct stuff to the classpath
fhanik [Sat, 25 Oct 2008 00:17:54 +0000 (00:17 +0000)]
added correct stuff to the classpath

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707797 13f79535-47bb-0310-9956-ffa450edef68

17 years agocheck in eclipse files
fhanik [Sat, 25 Oct 2008 00:13:10 +0000 (00:13 +0000)]
check in eclipse files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707795 13f79535-47bb-0310-9956-ffa450edef68

17 years agomove over to an independent module
fhanik [Sat, 25 Oct 2008 00:06:20 +0000 (00:06 +0000)]
move over to an independent module

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707794 13f79535-47bb-0310-9956-ffa450edef68

17 years agoApply Remy's patch for 45735 and align trunk with 6.0.x.
markt [Fri, 24 Oct 2008 21:23:08 +0000 (21:23 +0000)]
Apply Remy's patch for 45735 and align trunk with 6.0.x.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707751 13f79535-47bb-0310-9956-ffa450edef68

17 years agoRevert 680710 - no interst in porting this to 6.0.x
markt [Fri, 24 Oct 2008 20:33:31 +0000 (20:33 +0000)]
Revert 680710 - no interst in porting this to 6.0.x

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707736 13f79535-47bb-0310-9956-ffa450edef68

17 years agoDuring a read or write timeout, we were cancelling the main key, this is fine for...
fhanik [Fri, 24 Oct 2008 16:14:07 +0000 (16:14 +0000)]
During a read or write timeout, we were cancelling the main key, this is fine for regular IO, but for Comet IO, this will cause events to stop since we remove the socket from the main selector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707670 13f79535-47bb-0310-9956-ffa450edef68

17 years agosimple connection pool contribution - currently built using
fhanik [Thu, 23 Oct 2008 05:14:50 +0000 (05:14 +0000)]
simple connection pool contribution - currently built using
ant -f extras.xml conpool
until we have a way to release it as a module, coming soon

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707275 13f79535-47bb-0310-9956-ffa450edef68

17 years agoSet the default thread count to 200
fhanik [Thu, 23 Oct 2008 04:10:59 +0000 (04:10 +0000)]
Set the default thread count to 200

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707264 13f79535-47bb-0310-9956-ffa450edef68

17 years agofix thread boundaries by adding a queue to the pool
fhanik [Wed, 22 Oct 2008 20:00:58 +0000 (20:00 +0000)]
fix thread boundaries by adding a queue to the pool

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707181 13f79535-47bb-0310-9956-ffa450edef68

17 years agoCorrect default setting according to documentation
fhanik [Wed, 22 Oct 2008 19:39:52 +0000 (19:39 +0000)]
Correct default setting according to documentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@707175 13f79535-47bb-0310-9956-ffa450edef68

17 years agofancier now
fhanik [Tue, 21 Oct 2008 19:27:36 +0000 (19:27 +0000)]
fancier now

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706729 13f79535-47bb-0310-9956-ffa450edef68

17 years agoimprove the stock ticker example
fhanik [Tue, 21 Oct 2008 19:16:15 +0000 (19:16 +0000)]
improve the stock ticker example

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706726 13f79535-47bb-0310-9956-ffa450edef68

17 years agowork on the bayeux samples
fhanik [Tue, 21 Oct 2008 18:07:04 +0000 (18:07 +0000)]
work on the bayeux samples

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706696 13f79535-47bb-0310-9956-ffa450edef68

17 years agoif replicated context starts without clustering enabled, then the map is not swapped...
fhanik [Mon, 20 Oct 2008 22:36:56 +0000 (22:36 +0000)]
if replicated context starts without clustering enabled, then the map is not swapped, and we get class cast exception upon shutdown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706433 13f79535-47bb-0310-9956-ffa450edef68

17 years agoDefault JNDI name for annotation lookup should be based on the class where the annota...
markt [Mon, 20 Oct 2008 09:11:55 +0000 (09:11 +0000)]
Default JNDI name for annotation lookup should be based on the class where the annotation was found which isn't always the class of the instance being created.
Reported as part of the follow-up to https://issues.apache.org/bugzilla/show_bug.cgi?id=45285
Based on a patch for 6.0.x provided by Florent BENOIT.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706159 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix generics warnings
markt [Mon, 20 Oct 2008 08:57:01 +0000 (08:57 +0000)]
Fix generics warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706155 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix the remaining EL / TCK issues. With this patch the EL TCK tests pass and my test...
markt [Sun, 19 Oct 2008 21:26:40 +0000 (21:26 +0000)]
Fix the remaining EL / TCK issues. With this patch the EL TCK tests pass and my test cases for bugs 42565, 44994, 45015, 45451, 45427, 45511 and some additional tests for edge cases all pass.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@706071 13f79535-47bb-0310-9956-ffa450edef68

17 years agoUpdate docs: clarify context.xml copying and multi-level contexts, remove reference...
markt [Fri, 10 Oct 2008 11:12:21 +0000 (11:12 +0000)]
Update docs: clarify context.xml copying and multi-level contexts, remove reference to default context

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@703403 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45977
markt [Thu, 9 Oct 2008 22:58:03 +0000 (22:58 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45977
Trivial comment clean up. No plans to backport this.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@703286 13f79535-47bb-0310-9956-ffa450edef68

17 years agoupdate changelog
fhanik [Wed, 8 Oct 2008 23:31:04 +0000 (23:31 +0000)]
update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@703018 13f79535-47bb-0310-9956-ffa450edef68

17 years agoExpose all socket settings available for the JIO connector, buffer size can make...
fhanik [Wed, 8 Oct 2008 23:28:51 +0000 (23:28 +0000)]
Expose all socket settings available for the JIO connector, buffer size can make large differences, but they are hidden
Make settings consistent with those for the NIO connector, so switching between Java connectors is seamless

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@703017 13f79535-47bb-0310-9956-ffa450edef68

17 years agoproperly cleanup socket object, since we have the ability to chache Http11Processor...
fhanik [Wed, 8 Oct 2008 01:03:02 +0000 (01:03 +0000)]
properly cleanup socket object, since we have the ability to chache Http11Processor objects the processor must remove its reference to the socket, since sockets contain buffers (especially SSL sockets) and it could be considered a semi mem leak

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702676 13f79535-47bb-0310-9956-ffa450edef68

17 years agoBetter fix for 45636
markt [Tue, 7 Oct 2008 20:54:47 +0000 (20:54 +0000)]
Better fix for 45636

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702632 13f79535-47bb-0310-9956-ffa450edef68

17 years agoRevert patch - it caused a regression. Correct patch to follow.
markt [Tue, 7 Oct 2008 20:48:45 +0000 (20:48 +0000)]
Revert patch - it caused a regression. Correct patch to follow.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702628 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix comment typo
markt [Tue, 7 Oct 2008 19:26:30 +0000 (19:26 +0000)]
Fix comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702595 13f79535-47bb-0310-9956-ffa450edef68

17 years agoEG confirmed that attribute values should be fully escaped, including any EL. Note...
markt [Tue, 7 Oct 2008 19:10:51 +0000 (19:10 +0000)]
EG confirmed that attribute values should be fully escaped, including any EL. Note this does not fix bug 45451.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702587 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45951
markt [Mon, 6 Oct 2008 18:25:55 +0000 (18:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45951
Based on jfclere's patch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702219 13f79535-47bb-0310-9956-ffa450edef68

17 years agoHandle nested contexts when foo#bar.xml exists
markt [Mon, 6 Oct 2008 17:30:44 +0000 (17:30 +0000)]
Handle nested contexts when foo#bar.xml exists
Bug reported on users list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@702208 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd support for full client-cert chains to AJP
billbarker [Sun, 5 Oct 2008 23:43:00 +0000 (23:43 +0000)]
Add support for full client-cert chains to AJP

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@701902 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix regression in previous fix for https://issues.apache.org/bugzilla/show_bug.cgi...
markt [Fri, 3 Oct 2008 16:19:01 +0000 (16:19 +0000)]
Fix regression in previous fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=43656
Patch provided by Nils Eckert.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@701432 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45940
markt [Fri, 3 Oct 2008 12:15:53 +0000 (12:15 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45940
typo user->username

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@701362 13f79535-47bb-0310-9956-ffa450edef68

17 years agoBetter fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
markt [Fri, 3 Oct 2008 12:09:16 +0000 (12:09 +0000)]
Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
With this patch, the allowLinking flag applies to all web application resources. It is very slightly slower. On my machine with allowLinking=false, the change to line 899 increases the time from ~7 microseconds to create the file to ~70 microseconds to create and validate the file. As far as I can tell, this change is only going to affect context start times. If directory listings are enabled in the default servlet, they will also be slightly slower but they were horribly slow to start with.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@701358 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45933
markt [Fri, 3 Oct 2008 11:53:28 +0000 (11:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45933
Don't use parser from web-app for tld files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@701355 13f79535-47bb-0310-9956-ffa450edef68

17 years agoRevert this patch whilst I figure out why it breaks class loading.
markt [Thu, 2 Oct 2008 11:47:46 +0000 (11:47 +0000)]
Revert this patch whilst I figure out why it breaks class loading.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@701091 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
markt [Wed, 1 Oct 2008 14:23:09 +0000 (14:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
When listing the resources for a collection, don't include invalid resources, particularly linked resources when allowLinking=false

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700784 13f79535-47bb-0310-9956-ffa450edef68

17 years agoUpdate javadoc. Add a todo reminder.
markt [Wed, 1 Oct 2008 10:54:34 +0000 (10:54 +0000)]
Update javadoc. Add a todo reminder.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700735 13f79535-47bb-0310-9956-ffa450edef68

17 years agoMove JmxRemote to extras. Fix Tomcat hang on shutdown. Improve logging. Update the...
markt [Wed, 1 Oct 2008 10:47:41 +0000 (10:47 +0000)]
Move JmxRemote to extras. Fix Tomcat hang on shutdown. Improve logging. Update the docs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700734 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix some issues discovered when using this with PuTTY.
markt [Wed, 1 Oct 2008 00:38:00 +0000 (00:38 +0000)]
Fix some issues discovered when using this with PuTTY.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700645 13f79535-47bb-0310-9956-ffa450edef68

17 years agoCorrect valve name in javadoc
markt [Tue, 30 Sep 2008 21:18:45 +0000 (21:18 +0000)]
Correct valve name in javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700580 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix some more Find Bugs nags in the CGIServlet. Minor functional changes.
markt [Tue, 30 Sep 2008 17:28:12 +0000 (17:28 +0000)]
Fix some more Find Bugs nags in the CGIServlet. Minor functional changes.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700532 13f79535-47bb-0310-9956-ffa450edef68

17 years agoCode clean up. Use generics. Remove used code and a couple of other Find Bugs issues.
markt [Tue, 30 Sep 2008 17:10:48 +0000 (17:10 +0000)]
Code clean up. Use generics. Remove used code and a couple of other Find Bugs issues.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700526 13f79535-47bb-0310-9956-ffa450edef68

17 years agoRemove the deprecated DateTool and some other (all bar one) deprecated methods that...
markt [Mon, 29 Sep 2008 16:26:29 +0000 (16:26 +0000)]
Remove the deprecated DateTool and some other (all bar one) deprecated methods that depended on it. Update SSI and ServerCookie to use local formats in a thread safe way.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700167 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45906
markt [Mon, 29 Sep 2008 13:24:36 +0000 (13:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45906
Improve ResourceAttributes ETag handling.
Patch provided by Chris Hubick

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@700125 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix date format issue reported by Find Bugs.
markt [Sat, 27 Sep 2008 18:34:06 +0000 (18:34 +0000)]
Fix date format issue reported by Find Bugs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699714 13f79535-47bb-0310-9956-ffa450edef68

17 years agoRemove unused code reported by Find Bugs / Eclipse. No functional change.
markt [Sat, 27 Sep 2008 18:32:56 +0000 (18:32 +0000)]
Remove unused code reported by Find Bugs / Eclipse. No functional change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699713 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix string comp bugs reported by Find Bugs
markt [Sat, 27 Sep 2008 13:45:27 +0000 (13:45 +0000)]
Fix string comp bugs reported by Find Bugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699646 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix cast error reported by Find Bugs
markt [Sat, 27 Sep 2008 13:42:43 +0000 (13:42 +0000)]
Fix cast error reported by Find Bugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699645 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix signed/unsigned conversion reported by Find Bugs
markt [Sat, 27 Sep 2008 13:41:53 +0000 (13:41 +0000)]
Fix signed/unsigned conversion reported by Find Bugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699644 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix HTML decoding bug reported by Find Bugs
markt [Sat, 27 Sep 2008 13:12:07 +0000 (13:12 +0000)]
Fix HTML decoding bug reported by Find Bugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699635 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix minor memory leak found by find bugs.
markt [Sat, 27 Sep 2008 13:10:29 +0000 (13:10 +0000)]
Fix minor memory leak found by find bugs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699634 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix serialisation issues reported by find bugs
markt [Sat, 27 Sep 2008 13:09:48 +0000 (13:09 +0000)]
Fix serialisation issues reported by find bugs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699633 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd a new listener that enables the JMX ports to be fixed. This makes using jconsole...
markt [Fri, 26 Sep 2008 22:20:51 +0000 (22:20 +0000)]
Add a new listener that enables the JMX ports to be fixed. This makes using jconsole etc through a firewall / SSH tunnel etc. a lot easier. As a bonus, the config docs include all the current listeners as well.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699523 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45851
markt [Fri, 26 Sep 2008 17:37:34 +0000 (17:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45851
Correct NPE when cluster is defined at engine level
Ensure that only 1 thread writes the replicated WAR to disk and that the messages containing the WAR are processed in the correct order.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699427 13f79535-47bb-0310-9956-ffa450edef68

17 years agoCode clean up in o.a.c.h.deploy
markt [Fri, 26 Sep 2008 12:20:03 +0000 (12:20 +0000)]
Code clean up in o.a.c.h.deploy
No functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699296 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAllow the maximum allowed size of a resource that is cached to be configured. The...
markt [Fri, 26 Sep 2008 11:56:42 +0000 (11:56 +0000)]
Allow the maximum allowed size of a resource that is cached to be configured. The default of cacheMaxSize/20 gave too high a value for large caches.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699287 13f79535-47bb-0310-9956-ffa450edef68

17 years agoPartial fix for 45878. If we are happy with this approach for the spec JARs, extend...
markt [Thu, 25 Sep 2008 23:20:48 +0000 (23:20 +0000)]
Partial fix for 45878. If we are happy with this approach for the spec JARs, extend it to the remaining Tomcat JARs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699128 13f79535-47bb-0310-9956-ffa450edef68

17 years agoUpdate default year
markt [Thu, 25 Sep 2008 23:00:57 +0000 (23:00 +0000)]
Update default year

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699126 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd NOTICE file to uninstall section.
markt [Thu, 25 Sep 2008 11:07:44 +0000 (11:07 +0000)]
Add NOTICE file to uninstall section.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698925 13f79535-47bb-0310-9956-ffa450edef68

17 years agoUse lastest tc-native version.
jfclere [Thu, 25 Sep 2008 09:29:23 +0000 (09:29 +0000)]
Use lastest tc-native version.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698892 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45879
markt [Wed, 24 Sep 2008 16:21:25 +0000 (16:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45879
Move the NOTICE file to the install dir

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698629 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=45852
markt [Wed, 24 Sep 2008 15:47:40 +0000 (15:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45852
Add special handling a for charset that Java uses a non-default name for

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698613 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd new LockOut Realm plus docs
markt [Tue, 23 Sep 2008 16:49:25 +0000 (16:49 +0000)]
Add new LockOut Realm plus docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698236 13f79535-47bb-0310-9956-ffa450edef68

17 years agoNow containers can have multiple realms, need to make sure we don't get duplicate...
markt [Tue, 23 Sep 2008 16:35:42 +0000 (16:35 +0000)]
Now containers can have multiple realms, need to make sure we don't get duplicate names for the realms in jmx.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698227 13f79535-47bb-0310-9956-ffa450edef68

17 years agoThere is no admin app in tc6.
markt [Mon, 22 Sep 2008 21:55:50 +0000 (21:55 +0000)]
There is no admin app in tc6.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@698012 13f79535-47bb-0310-9956-ffa450edef68

17 years agoImprove Active Directory compatibility of the JNDIRealm.
rjung [Fri, 19 Sep 2008 21:23:22 +0000 (21:23 +0000)]
Improve Active Directory compatibility of the JNDIRealm.

AD often returns referrals and when iterating through
NamingEnumerations those produce PartialResultsException
we need to ignore. Since there is no robust way of detecting
whether they are actually thrown because of AD referrals,
we keep the handling configurable.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@697248 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd an optional and configurable default role to the JNDIRealm.
rjung [Fri, 19 Sep 2008 19:51:59 +0000 (19:51 +0000)]
Add an optional and configurable default role to the JNDIRealm.
This comes handy, if you only want to authenticate the users,
but have a security constraint with a role in the app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@697213 13f79535-47bb-0310-9956-ffa450edef68

17 years agoPort r486217, which was applied to connectors, but has
rjung [Fri, 19 Sep 2008 19:12:59 +0000 (19:12 +0000)]
Port r486217, which was applied to connectors, but has
never been applied to 6.0 and trunk.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@697192 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd Mark's proposed fix for BZ 45026:
rjung [Fri, 19 Sep 2008 18:51:14 +0000 (18:51 +0000)]
Add Mark's proposed fix for BZ 45026:
mod_jk + httpd 2.x fails with a null status message.

Although the problem has been fixed in future httpd and mod_jk
versions, we should also stay safe on the backend side.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@697183 13f79535-47bb-0310-9956-ffa450edef68

17 years agoCorrect wrong "No role found" realm debug logging,
rjung [Fri, 19 Sep 2008 17:33:22 +0000 (17:33 +0000)]
Correct wrong "No role found" realm debug logging,
even if a role was found.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@697158 13f79535-47bb-0310-9956-ffa450edef68

17 years agoMore Spanish translations
markt [Thu, 18 Sep 2008 21:18:41 +0000 (21:18 +0000)]
More Spanish translations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@696810 13f79535-47bb-0310-9956-ffa450edef68

17 years agoUpdate auto generated files as a result of ELParser.jjt change
markt [Thu, 18 Sep 2008 19:53:24 +0000 (19:53 +0000)]
Update auto generated files as a result of ELParser.jjt change
I have not re-instated the AL2 header in the auto-generated files. On reflection I don't think it makes sense for auto-generated files and the file they are generated from has the AL2 header. It also makes re-generating the files simpler.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@696782 13f79535-47bb-0310-9956-ffa450edef68

17 years agoAdd explicit lookaheads where they could be ambiguity. This resolves some TCK failure...
markt [Thu, 18 Sep 2008 19:42:54 +0000 (19:42 +0000)]
Add explicit lookaheads where they could be ambiguity. This resolves some TCK failures with the fix for 42565.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@696780 13f79535-47bb-0310-9956-ffa450edef68

17 years agoFix ClassCastException when we try to cast a
rjung [Thu, 18 Sep 2008 17:08:10 +0000 (17:08 +0000)]
Fix ClassCastException when we try to cast a

NullPointerException to an ELException.
I still need to investigate where the NPE came from,
but simply casting seems unsafe in any case.

Use a cast if possible and recreate exception
otherwise.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@696716 13f79535-47bb-0310-9956-ffa450edef68