tomcat7.0
15 years agocorrect download location
fhanik [Thu, 25 Feb 2010 19:34:55 +0000 (19:34 +0000)]
correct download location

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916417 13f79535-47bb-0310-9956-ffa450edef68

15 years agoupgrade location and version of H2, this location should not change as frequently
fhanik [Thu, 25 Feb 2010 17:21:10 +0000 (17:21 +0000)]
upgrade location and version of H2, this location should not change as frequently

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916361 13f79535-47bb-0310-9956-ffa450edef68

15 years agocorrect a typo
kkolinko [Thu, 25 Feb 2010 09:32:08 +0000 (09:32 +0000)]
correct a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916196 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCorrect the number
kkolinko [Thu, 25 Feb 2010 08:06:19 +0000 (08:06 +0000)]
Correct the number

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916170 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprovements for JspC:
kkolinko [Thu, 25 Feb 2010 07:03:14 +0000 (07:03 +0000)]
Improvements for JspC:
- allow the encoding used for web.xml files to be specified explicitly,
- allow the addWebXmlMappings option to be specified on the command line

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916157 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused public methods
kkolinko [Thu, 25 Feb 2010 06:08:58 +0000 (06:08 +0000)]
Remove unused public methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916143 13f79535-47bb-0310-9956-ffa450edef68

15 years agoupdated the JavaDoc
kkolinko [Thu, 25 Feb 2010 06:05:55 +0000 (06:05 +0000)]
updated the JavaDoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916141 13f79535-47bb-0310-9956-ffa450edef68

15 years agofix for #mergeIntoWebXml()
kkolinko [Thu, 25 Feb 2010 02:58:25 +0000 (02:58 +0000)]
fix for #mergeIntoWebXml()
Note that the "inserted" flag was never set to true in the old code.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@916097 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=48392
fhanik [Wed, 24 Feb 2010 19:27:09 +0000 (19:27 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=48392
Add an interceptor to be able to wrap existing statements and result sets to prevent code from accessing the connection
Patch submitted by gsfernandes@gmail.com

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915940 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMoved utils to connector ( the servlet part will either go away or be a separate...
costin [Wed, 24 Feb 2010 18:03:00 +0000 (18:03 +0000)]
Moved utils to connector ( the servlet part will either go away or be a separate package ). Make it compile again on android. Few sync
issues found while load testing. SSL fixes. Separate build target for connector.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915902 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix thrown accept error on shutdown
mturk [Wed, 24 Feb 2010 16:49:19 +0000 (16:49 +0000)]
Fix thrown accept error on shutdown

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915861 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd remark about reliability of System.gc() to
rjung [Wed, 24 Feb 2010 11:35:58 +0000 (11:35 +0000)]
Add remark about reliability of System.gc() to
manager diagnostics docs.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915757 13f79535-47bb-0310-9956-ffa450edef68

15 years agofixes for #getElement():
kkolinko [Wed, 24 Feb 2010 10:12:58 +0000 (10:12 +0000)]
fixes for #getElement():
- avoid infinite looping on unexpected end of file
- fix XML comment reading

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915737 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate version of native bundled in distributives to 1.1.20.
kkolinko [Tue, 23 Feb 2010 07:36:05 +0000 (07:36 +0000)]
Update version of native bundled in distributives to 1.1.20.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915226 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove comment. jvmRoute replacement happens elsewhere
markt [Mon, 22 Feb 2010 21:45:35 +0000 (21:45 +0000)]
Remove comment. jvmRoute replacement happens elsewhere

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915076 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove comment - odds of session duplication are so small to be insignificant
markt [Mon, 22 Feb 2010 21:44:43 +0000 (21:44 +0000)]
Remove comment - odds of session duplication are so small to be insignificant

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915075 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48783
markt [Mon, 22 Feb 2010 21:21:06 +0000 (21:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48783
Correct defaults

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915072 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIn some drivers, the call to setTransactionIsolation should be the very first call
fhanik [Fri, 19 Feb 2010 23:02:49 +0000 (23:02 +0000)]
In some drivers, the call to setTransactionIsolation should be the very first call

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@912026 13f79535-47bb-0310-9956-ffa450edef68

15 years agoComment typo
markt [Thu, 18 Feb 2010 21:35:48 +0000 (21:35 +0000)]
Comment typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@911601 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake sure we favor the values from AjpMessage.processHeader. If the signature is...
mturk [Thu, 18 Feb 2010 16:44:57 +0000 (16:44 +0000)]
Make sure we favor the values from AjpMessage.processHeader. If the signature is invalid len can be any random number in that case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@911481 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore (minor) lifecycle clean-up
markt [Wed, 17 Feb 2010 13:53:08 +0000 (13:53 +0000)]
More (minor) lifecycle clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910975 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove logging behaviour when shutdown occurs via a shutdownhook. If present, use...
markt [Wed, 17 Feb 2010 13:51:37 +0000 (13:51 +0000)]
Improve logging behaviour when shutdown occurs via a shutdownhook. If present, use Catalina's shutdown hook to shutdown Tomcat and JULI. This enables them to be shutdown in the correct order.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910974 13f79535-47bb-0310-9956-ffa450edef68

15 years agoHold off on update until archive syncs (should be no more than 24 hrs)
markt [Wed, 17 Feb 2010 13:44:28 +0000 (13:44 +0000)]
Hold off on update until archive syncs (should be no more than 24 hrs)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910969 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to latest native connector
markt [Wed, 17 Feb 2010 12:28:13 +0000 (12:28 +0000)]
Update to latest native connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910947 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore lifecycle clean-up
markt [Wed, 17 Feb 2010 09:38:07 +0000 (09:38 +0000)]
More lifecycle clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910883 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused imports
markt [Wed, 17 Feb 2010 09:21:30 +0000 (09:21 +0000)]
Remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910879 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd Lifecycle to Container, Server and Service
markt [Wed, 17 Feb 2010 09:20:59 +0000 (09:20 +0000)]
Add Lifecycle to Container, Server and Service
Remove casts instanceof tests and any other code this makes unnecessary

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910877 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProvide slightly more efficient implementations for ScopeMap.size() and ScopeMap...
kkolinko [Wed, 17 Feb 2010 02:26:41 +0000 (02:26 +0000)]
Provide slightly more efficient implementations for ScopeMap.size() and ScopeMap.containsKey().

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910803 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix a bug in ImplicitObjectELResolver.ScopeMap intruduced when applying generics...
kkolinko [Wed, 17 Feb 2010 01:52:41 +0000 (01:52 +0000)]
Fix a bug in ImplicitObjectELResolver.ScopeMap intruduced when applying generics there:
the get(String) and remove(String) methods were not overwriting the ones of AbstractMap,
because those are declared as get(Object) and remove(Object),
thus using ineffective implementations provided by AbstractMap.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910796 13f79535-47bb-0310-9956-ffa450edef68

15 years agoApply my patch from https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c20
kkolinko [Wed, 17 Feb 2010 01:10:34 +0000 (01:10 +0000)]
Apply my patch from https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c20
This patch
- Reverts r905145,
- Provides an alternative fix for bug 48616 and bug 42390,
- Replaces Vector -> List, Hashtable -> HashMap in the affected API.

JspFragments are scriptless, so no need to declare or sync scripting
variables for fragments. Since errors in syncing the scripting variables for
JSP Fragments caused 48616 & 42390, this fixes both these bugs too.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910792 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert r904914. https://issues.apache.org/bugzilla/show_bug.cgi?id=48629
markt [Tue, 16 Feb 2010 21:15:21 +0000 (21:15 +0000)]
Revert r904914. https://issues.apache.org/bugzilla/show_bug.cgi?id=48629
 now proposes a better solution

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910695 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIf the memory leak occured in the ROOT application, display "/" instead on an empty...
kkolinko [Tue, 16 Feb 2010 17:29:57 +0000 (17:29 +0000)]
If the memory leak occured in the ROOT application, display "/" instead on an empty line

It might be better to apply this fix to StandardHost.findReloadedContextMemoryLeaks(),
as it is equally hard to see an empty string when calling this method through JConsole,
but I am not sure that I want to introduce irregularity into the API.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910612 13f79535-47bb-0310-9956-ffa450edef68

15 years agoManifest improvements
markt [Tue, 16 Feb 2010 17:23:23 +0000 (17:23 +0000)]
Manifest improvements
- automate copyright year
- add manifests for el & annotations
- improve default NOTICE
- add info to bootstrap manifest

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910604 13f79535-47bb-0310-9956-ffa450edef68

15 years agocorrect a misprint
kkolinko [Tue, 16 Feb 2010 16:34:10 +0000 (16:34 +0000)]
correct a misprint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910584 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48589
markt [Tue, 16 Feb 2010 11:40:55 +0000 (11:40 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48589
Make JNDIRealm easier to extend by making the User class protected
Based on a patch by Candid Dauth

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910485 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48582
markt [Tue, 16 Feb 2010 11:07:00 +0000 (11:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48582
Avoid NPE as config may be null but ctxt won't be

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910471 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48580
markt [Tue, 16 Feb 2010 09:27:49 +0000 (09:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48580
Prevent AccessControlException if first access is to a JSP that uses a FunctionMapper

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910442 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional test for BZ 48616
kkolinko [Tue, 16 Feb 2010 04:52:38 +0000 (04:52 +0000)]
Additional test for BZ 48616

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910395 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWorkaround Java 6/7 bug described in https://issues.apache.org/bugzilla/show_bug...
markt [Tue, 16 Feb 2010 00:46:07 +0000 (00:46 +0000)]
Workaround Java 6/7 bug described in https://issues.apache.org/bugzilla/show_bug.cgi?id=48498
Avoid the ArrayIndexOutOfBoundsException

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910370 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48545
markt [Mon, 15 Feb 2010 17:14:27 +0000 (17:14 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48545
Truststores don't have to have passwords
Based on a patch by 'smmwpf54'

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910266 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSpacing
markt [Mon, 15 Feb 2010 08:09:39 +0000 (08:09 +0000)]
Spacing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910172 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to dbcp 1.4 release that supports JDBC4 and compiles on Java 6
markt [Mon, 15 Feb 2010 08:09:05 +0000 (08:09 +0000)]
Update to dbcp 1.4 release that supports JDBC4 and compiles on Java 6

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910171 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse the Context interface rather than StandardEngine
markt [Mon, 15 Feb 2010 00:06:05 +0000 (00:06 +0000)]
Use the Context interface rather than StandardEngine

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910134 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse the Context interface rather than StandardContext
markt [Sun, 14 Feb 2010 23:54:52 +0000 (23:54 +0000)]
Use the Context interface rather than StandardContext

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910125 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse interfaces in o.a.c.startup.Tomcat and update tests as appropriate
markt [Sun, 14 Feb 2010 23:45:18 +0000 (23:45 +0000)]
Use interfaces in o.a.c.startup.Tomcat and update tests as appropriate

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910123 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd missing test
markt [Sun, 14 Feb 2010 23:44:20 +0000 (23:44 +0000)]
Add missing test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@910122 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48384
markt [Sat, 13 Feb 2010 20:12:11 +0000 (20:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48384
Add a per context xslt option for directory listings
Make the fallback options work as described in the docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909887 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAddress review comments
markt [Sat, 13 Feb 2010 19:22:02 +0000 (19:22 +0000)]
Address review comments
Don't use toString() to try and co-erce any old object to an Enum - the spec only mentions String

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909875 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48371
markt [Sat, 13 Feb 2010 18:25:07 +0000 (18:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48371
Skip comments when working out where to insert generated servlets and associated mappings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909869 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavaDoc correction
kkolinko [Sat, 13 Feb 2010 18:14:32 +0000 (18:14 +0000)]
JavaDoc correction

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909866 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavaDoc correction
kkolinko [Sat, 13 Feb 2010 18:04:52 +0000 (18:04 +0000)]
JavaDoc correction

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909865 13f79535-47bb-0310-9956-ffa450edef68

15 years agoreverted Filip's r909673
kkolinko [Sat, 13 Feb 2010 16:37:49 +0000 (16:37 +0000)]
reverted Filip's r909673

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909845 13f79535-47bb-0310-9956-ffa450edef68

15 years agoChange a few variable names to reduce potential confusion - no functional change
markt [Sat, 13 Feb 2010 11:02:23 +0000 (11:02 +0000)]
Change a few variable names to reduce potential confusion - no functional change

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909789 13f79535-47bb-0310-9956-ffa450edef68

15 years agofix compilation error
fhanik [Sat, 13 Feb 2010 00:51:47 +0000 (00:51 +0000)]
fix compilation error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909673 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48318
markt [Fri, 12 Feb 2010 22:12:48 +0000 (22:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48318
Handle case where WebDAV resource is in directory listing but is not accessible

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909636 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate for new Eclipse lib
markt [Fri, 12 Feb 2010 21:34:20 +0000 (21:34 +0000)]
Update for new Eclipse lib
Align with new trunk build script

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909613 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd listener before child is added else listener won't get called on first load
markt [Fri, 12 Feb 2010 19:15:32 +0000 (19:15 +0000)]
Add listener before child is added else listener won't get called on first load

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909563 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDocument new findleaks command
markt [Fri, 12 Feb 2010 18:03:48 +0000 (18:03 +0000)]
Document new findleaks command

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909542 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a find leaks option - with a suitable warning to the manager app (html & text)
markt [Fri, 12 Feb 2010 17:51:06 +0000 (17:51 +0000)]
Add a find leaks option - with a suitable warning to the manager app (html & text)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909528 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake class loader registration more robust
markt [Fri, 12 Feb 2010 17:50:22 +0000 (17:50 +0000)]
Make class loader registration more robust

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909526 13f79535-47bb-0310-9956-ffa450edef68

15 years agoLooks like the ResourceBundle leaks are triggered by a GC bug - only seems to affect...
markt [Fri, 12 Feb 2010 17:49:49 +0000 (17:49 +0000)]
Looks like the ResourceBundle leaks are triggered by a GC bug - only seems to affect Sun JVMs.
The fix is also Sun specific so only log a debug message if the internal field can't be found on a non-Sun JVM (it isn't there for IBM for example)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909525 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove quotes from example - they break it
markt [Fri, 12 Feb 2010 09:58:13 +0000 (09:58 +0000)]
Remove quotes from example - they break it

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909321 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWhen the key is null (i.e., a stale entry), it cannot be removed with an explicit...
kkolinko [Fri, 12 Feb 2010 03:19:31 +0000 (03:19 +0000)]
When the key is null (i.e., a stale entry), it cannot be removed with an explicit remove(key) call: you'll get an NPE. Those can be removed with expungeStaleEntries() call.
Also, simplified the code: Reference.referent can be accessed by calling get() - no need to use reflection for that.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909212 13f79535-47bb-0310-9956-ffa450edef68

15 years agofollowup to r908002
kkolinko [Fri, 12 Feb 2010 02:22:23 +0000 (02:22 +0000)]
followup to r908002
Use the debug message (added in r908002) for debug output

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909206 13f79535-47bb-0310-9956-ffa450edef68

15 years agofollowup to r909134:
kkolinko [Fri, 12 Feb 2010 02:01:41 +0000 (02:01 +0000)]
followup to r909134:
correct a misprint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909204 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd rudimentary detection for PermGen memory leaks on web application reload. Only...
markt [Thu, 11 Feb 2010 20:32:09 +0000 (20:32 +0000)]
Add rudimentary detection for PermGen memory leaks on web application reload. Only available via JMX for now. Next step is to add it to the manager app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909134 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImproved memory leak prevention for resource ResourceBundle
markt [Thu, 11 Feb 2010 18:09:08 +0000 (18:09 +0000)]
Improved memory leak prevention for resource ResourceBundle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909097 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert simple ResourceBundle fix
markt [Thu, 11 Feb 2010 16:55:26 +0000 (16:55 +0000)]
Revert simple ResourceBundle fix
On reflection (no pun intended) a reflection based will be better since
- it can be implemented at a single point
- it can easily be ported to Tomcat 6
- it will be able to handle any exotic class loader structures created by apps

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909072 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore memory leak prevention - ResourceBundle
markt [Thu, 11 Feb 2010 15:14:55 +0000 (15:14 +0000)]
More memory leak prevention - ResourceBundle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@909017 13f79535-47bb-0310-9956-ffa450edef68

15 years agoConvert my ApacheCon securing Tomcat presentation to a how to
markt [Thu, 11 Feb 2010 13:17:05 +0000 (13:17 +0000)]
Convert my ApacheCon securing Tomcat presentation to a how to

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908955 13f79535-47bb-0310-9956-ffa450edef68

15 years agoThis is no longer security related as unsafe usage is blocked
markt [Thu, 11 Feb 2010 12:23:36 +0000 (12:23 +0000)]
This is no longer security related as unsafe usage is blocked

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908942 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48726
markt [Wed, 10 Feb 2010 23:47:11 +0000 (23:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48726
Prevent OOME when uploading large files with the deployer
Patch provided by 'adam'

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908759 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48716
markt [Wed, 10 Feb 2010 23:36:51 +0000 (23:36 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48716
Provide an undocumented 'shoot yourself in the foot' option to disable the JULI logging reset

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908754 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate logging docs
markt [Wed, 10 Feb 2010 22:55:58 +0000 (22:55 +0000)]
Update logging docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908721 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPart of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 that is...
markt [Wed, 10 Feb 2010 22:41:55 +0000 (22:41 +0000)]
Part of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 that is not in trunk

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908701 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAnother copy/paste error
markt [Wed, 10 Feb 2010 22:40:14 +0000 (22:40 +0000)]
Another copy/paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908697 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean-up
markt [Wed, 10 Feb 2010 22:39:35 +0000 (22:39 +0000)]
Clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908696 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavadoc police
markt [Wed, 10 Feb 2010 19:37:13 +0000 (19:37 +0000)]
Javadoc police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908645 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprovements for building jasper-jdt.jar:
kkolinko [Wed, 10 Feb 2010 13:10:51 +0000 (13:10 +0000)]
Improvements for building jasper-jdt.jar:
- Rebuild jasper-jdt.jar if jdt.jar was updated or redownloaded, or the build file was updated
- Purge target directory before unjarring, to avoid repacking stale files
- Clean unjarred files after the build as they are not needed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908484 13f79535-47bb-0310-9956-ffa450edef68

15 years ago- Update JDT compiler to version 3.5.1
kkolinko [Wed, 10 Feb 2010 00:50:40 +0000 (00:50 +0000)]
- Update JDT compiler to version 3.5.1
- Use JDT Core Batch Compiler download instead of JDT SDK download. It lessens the download size from 40 MB down to 1.6 MB.
- Implement support for two alternative download locations of a file.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908300 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to latest version of JDT compiler
markt [Tue, 9 Feb 2010 11:51:30 +0000 (11:51 +0000)]
Update to latest version of JDT compiler

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908009 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIf the ThreadLocal is set to null, there won't be a memory leak but GC is required...
markt [Tue, 9 Feb 2010 11:17:05 +0000 (11:17 +0000)]
If the ThreadLocal is set to null, there won't be a memory leak but GC is required to clean up the keys. Continue to remove the keys if found to reduce the volume of data that has to be looked at when tracing memory leaks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908002 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSplit out the download target so only dependencies for the current target are downloa...
markt [Tue, 9 Feb 2010 10:24:37 +0000 (10:24 +0000)]
Split out the download target so only dependencies for the current target are downloaded rather than everything
Move the bayeux download to the bayeux build file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907991 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSpeed up a clean build slightly and provide Eclipse with a permanent location for...
markt [Tue, 9 Feb 2010 09:25:35 +0000 (09:25 +0000)]
Speed up a clean build slightly and provide Eclipse with a permanent location for the web services libraries

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907983 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix parsing bug spotted when reviewing r907538
kkolinko [Tue, 9 Feb 2010 01:06:01 +0000 (01:06 +0000)]
Fix parsing bug spotted when reviewing r907538
Allowing #{} expressions to be parsed even when they are disabled breaks ${} expressions if they are intermixed with them. See the testcase added in r907860, r907862.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907864 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional test from review of r907538
kkolinko [Tue, 9 Feb 2010 01:02:12 +0000 (01:02 +0000)]
Additional test from review of r907538

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907862 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdditional test from review of r907538
kkolinko [Tue, 9 Feb 2010 01:01:23 +0000 (01:01 +0000)]
Additional test from review of r907538

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907860 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170
markt [Mon, 8 Feb 2010 22:20:55 +0000 (22:20 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170
Remove unnecessary syncs that cause issues under heavy load

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907825 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTab police and line length
markt [Mon, 8 Feb 2010 22:15:36 +0000 (22:15 +0000)]
Tab police and line length

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907824 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48109
markt [Mon, 8 Feb 2010 22:07:24 +0000 (22:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48109
Extent try catch block (diff is a lot simpler if you ignore whitespace) to ensure InputStream is closed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907819 13f79535-47bb-0310-9956-ffa450edef68

15 years agoLog when a valid shutdown command is received. This may help in tracking down "Tomcat...
markt [Mon, 8 Feb 2010 19:29:53 +0000 (19:29 +0000)]
Log when a valid shutdown command is received. This may help in tracking down "Tomcat just stops" style reports.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907768 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAllow the global naming context to be reset. Useful when running multiple embedded...
markt [Mon, 8 Feb 2010 17:07:28 +0000 (17:07 +0000)]
Allow the global naming context to be reset. Useful when running multiple embedded instances in series since it allows each instance to configure its own global naming context.
Doesn't help with multiple instances in parallel - but that was broken anyway.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907727 13f79535-47bb-0310-9956-ffa450edef68

15 years agoGet logic right way around
markt [Mon, 8 Feb 2010 16:47:47 +0000 (16:47 +0000)]
Get logic right way around

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907721 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAvoid adding the package twice
markt [Mon, 8 Feb 2010 16:45:08 +0000 (16:45 +0000)]
Avoid adding the package twice

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907720 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEnsure appBase is valid. Prevents spurious stacktraces in tests
markt [Mon, 8 Feb 2010 16:25:13 +0000 (16:25 +0000)]
Ensure appBase is valid. Prevents spurious stacktraces in tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907717 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake the tesst easier to debug
markt [Mon, 8 Feb 2010 16:13:21 +0000 (16:13 +0000)]
Make the tesst easier to debug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907713 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore memory leak protection on reload.
markt [Mon, 8 Feb 2010 13:29:13 +0000 (13:29 +0000)]
More memory leak protection on reload.
Use of java.util.Timer

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907652 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProtect against NPE whilst running the test
markt [Mon, 8 Feb 2010 13:27:45 +0000 (13:27 +0000)]
Protect against NPE whilst running the test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907651 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd a test case for TimerThread thread/memory leaks on reload as I have some ideas...
markt [Mon, 8 Feb 2010 12:57:08 +0000 (12:57 +0000)]
Add a test case for TimerThread thread/memory leaks on reload as I have some ideas on how to safely terminate those threads

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907646 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48660
markt [Mon, 8 Feb 2010 02:27:43 +0000 (02:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48660
Compression should add to Vary header rather than over-write it

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@907544 13f79535-47bb-0310-9956-ffa450edef68