git.internetallee.de Git

markt [Fri, 5 Nov 2010 18:38:23 +0000 (18:38 +0000)]

Parallel deployment
Additional Context.get[Name|Path]() clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031706 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 5 Nov 2010 18:17:56 +0000 (18:17 +0000)]

Parallel deployment
Additional Context.get[Name|Path]() clean up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031690 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Fri, 5 Nov 2010 17:59:51 +0000 (17:59 +0000)]

Remove unused method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031683 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

pero [Fri, 5 Nov 2010 15:50:51 +0000 (15:50 +0000)]

Make attribute enabled changeable via JMX at AccessLogValve

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031643 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 5 Nov 2010 12:27:49 +0000 (12:27 +0000)]

BZ50219: Fix typo in jndi-resources-howto.xml.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031535 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 23:03:26 +0000 (23:03 +0000)]

https://issues.apache.org/bugzilla/show_bug.cgi?id=50168
Add a DESTROYING state and associated events and use them to ensure Contexts are only destroyed once.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031335 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 19:58:43 +0000 (19:58 +0000)]

Use the local copy of the docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031196 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 19:53:15 +0000 (19:53 +0000)]

Typos.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031194 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 19:51:30 +0000 (19:51 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50127
Also fix all the other Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031190 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 17:59:20 +0000 (17:59 +0000)]

https://issues.apache.org/bugzilla/show_bug.cgi?id=50159
Add a new attribute for <Resource> elements, singleton that controls whether or not a new object is created every time a JNDI lookup is performed to obtain the resource. The default value is true, which will return the same instance of the resource in every JNDI lookup.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031112 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 17:42:41 +0000 (17:42 +0000)]

List bugs in numerical order

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031099 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

funkman [Thu, 4 Nov 2010 15:47:56 +0000 (15:47 +0000)]

Allow for configest

Now one may type in bin/configtest.sh and then check the
exit code.

This will try to use the default loggers so it may spew
"a lot" to stdout/err so as to avoid clobbering existing
log files in use.

Potential future todo
- Making the parsing of server.xml more finicky as to avoid
bad values being ignored (example - use 'x8005' as the
shutdown port - and tomcat still starts up fine )

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1031043 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 4 Nov 2010 00:50:41 +0000 (00:50 +0000)]

Ensure embedded jars contain all the necessary classes
Re-order things so it is easier to check all are present

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030783 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 3 Nov 2010 12:19:46 +0000 (12:19 +0000)]

Typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030433 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Wed, 3 Nov 2010 12:18:27 +0000 (12:18 +0000)]

Typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030431 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Tue, 2 Nov 2010 22:04:44 +0000 (22:04 +0000)]

Improve handling of nulls in StandardEngine.logAccess()

This takes care of the case when findChild(getDefaultHost()) returns null.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030253 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Tue, 2 Nov 2010 13:30:52 +0000 (13:30 +0000)]

Log the right JSP.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Tue, 2 Nov 2010 12:14:43 +0000 (12:14 +0000)]

Add logging and JMX support to JSP unloading.

Also need to make getContent() public in
FastRemovalDequeue to support logging.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030014 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Tue, 2 Nov 2010 10:57:26 +0000 (10:57 +0000)]

Fix some MBean descriptors:
- "asyncSupported" needs is="true" for Valves
- "containerName" is gone in valves since r940802
- "enabled" uses "get" instead of "is"

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1030000 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Tue, 2 Nov 2010 10:55:05 +0000 (10:55 +0000)]

Fix MBean description.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029999 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Tue, 2 Nov 2010 10:32:59 +0000 (10:32 +0000)]

The jspFile attribute is no longer available
in the StandardWrapper as of r1003589.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029996 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 1 Nov 2010 17:51:19 +0000 (17:51 +0000)]

Review comment from kkolinko
Make sure we initialize StandardEngine.accessLog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029767 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 1 Nov 2010 17:22:33 +0000 (17:22 +0000)]

Make Tomcat more tolerant of nulls when generating JMX names for Valves.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029755 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

funkman [Mon, 1 Nov 2010 15:53:22 +0000 (15:53 +0000)]

changelog update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029720 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

funkman [Mon, 1 Nov 2010 15:48:32 +0000 (15:48 +0000)]

bug 49180

Add option to disable log rotation in FileHandler
credit: Pid (pidster at apache )

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029719 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

funkman [Mon, 1 Nov 2010 15:30:48 +0000 (15:30 +0000)]

redesign of home page
by Pid (pidster at apache )

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029708 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 1 Nov 2010 11:26:00 +0000 (11:26 +0000)]

Parallel deployment
Fix regression that broke WAR deployments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029616 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 1 Nov 2010 02:04:53 +0000 (02:04 +0000)]

Parallel deployment
- More work separating Context.name & Context.path
- Review use of Context.getName() and Context.getPath() and use the correct one
- Start to add webappVersion property to Context (many components not version aware - e.g. Manager app)
- Set version when deploying apps if version is specified
- Include version in Context.name if version is specified
- New ContextName util class to handle all path/name/version etc translations

In most cases the behaviour is unchanged if the version is not specified. The one exception is JMX ObjectNames that used to contain a key value pair "path=...". Since context path is no longer unique when using versions, this has been changed to "context=..." and the context name used which is unique.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029527 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Sun, 31 Oct 2010 15:22:12 +0000 (15:22 +0000)]

Remove space char from the end of a line

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029380 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 31 Oct 2010 13:11:55 +0000 (13:11 +0000)]

Parallel deployment
Start to separate context.name and context.path
Currently name==path but eventually name may include a version element but path will not.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1029330 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 23:53:15 +0000 (23:53 +0000)]

Make sure, we mention the unit "seconds" for
jspIdleTimeout everywhere.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028950 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 23:34:37 +0000 (23:34 +0000)]

Document jspIdleTimeout.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028944 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 23:22:35 +0000 (23:22 +0000)]

Add new JSP init parameter "jspIdleTimeout".

If set > 0 (default -1), a background task
will unload all JSPs being idle longer than this
time in seconds.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028940 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 23:08:59 +0000 (23:08 +0000)]

We will no longer continuously update the jspQueue
order. Instead only update each JSP once between
background task runs.

Changes to JspRuntimeContext:
- Rename "ticket" to "unloadHandle"
- Rename "lastCheck" to "lastCompileCheck" to clarify purpose
- Add lastJspQueueUpdate which contains the time of
  the last run of checkUnload()
- Add getter for lastJspQueueUpdate
- Background task checkUnload() now only tracks the time
  of its last execution.

Changes to JspServletWrapper:
- Rename "ticket" to "unloadHandle"
- Replace options.getMaxLoadedJsps() with final field "unloadByCount"
- Do no longer move wrapper in jspQueue on each access.
  Only move once after each run of the background task checkUnload().

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028939 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 22:44:52 +0000 (22:44 +0000)]

Changes to FastRemovalDequeue:
- Make queue thread safe and remove external synchronisation
- Provide maximal size to queue
- Include size checking when adding entries
- Return handle to displaced entries when queue overflows
  while adding a new entry
- Explicitely invalidate queue entries on removal by using
  new field "valid"

Changes to JspRuntimeContext:
- Initialize FastRemovalDequeue with correct size
- No more external synchronisation for FastRemovalDequeue
- Private utility method to unload a wrapper
- Check for displaced wrapper when adding a new wrapper
  to the queue and unload it

Changes to JspServletWrapper:
- No more explicit overflow check for the queue. It's now
  done implicitely when adding to the queue.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028935 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 17:54:27 +0000 (17:54 +0000)]

Simplify JSP limiter:

- inline getJspForUnload
  It is only used privately and only in one place
  plus the code gets easier to understand.

- remove compilation interval check from
  background method checkUnload(). Better to run
  on every iteration of the background job.

- Do not check JSP count against the size of
  the wrapper list (jsps). Instead check against
  the queue length.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028863 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 17:47:01 +0000 (17:47 +0000)]

Rearrange placement of JSP limter code in JSP
servlet wrapper. Do everything in one place:

- add to the queue if this is the first time
and only then check for the size and shrink
if necessary

- move to the front of the queue otherwise

Move this in front of the actual servlet service.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028862 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Fri, 29 Oct 2010 17:41:05 +0000 (17:41 +0000)]

Improve Jsp limiter:

- Under high load entries removed from the jspQueue
  were already re-added via moveFirst by some other
  concurrent request, before the JspWrapper was
  unregistered. Add "valid" field to the Entry
  object to mark as invalid during removal.

- Improve comment about thread-safetyness and add
  comment about the new "valid" field.

- Add new getSize(). Will be used soon.

- Reorder getters and setters of Entry.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028861 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

funkman [Fri, 29 Oct 2010 13:43:30 +0000 (13:43 +0000)]

for resourceOnlyServlets allow whitespace in the comma
seperated list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028737 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Fri, 29 Oct 2010 01:13:43 +0000 (01:13 +0000)]

Add changelog entry for r1005802
Also corrected a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028575 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Fri, 29 Oct 2010 00:56:05 +0000 (00:56 +0000)]

Use correct arguments for an error message in TagLibraryInfoImpl.
It is a followup to r937791

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028565 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 28 Oct 2010 22:34:52 +0000 (22:34 +0000)]

Missing closing tag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028523 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 28 Oct 2010 22:33:45 +0000 (22:33 +0000)]

Add new feature

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028522 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 28 Oct 2010 22:29:25 +0000 (22:29 +0000)]

Provide configuration option to work around new welcome file mapping requirements of section 10.10 Servlet 3.0 that break a lot of existing apps. The default configuration retains the current Tomcat 6.0.x behaviour. Enabling STRICT_SERVLET_COMPLILANCE enforces the new requirements by default. Includes test cases.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028521 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Thu, 28 Oct 2010 17:30:28 +0000 (17:30 +0000)]

Move Entry to an inner class of FastRemovalDequeue.

All implementation details of Entry are now opaque
to the consumer of the FastRemovalDequeue.

Remove double generification when using the inner
class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028396 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Thu, 28 Oct 2010 17:13:25 +0000 (17:13 +0000)]

Reduce visibility. All those are only needed
by the Queue implementation, not by the consumer
of the collection.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028389 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

rjung [Thu, 28 Oct 2010 16:27:31 +0000 (16:27 +0000)]

Overhaul JspQueue, no functional change for Jasper.

- Rename class to FastRemovalDequeue, because
  it can be used gnerally. Nothing jsp related in it.

- Rename "head" to "first" as a better match for the
  existing "last"

- Switch previous and next: "previous" was
  pointing from first to last, "next" from
  last to first. Mind-bending.

- Add a bit to the description. Remove "ticket"
  language.

- Use more standard terminology "push" to
  insert in front and "pop" to remove from last

- Add methods shift and unshift for the operations
  at the other ends. Not used yet.

- Add remove() method (not used yet).

- Rename makeYoungest() to moveFirst() and add
  moveLast() (not used yet). This data structure
  doesn't actually know about young or old.

Add "Entry-" prefix to Entry.toString().

Rename makeFirst() in JspRuntimeContext to
makeYoungest(), because there we actually are using
timestamp information.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028377 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 28 Oct 2010 12:31:07 +0000 (12:31 +0000)]

Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028276 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Thu, 28 Oct 2010 11:35:48 +0000 (11:35 +0000)]

Add changelog entry for r1027893

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1028263 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

mturk [Wed, 27 Oct 2010 10:27:03 +0000 (10:27 +0000)]

Upgrade to latest released Daemon 1.0.4

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027893 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 26 Oct 2010 22:19:49 +0000 (22:19 +0000)]

Fix the javadoc and Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027762 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 26 Oct 2010 22:09:20 +0000 (22:09 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50157
Ensure MapperListener is only added to a container object once.
Also
- Improve debug logging for MapperListener registration.
- Expose names of LifecycleListeners and ContainerListers for StandardContext via JMX.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027760 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 26 Oct 2010 13:23:35 +0000 (13:23 +0000)]

Update ready for next release

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027542 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 26 Oct 2010 12:30:35 +0000 (12:30 +0000)]

Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50140
Don't ignore a user specified install directory on 64-bit platforms
Allow 32-bit or 64-bit JVMs to be selected when installing on a 64-bit platform

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027504 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Tue, 26 Oct 2010 10:03:41 +0000 (10:03 +0000)]

Align default with Context default

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027440 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 25 Oct 2010 15:27:05 +0000 (15:27 +0000)]

Trivial typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027166 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 25 Oct 2010 15:04:38 +0000 (15:04 +0000)]

Staled is not a word

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027160 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 25 Oct 2010 13:57:15 +0000 (13:57 +0000)]

Fix a couple of other typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027121 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Mon, 25 Oct 2010 13:55:54 +0000 (13:55 +0000)]

Fix numerous typos.
Patch provide by Luke Meyer.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1027120 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Mon, 25 Oct 2010 00:13:56 +0000 (00:13 +0000)]

Improve exception handling in PersistentManagerBase.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026920 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Sun, 24 Oct 2010 22:52:07 +0000 (22:52 +0000)]

Followup to r1026784
Print a stacktrace if an exception (e.g. IOException) happens when calling store.keys() and running under a security manager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026912 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 15:19:51 +0000 (15:19 +0000)]

Fix the Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026821 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 15:14:45 +0000 (15:14 +0000)]

Remove unused DummyRequest
Move DummyResponse to tests where it is used

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026819 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 15:03:15 +0000 (15:03 +0000)]

Fix Javadoc warnings reported by Buildbot

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026815 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 14:29:20 +0000 (14:29 +0000)]

Re-factor to avoid IDE warnings re possible nulls.
Includes a fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50129

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026807 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 14:17:33 +0000 (14:17 +0000)]

Fair amount of clean-up. Add it to the changelog.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026806 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 14:12:29 +0000 (14:12 +0000)]

Update changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026805 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 14:11:15 +0000 (14:11 +0000)]

Enable Checkstyle import checks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026803 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 14:09:37 +0000 (14:09 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.core package (remainder)
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026802 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 14:04:56 +0000 (14:04 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.core package (partial)
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026801 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:33:33 +0000 (13:33 +0000)]

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:29:36 +0000 (13:29 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.authenticator package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026796 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:28:15 +0000 (13:28 +0000)]

Code clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026795 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:25:36 +0000 (13:25 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.ha package
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026793 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:14:24 +0000 (13:14 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.ha.authenticator package
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026790 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:12:18 +0000 (13:12 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.loader package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026789 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:10:31 +0000 (13:10 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.mbeans package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026788 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:08:54 +0000 (13:08 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.startup package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026787 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:08:26 +0000 (13:08 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.realm package
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026786 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:02:24 +0000 (13:02 +0000)]

Avoid NPE
Don't use exception.printStackTrace()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026784 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 13:01:28 +0000 (13:01 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.session package
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026782 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 12:52:04 +0000 (12:52 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026780 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 12:21:08 +0000 (12:21 +0000)]

Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026773 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 12:18:47 +0000 (12:18 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina package
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026772 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 12:13:53 +0000 (12:13 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.catalina.valves package
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026771 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 11:55:10 +0000 (11:55 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.el package
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026769 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Sun, 24 Oct 2010 11:41:12 +0000 (11:41 +0000)]

Fix Eclipse nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026768 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Fri, 22 Oct 2010 21:59:51 +0000 (21:59 +0000)]

Revert part of r1026157

Removing "throwa NamingException" from parseName() methods as was done in r1026157 changed their API,
so that derived classes won't be able to throw that exception anymore.

I do not know the full story behind these two parseName() methods, but if they were supposed be overwritten it seems likely that they may throw a NamingException.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026506 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

kkolinko [Fri, 22 Oct 2010 21:15:03 +0000 (21:15 +0000)]

correct typos

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026496 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 22:28:59 +0000 (22:28 +0000)]

Add release date

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026166 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 22:24:01 +0000 (22:24 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026165 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 22:20:32 +0000 (22:20 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026164 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 22:14:58 +0000 (22:14 +0000)]

Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026163 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 22:09:45 +0000 (22:09 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026157 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 21:53:09 +0000 (21:53 +0000)]

Clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026152 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 21:48:01 +0000 (21:48 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix Eclipse warnings
Align modifyAttributes() with WARDirContext

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026150 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 16:41:40 +0000 (16:41 +0000)]

Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026061 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 16:39:50 +0000 (16:39 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026060 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 16:26:50 +0000 (16:26 +0000)]

Allow Checkstyle's unused imports test to be used with this class
Fix Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026057 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

markt [Thu, 21 Oct 2010 16:18:12 +0000 (16:18 +0000)]

Allow Checkstyle's unused imports test to be used with the o.a.tomcat.util classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1026054 13f79535-47bb-0310-9956-ffa450edef68

Unnamed repository; edit this file to name it for gitweb.

RSS Atom