horde.git
15 years agoFix ajax view prefs display when switching prefs apps.
Michael M Slusarz [Thu, 15 Jul 2010 17:19:17 +0000 (11:19 -0600)]
Fix ajax view prefs display when switching prefs apps.

15 years agoNo need to use getFormData(); just use $vars.
Michael M Slusarz [Thu, 15 Jul 2010 17:14:24 +0000 (11:14 -0600)]
No need to use getFormData(); just use $vars.

15 years agoIt is nlsconfig, not config
Michael M Slusarz [Thu, 15 Jul 2010 16:41:27 +0000 (10:41 -0600)]
It is nlsconfig, not config

15 years agochanges
Michael J. Rubinsky [Thu, 15 Jul 2010 16:55:03 +0000 (12:55 -0400)]
changes

15 years agoreveresed logic
Michael J. Rubinsky [Thu, 15 Jul 2010 16:45:28 +0000 (12:45 -0400)]
reveresed logic

15 years agoDon't allow fixed block types to be changed.
Michael J. Rubinsky [Thu, 15 Jul 2010 16:17:25 +0000 (12:17 -0400)]
Don't allow fixed block types to be changed.

Bug: 9141

15 years agofix scope
Michael J. Rubinsky [Thu, 15 Jul 2010 15:40:01 +0000 (11:40 -0400)]
fix scope

15 years agoHorde_Nls::$config -> $registry->config
Michael J. Rubinsky [Thu, 15 Jul 2010 15:36:03 +0000 (11:36 -0400)]
Horde_Nls::$config -> $registry->config

15 years agoRemove lingering horde/Core reference in horde/Nls
Michael M Slusarz [Wed, 14 Jul 2010 21:49:58 +0000 (15:49 -0600)]
Remove lingering horde/Core reference in horde/Nls

15 years agoHorde version check improvements.
Michael M Slusarz [Wed, 14 Jul 2010 20:38:23 +0000 (14:38 -0600)]
Horde version check improvements.

Move code into Horde_Config::.
Use SimpleXML and Horde_Http_Client.

15 years agoClean up PHP Shell script
Michael M Slusarz [Wed, 14 Jul 2010 20:17:18 +0000 (14:17 -0600)]
Clean up PHP Shell script

15 years agoMissed some Horde_Tree::singleton() conversions
Michael M Slusarz [Wed, 14 Jul 2010 19:48:24 +0000 (13:48 -0600)]
Missed some Horde_Tree::singleton() conversions

15 years agoDataTree browser tweaks.
Michael M Slusarz [Wed, 14 Jul 2010 19:43:52 +0000 (13:43 -0600)]
DataTree browser tweaks.

Fix not showing deeper children.
Don't use globals.
Use Horde_Url.
Avoid output buffering.

15 years agoFix location of nls configuration data.
Michael M Slusarz [Wed, 14 Jul 2010 19:11:05 +0000 (13:11 -0600)]
Fix location of nls configuration data.

$GLOBALS['nls'] hasn't been used for awhile.  Regardless, the correct
location is now $registry->nlsconfig.

15 years agoRe-add session code to Horde_Tree.
Michael M Slusarz [Wed, 14 Jul 2010 19:00:43 +0000 (13:00 -0600)]
Re-add session code to Horde_Tree.

Sessions can be used outside of Horde - we aren't using any Horde
specific session functionality.

15 years agoAdd Horde_Crypt_Exception
Michael M Slusarz [Wed, 14 Jul 2010 06:57:12 +0000 (00:57 -0600)]
Add Horde_Crypt_Exception

15 years agophpdoc
Michael M Slusarz [Wed, 14 Jul 2010 06:47:43 +0000 (00:47 -0600)]
phpdoc

15 years agoDisable this sort by default.
Michael M Slusarz [Wed, 14 Jul 2010 06:46:47 +0000 (00:46 -0600)]
Disable this sort by default.

Admins should really sort by hand if this isn't an acceptable sort in
their language.  Otherwise we are wasting a bunch of CPU cycles on every
page for no good reason (sorting is not a trivial task).

15 years agoFix changed location
Michael M Slusarz [Wed, 14 Jul 2010 05:12:04 +0000 (23:12 -0600)]
Fix changed location

15 years agoCharset now required for a bunch of MIME functions.
Michael M Slusarz [Wed, 14 Jul 2010 05:09:28 +0000 (23:09 -0600)]
Charset now required for a bunch of MIME functions.

Better goal would be to convert Horde_Mime_Address to OO-interface, and
then inject charset. But this gets things to work again.

15 years agoRemove horde/Core dependency in horde/Tree.
Michael M Slusarz [Wed, 14 Jul 2010 02:57:00 +0000 (20:57 -0600)]
Remove horde/Core dependency in horde/Tree.

15 years agophpdoc
Michael M Slusarz [Wed, 14 Jul 2010 02:22:04 +0000 (20:22 -0600)]
phpdoc

15 years agoRemove horde/Core dependency in horde/Notification
Michael M Slusarz [Wed, 14 Jul 2010 02:17:27 +0000 (20:17 -0600)]
Remove horde/Core dependency in horde/Notification

15 years agoRemove (some) horde/Core dependencies in horde/Mime
Michael M Slusarz [Wed, 14 Jul 2010 00:42:34 +0000 (18:42 -0600)]
Remove (some) horde/Core dependencies in horde/Mime

15 years agows
Michael M Slusarz [Tue, 13 Jul 2010 22:10:25 +0000 (16:10 -0600)]
ws

15 years agoRemove horde/Core dependency in horde/Data
Michael M Slusarz [Tue, 13 Jul 2010 22:05:44 +0000 (16:05 -0600)]
Remove horde/Core dependency in horde/Data

15 years agoRemove horde/Core dependency in horde/Crypt
Michael M Slusarz [Tue, 13 Jul 2010 21:59:44 +0000 (15:59 -0600)]
Remove horde/Core dependency in horde/Crypt

15 years agoRemove horde/Core dependency in horde/Auth
Michael M Slusarz [Tue, 13 Jul 2010 21:36:55 +0000 (15:36 -0600)]
Remove horde/Core dependency in horde/Auth

15 years agoTicket #9124: Remove horde/Core dependency from horde/Nls.
Michael M Slusarz [Tue, 13 Jul 2010 19:45:58 +0000 (13:45 -0600)]
Ticket #9124: Remove horde/Core dependency from horde/Nls.

Move all of the Horde_Nls:: code dependent on Horde configuration to
horde/Core.  A core dependency has thus manifested itself in a bunch of
framework libraries thought to be horde/Core free (since getCharset() is
dependent on the local Horde configuration).

The following functions have been moved to registry:
Horde_Nls::config -> Horde_Registry::$nlsconfig
Horde_Nls::select() -> Horde_Registry::preferredLang()
Horde_Nls::setLanguage() -> Horde_Registry::setLanguage()
Horde_Nls::setTextdomain() -> Horde_Registry::setTextdomain()
Horde_Nls::setLanguageEnvironment() ->
Horde_Registry::setLanguageEnvironment()
Horde_Nls::isValid() -> Horde_Registry::isValidLang()
Horde_Nls::getCharset() -> Horde_Registry::getCharset()
Horde_Nls::getExternalCharset() -> Horde_Registry::getExternalCharset()
Horde_Nls::getEmailCharset() -> Horde_Registry::getEmailCharset()
Horde_Nls::setCharset() -> Horde_Registry::setCharset()
Horde_Nls::setCharsetEnvironment() ->
Horde_Registry::setCharsetEnvironment()
Horde_Nls::setTimeZone() -> Horde_Registry::setTimeZone()

Horde_Nls::generateFlagImageByHost() ->
Horde_Ui_FlagImage::generateFlagImageByHost()

Horde_Registry::initApp() now accepts the boolean 'timezone' parameter,
which will set the timezone if true.

15 years agoCSS tweak
Michael M Slusarz [Tue, 13 Jul 2010 06:12:33 +0000 (00:12 -0600)]
CSS tweak

15 years agoSome more places to use self::
Michael M Slusarz [Tue, 13 Jul 2010 01:57:35 +0000 (19:57 -0600)]
Some more places to use self::

15 years agoIMP::composeLink() always returns a Horde_Url object.
Michael M Slusarz [Tue, 13 Jul 2010 01:51:29 +0000 (19:51 -0600)]
IMP::composeLink() always returns a Horde_Url object.

15 years agoAdd support for callback when converting URL to string.
Michael M Slusarz [Tue, 13 Jul 2010 01:49:03 +0000 (19:49 -0600)]
Add support for callback when converting URL to string.

15 years agoBug #9138: Use correct default value for Sent Mail mailbox
Michael M Slusarz [Tue, 13 Jul 2010 01:18:12 +0000 (19:18 -0600)]
Bug #9138: Use correct default value for Sent Mail mailbox

15 years agoMore generic default for emoticon filter - talk in terms of replacement text rather...
Michael M Slusarz [Tue, 13 Jul 2010 01:09:38 +0000 (19:09 -0600)]
More generic default for emoticon filter - talk in terms of replacement text rather than image

15 years agophpdoc
Michael M Slusarz [Mon, 12 Jul 2010 04:40:09 +0000 (22:40 -0600)]
phpdoc

15 years agoUse callback rather than preg e modifier
Michael M Slusarz [Fri, 9 Jul 2010 22:02:43 +0000 (16:02 -0600)]
Use callback rather than preg e modifier

15 years agoFix phpdoc for Text_Filter package
Michael M Slusarz [Fri, 9 Jul 2010 21:58:39 +0000 (15:58 -0600)]
Fix phpdoc for Text_Filter package

15 years agoFixes for importing iCalendar files with RECURRENCE-ID set.
Michael J. Rubinsky [Sun, 11 Jul 2010 14:56:58 +0000 (10:56 -0400)]
Fixes for importing iCalendar files with RECURRENCE-ID set.

The original recurring event must be imported before any instances of
RECURRENCE-ID exceptions or the original event will not be found to modify.

15 years agobreak out recurrence parsing to it's own method.
Michael J. Rubinsky [Sun, 11 Jul 2010 14:06:36 +0000 (10:06 -0400)]
break out recurrence parsing to it's own method.

Give Ical event's their own recurrence parsing code, we don't want
to query the persistent storage for any events.

Bug: 9133

15 years agophpdoc typo
Michael J. Rubinsky [Sun, 11 Jul 2010 14:05:26 +0000 (10:05 -0400)]
phpdoc typo

15 years agoavoid undefined index warnings
Michael J. Rubinsky [Sun, 11 Jul 2010 00:35:03 +0000 (20:35 -0400)]
avoid undefined index warnings

15 years agoFinish Portugues date parser.
Jan Schneider [Sat, 10 Jul 2010 08:42:54 +0000 (10:42 +0200)]
Finish Portugues date parser.

15 years agoRevert "I *think* we always want Horde::url() to use Horde webroot"
Michael M Slusarz [Fri, 9 Jul 2010 21:21:20 +0000 (15:21 -0600)]
Revert "I *think* we always want Horde::url() to use Horde webroot"

This reverts commit 05f2a53df4b555f1fdaded5213af80fed4bc0907.

15 years agoRevert "Reuse existing code"
Michael M Slusarz [Fri, 9 Jul 2010 21:20:07 +0000 (15:20 -0600)]
Revert "Reuse existing code"

This reverts commit a78f6933f4a0d2f80e7a3952c15bbe8f436815ea.

15 years agoThis doesn't look right to me.
Michael J. Rubinsky [Fri, 9 Jul 2010 20:48:16 +0000 (16:48 -0400)]
This doesn't look right to me.

Not sure why we wouldn't want the application's webroot if we
are generating a full url.

15 years agosimplify
Michael J. Rubinsky [Fri, 9 Jul 2010 18:52:22 +0000 (14:52 -0400)]
simplify

15 years agoOutput inline script when using dimp but displaying non-dimp content
Michael M Slusarz [Fri, 9 Jul 2010 17:24:52 +0000 (11:24 -0600)]
Output inline script when using dimp but displaying non-dimp content

15 years agoI *think* we always want Horde::url() to use Horde webroot
Michael M Slusarz [Fri, 9 Jul 2010 17:15:14 +0000 (11:15 -0600)]
I *think* we always want Horde::url() to use Horde webroot

All of a sudden, I was getting weird redirects to URLs like
example.com/imp/imp during logins - because webroot was example.com/imp

This might be an artifact of new sidebar code (?)

If you want the application's webroot, I believe this is what
Horde::applicationUrl() is for.

15 years agoSimplify
Michael M Slusarz [Fri, 9 Jul 2010 17:13:14 +0000 (11:13 -0600)]
Simplify

15 years agoWas wondering why I had a 150px gap on every page
Michael M Slusarz [Fri, 9 Jul 2010 17:00:19 +0000 (11:00 -0600)]
Was wondering why I had a 150px gap on every page

15 years agoBFN
Michael J. Rubinsky [Fri, 9 Jul 2010 16:47:30 +0000 (12:47 -0400)]
BFN

15 years agoLooks like this is probably what was intended.
Michael J. Rubinsky [Fri, 9 Jul 2010 16:34:19 +0000 (12:34 -0400)]
Looks like this is probably what was intended.

Calling calendar/export first while catching the exception will avoid
unwanted notifications when this isn't actually an update operation.

15 years agoRevert "prune code that produced no effects."
Michael J. Rubinsky [Fri, 9 Jul 2010 16:33:02 +0000 (12:33 -0400)]
Revert "prune code that produced no effects."

This reverts commit 376aa47974882aa477dfc7ba585387fd6811c326.

15 years agoprune code that produced no effects.
Michael J. Rubinsky [Fri, 9 Jul 2010 16:31:37 +0000 (12:31 -0400)]
prune code that produced no effects.

15 years agoADD is only used when adding new instances to an existing recurring event series.
Michael J. Rubinsky [Fri, 9 Jul 2010 16:20:47 +0000 (12:20 -0400)]
ADD is only used when adding new instances to an existing recurring event series.

As per RFC 2446, REQUEST should be used when modifying an existing event. We currently
don't support adding instances to the existing recurring event series via iTip without
sending the entire event series again.

Bug: 9131
Reported By: patrick.abiven@apitech.fr

15 years agoHandle iTip CANCEL request of a recurring event instance correctly.
Michael J. Rubinsky [Thu, 8 Jul 2010 23:56:04 +0000 (19:56 -0400)]
Handle iTip CANCEL request of a recurring event instance correctly.

According to RFC 2446, when cancelling an instance of a recurring
event, the RECURRENCE-ID value MUST be specified along with the UID.
If cancelling the entire event series, the RECURRENCE-ID value
MUST NOT be included.

Bug: 8956

15 years agoavoid undefined index notices
Michael J. Rubinsky [Fri, 9 Jul 2010 00:38:02 +0000 (20:38 -0400)]
avoid undefined index notices

15 years agoEmoticons filter fixes.
Michael M Slusarz [Fri, 9 Jul 2010 06:58:36 +0000 (00:58 -0600)]
Emoticons filter fixes.

Fix image generation with new Horde_Themes code.
Remove Core dependency from Emoticons filter by moving image generation
code to a Core library.

15 years agoDon't use Horde-specific app assumption in factory.
Michael M Slusarz [Fri, 9 Jul 2010 06:25:04 +0000 (00:25 -0600)]
Don't use Horde-specific app assumption in factory.

15 years agoReuse existing code
Michael M Slusarz [Fri, 9 Jul 2010 05:58:24 +0000 (23:58 -0600)]
Reuse existing code

15 years agoRequest #9129: Allow admin to define list of safe e-mail addresses that will not...
Michael M Slusarz [Fri, 9 Jul 2010 05:47:41 +0000 (23:47 -0600)]
Request #9129: Allow admin to define list of safe e-mail addresses that will not experience HTML image blocking

15 years agoFix typo.
Michael M Slusarz [Fri, 9 Jul 2010 05:33:50 +0000 (23:33 -0600)]
Fix typo.

15 years agoDon't display HTML image options if HTML inline viewing is disabled
Michael M Slusarz [Fri, 9 Jul 2010 05:29:28 +0000 (23:29 -0600)]
Don't display HTML image options if HTML inline viewing is disabled

15 years agoMake use of the configspecial we have for contact sources.
Michael J. Rubinsky [Thu, 8 Jul 2010 22:06:33 +0000 (18:06 -0400)]
Make use of the configspecial we have for contact sources.

Re-add this now that we are working towards Horde 4
(Finally) closes Bug: 3271

15 years agoRevert "need to ucfirst() the $app name when using it as a class name part."
Michael J. Rubinsky [Thu, 8 Jul 2010 21:22:47 +0000 (17:22 -0400)]
Revert "need to ucfirst() the $app name when using it as a class name part."

This reverts commit 8c00d6c96fca1c435b98dff42d203a304d45af4d.

15 years agoneed to ucfirst() the $app name when using it as a class name part.
Michael J. Rubinsky [Thu, 8 Jul 2010 18:53:12 +0000 (14:53 -0400)]
need to ucfirst() the $app name when using it as a class name part.

15 years agochanges
Michael J. Rubinsky [Thu, 8 Jul 2010 18:23:51 +0000 (14:23 -0400)]
changes

15 years agoIf default addressbook is not browsable, try one from the addressbook pref.
Michael J. Rubinsky [Thu, 8 Jul 2010 18:20:49 +0000 (14:20 -0400)]
If default addressbook is not browsable, try one from the addressbook pref.

Bug: 6536

15 years agoGlobal scope
Michael J. Rubinsky [Thu, 8 Jul 2010 18:13:33 +0000 (14:13 -0400)]
Global scope

15 years agoglobal scope
Michael J. Rubinsky [Thu, 8 Jul 2010 18:01:38 +0000 (14:01 -0400)]
global scope

15 years agoadd missing semi-colon.
Michael J. Rubinsky [Thu, 8 Jul 2010 18:00:02 +0000 (14:00 -0400)]
add missing semi-colon.

15 years agoget rid of remaining PEAR_Error in Horde_Image
Michael J. Rubinsky [Thu, 8 Jul 2010 14:51:56 +0000 (10:51 -0400)]
get rid of remaining PEAR_Error in Horde_Image

15 years agothese don't return PEAR_Error
Michael J. Rubinsky [Thu, 8 Jul 2010 14:16:43 +0000 (10:16 -0400)]
these don't return PEAR_Error

15 years agoadd some missing methods to the Gd driver that some effects use.
Michael J. Rubinsky [Thu, 8 Jul 2010 14:03:13 +0000 (10:03 -0400)]
add some missing methods to the Gd driver that some effects use.

I think my plan was to remove support for these effects from the GD driver,
but I'll leave these in for now since they sort-of work. They are ugly as heck,
but that's what you get for using Gd...

15 years ago2 more utility functions to Horde_Image
Michael J. Rubinsky [Thu, 8 Jul 2010 14:02:39 +0000 (10:02 -0400)]
2 more utility functions to Horde_Image

15 years agoThese methods need to be public so the effect objects can see them.
Michael J. Rubinsky [Thu, 8 Jul 2010 13:46:50 +0000 (09:46 -0400)]
These methods need to be public so the effect objects can see them.

15 years agoFix method name.
Michael J. Rubinsky [Thu, 8 Jul 2010 13:22:29 +0000 (09:22 -0400)]
Fix method name.

Closes Bug: 9128

15 years agochanges
Michael J. Rubinsky [Thu, 8 Jul 2010 00:14:08 +0000 (20:14 -0400)]
changes

15 years agoMore complete support for reccuring event exceptions when dealing with iCalendar...
Michael J. Rubinsky [Wed, 7 Jul 2010 22:53:29 +0000 (18:53 -0400)]
More complete support for reccuring event exceptions when dealing with iCalendar files
Bug: 9091

15 years agoThe only expected exception here would be a Horde_Exception_Not_Found.
Michael J. Rubinsky [Wed, 7 Jul 2010 22:48:20 +0000 (18:48 -0400)]
The only expected exception here would be a Horde_Exception_Not_Found.

Any other exception should be an error.

15 years agoDon't show errors before we've actually done anything.
Michael J. Rubinsky [Wed, 7 Jul 2010 22:13:09 +0000 (18:13 -0400)]
Don't show errors before we've actually done anything.

15 years agoMake sure the Kronolith::getDriver() reloads the calendar parameters
Jan Schneider [Wed, 7 Jul 2010 22:02:06 +0000 (00:02 +0200)]
Make sure the Kronolith::getDriver() reloads the calendar parameters
when re-using an existing Ical driver.
Don't re-use the HTTP client if opening another calendar.
Fix caching of error messages.
Remote calendar user names are not encrypted.

15 years agoOnly support basic auth at the moment, so use that if any auth is requested.
Jan Schneider [Wed, 7 Jul 2010 21:53:20 +0000 (23:53 +0200)]
Only support basic auth at the moment, so use that if any auth is requested.

15 years agofix parameter passing to Kronolith_Driver#listEvents
Michael J. Rubinsky [Wed, 7 Jul 2010 18:13:51 +0000 (14:13 -0400)]
fix parameter passing to Kronolith_Driver#listEvents

15 years agoDon't request tags if we don't have any events.
Michael J. Rubinsky [Wed, 7 Jul 2010 17:54:48 +0000 (13:54 -0400)]
Don't request tags if we don't have any events.

15 years agoStrip index.php from selfUrl().
Jan [Wed, 7 Jul 2010 16:10:33 +0000 (17:10 +0100)]
Strip index.php from selfUrl().

15 years agoIf we don't need authentication and have a target URL, redirect there.
Jan [Wed, 7 Jul 2010 16:10:32 +0000 (17:10 +0100)]
If we don't need authentication and have a target URL, redirect there.

15 years agoLoad the timeobjects *after* correcting the start/end dates.
Jan Schneider [Wed, 7 Jul 2010 14:08:38 +0000 (16:08 +0200)]
Load the timeobjects *after* correcting the start/end dates.

15 years agoJump through a number of hoops to make sure we always get events for the time span...
Jan Schneider [Wed, 7 Jul 2010 13:35:06 +0000 (15:35 +0200)]
Jump through a number of hoops to make sure we always get events for the time span that is already stored in the cache.

15 years agoMFB:
Gunnar Wrobel [Wed, 7 Jul 2010 09:41:05 +0000 (11:41 +0200)]
MFB:

Split Kolab_Resource from Kolab_Filter.
Complete separation between resource handling and the filter package.

15 years agoMFB:
Gunnar Wrobel [Wed, 7 Jul 2010 07:31:20 +0000 (09:31 +0200)]
MFB:

Actually use the newer Freebusy handler.
Merge several minor fixes from Git HEAD. Reactivated some tests.
kolab/issue4257 (Always accept policy doesnt set atendee status to accepted)

15 years agoRevert "RB_confirm is too specific - add to RB_window instead"
Jan Schneider [Wed, 7 Jul 2010 09:19:24 +0000 (11:19 +0200)]
Revert "RB_confirm is too specific - add to RB_window instead"

There was a reason this was so specific. We already use forms in RB dialogs,
e.g. in Kronolith, that we don't want to look like a confirm dialog.

This reverts commit 59140912dd17385553124964ec4c8d824fa753b2.

15 years agoReplace short open tags.
Jan Schneider [Wed, 7 Jul 2010 08:38:24 +0000 (10:38 +0200)]
Replace short open tags.

15 years agoBug #6832: Add confirm dialog when moving to notepad/tasklist
Michael M Slusarz [Wed, 7 Jul 2010 05:15:18 +0000 (23:15 -0600)]
Bug #6832: Add confirm dialog when moving to notepad/tasklist

15 years agoMake sure these entries are not confused for IMAP mailboxes
Michael M Slusarz [Wed, 7 Jul 2010 04:53:51 +0000 (22:53 -0600)]
Make sure these entries are not confused for IMAP mailboxes

15 years agoUse IMPDialog for DIMP folder actions.
Michael M Slusarz [Wed, 7 Jul 2010 04:11:01 +0000 (22:11 -0600)]
Use IMPDialog for DIMP folder actions.

15 years agoAllow IMPDialog to handle simple Yes/No dialogs
Michael M Slusarz [Wed, 7 Jul 2010 03:44:37 +0000 (21:44 -0600)]
Allow IMPDialog to handle simple Yes/No dialogs

Add a bit of IMPDialog documentation

15 years agoRB_confirm is too specific - add to RB_window instead
Michael M Slusarz [Wed, 7 Jul 2010 03:53:12 +0000 (21:53 -0600)]
RB_confirm is too specific - add to RB_window instead

15 years agoDescription of file.
Michael M Slusarz [Wed, 7 Jul 2010 01:18:34 +0000 (19:18 -0600)]
Description of file.