tomcat7.0
15 years agoAdd another property access to our security policy.
rjung [Sun, 11 Apr 2010 01:26:43 +0000 (01:26 +0000)]
Add another property access to our security policy.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932823 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd permission to read the STRICT_SERVLET_COMPLIANCE property
rjung [Sun, 11 Apr 2010 01:08:09 +0000 (01:08 +0000)]
Add permission to read the STRICT_SERVLET_COMPLIANCE property
to our default policy for the security manager.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932822 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd missing class.
jfclere [Sat, 10 Apr 2010 18:07:39 +0000 (18:07 +0000)]
Add missing class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932776 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failure (with security manager): Preload required class.
markt [Sat, 10 Apr 2010 15:53:14 +0000 (15:53 +0000)]
TCK failure (with security manager): Preload required class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932751 13f79535-47bb-0310-9956-ffa450edef68

15 years agoJavadoc update
markt [Fri, 9 Apr 2010 11:43:16 +0000 (11:43 +0000)]
Javadoc update

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932363 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49075
markt [Fri, 9 Apr 2010 11:16:40 +0000 (11:16 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49075
NPE protection if roles is null and roles needs to be modifiable

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932357 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate EL & JSP versions
markt [Fri, 9 Apr 2010 08:01:07 +0000 (08:01 +0000)]
Update EL & JSP versions
Minor tweaks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@932289 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse chunked encoding for http 1.1 requests with no content-length (regardless of...
markt [Wed, 7 Apr 2010 22:17:19 +0000 (22:17 +0000)]
Use chunked encoding for http 1.1 requests with no content-length (regardless of keep-alive) so client can differentiate between complete and partial responses.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931709 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFurther corrections to SSL session timeout attribute name.
markt [Wed, 7 Apr 2010 21:46:55 +0000 (21:46 +0000)]
Further corrections to SSL session timeout attribute name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931699 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix typo
markt [Wed, 7 Apr 2010 20:11:57 +0000 (20:11 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931664 13f79535-47bb-0310-9956-ffa450edef68

15 years agoStart working on a statement cache. Add in disconnect event for interceptors, make...
fhanik [Wed, 7 Apr 2010 13:54:21 +0000 (13:54 +0000)]
Start working on a statement cache. Add in disconnect event for interceptors, make the statement decorator extensible

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931550 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018
kkolinko [Wed, 7 Apr 2010 03:24:08 +0000 (03:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49018
Fix processing of time argument in the "Expire sessions" action in the Manager web application

Also, provide separate templates for the "managerServlet.sessiontimeout" message, to allow it to be properly translated into other languages. I cannot provide the actual translations, though. The translated variants of the new messages are now a mix of English and translated text, which just mimics the old behaviour.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931415 13f79535-47bb-0310-9956-ffa450edef68

15 years agomemberAlive is not called if member has not already existed in membership.
kfujino [Tue, 6 Apr 2010 09:25:59 +0000 (09:25 +0000)]
memberAlive is not called if member has not already existed in membership.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@931061 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert accidental commit
markt [Mon, 5 Apr 2010 19:38:28 +0000 (19:38 +0000)]
Revert accidental commit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930936 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix the immediate problem described in https://issues.apache.org/bugzilla/show_bug...
markt [Sun, 4 Apr 2010 16:26:51 +0000 (16:26 +0000)]
Fix the immediate problem described in https://issues.apache.org/bugzilla/show_bug.cgi?id=48648
Still need review remainder of bug report

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930711 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49014
markt [Sun, 4 Apr 2010 10:37:17 +0000 (10:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49014
Add test cases for the RemoteIpFilter
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930659 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48983
markt [Sun, 4 Apr 2010 10:25:56 +0000 (10:25 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48983
Additional debug logging for when RemoteIp(Valve|Filter) is not invoked

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930657 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48914
markt [Sun, 4 Apr 2010 10:09:18 +0000 (10:09 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48914
Invoke should use parameters provided in expression in preference to parameters provided in invoke() call

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930653 13f79535-47bb-0310-9956-ffa450edef68

15 years agoModify unit tests to take account of https://issues.apache.org/bugzilla/show_bug...
markt [Sun, 4 Apr 2010 10:08:04 +0000 (10:08 +0000)]
Modify unit tests to take account of https://issues.apache.org/bugzilla/show_bug.cgi?id=48914
Invoke should use parameters provided in expression in preference to parameters provided in invoke() call

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930652 13f79535-47bb-0310-9956-ffa450edef68

15 years agoCleanup. Remove field that is never initialized and never read.
kkolinko [Sat, 3 Apr 2010 17:40:53 +0000 (17:40 +0000)]
Cleanup. Remove field that is never initialized and never read.
req.getResponse() is used instead of it when needed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930549 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: If a servlet/filter has any mappings in the main web.xml, these overrid...
markt [Sat, 3 Apr 2010 12:41:31 +0000 (12:41 +0000)]
TCK failures: If a servlet/filter has any mappings in the main web.xml, these override rather than replace the mappings defined in the fragments. The same goes for fragments and annotations.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930514 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix copy paste error
fhanik [Fri, 2 Apr 2010 14:59:33 +0000 (14:59 +0000)]
Fix copy paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@930289 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
markt [Wed, 31 Mar 2010 13:06:30 +0000 (13:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030
Failure of one connector should not leave some connectors started and some ignored

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929521 13f79535-47bb-0310-9956-ffa450edef68

15 years agodelete test file
kfujino [Wed, 31 Mar 2010 08:09:40 +0000 (08:09 +0000)]
delete test file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929428 13f79535-47bb-0310-9956-ffa450edef68

15 years agocommit access test
kfujino [Wed, 31 Mar 2010 08:06:13 +0000 (08:06 +0000)]
commit access test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929427 13f79535-47bb-0310-9956-ffa450edef68

15 years agodelete test file
kfujino [Wed, 31 Mar 2010 06:32:46 +0000 (06:32 +0000)]
delete test file

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929404 13f79535-47bb-0310-9956-ffa450edef68

15 years agocommit access test
kfujino [Wed, 31 Mar 2010 06:08:32 +0000 (06:08 +0000)]
commit access test

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929394 13f79535-47bb-0310-9956-ffa450edef68

15 years agoWhen changing a session ID, use the internal add cookie method in the same way as...
markt [Tue, 30 Mar 2010 21:01:02 +0000 (21:01 +0000)]
When changing a session ID, use the internal add cookie method in the same way as when first creating a session cookie.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929284 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClear up state handling a bit
fhanik [Tue, 30 Mar 2010 16:03:32 +0000 (16:03 +0000)]
Clear up state handling a bit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@929181 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895
markt [Mon, 29 Mar 2010 15:01:14 +0000 (15:01 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48895
Make clearing thread locals optional and disabled by default since it isn't thread-safe

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928798 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48840
markt [Mon, 29 Mar 2010 11:51:46 +0000 (11:51 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48840
If CDPATH is set, cd may result in output to stdout.
Swallow the output. This is safe since the script outputs the value used for CATALINA_HOME so any issues will be visible then.
Patch provided by mdietze

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928732 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
markt [Mon, 29 Mar 2010 10:37:53 +0000 (10:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
Correctly handle multi-line headers with the NIO connector
Patch suggested by Richa Baronia

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928695 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTest case for https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
markt [Mon, 29 Mar 2010 10:36:55 +0000 (10:36 +0000)]
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=48839
Fix to follow shortly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928694 13f79535-47bb-0310-9956-ffa450edef68

15 years agoNew installer side graphics. Artwork provided by Adela Turk
mturk [Mon, 29 Mar 2010 05:46:57 +0000 (05:46 +0000)]
New installer side graphics. Artwork provided by Adela Turk

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928599 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48717
markt [Sun, 28 Mar 2010 19:34:12 +0000 (19:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48717
When a node joins a cluster and it receives all the current sessions, ensure the sessionCreated event is fired if the Manager is configured to replicate session events

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928482 13f79535-47bb-0310-9956-ffa450edef68

15 years agoLanguage tweaks
markt [Sun, 28 Mar 2010 12:28:54 +0000 (12:28 +0000)]
Language tweaks

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928388 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48662
markt [Sun, 28 Mar 2010 11:57:46 +0000 (11:57 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48662
Make extraction of context.xml files configurable and disable it by default for Tomcat 7

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928380 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMUST_STOP is also a valid state from which to transition to STOPPING_PREP
markt [Sun, 28 Mar 2010 10:07:42 +0000 (10:07 +0000)]
MUST_STOP is also a valid state from which to transition to STOPPING_PREP

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928370 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse both single and double quotes in the test, for diversity
kkolinko [Sat, 27 Mar 2010 09:11:45 +0000 (09:11 +0000)]
Use both single and double quotes in the test, for diversity

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928175 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd in some debug, what is causing some TCK failures is a request/response pair not...
fhanik [Sat, 27 Mar 2010 01:50:13 +0000 (01:50 +0000)]
Add in some debug, what is causing some TCK failures is a request/response pair not being recycled properly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@928120 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdjust startAsync().complete() behavior
fhanik [Fri, 26 Mar 2010 16:21:57 +0000 (16:21 +0000)]
Adjust startAsync().complete() behavior

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927951 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean up
markt [Fri, 26 Mar 2010 15:43:44 +0000 (15:43 +0000)]
Clean up
 - Eclipse warnings
 - Unnecessary code
 - Line length
 - i18n message names

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927923 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdjust examples to the latest implementation
fhanik [Fri, 26 Mar 2010 15:21:39 +0000 (15:21 +0000)]
Adjust examples to the latest implementation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927911 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMark example servlets as async
fhanik [Fri, 26 Mar 2010 15:16:52 +0000 (15:16 +0000)]
Mark example servlets as async

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927908 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMark ResourceEntry.loadedClass as volatile.
kkolinko [Fri, 26 Mar 2010 14:40:30 +0000 (14:40 +0000)]
Mark ResourceEntry.loadedClass as volatile.
That is because WebappClassLoader#findClassInternal() uses double-checked locking to initialize this field.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927877 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMissed a file in r927850
markt [Fri, 26 Mar 2010 13:48:30 +0000 (13:48 +0000)]
Missed a file in r927850

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927851 13f79535-47bb-0310-9956-ffa450edef68

15 years agoImprove log message when deploying from configBase to make it clearer where xml file...
markt [Fri, 26 Mar 2010 13:47:18 +0000 (13:47 +0000)]
Improve log message when deploying from configBase to make it clearer where xml file is read from.
Javadoc tweak

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927850 13f79535-47bb-0310-9956-ffa450edef68

15 years agospec says that "started" is defined as started until the thread has returned to the...
fhanik [Fri, 26 Mar 2010 13:38:02 +0000 (13:38 +0000)]
spec says that "started" is defined as started until the thread has returned to the container.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927845 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove tests rendered unnecessary when context.xml files were moved from appBase...
markt [Fri, 26 Mar 2010 13:36:22 +0000 (13:36 +0000)]
Remove tests rendered unnecessary when context.xml files were moved from appBase to configBase

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927844 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48992
kkolinko [Fri, 26 Mar 2010 10:28:47 +0000 (10:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48992
Fix XML tags in examples for CombinedRealm and LockOutRealm
Based on the patch by Fumiyuki Shimizu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927759 13f79535-47bb-0310-9956-ffa450edef68

15 years agoObey the rules on quoting
markt [Thu, 25 Mar 2010 22:46:40 +0000 (22:46 +0000)]
Obey the rules on quoting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927623 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
markt [Thu, 25 Mar 2010 22:46:12 +0000 (22:46 +0000)]
Re-fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
Regression in recent parsing re-factoring

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927621 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd an additional test case for bug 45015.
markt [Thu, 25 Mar 2010 21:41:46 +0000 (21:41 +0000)]
Add an additional test case for bug 45015.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927597 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRemove unused imports
markt [Thu, 25 Mar 2010 20:43:23 +0000 (20:43 +0000)]
Remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927591 13f79535-47bb-0310-9956-ffa450edef68

15 years agoprevent duplicate threads processing the same socket
fhanik [Thu, 25 Mar 2010 20:11:32 +0000 (20:11 +0000)]
prevent duplicate threads processing the same socket

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927576 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIgnore setenv.* so I don't accidently check it in
markt [Thu, 25 Mar 2010 19:47:33 +0000 (19:47 +0000)]
Ignore setenv.* so I don't accidently check it in

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927567 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate project name
markt [Thu, 25 Mar 2010 19:45:51 +0000 (19:45 +0000)]
Update project name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927566 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAddress various class-loader deadlock / sync issues
markt [Thu, 25 Mar 2010 19:44:41 +0000 (19:44 +0000)]
Address various class-loader deadlock / sync issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=44041
https://issues.apache.org/bugzilla/show_bug.cgi?id=48694
https://issues.apache.org/bugzilla/show_bug.cgi?id=48903

Whilst parallel class-loading would be a nice feature, the various issues that have emerged have demonstrated that anything other than synchronized(this) is likely to cause issues.

Parallel class-loading will be explored for Tomcat 7 (disabled by default) and ported back to 6.0.x when proven to be stable.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927565 13f79535-47bb-0310-9956-ffa450edef68

15 years agoClean up. The setAsync can be done in a single bottleneck, instead mixed into the...
fhanik [Thu, 25 Mar 2010 19:32:46 +0000 (19:32 +0000)]
Clean up. The setAsync can be done in a single bottleneck, instead mixed into the processor

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927555 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: Make valve Async aware - with some help from Filip
markt [Thu, 25 Mar 2010 18:11:52 +0000 (18:11 +0000)]
TCK failures: Make valve Async aware - with some help from Filip

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927525 13f79535-47bb-0310-9956-ffa450edef68

15 years agorecycle properly
fhanik [Thu, 25 Mar 2010 17:07:55 +0000 (17:07 +0000)]
recycle properly

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927502 13f79535-47bb-0310-9956-ffa450edef68

15 years agoEnable async behavior for the AJP connector
fhanik [Thu, 25 Mar 2010 16:41:05 +0000 (16:41 +0000)]
Enable async behavior for the AJP connector

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927490 13f79535-47bb-0310-9956-ffa450edef68

15 years agoPrevent looping by correctly setting the socket wrapper async state
fhanik [Thu, 25 Mar 2010 15:45:13 +0000 (15:45 +0000)]
Prevent looping by correctly setting the socket wrapper async state

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927455 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake sure start() and stop() are called on Wrappers. This was a regression in the...
markt [Thu, 25 Mar 2010 00:59:23 +0000 (00:59 +0000)]
Make sure start() and stop() are called on Wrappers. This was a regression in the recent Lifecycle changes.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927247 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse context path in debug log message
markt [Thu, 25 Mar 2010 00:33:35 +0000 (00:33 +0000)]
Use context path in debug log message

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927240 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd in a slightly different behavior for dispatch.
fhanik [Wed, 24 Mar 2010 21:26:47 +0000 (21:26 +0000)]
Add in a slightly different behavior for dispatch.
dispatch() will return immediately, according to spec. But if dispatch is called from the tomcat worker thread, then the dispatch will not happen until the worker thread has backed out of the call. This prevents multiple threads being launched into the same request/response and causing potential concurrency issues.
The Async state machine guarantees that multiple dispatch can not be called.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927182 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTracking down a memory leak. Add some debug logging to the mapper.
markt [Wed, 24 Mar 2010 16:13:29 +0000 (16:13 +0000)]
Tracking down a memory leak. Add some debug logging to the mapper.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927105 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAdd support for detecting Spring Security user names in the manager app
markt [Wed, 24 Mar 2010 14:05:15 +0000 (14:05 +0000)]
Add support for detecting Spring Security user names in the manager app

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927062 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSimpler fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48790 based on...
markt [Wed, 24 Mar 2010 12:38:23 +0000 (12:38 +0000)]
Simpler fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48790 based on a patch by kkolinko
Make maxActive thread safe. Probably unnecessary but technically a bug.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927037 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48790 in preparatio...
markt [Wed, 24 Mar 2010 12:26:11 +0000 (12:26 +0000)]
Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48790 in preparation for a simpler solution

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@927031 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: Fix session expiry on cross-context requests. Need to test the local...
markt [Tue, 23 Mar 2010 18:43:19 +0000 (18:43 +0000)]
TCK failures: Fix session expiry on cross-context requests. Need to test the local session is valid before calling access() which will make it valid again.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926716 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: Don't delegate dispatcher type to wrapped request as it may well be...
markt [Tue, 23 Mar 2010 13:16:50 +0000 (13:16 +0000)]
TCK failures: Don't delegate dispatcher type to wrapped request as it may well be different.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926562 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: Look for the right element
markt [Mon, 22 Mar 2010 22:29:18 +0000 (22:29 +0000)]
TCK failures: Look for the right element

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926379 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: Make sure FilterDefs where async-support was not defined are set to...
markt [Mon, 22 Mar 2010 22:28:38 +0000 (22:28 +0000)]
TCK failures: Make sure FilterDefs where async-support was not defined are set to the default of false before being added to the context

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926378 13f79535-47bb-0310-9956-ffa450edef68

15 years agoTCK failures: Servlets do not support async by default
markt [Mon, 22 Mar 2010 22:27:24 +0000 (22:27 +0000)]
TCK failures: Servlets do not support async by default

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926377 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSRV.9.3 says we must throw a FNFE
markt [Mon, 22 Mar 2010 21:38:52 +0000 (21:38 +0000)]
SRV.9.3 says we must throw a FNFE

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926355 13f79535-47bb-0310-9956-ffa450edef68

15 years agoProvide the method expected by the digester for adding security-role-ref elements
markt [Mon, 22 Mar 2010 21:00:24 +0000 (21:00 +0000)]
Provide the method expected by the digester for adding security-role-ref elements

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926332 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore async stuff, implement timeout handling
fhanik [Mon, 22 Mar 2010 17:44:24 +0000 (17:44 +0000)]
More async stuff, implement timeout handling

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926219 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMake method names consistent with the names the digester looks for
markt [Mon, 22 Mar 2010 14:23:26 +0000 (14:23 +0000)]
Make method names consistent with the names the digester looks for

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926101 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix some TCK issues. The behaviour is undefined in the spec, so go with the TCK requi...
markt [Mon, 22 Mar 2010 13:57:46 +0000 (13:57 +0000)]
Fix some TCK issues. The behaviour is undefined in the spec, so go with the TCK requirements

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926087 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFire listeners in reverse order for requestDestroyed
markt [Mon, 22 Mar 2010 13:18:31 +0000 (13:18 +0000)]
Fire listeners in reverse order for requestDestroyed

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926064 13f79535-47bb-0310-9956-ffa450edef68

15 years agoServlets added through the new ServletContext.addServlet(...) methods may not be...
markt [Mon, 22 Mar 2010 12:52:07 +0000 (12:52 +0000)]
Servlets added through the new ServletContext.addServlet(...) methods may not be initialised

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926055 13f79535-47bb-0310-9956-ffa450edef68

15 years agoIt is valid to call startAsync() inside a dispatched request
markt [Mon, 22 Mar 2010 11:50:53 +0000 (11:50 +0000)]
It is valid to call startAsync() inside a dispatched request

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@926042 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlways use the InstanceManager to create listeners, filters & servlets
markt [Sun, 21 Mar 2010 22:18:03 +0000 (22:18 +0000)]
Always use the InstanceManager to create listeners, filters & servlets

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@925921 13f79535-47bb-0310-9956-ffa450edef68

15 years agoArrays indexes start at zero so no need for "... + 1"
markt [Sun, 21 Mar 2010 22:17:19 +0000 (22:17 +0000)]
Arrays indexes start at zero so no need for "... + 1"

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@925920 13f79535-47bb-0310-9956-ffa450edef68

15 years agoDoh! Return the newly created registrations rather than just creating work for the...
markt [Sun, 21 Mar 2010 21:53:16 +0000 (21:53 +0000)]
Doh! Return the newly created registrations rather than just creating work for the garbage collector.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@925905 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix various exceptions that prevented one of the TCK web applications from starting
markt [Sun, 21 Mar 2010 21:22:54 +0000 (21:22 +0000)]
Fix various exceptions that prevented one of the TCK web applications from starting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@925901 13f79535-47bb-0310-9956-ffa450edef68

15 years agoFix a couple of ASync issues that were causing Servlet 3.0 TCK test failures.
markt [Sun, 21 Mar 2010 14:13:40 +0000 (14:13 +0000)]
Fix a couple of ASync issues that were causing Servlet 3.0 TCK test failures.
1. <quote section="2.3.3.3" page="17">
The complete method can be invoked by the container if the request is dispatched to a servlet that does not support async processing, or the target servlet called by AsyncContext.dispatch does not do a subsequent call to startAsync. In this case, it is the container's responsibility to call complete() as soon as that servlet's service method is exited.
</quote>
2. <quote section="2.3.3.3" page ="13">
public boolean isAsyncStarted() - Returns true if async processing has started on this request, and false otherwise. If this request has been dispatched using one of the AsyncContext.dispatch methods since it was put in asynchronous mode, or a call to AsynContext.complete is made, this method returns false.
</quote>

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@925769 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMore async stuff, only timeout left
fhanik [Fri, 19 Mar 2010 14:22:09 +0000 (14:22 +0000)]
More async stuff, only timeout left

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@925232 13f79535-47bb-0310-9956-ffa450edef68

15 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=48934
fhanik [Thu, 18 Mar 2010 13:54:27 +0000 (13:54 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=48934
The wrong sender was disconnected, should only be the sender holding the actual TCP connections.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@924776 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse better variable name.
markt [Thu, 18 Mar 2010 10:25:04 +0000 (10:25 +0000)]
Use better variable name.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@924686 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse TEMP environment for storing the autoresponse file, and make sure the file was...
mturk [Fri, 12 Mar 2010 15:52:09 +0000 (15:52 +0000)]
Use TEMP environment for storing the autoresponse file, and make sure the file was created

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@922301 13f79535-47bb-0310-9956-ffa450edef68

15 years agocorrect a comment
kkolinko [Fri, 12 Mar 2010 14:28:46 +0000 (14:28 +0000)]
correct a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@922273 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUse real exit value if shutdown via stop
mturk [Fri, 12 Mar 2010 12:13:45 +0000 (12:13 +0000)]
Use real exit value if shutdown via stop

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@922228 13f79535-47bb-0310-9956-ffa450edef68

15 years agoSuppress anoying Terminate batch job prompt when hitting CTRL+C. Note however that...
mturk [Fri, 12 Mar 2010 11:38:43 +0000 (11:38 +0000)]
Suppress anoying Terminate batch job prompt when hitting CTRL+C. Note however that it leaves the file named yes in the bin directory

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@922223 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRe-work the script to make it more Gump friendly
billbarker [Fri, 12 Mar 2010 03:52:01 +0000 (03:52 +0000)]
Re-work the script to make it more Gump friendly

No functional change for normal builds, but allows skipping a taskdef that Gump doesn't want or need when running tests.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@922136 13f79535-47bb-0310-9956-ffa450edef68

15 years agoAlternative fix for bug 48795. Add a new property to control if the next request...
markt [Thu, 11 Mar 2010 20:28:34 +0000 (20:28 +0000)]
Alternative fix for bug 48795. Add a new property to control if the next request always triggers recompilation after a compilation failure. Defaults to false and only applies in development mode

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@922010 13f79535-47bb-0310-9956-ffa450edef68

15 years agoMark the min(a,b) method as static.
kkolinko [Thu, 11 Mar 2010 18:32:39 +0000 (18:32 +0000)]
Mark the min(a,b) method as static.
Inspired by https://issues.apache.org/bugzilla/show_bug.cgi?id=44265

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@921973 13f79535-47bb-0310-9956-ffa450edef68

15 years agoRevert 921464 for rework
markt [Thu, 11 Mar 2010 13:23:09 +0000 (13:23 +0000)]
Revert 921464 for rework

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@921838 13f79535-47bb-0310-9956-ffa450edef68

15 years agoUpdate to NSIS 2.46
kkolinko [Wed, 10 Mar 2010 23:39:45 +0000 (23:39 +0000)]
Update to NSIS 2.46

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@921630 13f79535-47bb-0310-9956-ffa450edef68