markt [Sun, 3 Oct 2010 19:18:20 +0000 (19:18 +0000)]
Correct fix version. I think a few more of these need correcting. Checking now...
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1004028 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 3 Oct 2010 19:16:32 +0000 (19:16 +0000)]
Improve handling of setting primitive values on beans.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1004027 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 3 Oct 2010 17:27:42 +0000 (17:27 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49922
Don't map filter twice if filter matches multiple mapping.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1004006 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Sun, 3 Oct 2010 17:03:05 +0000 (17:03 +0000)]
Correct changelog entry for r1003923
7.0.3 was cut from r1003911, so this one will be in 7.0.4 as Mark noted in BZ
Correct a typo in the bug number. It is BZ 49998
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1004001 13f79535-47bb-0310-9956-
ffa450edef68
timw [Sun, 3 Oct 2010 06:53:15 +0000 (06:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49998
Handle single quoted attributes in detection of jsp:root element in XML syntax JSP files.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003923 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 2 Oct 2010 22:15:50 +0000 (22:15 +0000)]
Bump version
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003904 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 2 Oct 2010 21:14:37 +0000 (21:14 +0000)]
Fix NPE and TCK failures caused by previous fix for bug 49799.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003891 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 2 Oct 2010 18:53:30 +0000 (18:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49985
Make thread safe
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003861 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 2 Oct 2010 17:57:42 +0000 (17:57 +0000)]
Revert r1003552 & r1003550 as it had a significant negative performance impact (orders of magnitude) on Windows during testing.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003846 13f79535-47bb-0310-9956-
ffa450edef68
mturk [Sat, 2 Oct 2010 17:32:14 +0000 (17:32 +0000)]
Create service-install.log file during installation with params that were used to invoke commons daemon
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003840 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 17:29:03 +0000 (17:29 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49916
Switch to using an initialisation parameter to pass JSP file information from Catalina to Jasper. This simplifies the Catalina code as well as making it easier for Geronimo and others to integrate Jasper.
Patch provided by David Jencks.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003589 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 16:49:29 +0000 (16:49 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49915
Make error more obvious, particularly when accessed via JConsole, if StandardServer.storeConfig() is called when there is no StoreConfig implementation present.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003581 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 16:34:37 +0000 (16:34 +0000)]
Update changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003574 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 16:32:31 +0000 (16:32 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49905
Prevent memory leak when using aysnc session replication
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003572 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 15:08:23 +0000 (15:08 +0000)]
-e doesn't exist on Solaris
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003556 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 14:58:43 +0000 (14:58 +0000)]
Add a TODO
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003552 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 14:54:53 +0000 (14:54 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49890
Detect when the JVM bug occurs and log an error asking for more information.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003550 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 14:36:31 +0000 (14:36 +0000)]
getKeyCount() didn't do anything due to local variable definition
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003548 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 11:37:05 +0000 (11:37 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49861
Don't use commas when logging RMI port values
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003488 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 11:15:56 +0000 (11:15 +0000)]
Fix Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003485 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 11:10:51 +0000 (11:10 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49667
Ensure JDBC leak prevention code doesn't trigger the very memory leak it is meant to be fixing.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003481 13f79535-47bb-0310-9956-
ffa450edef68
markt [Fri, 1 Oct 2010 10:21:58 +0000 (10:21 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49860
Add support for trailing headers
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003461 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 21:47:46 +0000 (21:47 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49856
Add an executorName attribute to Connectors so it is possible to trace ThreadPool to Connector to Executor via JMX.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003304 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 21:40:11 +0000 (21:40 +0000)]
Fix Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003301 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 21:39:16 +0000 (21:39 +0000)]
Register and deregister Executors in JMX
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003299 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 18:00:23 +0000 (18:00 +0000)]
Fix warnings in this package
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003187 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 17:56:42 +0000 (17:56 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49730
Race condition in executor can lead to long delays in request processing
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003183 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 17:35:35 +0000 (17:35 +0000)]
Fix the root cause of the previous TCK failures (badly re-factored flush()) and restore the changes that were just working around the symptoms (poller stuff).
Servlet 3.0 passes for the AJP/APR connector as of this commit.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003177 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 16:16:05 +0000 (16:16 +0000)]
Fix remaining issues with AJP/APR and TCK. Note mod_jk log is full of warnings so there is still work to do here.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003136 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 13:44:11 +0000 (13:44 +0000)]
Fix some of the remaining issues with the AJP/APR connector post async refactoring. Still does not pass the TCK.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1003065 13f79535-47bb-0310-9956-
ffa450edef68
kfujino [Thu, 30 Sep 2010 02:49:34 +0000 (02:49 +0000)]
Avoid NPE when mapOwner is null.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002935 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 00:31:33 +0000 (00:31 +0000)]
Clean-up. No functional change.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002912 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 00:28:59 +0000 (00:28 +0000)]
Get AJP working after async refactoring. Some issues remain with AJP/APR connector which still has a handful of TCK failures.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002911 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 30 Sep 2010 00:27:45 +0000 (00:27 +0000)]
Minor clean-up to align with AJP
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002910 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 16:18:21 +0000 (16:18 +0000)]
Tweak the refactoring
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002714 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 16:13:05 +0000 (16:13 +0000)]
Re-factor the async state machine into a separate class so it can be re-used for the AJP processors as well.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002711 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 16:02:24 +0000 (16:02 +0000)]
Rename local variable to make code clearer
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002703 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 15:36:54 +0000 (15:36 +0000)]
Refactor logging
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002683 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 15:21:53 +0000 (15:21 +0000)]
Reduce code duplication in the APR connectors (prior to aligning with the Async refactoring)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002673 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 10:15:51 +0000 (10:15 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50021
Don't reference ExceptionUtisl from Bootstrap - it won't be visible at startup.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002562 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 29 Sep 2010 10:07:10 +0000 (10:07 +0000)]
Fix error in fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Should use ExcpetionUtils from o.a.tomcat.util, not o.a.jasper.util
Fixed with the help of Eclipe's organise imports that also removed a few unused imports.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002556 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Wed, 29 Sep 2010 08:18:52 +0000 (08:18 +0000)]
Correct a typo in message
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002514 13f79535-47bb-0310-9956-
ffa450edef68
timw [Wed, 29 Sep 2010 08:08:32 +0000 (08:08 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=50018
Minor javadoc corrections in Jasper.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002509 13f79535-47bb-0310-9956-
ffa450edef68
mturk [Wed, 29 Sep 2010 05:43:57 +0000 (05:43 +0000)]
Be consistent with CATALINA_PID quoting and always redirect all streams to /dev/null cause we are interested only in return value
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002481 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 21:30:27 +0000 (21:30 +0000)]
More review comments form mturk. Tighten up handling of ps output.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002362 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 21:20:06 +0000 (21:20 +0000)]
Respond to mturk's review. Make rm more robust. Avoid potential issues with (...).
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002359 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 20:43:32 +0000 (20:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49195
Avoid error message when shutting down Windows service when the shutdown port is disabled.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002349 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 17:23:05 +0000 (17:23 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665
Better handling for missing TLD files. Report JSP filename and location.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002274 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 17:02:33 +0000 (17:02 +0000)]
Update
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002264 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 16:59:54 +0000 (16:59 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49728
Improve PID file handling, particularly when another process creates it and Tomcat is unable to write to the file.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002263 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 14:43:03 +0000 (14:43 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49657
Correctly handle CGI executables with spaces in the name/path
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002185 13f79535-47bb-0310-9956-
ffa450edef68
markt [Tue, 28 Sep 2010 12:08:53 +0000 (12:08 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49625
Ensure Vary header is set if response may be compressed rather than only setting it if it is compressed.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002133 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Tue, 28 Sep 2010 11:37:14 +0000 (11:37 +0000)]
Add license header
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002120 13f79535-47bb-0310-9956-
ffa450edef68
timw [Tue, 28 Sep 2010 09:36:08 +0000 (09:36 +0000)]
Moved all Eclipse specific files into res/ide-support/eclipse.
Removed spaces from launch target filenames.
Corrected launch targets to run in output/build instead of root directory (still not sure if they're a good idea)
Added an Ant ide-eclipse target to prepare the working copy to be built with Eclipse and create Eclipse project files.
Updated the Building docs to document new Eclipse setup method.
Added descriptions of how to configure Eclipse to respect Tomcat coding conventions to the Building guide.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002073 13f79535-47bb-0310-9956-
ffa450edef68
timw [Tue, 28 Sep 2010 09:28:30 +0000 (09:28 +0000)]
Adding myself to active devs list.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1002070 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 23:09:54 +0000 (23:09 +0000)]
Update
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001958 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 23:06:08 +0000 (23:06 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49209
Prevent possible AccessControlException during undeployment when running with a security manager
Patch provided by Sylvain Laurent
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001955 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:31:03 +0000 (22:31 +0000)]
Update
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001941 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:29:30 +0000 (22:29 +0000)]
Remaining fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001939 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:22:02 +0000 (22:22 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001938 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:17:30 +0000 (22:17 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001934 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:16:26 +0000 (22:16 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001933 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:12:05 +0000 (22:12 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001932 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 22:01:45 +0000 (22:01 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001923 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 21:32:25 +0000 (21:32 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001915 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 20:52:49 +0000 (20:52 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Some Throwables must always be re-thrown
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001904 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 20:24:18 +0000 (20:24 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48644
Don't catch Throwable
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001899 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 12:58:06 +0000 (12:58 +0000)]
Fix comment typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001719 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 12:56:38 +0000 (12:56 +0000)]
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001718 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 12:13:32 +0000 (12:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49884
This required a major re-factoring of the async implementation. In summary:
- Moved state management to the Coyote Processor
- Added a SocketWrapper to the APR socket
- Added syncs to ensure only one async state change at a time
- Added syncs to ensure only one thread changing a socket's state at a time
A number of new bugs were also uncovered and fixed by this re-factoring:
- delay processing complete() and dispatch() until request where startAsync() is called finished processing
- onAsyncStart listener event
Currently the test case for bug 49884 passes with the security manager enabled using "ab -n 5000 -c 150 -k ..." (it broke with "ab -n 50 -c 10 ..." previously)
The unit tests pass for all three HTTP connectors.
The AJP connectors have only been modified to ensure the code compiles.
The following work remains:
- Testing all connectors (HTTP and AJP) with TCK + security manager and fixing whatever is broken
- Further clean-up
- There is further scope for reducing code duplication between the connectors / aligning the code so it is easier to maintain.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001698 13f79535-47bb-0310-9956-
ffa450edef68
markt [Mon, 27 Sep 2010 00:17:26 +0000 (00:17 +0000)]
Change method name so it is easier to distinguish between async and comet processing. No so important here since comet isn't supported, but need to change it to align with changes to be made in NIO and APR
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001564 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 22:58:38 +0000 (22:58 +0000)]
Remove some unused code.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001553 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 22:50:30 +0000 (22:50 +0000)]
More NPE avoidance.
Keep process methods aligned.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001552 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 22:46:35 +0000 (22:46 +0000)]
Fix a handful of Eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001548 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 22:38:14 +0000 (22:38 +0000)]
Since SocketStatus is always OPEN or TIMEOUT for BIO, remove the test.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001546 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 22:37:31 +0000 (22:37 +0000)]
Add some Javadoc.
Use SocketStatus.OPEN rather than STOP since the BIO connector treats them the same way and it reduces code complexity. It also simplifies async re-factoring I have in the works,
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001545 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 22:22:25 +0000 (22:22 +0000)]
Better Javadoc.
If endpoint is shutting down, return false so connection to client is closed immediately.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001538 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 21:26:08 +0000 (21:26 +0000)]
Clean-up. Reduce whitespace, unnecessary comments
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001525 13f79535-47bb-0310-9956-
ffa450edef68
markt [Sun, 26 Sep 2010 17:57:07 +0000 (17:57 +0000)]
Tab police
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001485 13f79535-47bb-0310-9956-
ffa450edef68
timw [Sun, 26 Sep 2010 07:46:27 +0000 (07:46 +0000)]
Fixing Tomcat startup class in building instructions.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1001383 13f79535-47bb-0310-9956-
ffa450edef68
mturk [Fri, 24 Sep 2010 06:00:00 +0000 (06:00 +0000)]
Fix Bz #49993 by checking the JAVA_HOME/JRE_HOME environment variables
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000718 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 23 Sep 2010 21:08:14 +0000 (21:08 +0000)]
Reduce timeout from 60s to 3s to speed up async tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000625 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Thu, 23 Sep 2010 12:46:50 +0000 (12:46 +0000)]
Add a comment.
I guess it is too late to change it now, as the code is more than 3 years old.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000433 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Thu, 23 Sep 2010 12:15:56 +0000 (12:15 +0000)]
Take care of line endings for the two files added in r1000392
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000423 13f79535-47bb-0310-9956-
ffa450edef68
timw [Thu, 23 Sep 2010 10:38:56 +0000 (10:38 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102
Protecting AJP code -> header/method lookup arrays with getters.
No measurable slowdown (especially after a profiling JIT gets done with it).
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000400 13f79535-47bb-0310-9956-
ffa450edef68
timw [Thu, 23 Sep 2010 10:15:16 +0000 (10:15 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
Improvements and corrections for the Building Tomcat guide, plus
sample Eclipse launch targets.
Based on contribution from Wesley Acheson.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000392 13f79535-47bb-0310-9956-
ffa450edef68
timw [Thu, 23 Sep 2010 10:14:54 +0000 (10:14 +0000)]
Adding a description for build-docs task
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000391 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 23 Sep 2010 00:30:53 +0000 (00:30 +0000)]
Fix Javadoc warnings highlighted by buildbot
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000284 13f79535-47bb-0310-9956-
ffa450edef68
markt [Thu, 23 Sep 2010 00:19:20 +0000 (00:19 +0000)]
Parameterize the APR location for the unit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000283 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 22 Sep 2010 22:59:55 +0000 (22:59 +0000)]
Correctly define the ROOT context in unit tests
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000269 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 22 Sep 2010 20:04:32 +0000 (20:04 +0000)]
Add the missing onStartAsync event
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000164 13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Wed, 22 Sep 2010 14:48:53 +0000 (14:48 +0000)]
Improving the documentation for logging configuration in Apache Tomcat
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@
1000003 13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 22 Sep 2010 14:47:16 +0000 (14:47 +0000)]
Fix typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999995
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 22 Sep 2010 14:34:23 +0000 (14:34 +0000)]
Need ant-launcher.jar to compile JSPs with Ant rather than ECJ
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999980
13f79535-47bb-0310-9956-
ffa450edef68
mturk [Wed, 22 Sep 2010 14:29:07 +0000 (14:29 +0000)]
Use *modern* types of nsis install/uninstall icons
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999976
13f79535-47bb-0310-9956-
ffa450edef68
mturk [Wed, 22 Sep 2010 14:22:48 +0000 (14:22 +0000)]
Add connector wait for shutdown to changelog
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999972
13f79535-47bb-0310-9956-
ffa450edef68
markt [Wed, 22 Sep 2010 14:18:48 +0000 (14:18 +0000)]
Delete reference to option that was previously removed.
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999966
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Wed, 22 Sep 2010 13:15:46 +0000 (13:15 +0000)]
add release date for 7.0.2 beta,
from announcement on tomcat.apache.org
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999929
13f79535-47bb-0310-9956-
ffa450edef68
kkolinko [Tue, 21 Sep 2010 18:21:38 +0000 (18:21 +0000)]
correct a typo
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@999523
13f79535-47bb-0310-9956-
ffa450edef68
markt [Sat, 18 Sep 2010 21:41:44 +0000 (21:41 +0000)]
Remove unused code as identified by UCDetector
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@998554
13f79535-47bb-0310-9956-
ffa450edef68