tomcat7.0
16 years agomore javadoc and corrections
fhanik [Tue, 14 Jul 2009 00:08:01 +0000 (00:08 +0000)]
more javadoc and corrections

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793761 13f79535-47bb-0310-9956-ffa450edef68

16 years ago1. Ensure that any user defined CLASSPATH variables are not used on startup
kkolinko [Tue, 14 Jul 2009 00:01:01 +0000 (00:01 +0000)]
1. Ensure that any user defined CLASSPATH variables are not used on startup
(as is already implemented since rev.303663),
but now allow them to be specified in setenv.sh, in rare case when it is needed.

2. When preparing the CLASSPATH, do not treat the "debug" command specially,
because jdb does not need the tools.jar file.

3. Remove some wrong quotes in tool-wrapper.bat.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793757 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove not used methods
fhanik [Mon, 13 Jul 2009 22:29:16 +0000 (22:29 +0000)]
remove not used methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793733 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd tons of javadoc
fhanik [Mon, 13 Jul 2009 22:18:17 +0000 (22:18 +0000)]
Add tons of javadoc
Remove the finalizers, they behave way differently in the new JDK, so let the programmer be responsible for closures

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793732 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReplace o.a.catalina.util.StringManager with o.a.tomcat.util.res.StringManager
markt [Mon, 13 Jul 2009 22:03:12 +0000 (22:03 +0000)]
Replace o.a.catalina.util.StringManager with o.a.tomcat.util.res.StringManager
Catalina depends on o.a.tomcat.util already
Reduces duplicate code (which was also out of sync with latest updates)
The svn log for o.a.catalina.util.StringManager suggests this was the plan

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793728 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPrep required for the o.a.tomcat.util.res.StringManager to replace the o.a.c.util...
markt [Mon, 13 Jul 2009 21:49:14 +0000 (21:49 +0000)]
Prep required for the o.a.tomcat.util.res.StringManager to replace the o.a.c.util.StringManager
Adds handling for when classloaders common != server != shared

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793722 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused classes identified by the UCDetector plug-in
markt [Mon, 13 Jul 2009 20:20:59 +0000 (20:20 +0000)]
Remove unused classes identified by the UCDetector plug-in

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793694 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate to commons pool 1.5.2 to get latest fixes
markt [Mon, 13 Jul 2009 19:45:32 +0000 (19:45 +0000)]
Update to commons pool 1.5.2 to get latest fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793682 13f79535-47bb-0310-9956-ffa450edef68

16 years agoExplicitely return value 0 if we return without error
rjung [Mon, 13 Jul 2009 19:16:49 +0000 (19:16 +0000)]
Explicitely return value 0 if we return without error
from setclasspath.bat. Otherwise errorlevel in catalina.bat
is not reset.

catalina.bat checks for non-zero errorlevel after
the call to setclasspath.bat and then fails silently,
because it assumes setclasspath.bat to log any error.

If there is an error above the call to setclasspath.bat,
catalina.bat fails without any message.

Since there is only very basic logic above the call
to setclasspath.bat, let us reset errorlevel to ignore errors.

Example: any "set myvar=" for an undefined variable myvar
sets errorlevel to 1, although it is a correct statement,
setting the variable to an empty value.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793669 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTrack the TLD URIs processed for each webapp and don't process duplicates.
markt [Mon, 13 Jul 2009 16:43:26 +0000 (16:43 +0000)]
Track the TLD URIs processed for each webapp and don't process duplicates.
Because this tracks duplicate status in the RuleSet, each digester needs its own RuleSet rather than sharing the static one.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793621 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClear props - stops weird TortoiseSvn behaviour
markt [Mon, 13 Jul 2009 14:55:27 +0000 (14:55 +0000)]
Clear props - stops weird TortoiseSvn behaviour

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793600 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd some ignores
markt [Mon, 13 Jul 2009 14:53:32 +0000 (14:53 +0000)]
Add some ignores

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793598 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCreate a package file for the JavaDoc main package
fhanik [Mon, 13 Jul 2009 14:50:49 +0000 (14:50 +0000)]
Create a package file for the JavaDoc main package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793597 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAlternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
markt [Sun, 12 Jul 2009 16:28:21 +0000 (16:28 +0000)]
Alternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
Only add tools.jar to classpath when using debug option
Remove references to undocumented, half-implemented javac option
Remove unused environment variables

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793372 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r791331 that fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
markt [Sun, 12 Jul 2009 16:07:58 +0000 (16:07 +0000)]
Revert r791331 that fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=39194

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793369 13f79535-47bb-0310-9956-ffa450edef68

16 years agofix assertion
fhanik [Fri, 10 Jul 2009 21:40:26 +0000 (21:40 +0000)]
fix assertion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793117 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSome more concurrency testing
fhanik [Fri, 10 Jul 2009 21:38:16 +0000 (21:38 +0000)]
Some more concurrency testing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793116 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix a concurrency issue with connections being released and then trying to be reconnected
fhanik [Fri, 10 Jul 2009 21:02:43 +0000 (21:02 +0000)]
Fix a concurrency issue with connections being released and then trying to be reconnected

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793108 13f79535-47bb-0310-9956-ffa450edef68

16 years agojavadoc
fhanik [Fri, 10 Jul 2009 19:48:26 +0000 (19:48 +0000)]
javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793093 13f79535-47bb-0310-9956-ffa450edef68

16 years agocorrect dependency
fhanik [Fri, 10 Jul 2009 18:17:37 +0000 (18:17 +0000)]
correct dependency

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793062 13f79535-47bb-0310-9956-ffa450edef68

16 years agojavadoc corrections
fhanik [Fri, 10 Jul 2009 18:10:30 +0000 (18:10 +0000)]
javadoc corrections

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793060 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove dbcp
fhanik [Fri, 10 Jul 2009 17:16:25 +0000 (17:16 +0000)]
remove dbcp
add classpath to javadoc
start documenting DataSource

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793042 13f79535-47bb-0310-9956-ffa450edef68

16 years agowere not using DBCP anywhere
fhanik [Fri, 10 Jul 2009 17:08:35 +0000 (17:08 +0000)]
were not using DBCP anywhere

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793040 13f79535-47bb-0310-9956-ffa450edef68

16 years agocorrect counter behavior.
fhanik [Fri, 10 Jul 2009 16:42:00 +0000 (16:42 +0000)]
correct counter behavior.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793029 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBetter notes for future reference
markt [Fri, 10 Jul 2009 16:28:41 +0000 (16:28 +0000)]
Better notes for future reference

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793021 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r792945 - JSP.7.3.6.1 explicitly states locations without a leading '/' are...
markt [Fri, 10 Jul 2009 16:26:56 +0000 (16:26 +0000)]
Revert r792945 - JSP.7.3.6.1 explicitly states locations without a leading '/' are to be treated as relative to web.xml

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793019 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdded some comments and more thread safety around the size of the pool
fhanik [Fri, 10 Jul 2009 16:25:14 +0000 (16:25 +0000)]
Added some comments and more thread safety around the size of the pool

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793017 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd documentation and clarification around JMX
fhanik [Fri, 10 Jul 2009 16:02:57 +0000 (16:02 +0000)]
Add documentation and clarification around JMX

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793002 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect location of taglib element varies with spec version. WebRuleSet was using...
markt [Fri, 10 Jul 2009 15:53:59 +0000 (15:53 +0000)]
Correct location of taglib element varies with spec version. WebRuleSet was using 2.3 and earlier location. Update it to a) support 2.4 and later as well as 2.3 and earlier b) complain if taglib definition location is not consistent with declared spec version.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792996 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd manifest to binary JAR
fhanik [Fri, 10 Jul 2009 15:03:43 +0000 (15:03 +0000)]
Add manifest to binary JAR
Fix XML error in doc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792969 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd new jar to TLD exclusion list
markt [Fri, 10 Jul 2009 13:52:14 +0000 (13:52 +0000)]
Add new jar to TLD exclusion list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792954 13f79535-47bb-0310-9956-ffa450edef68

16 years agoServlet DTD and JSP spec are both quite clear that a <taglib-location> is <quote...
markt [Fri, 10 Jul 2009 13:27:01 +0000 (13:27 +0000)]
Servlet DTD and JSP spec are both quite clear that a <taglib-location> is <quote>a resource
relative to the root of the web application</quote>

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792945 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix infinite loop. Spotted by GSOC student Xie Xiaodong.
markt [Fri, 10 Jul 2009 10:13:11 +0000 (10:13 +0000)]
Fix infinite loop. Spotted by GSOC student Xie Xiaodong.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792863 13f79535-47bb-0310-9956-ffa450edef68

16 years agoNeeds to be volatile as it is used in double checked locking
markt [Fri, 10 Jul 2009 10:10:18 +0000 (10:10 +0000)]
Needs to be volatile as it is used in double checked locking

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792862 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused properties:
kkolinko [Thu, 9 Jul 2009 23:15:09 +0000 (23:15 +0000)]
Remove unused properties:
build.xml uses them, but dist.xml and extras.xml do not

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792745 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove build-webapps-precompile target from dist.xml
kkolinko [Thu, 9 Jul 2009 22:58:13 +0000 (22:58 +0000)]
Remove build-webapps-precompile target from dist.xml
Discussion: http://markmail.org/thread/ymgbgqm3lav6rnjh

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792740 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47149
kkolinko [Thu, 9 Jul 2009 22:53:56 +0000 (22:53 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47149
Explicitly specify encoding for the source files

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792739 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReduce coupling between StandardSession and JAAS as per Filip's suggestion
markt [Thu, 9 Jul 2009 08:35:39 +0000 (08:35 +0000)]
Reduce coupling between StandardSession and JAAS as per Filip's suggestion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792446 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove dependency on the modeler so that the pool can run outside of tomcat and still...
fhanik [Wed, 8 Jul 2009 22:34:40 +0000 (22:34 +0000)]
remove dependency on the modeler so that the pool can run outside of tomcat and still have jmx query notifications.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792340 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a manifest template for an osgi bundle
fhanik [Wed, 8 Jul 2009 16:31:20 +0000 (16:31 +0000)]
Add a manifest template for an osgi bundle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792216 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDocument a missing option
markt [Wed, 8 Jul 2009 12:49:12 +0000 (12:49 +0000)]
Document a missing option

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792120 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImprove shutdown time for NIO connectors, to block in a minimal fashion, yet leave...
fhanik [Tue, 7 Jul 2009 17:21:15 +0000 (17:21 +0000)]
Improve shutdown time for NIO connectors, to block in a minimal fashion, yet leave the pollers time to close out their connections

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791914 13f79535-47bb-0310-9956-ffa450edef68

16 years agoWhen shutting down, to so immediately
fhanik [Tue, 7 Jul 2009 17:08:31 +0000 (17:08 +0000)]
When shutting down, to so immediately

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791912 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd milliseconds, seconds is not granular enough for log entries
fhanik [Tue, 7 Jul 2009 17:08:05 +0000 (17:08 +0000)]
Add milliseconds, seconds is not granular enough for log entries

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791911 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
markt [Tue, 7 Jul 2009 16:33:02 +0000 (16:33 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
The JAAS contract for LoginModule says we have to call logout(). This won't always work (eg if there is no session) but is a reasonable effort.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791900 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove standardSession strings not used by DeltaSession
kkolinko [Tue, 7 Jul 2009 10:50:40 +0000 (10:50 +0000)]
Remove standardSession strings not used by DeltaSession

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791789 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpper case was a red herring.
markt [Mon, 6 Jul 2009 22:52:31 +0000 (22:52 +0000)]
Upper case was a red herring.
Thanks to http://greenbytes.de/tech/webdav/webdav-redirector-list.html

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791643 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTypo
markt [Mon, 6 Jul 2009 22:42:10 +0000 (22:42 +0000)]
Typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791641 13f79535-47bb-0310-9956-ffa450edef68

16 years agoXP 32-bit SP3 works with the re-direct
markt [Mon, 6 Jul 2009 22:41:38 +0000 (22:41 +0000)]
XP 32-bit SP3 works with the re-direct

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791640 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake webDAV fix filter more sophisticated. Eventual aim is to provide fixes tailored...
markt [Mon, 6 Jul 2009 22:20:11 +0000 (22:20 +0000)]
Make webDAV fix filter more sophisticated. Eventual aim is to provide fixes tailored to whichever broken client is trying to connect. Once I figure out how the client is broken of course. In the meantime, log when we know things go wrong. First up XP x64 SP2.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791634 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix copy and paste error
markt [Mon, 6 Jul 2009 21:19:39 +0000 (21:19 +0000)]
Fix copy and paste error

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791619 13f79535-47bb-0310-9956-ffa450edef68

16 years agoConvert the WebDAV fix valve to a filter.
markt [Mon, 6 Jul 2009 21:06:13 +0000 (21:06 +0000)]
Convert the WebDAV fix valve to a filter.
Based on a patch provided by Xie Xiaodong as part of GSOC 2009

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791616 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix
fhanik [Mon, 6 Jul 2009 15:45:32 +0000 (15:45 +0000)]
Fix
https://issues.apache.org/bugzilla/show_bug.cgi?id=47478
Patch provided by Keiichi Fujino

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791524 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
markt [Sun, 5 Jul 2009 22:46:51 +0000 (22:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
Align classpath for all platforms:
 - only add tools.jar to the classpath when required
 - document optional javac argument for catalina.sh|bat
 - make sure javac without generating warnings on start
Include a patch for setclasspath.sh by Jason Brittain

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791331 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd the CLAASSPATH to the output (will be useful while working on 39194 as well as...
markt [Sun, 5 Jul 2009 21:48:51 +0000 (21:48 +0000)]
Add the CLAASSPATH to the output (will be useful while working on 39194 as well as generally useful to see if it has been modified from the default)
Fix a minor alignment niggle with JRE_HOME in cataina.sh

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791328 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAs of JDK 1.4, JSSE was no longer a separate download
markt [Sun, 5 Jul 2009 21:45:32 +0000 (21:45 +0000)]
As of JDK 1.4, JSSE was no longer a separate download
No need to include it in the startup scripts

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791326 13f79535-47bb-0310-9956-ffa450edef68

16 years agomissprint
kkolinko [Sun, 5 Jul 2009 20:26:13 +0000 (20:26 +0000)]
missprint

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791310 13f79535-47bb-0310-9956-ffa450edef68

16 years agoadd indent
kkolinko [Sun, 5 Jul 2009 20:23:57 +0000 (20:23 +0000)]
add indent

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791308 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=39089
markt [Sun, 5 Jul 2009 14:24:43 +0000 (14:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39089
Add a know issues section to the Jasper docs detailing the error described in 39089 and providing some possible workarounds

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791254 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImprove error message to include TDL uri when there is a problem with a tld so user...
markt [Sun, 5 Jul 2009 13:25:21 +0000 (13:25 +0000)]
Improve error message to include TDL uri when there is a problem with a tld so user knows which TLD to look at

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791243 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove deprecated methods that are no longer used
markt [Sun, 5 Jul 2009 12:38:17 +0000 (12:38 +0000)]
Remove deprecated methods that are no longer used

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791235 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
markt [Sun, 5 Jul 2009 11:30:22 +0000 (11:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
Revert previous fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implement an alternative that doesn't have the side effects described in 38797

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791224 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert generics changes that require changes in spec classes
markt [Sun, 5 Jul 2009 11:11:57 +0000 (11:11 +0000)]
Revert generics changes that require changes in spec classes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791219 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSpecify explicit encoding when performing replace task.
kkolinko [Sun, 5 Jul 2009 00:17:22 +0000 (00:17 +0000)]
Specify explicit encoding when performing replace task.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791194 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix generics warnings
kkolinko [Sat, 4 Jul 2009 23:10:05 +0000 (23:10 +0000)]
Fix generics warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791186 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdded **/*.rtf to the list of exclusions and sorted it alphabetically.
kkolinko [Sat, 4 Jul 2009 22:58:08 +0000 (22:58 +0000)]
Added **/*.rtf to the list of exclusions and sorted it alphabetically.
(We have a License.rtf file)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791184 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDeprecation fixes
markt [Sat, 4 Jul 2009 15:59:05 +0000 (15:59 +0000)]
Deprecation fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791144 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove some unused code
markt [Sat, 4 Jul 2009 15:55:48 +0000 (15:55 +0000)]
Remove some unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791142 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix generics warnings
markt [Sat, 4 Jul 2009 15:46:47 +0000 (15:46 +0000)]
Fix generics warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791139 13f79535-47bb-0310-9956-ffa450edef68

16 years agoExplicitly specify encoding for the source files
kkolinko [Sat, 4 Jul 2009 00:06:05 +0000 (00:06 +0000)]
Explicitly specify encoding for the source files
Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=47149

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@791041 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMove everyone MarkMail says hasn't committed to trunk to retired. Crude, but results...
markt [Fri, 3 Jul 2009 06:55:26 +0000 (06:55 +0000)]
Move everyone MarkMail says hasn't committed to trunk to retired. Crude, but results match what I expected.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790809 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd me. Needs more cleanup for TC7
markt [Fri, 3 Jul 2009 06:44:52 +0000 (06:44 +0000)]
Add me. Needs more cleanup for TC7

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790806 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47443
markt [Fri, 3 Jul 2009 06:41:40 +0000 (06:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47443
Point to wiki for support rather than non-existent Jakarta page

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790805 13f79535-47bb-0310-9956-ffa450edef68

16 years agobreak out javadoc into its own target
fhanik [Thu, 2 Jul 2009 17:35:26 +0000 (17:35 +0000)]
break out javadoc into its own target

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790693 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd some doco, make shared variables volatile
fhanik [Thu, 2 Jul 2009 17:08:50 +0000 (17:08 +0000)]
Add some doco, make shared variables volatile

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790684 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSince testing is an optional feature, as Sebb said, we don't need the licenses defined
fhanik [Thu, 2 Jul 2009 15:02:19 +0000 (15:02 +0000)]
Since testing is an optional feature, as Sebb said, we don't need the licenses defined

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790612 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBe consistent - use singular rather than plural
markt [Thu, 2 Jul 2009 08:15:15 +0000 (08:15 +0000)]
Be consistent - use singular rather than plural

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790491 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=37984
markt [Wed, 1 Jul 2009 22:13:33 +0000 (22:13 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37984
Strip {MD5} as well as {SHA} from digested passwords

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790405 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused import
markt [Wed, 1 Jul 2009 22:08:43 +0000 (22:08 +0000)]
Remove unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@790401 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove some obsolete (and partially broken)
rjung [Tue, 30 Jun 2009 20:48:05 +0000 (20:48 +0000)]
Remove some obsolete (and partially broken)
message strings.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789944 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect url
fhanik [Tue, 30 Jun 2009 20:42:17 +0000 (20:42 +0000)]
Correct url

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789941 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r784853 - it broke most of the links in the left hand navigation menu for...
markt [Tue, 30 Jun 2009 20:16:32 +0000 (20:16 +0000)]
Revert r784853 - it broke most of the links in the left hand navigation menu for the docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789923 13f79535-47bb-0310-9956-ffa450edef68

16 years agoApply patch by sebb from
fhanik [Tue, 30 Jun 2009 19:15:28 +0000 (19:15 +0000)]
Apply patch by sebb from
https://issues.apache.org/bugzilla/show_bug.cgi?id=47458
Store db properties in build.properties using a prefix of testdb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789883 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse statics to reduce number of instances to one per thread rather than one per threa...
markt [Tue, 30 Jun 2009 18:30:45 +0000 (18:30 +0000)]
Use statics to reduce number of instances to one per thread rather than one per thread per access log.
Also make thread local final as per discussion on dev list.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789865 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove all usage of GPL or LGPL downloads.
fhanik [Mon, 29 Jun 2009 17:38:21 +0000 (17:38 +0000)]
Remove all usage of GPL or LGPL downloads.
Use H2 for test database (EPL1.0) as it can be downloaded and easily embedded.
Derby didn't work, too slow to populate test data with.
Add Javadoc per Sebb's suggestion.
Add EPL and CPL to LICENSE since we use it in the unit test cases.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789392 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd props changes missed in r789389
markt [Mon, 29 Jun 2009 17:27:35 +0000 (17:27 +0000)]
Add props changes missed in r789389

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789390 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix the JDBC driver clean-up. This was broken with the latest 1.4.x, 1.5.x and 1...
markt [Mon, 29 Jun 2009 17:20:24 +0000 (17:20 +0000)]
Fix the JDBC driver clean-up. This was broken with the latest 1.4.x, 1.5.x and 1.6.x JVMs as they checked if the classloader of the caller, which for the WebappClassLoader was the common loader.
It's not pretty, so there are plenty of comments explaining what is going on.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789389 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake alphabetical
markt [Mon, 29 Jun 2009 16:06:11 +0000 (16:06 +0000)]
Make alphabetical

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789372 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake properties configurable and resolve https://issues.apache.org/bugzilla/show_bug...
fhanik [Mon, 29 Jun 2009 14:36:57 +0000 (14:36 +0000)]
Make properties configurable and resolve https://issues.apache.org/bugzilla/show_bug.cgi?id=47440

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789345 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBetter error message according to
fhanik [Sun, 28 Jun 2009 15:58:13 +0000 (15:58 +0000)]
Better error message according to
https://issues.apache.org/bugzilla/show_bug.cgi?id=47439

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@789116 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdjust Main
costin [Thu, 25 Jun 2009 15:22:55 +0000 (15:22 +0000)]
Adjust Main

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@788390 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdjusting the tests
costin [Thu, 25 Jun 2009 15:16:44 +0000 (15:16 +0000)]
Adjusting the tests

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@788385 13f79535-47bb-0310-9956-ffa450edef68

16 years ago- added new methods stups from servlet, so it compiles
costin [Thu, 25 Jun 2009 15:00:52 +0000 (15:00 +0000)]
- added new methods stups from servlet, so it compiles
- removed all deps on coyote, it can now run with the new async connector from sandbox ( still need to update ). Coyote is still the default
- various cleanups in the simple/example integration support
- still passes all watchdog servlet and all but 7 jsp tests
- more separation between the servlets/filters and the engine - and few tweaks to allow file servlet to be used in other containers.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@788376 13f79535-47bb-0310-9956-ffa450edef68

16 years agoVery minor niggle
markt [Wed, 24 Jun 2009 20:56:19 +0000 (20:56 +0000)]
Very minor niggle

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@788180 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAnt doesn't merge two zipfilesets
mturk [Wed, 24 Jun 2009 14:53:06 +0000 (14:53 +0000)]
Ant doesn't merge two zipfilesets

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@788043 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDo not evaluate the same string twice.
kkolinko [Wed, 24 Jun 2009 11:44:45 +0000 (11:44 +0000)]
Do not evaluate the same string twice.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@787985 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdated the changelog
kkolinko [Wed, 24 Jun 2009 11:28:14 +0000 (11:28 +0000)]
Updated the changelog

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@787981 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdated Jasper runtime and JspC to use "1.6" as the values for compilerSourceVM,...
kkolinko [Wed, 24 Jun 2009 11:17:24 +0000 (11:17 +0000)]
Updated Jasper runtime and JspC to use "1.6" as the values for compilerSourceVM, compilerTargetVM options by default,
as Tomcat 7 runs on JRE 1.6+

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@787978 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r787678. Needs a rethink as Catalina TLD scanning did not require a URLClassLo...
markt [Tue, 23 Jun 2009 19:31:39 +0000 (19:31 +0000)]
Revert r787678. Needs a rethink as Catalina TLD scanning did not require a URLClassLoader whereas the Jasper code does.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@787798 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse correct encoding for error/debug messages include parameter bytes
markt [Tue, 23 Jun 2009 18:04:43 +0000 (18:04 +0000)]
Use correct encoding for error/debug messages include parameter bytes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@787770 13f79535-47bb-0310-9956-ffa450edef68