tomcat7.0
16 years agoUpdate to commons pool 1.5.4 (fix another regression)
markt [Tue, 17 Nov 2009 17:50:21 +0000 (17:50 +0000)]
Update to commons pool 1.5.4 (fix another regression)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881412 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate Javadoc to reflect changed default for useEquals
markt [Tue, 17 Nov 2009 17:39:51 +0000 (17:39 +0000)]
Update Javadoc to reflect changed default for useEquals

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881402 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the file handler thread safe
fhanik [Tue, 17 Nov 2009 17:35:57 +0000 (17:35 +0000)]
Make the file handler thread safe

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881396 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate throws declaration for Servlet 3 file upload
markt [Tue, 17 Nov 2009 02:41:55 +0000 (02:41 +0000)]
Update throws declaration for Servlet 3 file upload
Do the easy part of the implementation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881109 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImplement request.authenticate()
markt [Tue, 17 Nov 2009 02:19:49 +0000 (02:19 +0000)]
Implement request.authenticate()
This required re-factoring the Authenticator interface to use HttpServletResponse. It would be nice to refactor to use HttpServletRequest as well but at the moment the authenticator requires too much access to the request internals.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@881100 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove code that doesn't do anything
markt [Mon, 16 Nov 2009 15:15:45 +0000 (15:15 +0000)]
Remove code that doesn't do anything

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@880786 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47495
kkolinko [Sun, 15 Nov 2009 20:24:48 +0000 (20:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47495
Exit immediately if Catalina.load() failed to create a server instance.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836405 13f79535-47bb-0310-9956-ffa450edef68

16 years agocorrect a comment
kkolinko [Sun, 15 Nov 2009 15:17:08 +0000 (15:17 +0000)]
correct a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836371 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClear the values in username and password fields when they are read-only
kkolinko [Sat, 14 Nov 2009 16:30:21 +0000 (16:30 +0000)]
Clear the values in username and password fields when they are read-only

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836209 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReduce visibility (thanks Sebb)
markt [Sat, 14 Nov 2009 13:46:43 +0000 (13:46 +0000)]
Reduce visibility (thanks Sebb)
Remove unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836177 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore cookie refactoring
markt [Sat, 14 Nov 2009 03:47:48 +0000 (03:47 +0000)]
More cookie refactoring
 - new support class for common elements of parsing and writing
 - better consistency between parsing and writing
 - remove unused code
 - reduce visibility of methods where possible
 - auto-switch to v1 for any attribute that might require quoting
 - better names for constants
 - allow v0 cookies to break http spec (disabled by default)
 - update test cases and documentation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836113 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect comment
markt [Sat, 14 Nov 2009 02:48:51 +0000 (02:48 +0000)]
Correct comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836103 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd TODOs as per discussion on dev list
markt [Sat, 14 Nov 2009 02:48:19 +0000 (02:48 +0000)]
Add TODOs as per discussion on dev list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836102 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDo not offer default value for Tomcat administrator login
kkolinko [Fri, 13 Nov 2009 22:49:09 +0000 (22:49 +0000)]
Do not offer default value for Tomcat administrator login
Also change/indent some labels

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836045 13f79535-47bb-0310-9956-ffa450edef68

16 years ago1. Correct some computations in "configure" Function:
kkolinko [Fri, 13 Nov 2009 22:35:49 +0000 (22:35 +0000)]
1. Correct some computations in "configure" Function:
a) Always set initial value for $R5
b) $R4 and $R0 have to be consistent when Silent mode is used
2. Correct some messages. Do not mention Windows NT etc., as Win98 is all history now.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836036 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd suspect test and also allow connections to be unwrapped
fhanik [Fri, 13 Nov 2009 22:22:50 +0000 (22:22 +0000)]
Add suspect test and also allow connections to be unwrapped

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836028 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImplement suspectTimeout to allow JMX notifications and log events to take place...
fhanik [Fri, 13 Nov 2009 21:53:13 +0000 (21:53 +0000)]
Implement suspectTimeout to allow JMX notifications and log events to take place if a connection is checked out for too long. But don't abandon/close the connection.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@836011 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse a safe default of the useEquals, works on any VM.
fhanik [Fri, 13 Nov 2009 20:12:32 +0000 (20:12 +0000)]
Use a safe default of the useEquals, works on any VM.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835974 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd Apple J2SE runtime jars to those we skip when scanning for TLDs and web fragments
markt [Fri, 13 Nov 2009 15:48:41 +0000 (15:48 +0000)]
Add Apple J2SE runtime jars to those we skip when scanning for TLDs and web fragments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835886 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix NPEs on startup with relative ordering and provide somewhere to store results...
markt [Thu, 12 Nov 2009 21:36:49 +0000 (21:36 +0000)]
Fix NPEs on startup with relative ordering and provide somewhere to store results of annotation scanning when that is implemented

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835567 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake handling of / as a separator consistent with the rest of the cookie code.
markt [Thu, 12 Nov 2009 21:19:09 +0000 (21:19 +0000)]
Make handling of / as a separator consistent with the rest of the cookie code.
This actually relaxes treatment of / in cookie generation.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835552 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake TODO comments consistent to make them easier to find
markt [Thu, 12 Nov 2009 19:53:49 +0000 (19:53 +0000)]
Make TODO comments consistent to make them easier to find

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835516 13f79535-47bb-0310-9956-ffa450edef68

16 years agoServlet 3 implementation.
markt [Thu, 12 Nov 2009 17:29:00 +0000 (17:29 +0000)]
Servlet 3 implementation.
- Add support for relative fragment ordering and some test cases
- Re-order fragment and annotation processing to match spec
- Implement login/logout
- Provide a method to retrieve the Authenticator in use by a Context
- Add methods to Authenticator interface to facilitate the new login/login methods
- Enable Authenticator.register() to be used for logout as well as login

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835460 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFollowup to r.817822 and r.833545
kkolinko [Thu, 12 Nov 2009 11:20:43 +0000 (11:20 +0000)]
Followup to r.817822 and r.833545
You have to specify explicit encoding in a fixcrlf task

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835336 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake the location of stdout and stderr output configurable. Leave the default as...
fhanik [Wed, 11 Nov 2009 19:51:50 +0000 (19:51 +0000)]
Make the location of stdout and stderr output configurable. Leave the default as it always has been.
Currently, one can reconfigure the location of all logfiles except this one.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835036 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd similar SSL tests for NIO connector.
costin [Wed, 11 Nov 2009 19:13:24 +0000 (19:13 +0000)]
Add similar SSL tests for NIO connector.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@835017 13f79535-47bb-0310-9956-ffa450edef68

16 years agocode formatting
kkolinko [Wed, 11 Nov 2009 07:56:01 +0000 (07:56 +0000)]
code formatting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834794 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse new attribute name
markt [Tue, 10 Nov 2009 16:46:52 +0000 (16:46 +0000)]
Use new attribute name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834541 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDocument allowUnsafeLegacyRenegotiation
markt [Tue, 10 Nov 2009 15:43:17 +0000 (15:43 +0000)]
Document allowUnsafeLegacyRenegotiation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834510 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRename attribute
markt [Tue, 10 Nov 2009 15:38:37 +0000 (15:38 +0000)]
Rename attribute

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834506 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPrevent stack traces when closing ssl sockets after unwanted renegotiation attempt.
markt [Tue, 10 Nov 2009 15:33:50 +0000 (15:33 +0000)]
Prevent stack traces when closing ssl sockets after unwanted renegotiation attempt.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834504 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse a connector attribute rather than a system property to control renegotiation
markt [Tue, 10 Nov 2009 14:26:01 +0000 (14:26 +0000)]
Use a connector attribute rather than a system property to control renegotiation
Fix some trivial Eclispe warnings in the test
Don't try and invalidate the session in the client - an attacker probably won't do this
Add a test that checks the connector attribute can be used to enable renegotiation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834477 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix some minor Eclipse warnings
markt [Tue, 10 Nov 2009 13:40:08 +0000 (13:40 +0000)]
Fix some minor Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834461 13f79535-47bb-0310-9956-ffa450edef68

16 years agoInvalidate the session - so it can't be resumed.
costin [Tue, 10 Nov 2009 04:54:34 +0000 (04:54 +0000)]
Invalidate the session - so it can't be resumed.
Not sure what else we can do using this hook - we could switch to SSLEngine, but that's pretty large change.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834340 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTest case for the MITM/ssl re-negotiation, also a unit test for a simple ssl request
costin [Tue, 10 Nov 2009 01:04:13 +0000 (01:04 +0000)]
Test case for the MITM/ssl re-negotiation, also a unit test for a simple ssl request
( to check the fix didn't broke anything and ssl still works )

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834290 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix for the SSL midm - disable client re-negotiation, connection will be closed.
costin [Tue, 10 Nov 2009 01:02:43 +0000 (01:02 +0000)]
Fix for the SSL midm - disable client re-negotiation, connection will be closed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834289 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd merge code for the remaining elements in web.xml
markt [Tue, 10 Nov 2009 00:31:25 +0000 (00:31 +0000)]
Add merge code for the remaining elements in web.xml

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834286 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAlign all three StringManager implementations
markt [Mon, 9 Nov 2009 21:18:01 +0000 (21:18 +0000)]
Align all three StringManager implementations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834238 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringManagers should be static final
markt [Mon, 9 Nov 2009 21:06:37 +0000 (21:06 +0000)]
StringManagers should be static final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834233 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStringManagers should be final
markt [Mon, 9 Nov 2009 21:00:22 +0000 (21:00 +0000)]
StringManagers should be final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834229 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUnused code
markt [Mon, 9 Nov 2009 20:52:49 +0000 (20:52 +0000)]
Unused code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834227 13f79535-47bb-0310-9956-ffa450edef68

16 years agoLoggers should be final
markt [Mon, 9 Nov 2009 20:51:17 +0000 (20:51 +0000)]
Loggers should be final

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834226 13f79535-47bb-0310-9956-ffa450edef68

16 years agoThe assumption that contexts will always be file system based or that resources will...
markt [Mon, 9 Nov 2009 20:43:47 +0000 (20:43 +0000)]
The assumption that contexts will always be file system based or that resources will always be extracted to the work does not hold true, particularly for custom DirContext implementations. Don't make the assumption and clean-up up the redundant field that is no longer required.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834220 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused inner class
kkolinko [Mon, 9 Nov 2009 15:08:50 +0000 (15:08 +0000)]
Remove unused inner class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834099 13f79535-47bb-0310-9956-ffa450edef68

16 years agoWith rev.834080 WebappClassLoader#findResourceInternal(String,String) is always calle...
kkolinko [Mon, 9 Nov 2009 15:04:07 +0000 (15:04 +0000)]
With rev.834080 WebappClassLoader#findResourceInternal(String,String) is always called with AccessController.doPrivileged(), thus there is no need to wrap #findResourceInternal(File,String) call that is inside it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834096 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unnecessary code
markt [Mon, 9 Nov 2009 14:33:03 +0000 (14:33 +0000)]
Remove unnecessary code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834082 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPatch provided by Cyrille Le Clerc
markt [Mon, 9 Nov 2009 14:31:40 +0000 (14:31 +0000)]
Patch provided by Cyrille Le Clerc
* fix NPE in log statement if protocolHeader has not been defined and the servlet container does not support request.getHeader(null)
* fix mismatch between javadoc  and code for filter parameter name "allowedInternalProxies" -> "internalProxies"
* finish javadoc refactoring "XForwardedFilter" -> "RemoteIpFilter"
Also fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834081 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48097
kkolinko [Mon, 9 Nov 2009 14:29:55 +0000 (14:29 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48097
Patch by Mark Thomas.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834080 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r.831830. A better patch for issue 48097 was proposed.
kkolinko [Mon, 9 Nov 2009 14:26:00 +0000 (14:26 +0000)]
Revert r.831830. A better patch for issue 48097 was proposed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834078 13f79535-47bb-0310-9956-ffa450edef68

16 years agosvn:eol-style
kkolinko [Mon, 9 Nov 2009 13:30:40 +0000 (13:30 +0000)]
svn:eol-style

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834056 13f79535-47bb-0310-9956-ffa450edef68

16 years agosvn:eol-style
kkolinko [Mon, 9 Nov 2009 13:19:42 +0000 (13:19 +0000)]
svn:eol-style

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834052 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix CVE-2009-3548.
markt [Mon, 9 Nov 2009 13:04:52 +0000 (13:04 +0000)]
Fix CVE-2009-3548.
When installing using defaults, don't create an administrative user with a blank password
Note: This is already public - it was discussed on the users list. The formal announcement will go out shortly.
The patch also includes making the Manager and Host-Manager applications separately selectable with the addition of an administrative user only enabled if one of the manager apps is selected

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834047 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd support for displayName
markt [Mon, 9 Nov 2009 12:40:56 +0000 (12:40 +0000)]
Add support for displayName

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834036 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCookie is now serializable in Servlet 3.0
markt [Mon, 9 Nov 2009 12:34:45 +0000 (12:34 +0000)]
Cookie is now serializable in Servlet 3.0
Fix some Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834034 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse correct default manifest
markt [Mon, 9 Nov 2009 11:37:53 +0000 (11:37 +0000)]
Use correct default manifest
Use specific notice and license file for jsp jar

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834024 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd JSP 2.2 XSD
markt [Mon, 9 Nov 2009 11:31:08 +0000 (11:31 +0000)]
Add JSP 2.2 XSD

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834023 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd the JSP 2.2 schema. Note election to use CDDL.
markt [Mon, 9 Nov 2009 11:29:18 +0000 (11:29 +0000)]
Add the JSP 2.2 schema. Note election to use CDDL.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834022 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate schemas to latest draft as of 2009-11-05
markt [Mon, 9 Nov 2009 11:27:57 +0000 (11:27 +0000)]
Update schemas to latest draft as of 2009-11-05

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@834021 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore web.xml / fragment merge code
markt [Sat, 7 Nov 2009 00:46:50 +0000 (00:46 +0000)]
More web.xml / fragment merge code

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833619 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore inheritance
markt [Fri, 6 Nov 2009 23:51:30 +0000 (23:51 +0000)]
More inheritance

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833608 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse inheritance as it makes merging easier
markt [Fri, 6 Nov 2009 23:35:46 +0000 (23:35 +0000)]
Use inheritance as it makes merging easier
Fix a handful of Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833602 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix Eclipse warning
markt [Fri, 6 Nov 2009 22:34:38 +0000 (22:34 +0000)]
Fix Eclipse warning
Override equals (and therefore also hashcode) as it is required for fragment merging

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833586 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRestore original line ending after switching for windows installer
markt [Fri, 6 Nov 2009 20:16:58 +0000 (20:16 +0000)]
Restore original line ending after switching for windows installer

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833545 13f79535-47bb-0310-9956-ffa450edef68

16 years agoadd stubs and remove / add some @overrides to allow compilation
funkman [Fri, 6 Nov 2009 18:53:57 +0000 (18:53 +0000)]
add stubs and remove / add some @overrides to allow compilation

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833521 13f79535-47bb-0310-9956-ffa450edef68

16 years agofix typo - thanks Sebb
markt [Fri, 6 Nov 2009 18:48:20 +0000 (18:48 +0000)]
fix typo - thanks Sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833516 13f79535-47bb-0310-9956-ffa450edef68

16 years agoComet didn't work at all under a security manger. Need to allow web apps access to...
markt [Fri, 6 Nov 2009 18:26:39 +0000 (18:26 +0000)]
Comet didn't work at all under a security manger. Need to allow web apps access to the comet interfaces so move those interfaces to a separate package so we can grant access.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833510 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdditional permission required for JSPs to work
markt [Fri, 6 Nov 2009 18:09:32 +0000 (18:09 +0000)]
Additional permission required for JSPs to work

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833505 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove class that was remove in refactoring. Will probably need to add replacement.
markt [Fri, 6 Nov 2009 18:07:41 +0000 (18:07 +0000)]
Remove class that was remove in refactoring. Will probably need to add replacement.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833503 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake a differentiator which stock ticker is running
fhanik [Fri, 6 Nov 2009 17:01:20 +0000 (17:01 +0000)]
Make a differentiator which stock ticker is running

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833472 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix line endings
markt [Fri, 6 Nov 2009 16:27:45 +0000 (16:27 +0000)]
Fix line endings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833459 13f79535-47bb-0310-9956-ffa450edef68

16 years agosvn:eol-style
kkolinko [Fri, 6 Nov 2009 05:12:50 +0000 (05:12 +0000)]
svn:eol-style

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833300 13f79535-47bb-0310-9956-ffa450edef68

16 years agoApply Filip's suggestion to improve concurrency
markt [Thu, 5 Nov 2009 22:08:30 +0000 (22:08 +0000)]
Apply Filip's suggestion to improve concurrency

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833211 13f79535-47bb-0310-9956-ffa450edef68

16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=47330
markt [Thu, 5 Nov 2009 20:35:09 +0000 (20:35 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=47330
Add RemoteIpFilter
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833155 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48139
markt [Thu, 5 Nov 2009 19:12:14 +0000 (19:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48139
Correct javadoc - patch provided by sebb
Also fix remaining Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833131 13f79535-47bb-0310-9956-ffa450edef68

16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=48137
markt [Thu, 5 Nov 2009 19:08:42 +0000 (19:08 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=48137
Fix javadoc typos
Patch provided by qingyang.xu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833130 13f79535-47bb-0310-9956-ffa450edef68

16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=47495
funkman [Thu, 5 Nov 2009 18:46:43 +0000 (18:46 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=47495

If server.xml doesnt have read permission - let the user know

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833121 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48135
markt [Thu, 5 Nov 2009 18:41:30 +0000 (18:41 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48135
Also add generics where possible and other Eclipse warnings

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833120 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48133
markt [Thu, 5 Nov 2009 18:18:53 +0000 (18:18 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48133
Spelling errors in javadoc
Patch provided by qingyang.xu

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@833111 13f79535-47bb-0310-9956-ffa450edef68

16 years agohttps://issues.apache.org/bugzilla/show_bug.cgi?id=47330
markt [Thu, 5 Nov 2009 02:03:12 +0000 (02:03 +0000)]
https://issues.apache.org/bugzilla/show_bug.cgi?id=47330
Add RemoteIpValve
Patch provided by Cyrille Le Clerc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832974 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse Eclipse quick fix to remove unused imports
markt [Thu, 5 Nov 2009 01:30:02 +0000 (01:30 +0000)]
Use Eclipse quick fix to remove unused imports

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832963 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd other @Override annotations identified by Eclipse
markt [Thu, 5 Nov 2009 01:28:51 +0000 (01:28 +0000)]
Add other @Override annotations identified by Eclipse

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832961 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:22:13 +0000 (01:22 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb
This is the final patch for this bug fix.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832957 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:21:11 +0000 (01:21 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832956 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:19:20 +0000 (01:19 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832955 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:18:05 +0000 (01:18 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832954 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:16:53 +0000 (01:16 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832953 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:14:16 +0000 (01:14 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832951 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 01:13:12 +0000 (01:13 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb with some additional issues reported by Eclispe

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832950 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a few annotations missed by recent patches
markt [Thu, 5 Nov 2009 01:09:39 +0000 (01:09 +0000)]
Add a few annotations missed by recent patches

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832949 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
markt [Thu, 5 Nov 2009 00:58:58 +0000 (00:58 +0000)]
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48132
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832945 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48131
markt [Thu, 5 Nov 2009 00:46:07 +0000 (00:46 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48131
Patch provided by sebb

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832938 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48123
markt [Thu, 5 Nov 2009 00:34:33 +0000 (00:34 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48123
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832931 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48121
markt [Thu, 5 Nov 2009 00:30:25 +0000 (00:30 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48121
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832928 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48120
markt [Thu, 5 Nov 2009 00:28:09 +0000 (00:28 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48120
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832927 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=48117
markt [Thu, 5 Nov 2009 00:26:28 +0000 (00:26 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48117
Spelling errors

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832926 13f79535-47bb-0310-9956-ffa450edef68

16 years agorevert based on https://issues.apache.org/bugzilla/show_bug.cgi?id=47512#c4
funkman [Wed, 4 Nov 2009 16:40:16 +0000 (16:40 +0000)]
revert based on https://issues.apache.org/bugzilla/show_bug.cgi?id=47512#c4

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832792 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBugfix typos from 48119
idarwin [Wed, 4 Nov 2009 13:26:33 +0000 (13:26 +0000)]
Bugfix typos from 48119

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832734 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBugfix typos from 48118
idarwin [Wed, 4 Nov 2009 13:13:41 +0000 (13:13 +0000)]
Bugfix typos from 48118

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832733 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a comment
kkolinko [Wed, 4 Nov 2009 10:16:36 +0000 (10:16 +0000)]
Add a comment

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832697 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBinding java.lang.reflect.Proxy to JNDI directory raises java.lang.ClassCastException
funkman [Wed, 4 Nov 2009 01:18:08 +0000 (01:18 +0000)]
Binding java.lang.reflect.Proxy to JNDI directory raises java.lang.ClassCastException
https://issues.apache.org/bugzilla/show_bug.cgi?id=47512

Also acts as dead code removal

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@832638 13f79535-47bb-0310-9956-ffa450edef68