tomcat7.0
16 years agoFix unused import
markt [Thu, 23 Jul 2009 17:17:11 +0000 (17:17 +0000)]
Fix unused import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@797152 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect the file name
markt [Thu, 23 Jul 2009 17:15:55 +0000 (17:15 +0000)]
Correct the file name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@797151 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMoved and renamed TestELParser class.
kkolinko [Thu, 23 Jul 2009 13:15:41 +0000 (13:15 +0000)]
Moved and renamed TestELParser class.
Some more EL tests to be added later.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@797058 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd proxy caching configuration information to valves docs
markt [Thu, 23 Jul 2009 09:43:52 +0000 (09:43 +0000)]
Add proxy caching configuration information to valves docs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796987 13f79535-47bb-0310-9956-ffa450edef68

16 years agofix recursive loops
fhanik [Wed, 22 Jul 2009 19:48:56 +0000 (19:48 +0000)]
fix recursive loops

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796858 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRestore the @Overrides. Eclipse on my Mac wasn't configured right. Sorry for the...
markt [Wed, 22 Jul 2009 14:29:09 +0000 (14:29 +0000)]
Restore the @Overrides. Eclipse on my Mac wasn't configured right. Sorry for the noise.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796739 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReorder the start sequence
fhanik [Tue, 21 Jul 2009 23:05:47 +0000 (23:05 +0000)]
Reorder the start sequence

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796575 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDocument Linux performance/overhead of using multi lock mechanism
fhanik [Tue, 21 Jul 2009 16:20:11 +0000 (16:20 +0000)]
Document Linux performance/overhead of using multi lock mechanism

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796362 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAllow to run perf test as a one off
fhanik [Tue, 21 Jul 2009 16:19:34 +0000 (16:19 +0000)]
Allow to run perf test as a one off

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796361 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove not used classpath entries in the default setting
fhanik [Tue, 21 Jul 2009 13:13:10 +0000 (13:13 +0000)]
remove not used classpath entries in the default setting

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796285 13f79535-47bb-0310-9956-ffa450edef68

16 years agoWe can call dispatch after we dispatched.
fhanik [Tue, 21 Jul 2009 13:11:04 +0000 (13:11 +0000)]
We can call dispatch after we dispatched.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796284 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore @Override complaints on Mac
markt [Tue, 21 Jul 2009 06:48:03 +0000 (06:48 +0000)]
More @Override complaints on Mac

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796164 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMac compiler doesn't like @Override on methods implementing an interface.
markt [Tue, 21 Jul 2009 06:45:24 +0000 (06:45 +0000)]
Mac compiler doesn't like @Override on methods implementing an interface.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796162 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47518
markt [Tue, 21 Jul 2009 06:24:58 +0000 (06:24 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47518
Fix reference to old method in Valve Javadoc
Patch by Christopher Schultz

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796155 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSync up the Catalina and Jasper TLD scanning code prior to adding some optional exten...
markt [Mon, 20 Jul 2009 21:37:30 +0000 (21:37 +0000)]
Sync up the Catalina and Jasper TLD scanning code prior to adding some optional extensions for the embedded use case.
A couple of options from the Jasper side have been removed as they were only ever used with one value.
The JSP 2.1 TCK passes with these changes.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796030 13f79535-47bb-0310-9956-ffa450edef68

16 years agoWhy do I always spot comment typos 2s after I commit a change?
markt [Mon, 20 Jul 2009 21:24:45 +0000 (21:24 +0000)]
Why do I always spot comment typos 2s after I commit a change?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796017 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake sure the duplicateUri flag is reset each time a TLD file is parsed. This was...
markt [Mon, 20 Jul 2009 21:22:33 +0000 (21:22 +0000)]
Make sure the duplicateUri flag is reset each time a TLD file is parsed. This was causing seemly random TCK failures depending on the order the tests were run in.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@796016 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert the TldConfig part of r795860. It appears to have introduced intermittent...
markt [Mon, 20 Jul 2009 16:28:27 +0000 (16:28 +0000)]
Revert the TldConfig part of r795860. It appears to have introduced intermittent TCK failures.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795902 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSync the TLD file scanning code for WEB-INF between Catalina and Jasper
markt [Mon, 20 Jul 2009 14:39:17 +0000 (14:39 +0000)]
Sync the TLD file scanning code for WEB-INF between Catalina and Jasper
- Based on the Jasper algorithm
- Uses additional checks from Catalina (Jasper now ignores TLD files in WEB-INF/lib and WEB-INF classes)
- Adds comments noting the need to keep the two implementations in sync

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795860 13f79535-47bb-0310-9956-ffa450edef68

16 years agoresourcePath doesn't end in / so need to use exact match to ensure on WEB-INF/lib...
markt [Mon, 20 Jul 2009 13:43:45 +0000 (13:43 +0000)]
resourcePath doesn't end in / so need to use exact match to ensure on WEB-INF/lib gets excluded and not WEB-INF/libxtz

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795838 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd a note about keeping processing order in sync.
markt [Mon, 20 Jul 2009 13:20:07 +0000 (13:20 +0000)]
Add a note about keeping processing order in sync.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795824 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAlign the processing order. Need to scan WEB-INF before we scan all the JARs in the...
markt [Mon, 20 Jul 2009 13:17:37 +0000 (13:17 +0000)]
Align the processing order. Need to scan WEB-INF before we scan all the JARs in the class loader hierarchy

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795822 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBetter method name
markt [Mon, 20 Jul 2009 13:15:51 +0000 (13:15 +0000)]
Better method name

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795819 13f79535-47bb-0310-9956-ffa450edef68

16 years agoIf TLDs are defined in web.xml, duplicates are expected so only log at debug
markt [Mon, 20 Jul 2009 11:08:24 +0000 (11:08 +0000)]
If TLDs are defined in web.xml, duplicates are expected so only log at debug

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795767 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAlign tag library URIs in web.xml, TLDs and JSPs.
markt [Mon, 20 Jul 2009 11:00:50 +0000 (11:00 +0000)]
Align tag library URIs in web.xml, TLDs and JSPs.
Note that the inconsistencies didn't break anything as the TLD scanning found all the various URIs

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795764 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTab police
markt [Mon, 20 Jul 2009 10:56:09 +0000 (10:56 +0000)]
Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795760 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUse an import
markt [Mon, 20 Jul 2009 10:15:34 +0000 (10:15 +0000)]
Use an import

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795739 13f79535-47bb-0310-9956-ffa450edef68

16 years agoDuring a release, arguments are null
fhanik [Mon, 20 Jul 2009 01:45:18 +0000 (01:45 +0000)]
During a release, arguments are null

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795678 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd missing interface. Invalidates the 1.0.6 tag
fhanik [Mon, 20 Jul 2009 01:41:25 +0000 (01:41 +0000)]
Add missing interface. Invalidates the 1.0.6 tag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795676 13f79535-47bb-0310-9956-ffa450edef68

16 years agostart implementing concurrency around the state machine
fhanik [Mon, 20 Jul 2009 01:20:02 +0000 (01:20 +0000)]
start implementing concurrency around the state machine
startAsync and complete() are to be thread safe operations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795669 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47413
kkolinko [Sun, 19 Jul 2009 02:52:32 +0000 (02:52 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47413
First part of a composite expression "${a}${b}" was not coerced to String

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795466 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRewrote (reworded) the Javadoc comment for JvmRouteBinderValve class.
kkolinko [Sun, 19 Jul 2009 01:12:50 +0000 (01:12 +0000)]
Rewrote (reworded) the Javadoc comment for JvmRouteBinderValve class.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795457 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFixed https://issues.apache.org/bugzilla/show_bug.cgi?id=41564
markt [Sat, 18 Jul 2009 11:53:41 +0000 (11:53 +0000)]
Fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=41564
Updated Tomcat6 to Tomcat 7
I couldn't see anything obviously obsolete so I removed the warning.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795348 13f79535-47bb-0310-9956-ffa450edef68

16 years agoimplement AsyncContext.dispatch and AsyncContext.start methods
fhanik [Fri, 17 Jul 2009 22:47:13 +0000 (22:47 +0000)]
implement AsyncContext.dispatch and AsyncContext.start methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795261 13f79535-47bb-0310-9956-ffa450edef68

16 years agothe dispatcher type should be ASYNC when we are doing a dispatch
fhanik [Fri, 17 Jul 2009 22:37:54 +0000 (22:37 +0000)]
the dispatcher type should be ASYNC when we are doing a dispatch

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795256 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd notes
fhanik [Fri, 17 Jul 2009 21:54:34 +0000 (21:54 +0000)]
Add notes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795241 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAsync patches phase 1 - Async means the container thread can back out. This means...
fhanik [Fri, 17 Jul 2009 21:32:00 +0000 (21:32 +0000)]
Async patches phase 1 - Async means the container thread can back out. This means that valves need to be async aware. For example, access log valve, can no longer log upon exit of the method since the thread can back out based on async behavior.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795231 13f79535-47bb-0310-9956-ffa450edef68

16 years agovery simple async example
fhanik [Fri, 17 Jul 2009 21:14:13 +0000 (21:14 +0000)]
very simple async example

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795229 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=41661
markt [Fri, 17 Jul 2009 20:12:49 +0000 (20:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41661
Thread safety issue with JspConfig.init(). There is one JspConfig object per context and as per 41661, issues have been seen with this on real systems.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795210 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=41059
markt [Fri, 17 Jul 2009 17:19:59 +0000 (17:19 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41059
Reduce one possible source of errors if using ENABLE_CLEAR_REFERENCES=true
Patch by Curt Arnold

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795152 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPart 1 of a series of commits to align the Catalina and Jasper TLD scanning code...
markt [Fri, 17 Jul 2009 16:57:30 +0000 (16:57 +0000)]
Part 1 of a series of commits to align the Catalina and Jasper TLD scanning code and to provide additional features when embedding. This first commit modifies the Catalina code to:
- better match the spec
- improve logging
The JSP TCK passes with this patch applied

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795143 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake info message less harsh
markt [Fri, 17 Jul 2009 11:21:32 +0000 (11:21 +0000)]
Make info message less harsh

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@795043 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=40551
markt [Thu, 16 Jul 2009 20:07:19 +0000 (20:07 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=40551
Enable the JvmRouteBinderValve to work with PersistentManagers as well as clusters

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794822 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd the docs I forgot in the previous GSOC commit
markt [Thu, 16 Jul 2009 19:36:03 +0000 (19:36 +0000)]
Add the docs I forgot in the previous GSOC commit

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794800 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore GSOC work from Xie Xiadong
markt [Thu, 16 Jul 2009 19:34:49 +0000 (19:34 +0000)]
More GSOC work from Xie Xiadong
Initial implementation of RemoteHost and RemoteAddr filters.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794798 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRefactor the dispatcher types from int and Integer to the one supplied by the Servlet...
fhanik [Thu, 16 Jul 2009 17:44:46 +0000 (17:44 +0000)]
Refactor the dispatcher types from int and Integer to the one supplied by the Servlet specification.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794766 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMake clear this isn't the complete list if tag libraries for the app.
markt [Thu, 16 Jul 2009 16:16:40 +0000 (16:16 +0000)]
Make clear this isn't the complete list if tag libraries for the app.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794732 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=47515
fhanik [Thu, 16 Jul 2009 14:12:16 +0000 (14:12 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47515
Patch submitted by Ryuichi Yoshihara

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794684 13f79535-47bb-0310-9956-ffa450edef68

16 years agoConstants should be just that.
markt [Thu, 16 Jul 2009 13:52:24 +0000 (13:52 +0000)]
Constants should be just that.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794673 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove commons logging reference - this copy of the digester doesn't use it.
markt [Thu, 16 Jul 2009 13:06:38 +0000 (13:06 +0000)]
Remove commons logging reference - this copy of the digester doesn't use it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794663 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemainder of fix in trunk for 47444
markt [Wed, 15 Jul 2009 07:15:10 +0000 (07:15 +0000)]
Remainder of fix in trunk for 47444
Update references to Jakarta in Javadoc and JspC

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794161 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove Jakarta references from the docs.
markt [Wed, 15 Jul 2009 07:03:17 +0000 (07:03 +0000)]
Remove Jakarta references from the docs.
Update those sections of the docs as necessary.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794160 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTab police
markt [Wed, 15 Jul 2009 07:02:37 +0000 (07:02 +0000)]
Tab police

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794159 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove commented out reference to the balancer web-app. This is not included in trunk.
markt [Wed, 15 Jul 2009 06:55:25 +0000 (06:55 +0000)]
Remove commented out reference to the balancer web-app. This is not included in trunk.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794157 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPartial fix for bug 47444.
markt [Wed, 15 Jul 2009 06:53:20 +0000 (06:53 +0000)]
Partial fix for bug 47444.
Update taglib URIs in examples, removing Jakarta references

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794156 13f79535-47bb-0310-9956-ffa450edef68

16 years agoStart working on async, fairly similar to comet but much more convulated.
fhanik [Wed, 15 Jul 2009 00:33:14 +0000 (00:33 +0000)]
Start working on async, fairly similar to comet but much more convulated.
I'm gonna do checkins in fairly small chunks so folks can tag along and help out. Instead of doing one giant checkin

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794122 13f79535-47bb-0310-9956-ffa450edef68

16 years agoJNDI lookup errors often only include part of the name being looked up.
markt [Tue, 14 Jul 2009 21:52:14 +0000 (21:52 +0000)]
JNDI lookup errors often only include part of the name being looked up.
Provide debug logging that includes the complete name and how it was requested.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@794082 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd experimental new queue, runs faster but is not yet complete and needs some work...
fhanik [Tue, 14 Jul 2009 17:49:03 +0000 (17:49 +0000)]
Add experimental new queue, runs faster but is not yet complete and needs some work around concurrency, iterators and remove operations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793991 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix https://issues.apache.org/bugzilla/show_bug.cgi?id=40380
markt [Tue, 14 Jul 2009 17:22:47 +0000 (17:22 +0000)]
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=40380
Correct synchronisation of expire()
Should now only run one per session

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793981 13f79535-47bb-0310-9956-ffa450edef68

16 years agoImplements, doesn't override
markt [Tue, 14 Jul 2009 17:18:21 +0000 (17:18 +0000)]
Implements, doesn't override

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793979 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix typo
markt [Tue, 14 Jul 2009 15:38:07 +0000 (15:38 +0000)]
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793945 13f79535-47bb-0310-9956-ffa450edef68

16 years agoMore doco
fhanik [Tue, 14 Jul 2009 15:22:05 +0000 (15:22 +0000)]
More doco

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793937 13f79535-47bb-0310-9956-ffa450edef68

16 years agomore javadoc
fhanik [Tue, 14 Jul 2009 14:53:20 +0000 (14:53 +0000)]
more javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793919 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPatch by arielandres@hotmail.com
fhanik [Tue, 14 Jul 2009 14:46:34 +0000 (14:46 +0000)]
Patch by arielandres@hotmail.com
Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=47524

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793913 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAllow encoding to be specified for JULI FileHandler, and its subclasses (AsyncFileHan...
kkolinko [Tue, 14 Jul 2009 12:23:43 +0000 (12:23 +0000)]
Allow encoding to be specified for JULI FileHandler, and its subclasses (AsyncFileHandler).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793882 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSome initial implementations for the 3.0 dynamic registration methods. Moving back...
costin [Tue, 14 Jul 2009 05:38:02 +0000 (05:38 +0000)]
Some initial implementations for the 3.0 dynamic registration methods. Moving back web.xml config to separate package - with annotations requiring scanning of all files it needs to be done at deploy time - so it'll be better to just load a .ser file at startup.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793797 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix
fhanik [Tue, 14 Jul 2009 01:15:29 +0000 (01:15 +0000)]
Fix

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793773 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix test case
fhanik [Tue, 14 Jul 2009 00:21:17 +0000 (00:21 +0000)]
Fix test case

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793766 13f79535-47bb-0310-9956-ffa450edef68

16 years agomore javadoc and corrections
fhanik [Tue, 14 Jul 2009 00:08:01 +0000 (00:08 +0000)]
more javadoc and corrections

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793761 13f79535-47bb-0310-9956-ffa450edef68

16 years ago1. Ensure that any user defined CLASSPATH variables are not used on startup
kkolinko [Tue, 14 Jul 2009 00:01:01 +0000 (00:01 +0000)]
1. Ensure that any user defined CLASSPATH variables are not used on startup
(as is already implemented since rev.303663),
but now allow them to be specified in setenv.sh, in rare case when it is needed.

2. When preparing the CLASSPATH, do not treat the "debug" command specially,
because jdb does not need the tools.jar file.

3. Remove some wrong quotes in tool-wrapper.bat.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793757 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove not used methods
fhanik [Mon, 13 Jul 2009 22:29:16 +0000 (22:29 +0000)]
remove not used methods

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793733 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd tons of javadoc
fhanik [Mon, 13 Jul 2009 22:18:17 +0000 (22:18 +0000)]
Add tons of javadoc
Remove the finalizers, they behave way differently in the new JDK, so let the programmer be responsible for closures

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793732 13f79535-47bb-0310-9956-ffa450edef68

16 years agoReplace o.a.catalina.util.StringManager with o.a.tomcat.util.res.StringManager
markt [Mon, 13 Jul 2009 22:03:12 +0000 (22:03 +0000)]
Replace o.a.catalina.util.StringManager with o.a.tomcat.util.res.StringManager
Catalina depends on o.a.tomcat.util already
Reduces duplicate code (which was also out of sync with latest updates)
The svn log for o.a.catalina.util.StringManager suggests this was the plan

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793728 13f79535-47bb-0310-9956-ffa450edef68

16 years agoPrep required for the o.a.tomcat.util.res.StringManager to replace the o.a.c.util...
markt [Mon, 13 Jul 2009 21:49:14 +0000 (21:49 +0000)]
Prep required for the o.a.tomcat.util.res.StringManager to replace the o.a.c.util.StringManager
Adds handling for when classloaders common != server != shared

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793722 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRemove unused classes identified by the UCDetector plug-in
markt [Mon, 13 Jul 2009 20:20:59 +0000 (20:20 +0000)]
Remove unused classes identified by the UCDetector plug-in

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793694 13f79535-47bb-0310-9956-ffa450edef68

16 years agoUpdate to commons pool 1.5.2 to get latest fixes
markt [Mon, 13 Jul 2009 19:45:32 +0000 (19:45 +0000)]
Update to commons pool 1.5.2 to get latest fixes

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793682 13f79535-47bb-0310-9956-ffa450edef68

16 years agoExplicitely return value 0 if we return without error
rjung [Mon, 13 Jul 2009 19:16:49 +0000 (19:16 +0000)]
Explicitely return value 0 if we return without error
from setclasspath.bat. Otherwise errorlevel in catalina.bat
is not reset.

catalina.bat checks for non-zero errorlevel after
the call to setclasspath.bat and then fails silently,
because it assumes setclasspath.bat to log any error.

If there is an error above the call to setclasspath.bat,
catalina.bat fails without any message.

Since there is only very basic logic above the call
to setclasspath.bat, let us reset errorlevel to ignore errors.

Example: any "set myvar=" for an undefined variable myvar
sets errorlevel to 1, although it is a correct statement,
setting the variable to an empty value.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793669 13f79535-47bb-0310-9956-ffa450edef68

16 years agoTrack the TLD URIs processed for each webapp and don't process duplicates.
markt [Mon, 13 Jul 2009 16:43:26 +0000 (16:43 +0000)]
Track the TLD URIs processed for each webapp and don't process duplicates.
Because this tracks duplicate status in the RuleSet, each digester needs its own RuleSet rather than sharing the static one.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793621 13f79535-47bb-0310-9956-ffa450edef68

16 years agoClear props - stops weird TortoiseSvn behaviour
markt [Mon, 13 Jul 2009 14:55:27 +0000 (14:55 +0000)]
Clear props - stops weird TortoiseSvn behaviour

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793600 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd some ignores
markt [Mon, 13 Jul 2009 14:53:32 +0000 (14:53 +0000)]
Add some ignores

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793598 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCreate a package file for the JavaDoc main package
fhanik [Mon, 13 Jul 2009 14:50:49 +0000 (14:50 +0000)]
Create a package file for the JavaDoc main package

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793597 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAlternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
markt [Sun, 12 Jul 2009 16:28:21 +0000 (16:28 +0000)]
Alternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
Only add tools.jar to classpath when using debug option
Remove references to undocumented, half-implemented javac option
Remove unused environment variables

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793372 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r791331 that fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=39194
markt [Sun, 12 Jul 2009 16:07:58 +0000 (16:07 +0000)]
Revert r791331 that fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=39194

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793369 13f79535-47bb-0310-9956-ffa450edef68

16 years agofix assertion
fhanik [Fri, 10 Jul 2009 21:40:26 +0000 (21:40 +0000)]
fix assertion

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793117 13f79535-47bb-0310-9956-ffa450edef68

16 years agoSome more concurrency testing
fhanik [Fri, 10 Jul 2009 21:38:16 +0000 (21:38 +0000)]
Some more concurrency testing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793116 13f79535-47bb-0310-9956-ffa450edef68

16 years agoFix a concurrency issue with connections being released and then trying to be reconnected
fhanik [Fri, 10 Jul 2009 21:02:43 +0000 (21:02 +0000)]
Fix a concurrency issue with connections being released and then trying to be reconnected

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793108 13f79535-47bb-0310-9956-ffa450edef68

16 years agojavadoc
fhanik [Fri, 10 Jul 2009 19:48:26 +0000 (19:48 +0000)]
javadoc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793093 13f79535-47bb-0310-9956-ffa450edef68

16 years agocorrect dependency
fhanik [Fri, 10 Jul 2009 18:17:37 +0000 (18:17 +0000)]
correct dependency

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793062 13f79535-47bb-0310-9956-ffa450edef68

16 years agojavadoc corrections
fhanik [Fri, 10 Jul 2009 18:10:30 +0000 (18:10 +0000)]
javadoc corrections

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793060 13f79535-47bb-0310-9956-ffa450edef68

16 years agoremove dbcp
fhanik [Fri, 10 Jul 2009 17:16:25 +0000 (17:16 +0000)]
remove dbcp
add classpath to javadoc
start documenting DataSource

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793042 13f79535-47bb-0310-9956-ffa450edef68

16 years agowere not using DBCP anywhere
fhanik [Fri, 10 Jul 2009 17:08:35 +0000 (17:08 +0000)]
were not using DBCP anywhere

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793040 13f79535-47bb-0310-9956-ffa450edef68

16 years agocorrect counter behavior.
fhanik [Fri, 10 Jul 2009 16:42:00 +0000 (16:42 +0000)]
correct counter behavior.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793029 13f79535-47bb-0310-9956-ffa450edef68

16 years agoBetter notes for future reference
markt [Fri, 10 Jul 2009 16:28:41 +0000 (16:28 +0000)]
Better notes for future reference

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793021 13f79535-47bb-0310-9956-ffa450edef68

16 years agoRevert r792945 - JSP.7.3.6.1 explicitly states locations without a leading '/' are...
markt [Fri, 10 Jul 2009 16:26:56 +0000 (16:26 +0000)]
Revert r792945 - JSP.7.3.6.1 explicitly states locations without a leading '/' are to be treated as relative to web.xml

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793019 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdded some comments and more thread safety around the size of the pool
fhanik [Fri, 10 Jul 2009 16:25:14 +0000 (16:25 +0000)]
Added some comments and more thread safety around the size of the pool

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793017 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd documentation and clarification around JMX
fhanik [Fri, 10 Jul 2009 16:02:57 +0000 (16:02 +0000)]
Add documentation and clarification around JMX

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@793002 13f79535-47bb-0310-9956-ffa450edef68

16 years agoCorrect location of taglib element varies with spec version. WebRuleSet was using...
markt [Fri, 10 Jul 2009 15:53:59 +0000 (15:53 +0000)]
Correct location of taglib element varies with spec version. WebRuleSet was using 2.3 and earlier location. Update it to a) support 2.4 and later as well as 2.3 and earlier b) complain if taglib definition location is not consistent with declared spec version.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792996 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd manifest to binary JAR
fhanik [Fri, 10 Jul 2009 15:03:43 +0000 (15:03 +0000)]
Add manifest to binary JAR
Fix XML error in doc

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792969 13f79535-47bb-0310-9956-ffa450edef68

16 years agoAdd new jar to TLD exclusion list
markt [Fri, 10 Jul 2009 13:52:14 +0000 (13:52 +0000)]
Add new jar to TLD exclusion list

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792954 13f79535-47bb-0310-9956-ffa450edef68

16 years agoServlet DTD and JSP spec are both quite clear that a <taglib-location> is <quote...
markt [Fri, 10 Jul 2009 13:27:01 +0000 (13:27 +0000)]
Servlet DTD and JSP spec are both quite clear that a <taglib-location> is <quote>a resource
relative to the root of the web application</quote>

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@792945 13f79535-47bb-0310-9956-ffa450edef68