horde.git
14 years agoRemove unnecessary @todos
Chuck Hagenbuch [Mon, 24 Jan 2011 01:03:00 +0000 (20:03 -0500)]
Remove unnecessary @todos

14 years agoFix form name
Michael J. Rubinsky [Sun, 23 Jan 2011 22:18:09 +0000 (17:18 -0500)]
Fix form name

14 years agoFix tree graphics in the bookmark folder tree
Chuck Hagenbuch [Sun, 23 Jan 2011 21:56:38 +0000 (16:56 -0500)]
Fix tree graphics in the bookmark folder tree

14 years agouser_id is NOT NULL
Jan Schneider [Sun, 23 Jan 2011 21:36:28 +0000 (22:36 +0100)]
user_id is NOT NULL

14 years agoRevert commenting out cache code.
Jan Schneider [Sun, 23 Jan 2011 21:35:50 +0000 (22:35 +0100)]
Revert commenting out cache code.

14 years agoOne more place we need ids instead of names.
Michael J. Rubinsky [Sun, 23 Jan 2011 18:42:47 +0000 (13:42 -0500)]
One more place we need ids instead of names.

Add a utility function to act as callback to array_map, still need
to audit code for all places to use it.

14 years agoAdd test to ensure listShares results are keyed by name
Michael J. Rubinsky [Sun, 23 Jan 2011 18:25:33 +0000 (13:25 -0500)]
Add test to ensure listShares results are keyed by name

14 years agoHorde_Share::listShares() returns a hash keyed by name, not id.
Michael J. Rubinsky [Sun, 23 Jan 2011 18:15:30 +0000 (13:15 -0500)]
Horde_Share::listShares() returns a hash keyed by name, not id.

14 years agoCall alarmInit() (Bug #9519).
Jan Schneider [Sat, 22 Jan 2011 17:31:39 +0000 (18:31 +0100)]
Call alarmInit() (Bug #9519).

14 years agoRemove accidentally added file.
Jan Schneider [Sat, 22 Jan 2011 12:25:50 +0000 (13:25 +0100)]
Remove accidentally added file.

14 years agoThe rest of the places we need full urls for stylesheets
Michael J. Rubinsky [Sat, 22 Jan 2011 06:25:29 +0000 (01:25 -0500)]
The rest of the places we need full urls for stylesheets

14 years agoAnother try at serving css for API rendered views
Michael J. Rubinsky [Sat, 22 Jan 2011 06:20:52 +0000 (01:20 -0500)]
Another try at serving css for API rendered views

14 years agoHorde_Share_Datatree needs _idExists() also.
Michael J. Rubinsky [Sat, 22 Jan 2011 06:02:22 +0000 (01:02 -0500)]
Horde_Share_Datatree needs _idExists() also.

Probably a more effecient way to check this, but this driver is
deprecated. This is just to satisfy implementing the abstract method.

14 years agoMake getBody() repeatable
Chuck Hagenbuch [Sat, 22 Jan 2011 03:36:57 +0000 (22:36 -0500)]
Make getBody() repeatable

14 years agoNeed to remove the old-style named index incase this is an upgrade from h3
Michael J Rubinsky [Sat, 22 Jan 2011 02:28:40 +0000 (21:28 -0500)]
Need to remove the old-style named index incase this is an upgrade from h3

14 years agoCatch error if index doesn't exist
Michael J. Rubinsky [Sat, 22 Jan 2011 02:18:55 +0000 (21:18 -0500)]
Catch error if index doesn't exist

14 years agoRemove hierarchical driver, update package.xml
Michael J. Rubinsky [Sat, 22 Jan 2011 02:12:31 +0000 (21:12 -0500)]
Remove hierarchical driver, update package.xml

14 years agoSqlHierarchical driver is no more
Michael J. Rubinsky [Sat, 22 Jan 2011 02:08:42 +0000 (21:08 -0500)]
SqlHierarchical driver is no more

14 years agoMove hierarchical functionality into The Sql and Sqlng share drivers.
Michael J. Rubinsky [Sat, 22 Jan 2011 02:03:01 +0000 (21:03 -0500)]
Move hierarchical functionality into The Sql and Sqlng share drivers.

Ansel is refactored to use the Sql driver for now. More refactoring is needed
before it can be switched back and forth between any drivers. (Need to compose
Horde_Share_Object with Ansel_Gallery instead of Ansel_Gallery extending the
share object).

Squashed commit of the following:

commit ed76634819d4e6c1737366d5ffafbfcc0630d12c
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:59:26 2011 -0500

    Need to check against share ids in Ansel, not share_names

commit eb742b3414c3f27978beaa3c933f65f0e243efb2
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:38:09 2011 -0500

    Cleanup/small refactoring for merged hierarchical driver

commit b3e50233d7288f3007ddea45cb35e0724c664aed
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:28:16 2011 -0500

    extend Horde_Share_Object_Sql for now.

    Need to refactor so Ansel_Gallery is composed with Horde_Share_Object instead
    of extending it.

commit bb79f1f43aa7374cee325a70fd6849f52086ec75
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 20:23:56 2011 -0500

    Simplify

commit 76ae1f5d2bb28a9267e336d912f4bd2cc49a4894
Author: Michael J. Rubinsky <mrubinsk@horde.org>
Date:   Fri Jan 21 16:37:14 2011 -0500

    Merge hierarchical functionality into base sql and sqlng drivers.

14 years agoConvert horde/Serialize to PHPUnit
Michael M Slusarz [Fri, 21 Jan 2011 23:40:41 +0000 (16:40 -0700)]
Convert horde/Serialize to PHPUnit

14 years agojson_decode() returns null on error, not false
Michael M Slusarz [Fri, 21 Jan 2011 23:39:48 +0000 (16:39 -0700)]
json_decode() returns null on error, not false

14 years agooveride the next-gen driver's default table name so the stress-test can run
Michael J. Rubinsky [Fri, 21 Jan 2011 20:53:50 +0000 (15:53 -0500)]
overide the next-gen driver's default table name so the stress-test can run
with the same migrations used in the unit tests.

14 years agoAnd still more configuration checks.
Jan Schneider [Fri, 21 Jan 2011 20:07:46 +0000 (21:07 +0100)]
And still more configuration checks.

14 years agoAnother unnecessary loop.
Jan Schneider [Fri, 21 Jan 2011 19:14:42 +0000 (20:14 +0100)]
Another unnecessary loop.

14 years ago...and three times a charm
Michael J. Rubinsky [Fri, 21 Jan 2011 20:00:41 +0000 (15:00 -0500)]
...and three times a charm

14 years agoOne more place to check for entire config entry
Michael J. Rubinsky [Fri, 21 Jan 2011 19:58:20 +0000 (14:58 -0500)]
One more place to check for entire config entry

14 years agoBug #9455: Add ability to output full URL for CSS
Michael M Slusarz [Fri, 21 Jan 2011 19:47:52 +0000 (12:47 -0700)]
Bug #9455: Add ability to output full URL for CSS

14 years agoBug #9455: Add ability to return relative URL when converting to string
Michael M Slusarz [Fri, 21 Jan 2011 19:44:37 +0000 (12:44 -0700)]
Bug #9455: Add ability to return relative URL when converting to string

14 years agoDon't need session info for cache URL
Michael M Slusarz [Fri, 21 Jan 2011 19:30:01 +0000 (12:30 -0700)]
Don't need session info for cache URL

14 years agophpdoc/style
Michael M Slusarz [Fri, 21 Jan 2011 18:50:04 +0000 (11:50 -0700)]
phpdoc/style

14 years agoRemove unnecessary loop.
Jan Schneider [Fri, 21 Jan 2011 19:03:30 +0000 (20:03 +0100)]
Remove unnecessary loop.

14 years agoCheck for backend-specific configuration.
Jan Schneider [Fri, 21 Jan 2011 19:03:06 +0000 (20:03 +0100)]
Check for backend-specific configuration.

14 years agoBug #9514: Don't allow adding public key if already exists
Michael M Slusarz [Fri, 21 Jan 2011 18:40:49 +0000 (11:40 -0700)]
Bug #9514: Don't allow adding public key if already exists

14 years agoBreak key info parsing into separate method
Michael M Slusarz [Fri, 21 Jan 2011 18:36:50 +0000 (11:36 -0700)]
Break key info parsing into separate method

14 years agoFix error reporting
Michael M Slusarz [Fri, 21 Jan 2011 18:27:25 +0000 (11:27 -0700)]
Fix error reporting

14 years agoStill more iframe resize tweaks
Michael M Slusarz [Fri, 21 Jan 2011 17:54:18 +0000 (10:54 -0700)]
Still more iframe resize tweaks

14 years agoThrow exception if git repository not found
Michael M Slusarz [Thu, 20 Jan 2011 23:31:50 +0000 (16:31 -0700)]
Throw exception if git repository not found

14 years agoFix attribute_params column type.
Jan Schneider [Fri, 21 Jan 2011 17:16:22 +0000 (18:16 +0100)]
Fix attribute_params column type.

14 years agoCatch exceptions from API call.
Jan Schneider [Fri, 21 Jan 2011 14:16:16 +0000 (15:16 +0100)]
Catch exceptions from API call.

14 years agoRevert "Output full uris for stylesheets when rendering via API"
Michael J Rubinsky [Fri, 21 Jan 2011 16:31:25 +0000 (11:31 -0500)]
Revert "Output full uris for stylesheets when rendering via API"

This doesn't work as I expected.  Can't use Horde::includeStylesheetFiles() if
full urls are desired.
This reverts commit f9488bf92087ac71d7affbaa849d8d0435c98a99.

14 years agoOutput full uris for stylesheets when rendering via API
Michael J. Rubinsky [Fri, 21 Jan 2011 16:11:05 +0000 (11:11 -0500)]
Output full uris for stylesheets when rendering via API

14 years agoReturn an empty array, not an empty string
Michael J. Rubinsky [Fri, 21 Jan 2011 15:50:32 +0000 (10:50 -0500)]
Return an empty array, not an empty string

14 years agoFix case.
Michael J Rubinsky [Fri, 21 Jan 2011 15:40:12 +0000 (10:40 -0500)]
Fix case.

Did I mention how much I love mac's case insensitive fs? Grr..

14 years agofix column name
Michael J Rubinsky [Fri, 21 Jan 2011 14:49:48 +0000 (09:49 -0500)]
fix column name

14 years agoAdd stance for SQL-NG share driver.
Jan Schneider [Fri, 21 Jan 2011 13:30:59 +0000 (14:30 +0100)]
Add stance for SQL-NG share driver.

14 years agoAdd share NG migrations.
Jan Schneider [Fri, 21 Jan 2011 13:28:44 +0000 (14:28 +0100)]
Add share NG migrations.

14 years agoFix licenses.
Jan Schneider [Fri, 21 Jan 2011 13:27:34 +0000 (14:27 +0100)]
Fix licenses.

14 years agoUnset default value.
Jan Schneider [Fri, 21 Jan 2011 13:14:25 +0000 (14:14 +0100)]
Unset default value.

14 years agoCast number defaults to integer/float.
Jan Schneider [Fri, 21 Jan 2011 13:13:53 +0000 (14:13 +0100)]
Cast number defaults to integer/float.

14 years agoWe don't have any way to authenticate at the command line, so set
Jan Schneider [Thu, 20 Jan 2011 18:45:34 +0000 (19:45 +0100)]
We don't have any way to authenticate at the command line, so set
'authentication' always to 'none' when in CLI mode.

14 years agoCli object is already instantiated.
Jan Schneider [Thu, 20 Jan 2011 18:42:32 +0000 (19:42 +0100)]
Cli object is already instantiated.

14 years agoShow correct error message when running CLI scripts.
Jan Schneider [Thu, 20 Jan 2011 18:32:16 +0000 (19:32 +0100)]
Show correct error message when running CLI scripts.

14 years agoAdd script for later migration of share data.
Jan Schneider [Thu, 20 Jan 2011 18:09:20 +0000 (19:09 +0100)]
Add script for later migration of share data.

14 years agoFix path.
Jan Schneider [Thu, 20 Jan 2011 18:08:40 +0000 (19:08 +0100)]
Fix path.

14 years agoWrap prompt message, and place default value after the prompt when using
Jan Schneider [Thu, 20 Jan 2011 18:07:48 +0000 (19:07 +0100)]
Wrap prompt message, and place default value after the prompt when using
multiple choices.

14 years agoFix badly broken patchsets display
Michael M Slusarz [Thu, 20 Jan 2011 20:57:36 +0000 (13:57 -0700)]
Fix badly broken patchsets display

14 years agoMakes way more sense to link to file/revision from file log rather than patchsets...
Michael M Slusarz [Thu, 20 Jan 2011 20:52:58 +0000 (13:52 -0700)]
Makes way more sense to link to file/revision from file log rather than patchsets (which don't work with CVS)

14 years agoFix +/- determination for CVS files
Michael M Slusarz [Thu, 20 Jan 2011 20:44:04 +0000 (13:44 -0700)]
Fix +/- determination for CVS files

14 years agoBug #9528: Fix Windows-1258 conversion
Michael M Slusarz [Thu, 20 Jan 2011 20:23:54 +0000 (13:23 -0700)]
Bug #9528: Fix Windows-1258 conversion

Remove workaround for broken iconv() added here:

http://git.horde.org/co.php/framework/Util/Attic/String.php?sa=1&rt=horde&r=1.19

There's no PHP bug referenced, and I can't find any.  Adding this
extra character breaks Windows-1258 conversion.
If it was a bug in 2003, hopefully it has been fixed by now (all unit
tests pass).

14 years agoFix URL determination when scanning for URLs
Michael M Slusarz [Thu, 20 Jan 2011 18:05:21 +0000 (11:05 -0700)]
Fix URL determination when scanning for URLs

Don't search at beginning of string - URL can appear anywhere in text.

14 years agophpdoc
Michael M Slusarz [Thu, 20 Jan 2011 17:56:25 +0000 (10:56 -0700)]
phpdoc

14 years agoBug #9524: Fix method signature
Michael M Slusarz [Thu, 20 Jan 2011 17:49:47 +0000 (10:49 -0700)]
Bug #9524: Fix method signature

14 years agoThis should only need to be done on creation of IMAP object
Michael M Slusarz [Thu, 20 Jan 2011 17:17:42 +0000 (10:17 -0700)]
This should only need to be done on creation of IMAP object

14 years agoIE fixes
Michael M Slusarz [Thu, 20 Jan 2011 08:56:41 +0000 (01:56 -0700)]
IE fixes

14 years agoExtend the base query to allow quickly fetching folder information.
Gunnar Wrobel [Thu, 20 Jan 2011 14:48:11 +0000 (15:48 +0100)]
Extend the base query to allow quickly fetching folder information.

14 years agoOnly remove scheme and host if we don't want a full URL.
Jan Schneider [Thu, 20 Jan 2011 10:08:01 +0000 (11:08 +0100)]
Only remove scheme and host if we don't want a full URL.

14 years agoAs per RFC 3986 URI schemes are: ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ).
Jan Schneider [Thu, 20 Jan 2011 09:57:16 +0000 (10:57 +0100)]
As per RFC 3986 URI schemes are: ALPHA *( ALPHA / DIGIT / "+" / "-" / "." ).

14 years agoBug #9493: More thorough checking when retrieving PGP key by e-mail
Michael M Slusarz [Thu, 20 Jan 2011 08:47:05 +0000 (01:47 -0700)]
Bug #9493: More thorough checking when retrieving PGP key by e-mail

Add basic keyserver retrieval tests

14 years agoBug #9525: Switch header charsets if we can't encode properly
Michael M Slusarz [Thu, 20 Jan 2011 07:09:25 +0000 (00:09 -0700)]
Bug #9525: Switch header charsets if we can't encode properly

14 years agoFix transparent login to imp if using preauthenticate hook
Michael M Slusarz [Thu, 20 Jan 2011 06:37:29 +0000 (23:37 -0700)]
Fix transparent login to imp if using preauthenticate hook

14 years agoBug #9525: Add Horde_Mime::encodeAddress() tests
Michael M Slusarz [Thu, 20 Jan 2011 06:21:04 +0000 (23:21 -0700)]
Bug #9525: Add Horde_Mime::encodeAddress() tests

14 years agoConverted horde/Crypt package to PHPUnit
Michael M Slusarz [Thu, 20 Jan 2011 06:10:30 +0000 (23:10 -0700)]
Converted horde/Crypt package to PHPUnit

14 years agoBug #9349: Fix new subfolder doesn't show in folder list
Michael M Slusarz [Thu, 20 Jan 2011 05:00:27 +0000 (22:00 -0700)]
Bug #9349: Fix new subfolder doesn't show in folder list

Problem only occurred if all (unsubscribed) folders are viewed.
hasChildren() was always returning true because we created the parent
element before making the initial hasChildren() check.  Need to check
for children before this.

14 years agoDon't allow a protocol scheme to start with punctuation. Should they even be able...
Chuck Hagenbuch [Thu, 20 Jan 2011 04:20:45 +0000 (23:20 -0500)]
Don't allow a protocol scheme to start with punctuation. Should they even be able to start with numbers?

14 years agoBug #9525: Add validation tests
Michael M Slusarz [Thu, 20 Jan 2011 04:11:52 +0000 (21:11 -0700)]
Bug #9525: Add validation tests

14 years agoUpgrade deprecated function calls
Michael M Slusarz [Thu, 20 Jan 2011 04:11:30 +0000 (21:11 -0700)]
Upgrade deprecated function calls

14 years agoMore correct for IE
Michael M Slusarz [Wed, 19 Jan 2011 20:26:41 +0000 (13:26 -0700)]
More correct for IE

14 years agoBug #9523: Send a full link when sending the email to confirm the identity
Gonçalo Queirós [Tue, 18 Jan 2011 20:52:54 +0000 (20:52 +0000)]
Bug #9523: Send a full link when sending the email to confirm the identity

Signed-off-by: Michael M Slusarz <slusarz@curecanti.org>
14 years agoSimplify
Michael M Slusarz [Wed, 19 Jan 2011 19:04:45 +0000 (12:04 -0700)]
Simplify

14 years agoClean up DimpBase.go() method
Michael M Slusarz [Wed, 19 Jan 2011 00:06:14 +0000 (17:06 -0700)]
Clean up DimpBase.go() method

Separate action and arguments into separate items instead of parsing an
input string.

14 years agoBetter location to set mailbox name in the hash
Michael M Slusarz [Tue, 18 Jan 2011 23:00:47 +0000 (16:00 -0700)]
Better location to set mailbox name in the hash

14 years agoNG share driver.
Jan Schneider [Tue, 18 Jan 2011 23:12:26 +0000 (00:12 +0100)]
NG share driver.

14 years agoAdd migration script for Kronolith.
Jan Schneider [Tue, 18 Jan 2011 23:11:36 +0000 (00:11 +0100)]
Add migration script for Kronolith.

14 years agoRemove unnecessary DISTINCTs.
Jan Schneider [Tue, 18 Jan 2011 23:10:27 +0000 (00:10 +0100)]
Remove unnecessary DISTINCTs.

14 years agoFix DB adapter detection.
Jan Schneider [Tue, 18 Jan 2011 23:09:08 +0000 (00:09 +0100)]
Fix DB adapter detection.

14 years agoFix listing groups, catch empty member lists.
Jan Schneider [Tue, 18 Jan 2011 23:08:40 +0000 (00:08 +0100)]
Fix listing groups, catch empty member lists.

14 years agoNo idea why, but when this exception is an ErrorException, the autoloading is
Jan Schneider [Tue, 18 Jan 2011 22:55:13 +0000 (23:55 +0100)]
No idea why, but when this exception is an ErrorException, the autoloading is
not triggered.

14 years agoUse correct key when creating first share.
Jan Schneider [Tue, 18 Jan 2011 18:26:13 +0000 (19:26 +0100)]
Use correct key when creating first share.

14 years agoLog backtrace if logging an exception.
Jan Schneider [Tue, 18 Jan 2011 18:25:53 +0000 (19:25 +0100)]
Log backtrace if logging an exception.

14 years agoThe behavior is correct, remove outcommented lines.
Jan Schneider [Tue, 18 Jan 2011 17:34:22 +0000 (18:34 +0100)]
The behavior is correct, remove outcommented lines.

14 years agoAllow range to be specified in hash for dimp URL
Michael M Slusarz [Tue, 18 Jan 2011 21:22:23 +0000 (14:22 -0700)]
Allow range to be specified in hash for dimp URL

14 years agoRequest #9432: Better context menu UI for setting/removing flags
Michael M Slusarz [Tue, 18 Jan 2011 19:55:45 +0000 (12:55 -0700)]
Request #9432: Better context menu UI for setting/removing flags

14 years agoBug #9369: Allow a javascript variable name to be used for ckeditor config
Michael M Slusarz [Tue, 18 Jan 2011 18:44:50 +0000 (11:44 -0700)]
Bug #9369: Allow a javascript variable name to be used for ckeditor config

14 years agoBug #9514: Fix importing S/MIME key
Michael M Slusarz [Tue, 18 Jan 2011 08:25:05 +0000 (01:25 -0700)]
Bug #9514: Fix importing S/MIME key

14 years agoAdd _getPartStream()
Michael M Slusarz [Tue, 18 Jan 2011 08:18:35 +0000 (01:18 -0700)]
Add _getPartStream()

14 years agoHandle S/MIME message verify without cert verify as success
Michael M Slusarz [Tue, 18 Jan 2011 08:00:36 +0000 (01:00 -0700)]
Handle S/MIME message verify without cert verify as success

14 years agoTweak verify of S/MIME messages.
Michael M Slusarz [Tue, 18 Jan 2011 07:59:39 +0000 (00:59 -0700)]
Tweak verify of S/MIME messages.

Verify without verify signer's certificate should be a success, not an
exception.

14 years agoCleaner creation of hash fingerprint
Michael M Slusarz [Tue, 18 Jan 2011 07:43:48 +0000 (00:43 -0700)]
Cleaner creation of hash fingerprint

14 years agoFix deleting S/MIME Public keys
Michael M Slusarz [Tue, 18 Jan 2011 07:28:15 +0000 (00:28 -0700)]
Fix deleting S/MIME Public keys

14 years agoAdd form token to generated prefs URL
Michael M Slusarz [Tue, 18 Jan 2011 07:27:59 +0000 (00:27 -0700)]
Add form token to generated prefs URL