horde.git
15 years agoDo app pushing entirely within Registry.
Michael M Slusarz [Sun, 11 Apr 2010 01:27:52 +0000 (19:27 -0600)]
Do app pushing entirely within Registry.

This reverts commit 2b647b8ef7bb3be67b3b63616b9988de697744f6.

15 years agofix file name
Michael J. Rubinsky [Sat, 10 Apr 2010 19:35:45 +0000 (15:35 -0400)]
fix file name

15 years agoNeed to push $app onto the stack before loading it's preferences.
Michael J. Rubinsky [Sat, 10 Apr 2010 17:41:57 +0000 (13:41 -0400)]
Need to push $app onto the stack before loading it's preferences.

Prevents fatal errors due to autoloading not being setup for the app.

15 years agoMake sure we have the APIs needed for each folder class
Michael J. Rubinsky [Sat, 10 Apr 2010 17:22:09 +0000 (13:22 -0400)]
Make sure we have the APIs needed for each folder class

15 years agoAdd a Task message object in preperation for task synch support
Michael J. Rubinsky [Sat, 10 Apr 2010 16:32:54 +0000 (12:32 -0400)]
Add a Task message object in preperation for task synch support

...also consistently use self:: for these constants where appropriate

15 years agoset the activesync MEETINGSTATUS property accordingly.
Michael J. Rubinsky [Sat, 10 Apr 2010 16:10:16 +0000 (12:10 -0400)]
set the activesync MEETINGSTATUS property accordingly.

15 years agoRemove stale syncstate if we have a key mismatch
Michael J. Rubinsky [Sat, 10 Apr 2010 15:50:08 +0000 (11:50 -0400)]
Remove stale syncstate if we have a key mismatch

15 years agothis method is now obsolete
Michael J. Rubinsky [Sat, 10 Apr 2010 14:58:40 +0000 (10:58 -0400)]
this method is now obsolete

15 years agoWhen performing remotewipe, only send <status> and <remotewipe />
Michael J. Rubinsky [Sat, 10 Apr 2010 14:53:04 +0000 (10:53 -0400)]
When performing remotewipe, only send <status> and <remotewipe />

We were sending the entire provision section - it should be ignored by
clients...but the spec clearly states it should only contain <remotewipe />

15 years agoremove todo and obsolete constants
Michael J. Rubinsky [Sat, 10 Apr 2010 14:52:40 +0000 (10:52 -0400)]
remove todo and obsolete constants

15 years agoThrow exception if synckey is mangled, and return appropriate status code to PIM
Michael J. Rubinsky [Sat, 10 Apr 2010 14:09:42 +0000 (10:09 -0400)]
Throw exception if synckey is mangled, and return appropriate status code to PIM

15 years agoRemove a bunch of @todo
Michael J. Rubinsky [Sat, 10 Apr 2010 14:02:22 +0000 (10:02 -0400)]
Remove a bunch of @todo

15 years agoFix case of method name, remove deprecated code
Michael J. Rubinsky [Sat, 10 Apr 2010 13:48:22 +0000 (09:48 -0400)]
Fix case of method name, remove deprecated code

15 years agoInitial implementation of the sendMail method.
Michael J. Rubinsky [Sat, 10 Apr 2010 13:42:39 +0000 (09:42 -0400)]
Initial implementation of the sendMail method.

sendMail receives a rfc822 string from the PIM, parses it and sends it through Horde's configured mailer.
Currently only used when the PIM initiates sending appointment invitations. Still need to fill in the rest of the
implementation before it can be used more widely.

15 years agoInject a mailer instance into the activesync driver
Michael J. Rubinsky [Sat, 10 Apr 2010 13:42:01 +0000 (09:42 -0400)]
Inject a mailer instance into the activesync driver

15 years agoAdd SendMail.php to package.xml
Michael J. Rubinsky [Fri, 9 Apr 2010 22:55:11 +0000 (18:55 -0400)]
Add SendMail.php to package.xml

15 years agoWe need to implement SendMail:
Michael J. Rubinsky [Fri, 9 Apr 2010 22:50:34 +0000 (18:50 -0400)]
We need to implement SendMail:

Seems that some clients automatically call SendMail when creating a new appointment with attendees and send
them a meeting invitation. Implement the request class, but the driver currently discards the email rec'd. Need
to figure out what to do with this...

15 years agoThe last of the (currently implemented) constants.
Michael J. Rubinsky [Fri, 9 Apr 2010 22:39:06 +0000 (18:39 -0400)]
The last of the (currently implemented) constants.

..also comment out the defines for constants used in commands that are not yet implemented.

15 years agoRemove deprecated defines
Michael J. Rubinsky [Fri, 9 Apr 2010 22:08:47 +0000 (18:08 -0400)]
Remove deprecated defines

15 years agoMove Request related constants to the main Horde_ActiveSync class.
Michael J. Rubinsky [Fri, 9 Apr 2010 22:06:36 +0000 (18:06 -0400)]
Move Request related constants to the main Horde_ActiveSync class.

These are used in various places, avoid loading other files just to get
at these constants.

15 years agoFix constant name
Michael J. Rubinsky [Fri, 9 Apr 2010 22:06:10 +0000 (18:06 -0400)]
Fix constant name

15 years agoMore constant fixes
Michael J. Rubinsky [Fri, 9 Apr 2010 21:53:38 +0000 (17:53 -0400)]
More constant fixes

15 years agoDon't output any body, just the header. Devices won't show this anyway
Michael J. Rubinsky [Fri, 9 Apr 2010 21:52:03 +0000 (17:52 -0400)]
Don't output any body, just the header. Devices won't show this anyway

15 years agoTRUNCATION constants
Michael J. Rubinsky [Fri, 9 Apr 2010 20:13:20 +0000 (16:13 -0400)]
TRUNCATION constants

15 years agoClass constants for various sync request tags
Michael J. Rubinsky [Fri, 9 Apr 2010 20:07:15 +0000 (16:07 -0400)]
Class constants for various sync request tags

15 years agoStart moving these to class constants.
Michael J. Rubinsky [Fri, 9 Apr 2010 19:15:49 +0000 (15:15 -0400)]
Start moving these to class constants.

This one moves the POOMCONTACTS and POOMCONTACTS2 constants

15 years agoCorrectly determine if we are creating a session or not when calling rpc.php.
Michael J. Rubinsky [Fri, 9 Apr 2010 18:01:00 +0000 (14:01 -0400)]
Correctly determine if we are creating a session or not when calling rpc.php.

Need to determine type of server before calling appInit() and also need to let
Horde_Controller_Request_Http know we don't want a session.  This will probably
be taken care of when we use a full-fledged controller here, but for now we need to
pass the session_control value to the Request const'r.

15 years agoFix check if AS is disabled.
Jan Schneider [Fri, 9 Apr 2010 17:04:20 +0000 (19:04 +0200)]
Fix check if AS is disabled.

15 years agoDisplay subscription URLs.
Jan Schneider [Fri, 9 Apr 2010 15:49:40 +0000 (16:49 +0100)]
Display subscription URLs.

15 years agoTweak alignment and wording.
Jan Schneider [Fri, 9 Apr 2010 15:49:39 +0000 (16:49 +0100)]
Tweak alignment and wording.

15 years agoShow 'no items' notice if a calendar section is empty.
Jan Schneider [Fri, 9 Apr 2010 15:49:38 +0000 (16:49 +0100)]
Show 'no items' notice if a calendar section is empty.

15 years agoRender 'more' links inline.
Jan Schneider [Fri, 9 Apr 2010 15:49:37 +0000 (16:49 +0100)]
Render 'more' links inline.

15 years agoUse "bolder" arrow sign.
Jan Schneider [Fri, 9 Apr 2010 15:42:48 +0000 (17:42 +0200)]
Use "bolder" arrow sign.

15 years agoMFB: Remove deleted list contacts from the same address book too.
Jan Schneider [Fri, 9 Apr 2010 13:36:54 +0000 (15:36 +0200)]
MFB: Remove deleted list contacts from the same address book too.

15 years agoCheck for pear_error being returned from Horde_Share
Michael J. Rubinsky [Thu, 8 Apr 2010 19:53:41 +0000 (15:53 -0400)]
Check for pear_error being returned from Horde_Share

15 years agoNeed to define this variable even if we are wiping
Michael J. Rubinsky [Thu, 8 Apr 2010 19:50:30 +0000 (15:50 -0400)]
Need to define this variable even if we are wiping

15 years agoThese properties are only present in AS versions > 2.5
Michael J. Rubinsky [Thu, 8 Apr 2010 19:49:25 +0000 (15:49 -0400)]
These properties are only present in AS versions > 2.5

15 years agoInitial support for resources to contain email addresses.
Michael J. Rubinsky [Thu, 8 Apr 2010 18:49:05 +0000 (14:49 -0400)]
Initial support for resources to contain email addresses.

No notifications are sent, just stores the email address. Needed for
synch clients that support resource attendees.

15 years agoAvoid &new.
Gunnar Wrobel [Thu, 8 Apr 2010 18:30:11 +0000 (20:30 +0200)]
Avoid &new.

15 years agoRefactor the permission handling in Kolab_Storage.
Gunnar Wrobel [Thu, 8 Apr 2010 17:45:54 +0000 (19:45 +0200)]
Refactor the permission handling in Kolab_Storage.

15 years agoDon't attempt to send categories if none are set
Michael J. Rubinsky [Thu, 8 Apr 2010 17:25:18 +0000 (13:25 -0400)]
Don't attempt to send categories if none are set

15 years agoThis method is called statically
Michael J. Rubinsky [Thu, 8 Apr 2010 16:36:10 +0000 (12:36 -0400)]
This method is called statically

15 years agoFill in the remaining properties for event exceptions - and add missing support for...
Michael J. Rubinsky [Thu, 8 Apr 2010 14:34:09 +0000 (10:34 -0400)]
Fill in the remaining properties for event exceptions - and add missing support for the body (kronolith's Notes field) element.

15 years agoSome clients send a PROVISION command even when it's not told to do so by the server.
Michael J. Rubinsky [Thu, 8 Apr 2010 14:24:44 +0000 (10:24 -0400)]
Some clients send a PROVISION command even when it's not told to do so by the server.

We must check our provision setting when we receive a PROVISION request, and send back
a NOT_DEFINED status code if no policy exists on the server.

15 years agoThe list of internal attributes is just a list and not an association of attribute...
Gunnar Wrobel [Thu, 8 Apr 2010 13:10:24 +0000 (15:10 +0200)]
The list of internal attributes is just a list and not an association of attribute names and corresponding class names.

15 years agoAlways fetch single attributes.
Gunnar Wrobel [Thu, 8 Apr 2010 12:50:19 +0000 (14:50 +0200)]
Always fetch single attributes.

15 years agoMigrate hooks to H4 (Request #8954).
Jan Schneider [Thu, 8 Apr 2010 08:28:39 +0000 (10:28 +0200)]
Migrate hooks to H4 (Request #8954).

15 years agoAdd support for attendees when syncing via ActiveSync devices
Michael J. Rubinsky [Thu, 8 Apr 2010 00:12:39 +0000 (20:12 -0400)]
Add support for attendees when syncing via ActiveSync devices

15 years agoFix adding and getting attendees from the Appointment object.
Michael J. Rubinsky [Thu, 8 Apr 2010 00:10:58 +0000 (20:10 -0400)]
Fix adding and getting attendees from the Appointment object.

Adding attendees should now work when syncing

15 years agoOverride this even though it's not implemented. It's needed to prevent fatals when...
Michael J. Rubinsky [Wed, 7 Apr 2010 20:21:29 +0000 (16:21 -0400)]
Override this even though it's not implemented. It's needed to prevent fatals when searching.

Some devices send SEARCH requests when adding attendees to an event, this prevents those requests from
killing the server.

15 years agoBug #8612: Automatically disable tidy.clean_output PHP setting
Michael M Slusarz [Wed, 7 Apr 2010 22:44:30 +0000 (16:44 -0600)]
Bug #8612: Automatically disable tidy.clean_output PHP setting

15 years agoBug #8952: Fix casting spam parameter to number
Michael M Slusarz [Wed, 7 Apr 2010 22:30:11 +0000 (16:30 -0600)]
Bug #8952: Fix casting spam parameter to number

15 years agoWe really shouldn't need to be this detailed with the logging
Michael J. Rubinsky [Wed, 7 Apr 2010 19:59:15 +0000 (15:59 -0400)]
We really shouldn't need to be this detailed with the logging

15 years agoClean up some logging, and some other misc. cleanup
Michael J. Rubinsky [Wed, 7 Apr 2010 19:44:12 +0000 (15:44 -0400)]
Clean up some logging, and some other misc. cleanup

15 years agoMake folder list display display via template.
Michael M Slusarz [Thu, 8 Apr 2010 18:31:42 +0000 (12:31 -0600)]
Make folder list display display via template.

15 years agoIdentities prefs should be working again.
Michael M Slusarz [Wed, 7 Apr 2010 21:00:04 +0000 (15:00 -0600)]
Identities prefs should be working again.

15 years agoMake folder list display display via template.
Michael M Slusarz [Thu, 8 Apr 2010 18:31:42 +0000 (12:31 -0600)]
Make folder list display display via template.

15 years agoInitial support for resources to contain email addresses.
Michael J. Rubinsky [Thu, 8 Apr 2010 18:49:05 +0000 (14:49 -0400)]
Initial support for resources to contain email addresses.

No notifications are sent, just stores the email address. Needed for
synch clients that support resource attendees.

15 years agoAvoid &new.
Gunnar Wrobel [Thu, 8 Apr 2010 18:30:11 +0000 (20:30 +0200)]
Avoid &new.

15 years agoRefactor the permission handling in Kolab_Storage.
Gunnar Wrobel [Thu, 8 Apr 2010 17:45:54 +0000 (19:45 +0200)]
Refactor the permission handling in Kolab_Storage.

15 years agoDon't attempt to send categories if none are set
Michael J. Rubinsky [Thu, 8 Apr 2010 17:25:18 +0000 (13:25 -0400)]
Don't attempt to send categories if none are set

15 years agoThis method is called statically
Michael J. Rubinsky [Thu, 8 Apr 2010 16:36:10 +0000 (12:36 -0400)]
This method is called statically

15 years agoFill in the remaining properties for event exceptions - and add missing support for...
Michael J. Rubinsky [Thu, 8 Apr 2010 14:34:09 +0000 (10:34 -0400)]
Fill in the remaining properties for event exceptions - and add missing support for the body (kronolith's Notes field) element.

15 years agoSome clients send a PROVISION command even when it's not told to do so by the server.
Michael J. Rubinsky [Thu, 8 Apr 2010 14:24:44 +0000 (10:24 -0400)]
Some clients send a PROVISION command even when it's not told to do so by the server.

We must check our provision setting when we receive a PROVISION request, and send back
a NOT_DEFINED status code if no policy exists on the server.

15 years agoThe list of internal attributes is just a list and not an association of attribute...
Gunnar Wrobel [Thu, 8 Apr 2010 13:10:24 +0000 (15:10 +0200)]
The list of internal attributes is just a list and not an association of attribute names and corresponding class names.

15 years agoAlways fetch single attributes.
Gunnar Wrobel [Thu, 8 Apr 2010 12:50:19 +0000 (14:50 +0200)]
Always fetch single attributes.

15 years agoMigrate hooks to H4 (Request #8954).
Jan Schneider [Thu, 8 Apr 2010 08:28:39 +0000 (10:28 +0200)]
Migrate hooks to H4 (Request #8954).

15 years agoAdd support for attendees when syncing via ActiveSync devices
Michael J. Rubinsky [Thu, 8 Apr 2010 00:12:39 +0000 (20:12 -0400)]
Add support for attendees when syncing via ActiveSync devices

15 years agoFix adding and getting attendees from the Appointment object.
Michael J. Rubinsky [Thu, 8 Apr 2010 00:10:58 +0000 (20:10 -0400)]
Fix adding and getting attendees from the Appointment object.

Adding attendees should now work when syncing

15 years agoOverride this even though it's not implemented. It's needed to prevent fatals when...
Michael J. Rubinsky [Wed, 7 Apr 2010 20:21:29 +0000 (16:21 -0400)]
Override this even though it's not implemented. It's needed to prevent fatals when searching.

Some devices send SEARCH requests when adding attendees to an event, this prevents those requests from
killing the server.

15 years agoBug #8612: Automatically disable tidy.clean_output PHP setting
Michael M Slusarz [Wed, 7 Apr 2010 22:44:30 +0000 (16:44 -0600)]
Bug #8612: Automatically disable tidy.clean_output PHP setting

15 years agoBug #8952: Fix casting spam parameter to number
Michael M Slusarz [Wed, 7 Apr 2010 22:30:11 +0000 (16:30 -0600)]
Bug #8952: Fix casting spam parameter to number

15 years agoWe really shouldn't need to be this detailed with the logging
Michael J. Rubinsky [Wed, 7 Apr 2010 19:59:15 +0000 (15:59 -0400)]
We really shouldn't need to be this detailed with the logging

15 years agoClean up some logging, and some other misc. cleanup
Michael J. Rubinsky [Wed, 7 Apr 2010 19:44:12 +0000 (15:44 -0400)]
Clean up some logging, and some other misc. cleanup

15 years agoMerge branch 'master' into newprefs
Michael M Slusarz [Wed, 7 Apr 2010 16:36:25 +0000 (10:36 -0600)]
Merge branch 'master' into newprefs

15 years agoKey can't be empty when passing to Crypt_Blowfish
Michael M Slusarz [Wed, 7 Apr 2010 16:26:56 +0000 (10:26 -0600)]
Key can't be empty when passing to Crypt_Blowfish

15 years agoCatch messages with no date header
Michael M Slusarz [Wed, 7 Apr 2010 13:59:58 +0000 (07:59 -0600)]
Catch messages with no date header

15 years agoMerge branch 'master' into newprefs
Michael M Slusarz [Wed, 7 Apr 2010 16:35:37 +0000 (10:35 -0600)]
Merge branch 'master' into newprefs

15 years agoKey can't be empty when passing to Crypt_Blowfish
Michael M Slusarz [Wed, 7 Apr 2010 16:26:56 +0000 (10:26 -0600)]
Key can't be empty when passing to Crypt_Blowfish

15 years agoKey can't be empty when passing to Crypt_Blowfish
Michael M Slusarz [Wed, 7 Apr 2010 16:26:56 +0000 (10:26 -0600)]
Key can't be empty when passing to Crypt_Blowfish

15 years agoConvert turba addressbooks pref to json format
Michael M Slusarz [Wed, 7 Apr 2010 15:17:03 +0000 (09:17 -0600)]
Convert turba addressbooks pref to json format

15 years agoMove form processing for source/addressbook prefs to Widgets class
Michael M Slusarz [Wed, 7 Apr 2010 15:05:36 +0000 (09:05 -0600)]
Move form processing for source/addressbook prefs to Widgets class

15 years agoMove alarms handling into prefs ui widgets
Michael M Slusarz [Wed, 7 Apr 2010 14:51:54 +0000 (08:51 -0600)]
Move alarms handling into prefs ui widgets

15 years agoAllow injecting the Imap_Client into the Kolab_Storage driver.
Gunnar Wrobel [Wed, 24 Mar 2010 20:47:39 +0000 (21:47 +0100)]
Allow injecting the Imap_Client into the Kolab_Storage driver.

15 years agoAdd TODO.
Gunnar Wrobel [Wed, 24 Mar 2010 15:49:37 +0000 (16:49 +0100)]
Add TODO.

15 years agoMove addressbook param code back to the applications
Michael M Slusarz [Wed, 7 Apr 2010 14:32:02 +0000 (08:32 -0600)]
Move addressbook param code back to the applications

15 years agoNo need to pass UI object to widget code
Michael M Slusarz [Wed, 7 Apr 2010 14:19:29 +0000 (08:19 -0600)]
No need to pass UI object to widget code

15 years agoCatch messages with no date header
Michael M Slusarz [Wed, 7 Apr 2010 13:59:58 +0000 (07:59 -0600)]
Catch messages with no date header

15 years agoCatch messages with no date header
Michael M Slusarz [Wed, 7 Apr 2010 13:59:58 +0000 (07:59 -0600)]
Catch messages with no date header

15 years agoConvert mnemo to new preferences UI
Michael M Slusarz [Wed, 7 Apr 2010 13:33:58 +0000 (07:33 -0600)]
Convert mnemo to new preferences UI

15 years agoMerge branch 'master' into newprefs
Michael M Slusarz [Wed, 7 Apr 2010 13:26:00 +0000 (07:26 -0600)]
Merge branch 'master' into newprefs

Conflicts:
framework/Prefs/lib/Horde/Prefs/Ui.php

15 years agoImprovements to addressbook pref handling
Michael M Slusarz [Wed, 7 Apr 2010 13:04:06 +0000 (07:04 -0600)]
Improvements to addressbook pref handling

15 years agoMigrate to H4 (imp (at) lx-soft (dot) com, Request #8950).
Jan Schneider [Wed, 7 Apr 2010 07:56:23 +0000 (09:56 +0200)]
Migrate to H4 (imp (at) lx-soft (dot) com, Request #8950).

15 years agoImport Mnemo from CVS.
Jan Schneider [Wed, 7 Apr 2010 07:51:45 +0000 (09:51 +0200)]
Import Mnemo from CVS.

15 years agoConvert fima to new preferences UI code
Michael M Slusarz [Wed, 7 Apr 2010 07:04:15 +0000 (01:04 -0600)]
Convert fima to new preferences UI code

15 years agoConvert gollem to new preferences UI code
Michael M Slusarz [Wed, 7 Apr 2010 06:49:08 +0000 (00:49 -0600)]
Convert gollem to new preferences UI code

15 years agoConvert Ansel to new preferences UI code
Michael M Slusarz [Tue, 6 Apr 2010 23:26:40 +0000 (17:26 -0600)]
Convert Ansel to new preferences UI code

15 years ago$_FILES is always set.
Jan Schneider [Tue, 6 Apr 2010 15:25:32 +0000 (17:25 +0200)]
$_FILES is always set.

15 years agoFix saving multienum prefs that have their enums provided by prefsInit().
Jan Schneider [Tue, 6 Apr 2010 14:41:13 +0000 (16:41 +0200)]
Fix saving multienum prefs that have their enums provided by prefsInit().

15 years agoPreferences UI rewrite.
Michael M Slusarz [Thu, 25 Mar 2010 17:55:04 +0000 (11:55 -0600)]
Preferences UI rewrite.

Goals of the rewrite:
1. Make ALL preference page display across ALL applications handled by a
single point: the horde services preference page. This means moving all
application specifc preference handling to inside of
Horde_Registry_Application functions. NO page, other than
horde/services/prefs.php, should be using the Horde Prefs UI functions
anymore.
2. Move Horde Prefs UI code out of Prefs package and into the Core
package. UI handling is not something that should be handled by a
library (will eventually move other things out of Prefs too, including
Category Management and Identity code, since this is code that overlays
the Prefs driver in a Horde-specific manner)
3. Simplify the prefs UI configuration. Don't require 'shared' or
'locked' entries (default to false) or 'type' entry (default to
'implicit'). Remove some unneeded types (select). Improve documentation.
4. Handle dynamic population of entries and suppression of prefGroups
and specific preferences in Application::prefsInit(). This code confuses
the prefs.php file.
5. Abstract out some common 'special' preference handlers.  For
example, identical addressbook selection code is used in several
applications (imp, kronolith, whups). Move this code to a prefs UI
widgets class so it can be reused.
6. Convert prefs templates to Horde_Template. As always, I know the
arguments against HT, but the simple fact is that is still the only
time-tested method that we used and it does produce a template file that
is easy to edit. Not to mention that the PHP code polluting the old
include files made these files absolutely unreadable and/or
maintainable.
7. Remove credentials code.  It wasn't being used anywhere in the code (I
believe it used to be a hack for IMP-related auth in Horde 3.x, but
shouldn't be needed anymore due to new authentication code).
8. Other improvements that have escaped my mind since I have been
working on this code for several weeks now...

Reasons for the rewrite:
1. The old Prefs UI code was ancient and a mess.  It was a static file
and globals were used all over the place.  New UI code is OO-based and
allows us to pass the object around, making these like suppression of
groups/prefs, hiding buttons, and current state identification much
easier and cleaner.
2. There is a need to redo the UI itself, especially for dynamic
apps, to allow for a different/better preferences experience. Thus, the
UI will eventually be able to be themed based on the current view type
(dynamic, standard, mobile/minimal). To do this, all UI needs to be
controlled from a single source, rather than disparate scripts.
3. Add ability to mark preferences as 'advanced' so they are not shown
by default.  This is prefereable to the current method of 'locking'
advanced prefs.  Admins may very well want users to be able to change a
pref, but they don't want that pref shown to basic users.