Chuck Hagenbuch [Fri, 2 Oct 2009 00:42:11 +0000 (20:42 -0400)]
Avoid calling set_magic_quotes_runtime if magic_quotes_runtime wasn't on.
Chuck Hagenbuch [Thu, 1 Oct 2009 22:36:12 +0000 (18:36 -0400)]
remove references that cause "only variables should assgned by reference" errors
Chuck Hagenbuch [Thu, 1 Oct 2009 20:38:55 +0000 (16:38 -0400)]
fix variable name typo
Michael J. Rubinsky [Fri, 2 Oct 2009 00:56:58 +0000 (20:56 -0400)]
Actually, use the 'headers' option to add the headers, to make it
clearer why they can't be set before setOptions()
Michael J. Rubinsky [Fri, 2 Oct 2009 00:48:37 +0000 (20:48 -0400)]
Add headers after other values are set, otherwise they get overwritten.
Michael J. Rubinsky [Tue, 29 Sep 2009 19:40:42 +0000 (15:40 -0400)]
Remove @since
Michael J. Rubinsky [Thu, 1 Oct 2009 20:43:29 +0000 (16:43 -0400)]
More refactoring to use exceptions
Fixes issue in Bug: 8623 as well.
Michael M Slusarz [Thu, 1 Oct 2009 19:27:19 +0000 (13:27 -0600)]
Preserve entities in HTML output
Michael M Slusarz [Thu, 1 Oct 2009 19:41:09 +0000 (13:41 -0600)]
Michael M Slusarz [Thu, 1 Oct 2009 19:40:33 +0000 (13:40 -0600)]
Revert "More dimp row tweaking: use stripes and increase whitespace a bit"
This reverts commit
8a595316276fe4f8773db442aec331856891b4c6.
Michael M Slusarz [Thu, 1 Oct 2009 19:39:38 +0000 (13:39 -0600)]
CSS tweaks
Michael M Slusarz [Thu, 1 Oct 2009 18:08:40 +0000 (12:08 -0600)]
This is required to be UTF-8 since JSON data is always UTF-8
Chuck Hagenbuch [Thu, 1 Oct 2009 18:42:58 +0000 (14:42 -0400)]
- make constructors consistent across Request types
- consistently try to set proxy settings across Request types
- condense code in Curl and Peclhttp requests for translating between our constants and theirs
Chuck Hagenbuch [Thu, 1 Oct 2009 17:42:53 +0000 (13:42 -0400)]
Add HTTP auth support. All adapters support BASIC; Curl and Peclhttp support a bunch more.
Duck (Jakob Munih) [Thu, 1 Oct 2009 16:12:16 +0000 (18:12 +0200)]
Horde_Auth::authenticateFailure
Jan Schneider [Thu, 1 Oct 2009 13:37:37 +0000 (15:37 +0200)]
Add getIPAddress() (Bug #8620).
Jan Schneider [Mon, 28 Sep 2009 13:20:07 +0000 (15:20 +0200)]
Fix ngettext() calls, use date format parameter, use time format parameter.
Jan Schneider [Thu, 1 Oct 2009 12:00:55 +0000 (14:00 +0200)]
Update deleted attributes during synchronization (lst_hoe02@kwsoft.de, Request #6658).
Jan Schneider [Thu, 1 Oct 2009 10:36:46 +0000 (12:36 +0200)]
Merged, partially.
Jan Schneider [Thu, 1 Oct 2009 10:02:01 +0000 (12:02 +0200)]
MFB
Jan Schneider [Thu, 1 Oct 2009 10:01:32 +0000 (12:01 +0200)]
MFB: Avoid notices (Bug #8523).
Ryu [Wed, 30 Sep 2009 19:51:26 +0000 (21:51 +0200)]
Fix bug #8523 - Photo attribute is corrupted after a move or a copy
Signed-off-by: Jan Schneider <jan@horde.org>
Duck (Jakob Munih) [Thu, 1 Oct 2009 08:45:45 +0000 (10:45 +0200)]
use Horde::serviceLink
Duck (Jakob Munih) [Thu, 1 Oct 2009 07:33:14 +0000 (09:33 +0200)]
Don't access protected data directly
Duck (Jakob Munih) [Thu, 1 Oct 2009 06:46:13 +0000 (08:46 +0200)]
fckeditor -> Fckeditor
Michael M Slusarz [Wed, 30 Sep 2009 18:20:22 +0000 (12:20 -0600)]
More dimp row tweaking: use stripes and increase whitespace a bit
Michael M Slusarz [Wed, 30 Sep 2009 18:17:55 +0000 (12:17 -0600)]
stripe functions have moved inside of Horde namespace
Michael M Slusarz [Wed, 30 Sep 2009 18:13:58 +0000 (12:13 -0600)]
Tweak positioning of quicksearch box
Michael M Slusarz [Wed, 30 Sep 2009 08:29:07 +0000 (02:29 -0600)]
Indicate current quicksearch field in search box
Michael M Slusarz [Wed, 30 Sep 2009 06:19:28 +0000 (00:19 -0600)]
Better uidvalidity checking in dimp ajax handler
Michael M Slusarz [Wed, 30 Sep 2009 05:50:19 +0000 (23:50 -0600)]
More places to check uidvalidity.
Duck (Jakob Munih) [Wed, 30 Sep 2009 16:13:30 +0000 (18:13 +0200)]
Correctly catch errors
Duck (Jakob Munih) [Wed, 30 Sep 2009 15:29:53 +0000 (17:29 +0200)]
typo
Duck (Jakob Munih) [Wed, 30 Sep 2009 14:59:11 +0000 (16:59 +0200)]
We must throw an exeption on bad login
Chuck Hagenbuch [Wed, 30 Sep 2009 04:15:39 +0000 (00:15 -0400)]
refactor Horde_Feed tests for recent changes
Chuck Hagenbuch [Wed, 30 Sep 2009 04:14:38 +0000 (00:14 -0400)]
Refactor Horde_Feed to remove the static HTTP client, and to inject it
instead. Also use the method override support in the HTTP client instead of
hardcoding it at the feed level.
Chuck Hagenbuch [Wed, 30 Sep 2009 04:12:48 +0000 (00:12 -0400)]
Add support for http method overriding to the HTTP client. possibly should go in
a subclass or decorator instead.
/**
+ * Use POST instead of PUT and DELETE, sending X-HTTP-Method-Override with
+ * the intended method name instead.
+ *
+ * @var boolean
+ */
+ protected $_httpMethodOverride = false;
+
+ /**
* Horde_Http_Client constructor.
*
* @param array $args Any Http_Client settings to initialize in the
* constructor. Available settings are:
+ * client.httpMethodOverride
* client.proxyServer
* client.proxyUser
* client.proxyPass
@@ -62,7 +71,12 @@ class Horde_Http_Client
foreach ($args as $key => $val) {
list($object, $objectkey) = explode('.', $key, 2);
- $this->$object->$objectkey = $val;
+ if ($object == 'request') {
+ $this->$object->$objectkey = $val;
+ } elseif ($object == 'client') {
+ $objectKey = '_' . $objectKey;
+ $this->$objectKey = $val;
+ }
}
}
@@ -93,7 +107,11 @@ class Horde_Http_Client
*/
public function put($uri = null, $data = null, $headers = array())
{
- /* @TODO suport method override (X-Method-Override: PUT). */
+ if ($this->_httpMethodOverride) {
+ $headers = array_merge(array('X-HTTP-Method-Override' => 'PUT'), $headers);
+ return $this->post($uri, $data, $headers);
+ }
+
return $this->request('PUT', $uri, $data, $headers);
}
@@ -104,7 +122,11 @@ class Horde_Http_Client
*/
public function delete($uri = null, $headers = array())
{
- /* @TODO suport method override (X-Method-Override: DELETE). */
+ if ($this->_httpMethodOverride) {
+ $headers = array_merge(array('X-HTTP-Method-Override' => 'DELETE'), $headers);
+ return $this->post($uri, null, $headers);
+ }
+
return $this->request('DELETE', $uri, null, $headers);
}
Michael M Slusarz [Thu, 17 Sep 2009 21:58:46 +0000 (15:58 -0600)]
Try the grid with vertical lines only.
Jan Schneider [Tue, 29 Sep 2009 13:21:51 +0000 (15:21 +0200)]
Increase readability.
Gunnar Wrobel [Tue, 29 Sep 2009 21:21:46 +0000 (23:21 +0200)]
Merge branch 'framework_history_mock'
Michael J. Rubinsky [Tue, 29 Sep 2009 20:51:47 +0000 (16:51 -0400)]
Fix some things from a pretty mangled merge
Michael J. Rubinsky [Mon, 28 Sep 2009 16:53:22 +0000 (12:53 -0400)]
Remove listResources from Kronolth_Resource and refactor code to
use Kronolith_Driver_Resource::listResources instead.
Michael J. Rubinsky [Sat, 26 Sep 2009 21:07:29 +0000 (17:07 -0400)]
UI support for creating and maintaining resource groups.
Michael J. Rubinsky [Tue, 22 Sep 2009 00:00:00 +0000 (20:00 -0400)]
Move this to the base class.
Michael J. Rubinsky [Mon, 21 Sep 2009 23:53:27 +0000 (19:53 -0400)]
Correct conditional that catches conflicts.
Allow the next event to start at the end time of the previous event.
Michael J. Rubinsky [Fri, 18 Sep 2009 04:38:48 +0000 (00:38 -0400)]
Start fleshing out the K_Resource_Group stuff.
Michael J. Rubinsky [Fri, 18 Sep 2009 04:38:23 +0000 (00:38 -0400)]
spelling
Michael J. Rubinsky [Fri, 18 Sep 2009 04:35:11 +0000 (00:35 -0400)]
Refactor a bit.
Move Kronolith_Resource::checkResources to Kronolith_Resource_*::getResponse()
and remove the responsibilty of adding the event.
Michael J. Rubinsky [Thu, 17 Sep 2009 23:08:28 +0000 (19:08 -0400)]
Removed some cruft from original testing
Michael J. Rubinsky [Thu, 17 Sep 2009 23:06:58 +0000 (19:06 -0400)]
Clean up a bit.
Remove unused factory, add some phpdoc etc...
Michael J. Rubinsky [Thu, 17 Sep 2009 23:04:34 +0000 (19:04 -0400)]
Remove max_reservations.
It's not intuitive and won't be needed in 99.9% of the use cases. For
single resources that may be overbooked, the resource should be created
with a RESPONSETYPE_ALWAYS_EXCEPT responseType instead.
Michael J. Rubinsky [Thu, 17 Sep 2009 00:32:21 +0000 (20:32 -0400)]
Provide feedback on resource availability as soon as it's added to the attendees form.
If response type is Kronolith_Resource::RESPONSETYPE_AUTO then use the start and end datetime
values that are now passed from the event form to determine if the resource is free.
Still need to figure out how to (efficiently) pass the datetime values to take into account
AM/PM. Probably break out the javascript from the onClick handler into it's function and
provide logic to check the am/pm fields? Is there an easier/prettier way?
Michael J. Rubinsky [Wed, 16 Sep 2009 22:18:47 +0000 (18:18 -0400)]
Don't open resource calendars in _blank, use the same window
Michael J. Rubinsky [Sat, 12 Sep 2009 16:22:04 +0000 (12:22 -0400)]
Notify for acceptance as well
Michael J. Rubinsky [Sat, 12 Sep 2009 16:20:54 +0000 (12:20 -0400)]
Need to move this comparison after the loop.
If we are editing an event that was already accepted, we might hit max_reservations
before we get to the event we are editing.
Michael J. Rubinsky [Sat, 12 Sep 2009 15:44:07 +0000 (11:44 -0400)]
Make this "Response", just like the attendee's column
Michael J. Rubinsky [Sat, 12 Sep 2009 15:38:48 +0000 (11:38 -0400)]
Move static resource related methods to Kronolith_Resource::
Michael J. Rubinsky [Sat, 12 Sep 2009 15:06:36 +0000 (11:06 -0400)]
More additions based on some discussion with Gunnar in IRC:
- Allow specifying if a resource is required or optional
- Add a response_type property to resources. Specifies if REQUESTS are
either always accepted, always denied, automatically accepted/denied
based on actual availability, handled manually (still todo), or simply
ignored (set response to NONE).
Also, try to clean up the implementation - trying to make it more likely
to be able to be extened for kolab. No idea if this helps of not though ;)
Michael J. Rubinsky [Fri, 11 Sep 2009 19:21:27 +0000 (15:21 -0400)]
Rename sql script
Michael J. Rubinsky [Fri, 11 Sep 2009 19:09:15 +0000 (15:09 -0400)]
Lots of stuff:
- Move resource viewing/CRUD related pages to resources/*
- Have Kronolith_Resource objects present a Horde_Share_Object-like interface
- Remove the Resource link from the menu - put it in the panel under the "Manage My Calendars" link
- Various tweaks/corrections
Michael J. Rubinsky [Fri, 11 Sep 2009 16:03:49 +0000 (12:03 -0400)]
Add a link in Kronolith's menu for the resource page
Michael J. Rubinsky [Thu, 10 Sep 2009 16:12:20 +0000 (12:12 -0400)]
Only attempt to remove resources from the event if they have actually
accepted the event.
Michael J. Rubinsky [Thu, 10 Sep 2009 16:11:12 +0000 (12:11 -0400)]
notify user if a requested resource rejects invitation when saving event
Michael J. Rubinsky [Thu, 10 Sep 2009 14:28:57 +0000 (10:28 -0400)]
Initial adding of resource to an event from the attendees page.
Michael J. Rubinsky [Thu, 10 Sep 2009 14:26:20 +0000 (10:26 -0400)]
Add basic permission checking to Kronolith::listResources()
Michael J. Rubinsky [Wed, 9 Sep 2009 19:31:28 +0000 (15:31 -0400)]
Move hasPermisson to the base class, implement ::get() to behave like
a share.
Michael J. Rubinsky [Wed, 9 Sep 2009 19:30:54 +0000 (15:30 -0400)]
typos
Michael J. Rubinsky [Wed, 9 Sep 2009 19:10:56 +0000 (15:10 -0400)]
Experiment with getting either a share or resource here
Michael J. Rubinsky [Wed, 9 Sep 2009 18:49:02 +0000 (14:49 -0400)]
listEvents:: isn't detailed enough for this...manually compare
start/end times to determine if an event collides.
Add basic hasPermission method, not sure if it's really needed yet.
Michael J. Rubinsky [Tue, 29 Sep 2009 15:21:19 +0000 (11:21 -0400)]
resource scheduling blurb
Michael J. Rubinsky [Tue, 29 Sep 2009 15:20:15 +0000 (11:20 -0400)]
Add sql script updates
Michael J. Rubinsky [Mon, 28 Sep 2009 21:55:08 +0000 (17:55 -0400)]
Use Horde_Lock to lock the resource calendar.
Lock the resource calnedar right before we check availability, and
unlock it either after the invitation is denied, or if accepted,
after the event is added to the resource's calendar.
Michael J. Rubinsky [Mon, 28 Sep 2009 16:53:22 +0000 (12:53 -0400)]
Remove listResources from Kronolth_Resource and refactor code to
use Kronolith_Driver_Resource::listResources instead.
Michael J. Rubinsky [Mon, 28 Sep 2009 16:23:30 +0000 (12:23 -0400)]
Add resources to the event view as well
Michael J. Rubinsky [Sat, 26 Sep 2009 21:07:29 +0000 (17:07 -0400)]
UI support for creating and maintaining resource groups.
Michael J. Rubinsky [Wed, 23 Sep 2009 17:13:40 +0000 (13:13 -0400)]
Better check for valid resource
Michael J. Rubinsky [Tue, 22 Sep 2009 00:23:01 +0000 (20:23 -0400)]
More work on resource groups. Most of the backend support for resource groups is implemented,
but there is no GUI support yet.
Michael J. Rubinsky [Tue, 22 Sep 2009 00:00:00 +0000 (20:00 -0400)]
Move this to the base class.
Michael J. Rubinsky [Mon, 21 Sep 2009 23:58:35 +0000 (19:58 -0400)]
Protect against infinite recursion in case someone is silly enough to
add a resource to one of the resource's own events.
Michael J. Rubinsky [Mon, 21 Sep 2009 23:53:27 +0000 (19:53 -0400)]
Correct conditional that catches conflicts.
Allow the next event to start at the end time of the previous event.
Michael J. Rubinsky [Mon, 21 Sep 2009 21:59:02 +0000 (17:59 -0400)]
Split up the checking resoruce response and adding the (accepted) event to
the resource's calendar.
This is needed because we need the event to have a guid when it's added to
the resource's calendar, otherwise they end up with different GUIDs. This also
gives us some protection against an inconsistent state if there were to be an issue
saving the event to storage after it's been added to the resource's calendar.
Michael J. Rubinsky [Mon, 21 Sep 2009 21:55:25 +0000 (17:55 -0400)]
remove an errant var_dump
Michael J. Rubinsky [Sun, 20 Sep 2009 03:00:07 +0000 (23:00 -0400)]
typo
Michael J. Rubinsky [Fri, 18 Sep 2009 04:38:48 +0000 (00:38 -0400)]
Start fleshing out the K_Resource_Group stuff.
Michael J. Rubinsky [Fri, 18 Sep 2009 04:38:23 +0000 (00:38 -0400)]
spelling
Michael J. Rubinsky [Fri, 18 Sep 2009 04:35:11 +0000 (00:35 -0400)]
Refactor a bit.
Move Kronolith_Resource::checkResources to Kronolith_Resource_*::getResponse()
and remove the responsibilty of adding the event.
Michael J. Rubinsky [Fri, 18 Sep 2009 04:32:23 +0000 (00:32 -0400)]
Fix variable name
Michael J. Rubinsky [Fri, 18 Sep 2009 04:31:34 +0000 (00:31 -0400)]
Remove cruft
Michael J. Rubinsky [Thu, 17 Sep 2009 23:08:28 +0000 (19:08 -0400)]
Removed some cruft from original testing
Michael J. Rubinsky [Thu, 17 Sep 2009 23:06:58 +0000 (19:06 -0400)]
Clean up a bit.
Remove unused factory, add some phpdoc etc...
Michael J. Rubinsky [Thu, 17 Sep 2009 23:04:34 +0000 (19:04 -0400)]
Remove max_reservations.
It's not intuitive and won't be needed in 99.9% of the use cases. For
single resources that may be overbooked, the resource should be created
with a RESPONSETYPE_ALWAYS_EXCEPT responseType instead.
Michael J. Rubinsky [Thu, 17 Sep 2009 00:39:05 +0000 (20:39 -0400)]
use Horde_Support_GUID
Michael J. Rubinsky [Thu, 17 Sep 2009 00:32:21 +0000 (20:32 -0400)]
Provide feedback on resource availability as soon as it's added to the attendees form.
If response type is Kronolith_Resource::RESPONSETYPE_AUTO then use the start and end datetime
values that are now passed from the event form to determine if the resource is free.
Still need to figure out how to (efficiently) pass the datetime values to take into account
AM/PM. Probably break out the javascript from the onClick handler into it's function and
provide logic to check the am/pm fields? Is there an easier/prettier way?
Michael J. Rubinsky [Wed, 16 Sep 2009 22:18:47 +0000 (18:18 -0400)]
Don't open resource calendars in _blank, use the same window
Jan Schneider [Tue, 15 Sep 2009 14:27:49 +0000 (16:27 +0200)]
Fix sequence name.
Michael J. Rubinsky [Sat, 12 Sep 2009 16:22:04 +0000 (12:22 -0400)]
Notify for acceptance as well
Michael J. Rubinsky [Sat, 12 Sep 2009 16:20:54 +0000 (12:20 -0400)]
Need to move this comparison after the loop.
If we are editing an event that was already accepted, we might hit max_reservations
before we get to the event we are editing.
Michael J. Rubinsky [Sat, 12 Sep 2009 16:04:25 +0000 (12:04 -0400)]
Remove already added resources from the select list.
Also have listResources() return the results keyed by the resource_id
Michael J. Rubinsky [Sat, 12 Sep 2009 15:44:07 +0000 (11:44 -0400)]
Make this "Response", just like the attendee's column
Michael J. Rubinsky [Sat, 12 Sep 2009 15:38:48 +0000 (11:38 -0400)]
Move static resource related methods to Kronolith_Resource::