From 0848333eaff50a30c120e9144736cbd9fb176b56 Mon Sep 17 00:00:00 2001 From: Michael M Slusarz Date: Tue, 2 Nov 2010 13:39:36 -0600 Subject: [PATCH] Make sure Vcard entries always have labels --- framework/Core/lib/Horde/Core/Mime/Viewer/Vcard.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/framework/Core/lib/Horde/Core/Mime/Viewer/Vcard.php b/framework/Core/lib/Horde/Core/Mime/Viewer/Vcard.php index 00de31698..f3d4c91de 100644 --- a/framework/Core/lib/Horde/Core/Mime/Viewer/Vcard.php +++ b/framework/Core/lib/Horde/Core/Mime/Viewer/Vcard.php @@ -136,12 +136,15 @@ class Horde_Core_Mime_Viewer_Vcard extends Horde_Mime_Viewer_Base $html .= ' '; } + $addresses = $vc->getAllAttributes('EMAIL'); + $html .= ''; - $fullname = $vc->getAttributeDefault('FN', false); - if ($fullname !== false) { - $html .= $fullname; + if (($fullname = $vc->getAttributeDefault('FN', false)) === false) { + $fullname = count($addresses) + ? $addresses[0]['value'] + : Horde_Core_Translation::t("[No Label]"); } - $html .= ''; + $html .= $fullname . ''; $n = $vc->printableName(); if (!empty($n)) { @@ -324,7 +327,6 @@ class Horde_Core_Mime_Viewer_Vcard extends Horde_Mime_Viewer_Base } } - $addresses = $vc->getAllAttributes('EMAIL'); $emails = array(); foreach ($addresses as $address) { if (isset($address['params']['TYPE'])) { -- 2.11.0