From 35425e049a32014c7aa3b85f87d90ea8cd0d8d27 Mon Sep 17 00:00:00 2001 From: maxcooper Date: Mon, 19 Aug 2002 17:11:36 +0000 Subject: [PATCH] fixed bug 596684: NullPointerException when isUserInRole() is called for unauthenticated user --- .../org/securityfilter/realm/SimpleSecurityRealmBase.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/share/org/securityfilter/realm/SimpleSecurityRealmBase.java b/src/share/org/securityfilter/realm/SimpleSecurityRealmBase.java index 0b1bd74..1793cbc 100644 --- a/src/share/org/securityfilter/realm/SimpleSecurityRealmBase.java +++ b/src/share/org/securityfilter/realm/SimpleSecurityRealmBase.java @@ -1,7 +1,7 @@ /* - * $Header: /cvsroot/securityfilter/securityfilter/src/share/org/securityfilter/realm/SimpleSecurityRealmBase.java,v 1.3 2002/08/17 14:11:55 maxcooper Exp $ - * $Revision: 1.3 $ - * $Date: 2002/08/17 14:11:55 $ + * $Header: /cvsroot/securityfilter/securityfilter/src/share/org/securityfilter/realm/SimpleSecurityRealmBase.java,v 1.4 2002/08/19 17:11:36 maxcooper Exp $ + * $Revision: 1.4 $ + * $Date: 2002/08/19 17:11:36 $ * * ==================================================================== * The SecurityFilter Software License, Version 1.1 @@ -64,7 +64,7 @@ import java.io.Serializable; * a Principal object and this class does the conversions for you. * * @author Max Cooper (max@maxcooper.com) - * @version $Revision: 1.3 $ $Date: 2002/08/17 14:11:55 $ + * @version $Revision: 1.4 $ $Date: 2002/08/19 17:11:36 $ */ public class SimpleSecurityRealmBase implements SecurityRealmInterface { @@ -123,7 +123,11 @@ public class SimpleSecurityRealmBase implements SecurityRealmInterface { * @return true if the user is in the role, false otherwise */ public boolean isUserInRole(Principal principal, String rolename) { - return isUserInRole(principal.getName(), rolename); + String username = null; + if (principal != null) { + username = principal.getName(); + } + return isUserInRole(username, rolename); } } -- 2.11.0