From 426d5e9a84c56f1cf785538a9448d46262c158d2 Mon Sep 17 00:00:00 2001
From: markt <markt@13f79535-47bb-0310-9956-ffa450edef68>
Date: Thu, 29 Jul 2010 11:24:45 +0000
Subject: [PATCH] Fix an Eclipse nag

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@980407 13f79535-47bb-0310-9956-ffa450edef68
---
 java/org/apache/catalina/session/ManagerBase.java | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/java/org/apache/catalina/session/ManagerBase.java b/java/org/apache/catalina/session/ManagerBase.java
index 25fea7885..4219f2319 100644
--- a/java/org/apache/catalina/session/ManagerBase.java
+++ b/java/org/apache/catalina/session/ManagerBase.java
@@ -786,10 +786,11 @@ public abstract class ManagerBase extends LifecycleMBeanBase
         session.setValid(true);
         session.setCreationTime(System.currentTimeMillis());
         session.setMaxInactiveInterval(this.maxInactiveInterval);
-        if (sessionId == null) {
-            sessionId = generateSessionId();
+        String id = sessionId;
+        if (id == null) {
+            id = generateSessionId();
         }
-        session.setId(sessionId);
+        session.setId(id);
         sessionCounter++;
 
         return (session);
-- 
2.11.0