From 463bdfdb2da83ccd741665225244563747d66f02 Mon Sep 17 00:00:00 2001 From: markt Date: Wed, 14 Apr 2010 22:50:35 +0000 Subject: [PATCH] https://issues.apache.org/bugzilla/show_bug.cgi?id=49118 Use StringBuilder rather than concatenation git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@934234 13f79535-47bb-0310-9956-ffa450edef68 --- java/javax/servlet/http/HttpServlet.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/java/javax/servlet/http/HttpServlet.java b/java/javax/servlet/http/HttpServlet.java index fc713abce..14a8c5651 100644 --- a/java/javax/servlet/http/HttpServlet.java +++ b/java/javax/servlet/http/HttpServlet.java @@ -559,25 +559,25 @@ public abstract class HttpServlet extends GenericServlet { int responseLength; String CRLF = "\r\n"; - String responseString = "TRACE "+ req.getRequestURI()+ - " " + req.getProtocol(); + StringBuilder buffer = new StringBuilder("TRACE ").append(req.getRequestURI()) + .append(" ").append(req.getProtocol()); Enumeration reqHeaderEnum = req.getHeaderNames(); while( reqHeaderEnum.hasMoreElements() ) { String headerName = reqHeaderEnum.nextElement(); - responseString += CRLF + headerName + ": " + - req.getHeader(headerName); + buffer.append(CRLF).append(headerName).append(": ") + .append(req.getHeader(headerName)); } - responseString += CRLF; + buffer.append(CRLF); - responseLength = responseString.length(); + responseLength = buffer.length(); resp.setContentType("message/http"); resp.setContentLength(responseLength); ServletOutputStream out = resp.getOutputStream(); - out.print(responseString); + out.print(buffer.toString()); out.close(); return; } -- 2.11.0