From 4e2a0c64838d84f91804a938cd315e1257a317a7 Mon Sep 17 00:00:00 2001 From: Gunnar Wrobel Date: Thu, 26 Aug 2010 08:01:45 +0200 Subject: [PATCH] Add some todos (and use phpdoc rather than the TODO file). --- framework/Itip/TODO | 3 --- framework/Itip/lib/Horde/Itip/Event/Vevent.php | 6 ++++++ framework/Itip/lib/Horde/Itip/Resource/Identity.php | 1 + framework/Itip/package.xml | 1 - 4 files changed, 7 insertions(+), 4 deletions(-) delete mode 100644 framework/Itip/TODO diff --git a/framework/Itip/TODO b/framework/Itip/TODO deleted file mode 100644 index 4580e7378..000000000 --- a/framework/Itip/TODO +++ /dev/null @@ -1,3 +0,0 @@ - - - Merge with Horde Imp (Changes [Horde]: Extended message body; improved From, Changes [Kolab]: Do not automatically set the sequence attribute to 0 if it does not exist -> http://bugs.horde.org/ticket/4863; use lower case mailto -> http://bugs.horde.org/ticket/4872; Missing UID in the vEvent causes failure; - - Use parse_url diff --git a/framework/Itip/lib/Horde/Itip/Event/Vevent.php b/framework/Itip/lib/Horde/Itip/Event/Vevent.php index 84b1e8dcb..ced204f68 100644 --- a/framework/Itip/lib/Horde/Itip/Event/Vevent.php +++ b/framework/Itip/lib/Horde/Itip/Event/Vevent.php @@ -26,6 +26,10 @@ * @author Gunnar Wrobel * @license http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html LGPL * @link http://pear.horde.org/index.php?package=Itip + * + * @todo Clean this class up. Accessing private methods for copying the object + * is not nice. Reconsider if an interface is really needed. See also PMD + * report. */ class Horde_Itip_Event_Vevent implements Horde_Itip_Event @@ -112,6 +116,8 @@ implements Horde_Itip_Event * Return the organizer of the iTip event. * * @return string The organizer of the event. + * + * @todo Parse mailto using parse_url */ public function getOrganizer() { diff --git a/framework/Itip/lib/Horde/Itip/Resource/Identity.php b/framework/Itip/lib/Horde/Itip/Resource/Identity.php index bd45a1a8e..b2855745a 100644 --- a/framework/Itip/lib/Horde/Itip/Resource/Identity.php +++ b/framework/Itip/lib/Horde/Itip/Resource/Identity.php @@ -51,6 +51,7 @@ implements Horde_Itip_Resource * @param array $attendees The attendees of the invitation. * @param string $reply_to The selected identity for sending the * reply. + * @todo Parse mailto using parse_url */ public function __construct($identity, $attendees, $reply_to) { diff --git a/framework/Itip/package.xml b/framework/Itip/package.xml index c1f34302c..c805b772a 100644 --- a/framework/Itip/package.xml +++ b/framework/Itip/package.xml @@ -98,7 +98,6 @@ - -- 2.11.0