From 639b1d1514ac611f4371401dc74ff2512f788f95 Mon Sep 17 00:00:00 2001 From: markt Date: Sat, 27 Sep 2008 13:45:27 +0000 Subject: [PATCH] Fix string comp bugs reported by Find Bugs git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@699646 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/tomcat/util/digester/Digester.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/org/apache/tomcat/util/digester/Digester.java b/java/org/apache/tomcat/util/digester/Digester.java index 13371dd63..bfabd6207 100644 --- a/java/org/apache/tomcat/util/digester/Digester.java +++ b/java/org/apache/tomcat/util/digester/Digester.java @@ -2866,7 +2866,7 @@ public class Digester extends DefaultHandler { try { String newValue = IntrospectionUtils.replaceProperties(value, null, source); - if (value != newValue) { + if (!value.equals(newValue)) { newAttrs.setValue(i, newValue); } } @@ -2894,7 +2894,7 @@ public class Digester extends DefaultHandler { return bodyText; // return unchanged data } - if (out == in) { + if (out.equals(in)) { // No substitutions required. Don't waste memory creating // a new buffer return bodyText; -- 2.11.0