From 78b39a6dfb421c77548c7629ee241e6934f7adad Mon Sep 17 00:00:00 2001 From: markt Date: Wed, 15 Dec 2010 13:53:22 +0000 Subject: [PATCH] Fix another FindBugs niggle git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1049553 13f79535-47bb-0310-9956-ffa450edef68 --- .../WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java b/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java index d422d22c9..69d7ed20e 100644 --- a/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java +++ b/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/ShuffleSimpleTag.java @@ -19,6 +19,7 @@ package jsp2.examples.simpletag; import java.io.IOException; +import java.util.Random; import javax.servlet.jsp.JspException; import javax.servlet.jsp.tagext.JspFragment; @@ -29,13 +30,16 @@ import javax.servlet.jsp.tagext.SimpleTagSupport; * JspFragment and invokes then in a random order. */ public class ShuffleSimpleTag extends SimpleTagSupport { + // No need for this to use SecureRandom + private static Random random = new Random(); + private JspFragment fragment1; private JspFragment fragment2; private JspFragment fragment3; @Override public void doTag() throws JspException, IOException { - switch( (int)(Math.random() * 6) ) { + switch(random.nextInt(6)) { case 0: fragment1.invoke( null ); fragment2.invoke( null ); -- 2.11.0