From 78e26541e9e9b9ed18f9638fdadb98e78861d39f Mon Sep 17 00:00:00 2001
From: Michael M Slusarz <slusarz@curecanti.org>
Date: Fri, 13 Mar 2009 12:35:56 -0600
Subject: [PATCH] Fix dragdrop.js when drop area contains scrollbars.

Mouseover/mouseout events may not trigger when moving over a scrollbar,
so we need to observe the current position by looking at the mousemove
event instead.  Works out for the better since we are already processing
the mousemove event - allows us to remove 2 more global event observe
calls.
---
 imp/js/src/dragdrop.js | 68 +++++++++++++++++++-------------------------------
 1 file changed, 25 insertions(+), 43 deletions(-)

diff --git a/imp/js/src/dragdrop.js b/imp/js/src/dragdrop.js
index 270082873..74d1fd1aa 100644
--- a/imp/js/src/dragdrop.js
+++ b/imp/js/src/dragdrop.js
@@ -136,15 +136,9 @@ var DragDrop = {
 
     Drops: {
         drops: $H(),
-        init: false,
 
         register: function(obj)
         {
-            if (!this.init) {
-                document.observe('mouseover', this._mouseHandler.bindAsEventListener(this, 'over'));
-                document.observe('mouseout', this._mouseHandler.bindAsEventListener(this, 'out'));
-                this.init = true;
-            }
             this.drops.set(obj.element.identify(), obj);
             obj.element.addClassName('DropElt');
         },
@@ -156,35 +150,12 @@ var DragDrop = {
             }
 
             this.drops.unset(obj.element.identify());
-            obj.element.addClassName('DropElt');
+            obj.element.removeClassName('DropElt');
         },
 
         get_drop: function(el)
         {
             return this.drops.get(Object.isElement(el) ? $(el).identify() : el);
-        },
-
-        _mouseHandler: function(e, type)
-        {
-            var elt = e.element();
-
-            if (this.drops.size()) {
-                if (!elt.hasClassName('DropElt')) {
-                    elt = elt.up('.DropElt');
-                }
-
-                if (elt) {
-                    switch (type) {
-                    case 'over':
-                        this.get_drop(elt).mouseOver(e);
-                        break;
-
-                    case 'out':
-                        this.get_drop(elt).mouseOut(e);
-                        break;
-                    }
-                }
-            }
         }
     },
 
@@ -338,11 +309,26 @@ Drag = Class.create({
 
     _onMoveDrag: function(xy, e)
     {
-        var c_opt, caption, cname, d_cap,
+        var c_opt, caption, cname, d_cap, elt,
             d = DragDrop.Drops.drop,
             div = DragDrop.Drags.div,
             d_update = true;
 
+        /* Do mouseover/mouseout-like detection here. Saves on observe calls
+         * and handles case where mouse moves over scrollbars. */
+        if (DragDrop.Drops.drops.size()) {
+            elt = e.element();
+            if (!elt.hasClassName('DropElt')) {
+                elt = elt.up('.DropElt');
+            }
+
+            if (elt) {
+                DragDrop.Drops.get_drop(elt).mouseOver();
+            } else if (d) {
+                d.mouseOut();
+            }
+        }
+
         if (d && DragDrop.validDrop(this.element)) {
             d_cap = d.options.caption;
             if (d_cap) {
@@ -481,23 +467,19 @@ Drop = Class.create({
         DragDrop.Drops.unregister(this);
     },
 
-    mouseOver: function(e)
+    mouseOver: function()
     {
-        if (DragDrop.Drags.drag) {
-            DragDrop.Drops.drop = this;
-            if (Object.isFunction(this.options.onOver)) {
-                this.options.onOver(this.element, DragDrop.Drags.drag);
-            }
+        DragDrop.Drops.drop = this;
+        if (Object.isFunction(this.options.onOver)) {
+            this.options.onOver(this.element, DragDrop.Drags.drag);
         }
     },
 
-    mouseOut: function(e)
+    mouseOut: function()
     {
-        if (DragDrop.Drags.drag) {
-            if (Object.isFunction(this.options.onOut)) {
-                this.options.onOut(this.element, DragDrop.Drags.drag);
-            }
-            DragDrop.Drops.drop = null;
+        if (Object.isFunction(this.options.onOut)) {
+            this.options.onOut(this.element, DragDrop.Drags.drag);
         }
+        DragDrop.Drops.drop = null;
     }
 });
-- 
2.11.0