From 80c9f36981d57d06917e35575d2e9baa125c67f7 Mon Sep 17 00:00:00 2001 From: Gunnar Wrobel Date: Wed, 4 Nov 2009 16:17:51 +0100 Subject: [PATCH] Fix constructor. Add todo. Use array_shift instead of array_pop. --- framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php b/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php index 2eef350f8..5569e51fc 100644 --- a/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php +++ b/framework/Kolab_Server/lib/Horde/Kolab/Server/Object/Hash.php @@ -42,7 +42,7 @@ implements Horde_Kolab_Server_Object_Interface * @param Horde_Kolab_Server_Object $object The represented object. */ public function __construct( - Horde_Kolab_Server_Object $object + Horde_Kolab_Server_Object_Interface $object ) { $this->_object = $object; } @@ -134,8 +134,9 @@ implements Horde_Kolab_Server_Object_Interface public function getSingle($attr) { $value = $this->getExternal($attr); + //@todo: Check if that can actually be something other than an array. if (is_array($value)) { - return array_pop($value); + return array_shift($value); } else { return $value; } -- 2.11.0