From 90abf6980ef62de00c64b39cb7d215797618b831 Mon Sep 17 00:00:00 2001 From: kkolinko Date: Wed, 24 Feb 2010 10:12:58 +0000 Subject: [PATCH] fixes for #getElement(): - avoid infinite looping on unexpected end of file - fix XML comment reading git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@915737 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/jasper/JspC.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/java/org/apache/jasper/JspC.java b/java/org/apache/jasper/JspC.java index 174216d5f..840ceef00 100644 --- a/java/org/apache/jasper/JspC.java +++ b/java/org/apache/jasper/JspC.java @@ -19,6 +19,7 @@ package org.apache.jasper; import java.io.BufferedReader; import java.io.CharArrayWriter; +import java.io.EOFException; import java.io.File; import java.io.FileInputStream; import java.io.FileNotFoundException; @@ -947,15 +948,18 @@ public class JspC implements Options { while (!done) { int current = reader.read(); while (current != '>') { + if (current < 0) { + throw new EOFException(); + } result.append((char) current); current = reader.read(); } result.append((char) current); int len = result.length(); - if (len > 7 && result.substring(0, 4).equals("")) { + if (len >= 7 && result.substring(len - 3, len).equals("-->")) { done = true; } } else { -- 2.11.0