From 923c59f86c7bd32cf1c7181159ade7bf5f1eeb35 Mon Sep 17 00:00:00 2001 From: markt Date: Wed, 10 Feb 2010 23:36:51 +0000 Subject: [PATCH] Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48716 Provide an undocumented 'shoot yourself in the foot' option to disable the JULI logging reset git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@908754 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/catalina/loader/WebappClassLoader.java | 32 +++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/java/org/apache/catalina/loader/WebappClassLoader.java b/java/org/apache/catalina/loader/WebappClassLoader.java index 18e24726f..e9adf344f 100644 --- a/java/org/apache/catalina/loader/WebappClassLoader.java +++ b/java/org/apache/catalina/loader/WebappClassLoader.java @@ -436,6 +436,14 @@ public class WebappClassLoader */ private boolean clearReferencesStopThreads = false; + /** + * Should Tomcat call {@link org.apache.juli.logging.LogFactory#release()} + * when the class loader is stopped? If not specified, the default value + * of true is used. Changing the default setting is likely to + * lead to memory leaks and other issues. + */ + private boolean clearReferencesLogFactoryRelease = true; + // ------------------------------------------------------------- Properties @@ -638,6 +646,26 @@ public class WebappClassLoader } + /** + * Return the clearReferencesLogFactoryRelease flag for this Context. + */ + public boolean getClearReferencesLogFactoryRelease() { + return (this.clearReferencesLogFactoryRelease); + } + + + /** + * Set the clearReferencesLogFactoryRelease feature for this Context. + * + * @param clearReferencesLogFactoryRelease The new flag value + */ + public void setClearReferencesLogFactoryRelease( + boolean clearReferencesLogFactoryRelease) { + this.clearReferencesLogFactoryRelease = + clearReferencesLogFactoryRelease; + } + + // ------------------------------------------------------- Reloader Methods @@ -1741,7 +1769,9 @@ public class WebappClassLoader IntrospectionUtils.clear(); // Clear the classloader reference in common-logging - org.apache.juli.logging.LogFactory.release(this); + if (clearReferencesLogFactoryRelease) { + org.apache.juli.logging.LogFactory.release(this); + } // Clear the classloader reference in the VM's bean introspector java.beans.Introspector.flushCaches(); -- 2.11.0