From 96fa90528912b213ca97723ab4c61e2423c7e5de Mon Sep 17 00:00:00 2001 From: Jan Schneider Date: Wed, 5 Jan 2011 19:08:34 +0100 Subject: [PATCH] No need to return anything. --- framework/Share/lib/Horde/Share/Object.php | 2 -- framework/Share/lib/Horde/Share/Object/Sql.php | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/framework/Share/lib/Horde/Share/Object.php b/framework/Share/lib/Horde/Share/Object.php index c9c11537c..9c100cff8 100644 --- a/framework/Share/lib/Horde/Share/Object.php +++ b/framework/Share/lib/Horde/Share/Object.php @@ -246,8 +246,6 @@ abstract class Horde_Share_Object implements Serializable * @param Horde_Perms_Permission $perm Permission object. * @param boolean $update Should the share be saved * after this operation? - * - * @return boolean */ abstract public function setPermission($perm, $update = true); diff --git a/framework/Share/lib/Horde/Share/Object/Sql.php b/framework/Share/lib/Horde/Share/Object/Sql.php index b76b9b6e9..c5c75bf7c 100644 --- a/framework/Share/lib/Horde/Share/Object/Sql.php +++ b/framework/Share/lib/Horde/Share/Object/Sql.php @@ -236,16 +236,13 @@ class Horde_Share_Object_Sql extends Horde_Share_Object implements Serializable * @param Horde_Perms_Permission $perm Permission object. * @param boolean $update Should the share be saved * after this operation? - * - * @return boolean */ public function setPermission($perm, $update = true) { $this->data['perm'] = $perm->getData(); if ($update) { - return $this->save(); + $this->save(); } - return true; } /** -- 2.11.0