From aa7c940c8a2abd468f20b0c99c1a10fb782c9c74 Mon Sep 17 00:00:00 2001 From: pero Date: Fri, 30 Apr 2010 11:25:10 +0000 Subject: [PATCH] Fix NPE if no encoding parameter exists at request! git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@939639 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/catalina/connector/Request.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/java/org/apache/catalina/connector/Request.java b/java/org/apache/catalina/connector/Request.java index 36503cd12..f187eacdf 100644 --- a/java/org/apache/catalina/connector/Request.java +++ b/java/org/apache/catalina/connector/Request.java @@ -2513,9 +2513,13 @@ public class Request parts.add(part); if (part.getFilename() == null) { try { - parameters.addParameterValues(part.getName(), + String encoding = parameters.getEncoding(); + if(encoding == null) { + encoding = Parameters.DEFAULT_ENCODING; + } + parameters.addParameterValues(part.getName(), new String[] {part.getString( - parameters.getEncoding())}); + encoding)}); } catch (UnsupportedEncodingException uee) { try { parameters.addParameterValues(part.getName(), @@ -2533,7 +2537,7 @@ public class Request } catch (FileUploadBase.SizeException e) { partsParseException = new IllegalStateException(e); } catch (FileUploadException e) { - partsParseException = new IOException(); + partsParseException = new IOException(e); } return; -- 2.11.0