From b05c25b6d2e90cb8163ae8b69be7d623a29d849c Mon Sep 17 00:00:00 2001 From: rjung Date: Sat, 24 Sep 2011 11:02:41 +0000 Subject: [PATCH] Use setters when cloning attributes. Should be more safe in most cases. Example: setting name directly was wrong, because name in base class was something else then in the sub classes. Not using the setter for maxActiveSessions, because it will also call property change listeners. git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1175155 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/catalina/ha/session/ClusterManagerBase.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/java/org/apache/catalina/ha/session/ClusterManagerBase.java b/java/org/apache/catalina/ha/session/ClusterManagerBase.java index 8cf201f72..542f94d55 100644 --- a/java/org/apache/catalina/ha/session/ClusterManagerBase.java +++ b/java/org/apache/catalina/ha/session/ClusterManagerBase.java @@ -181,10 +181,10 @@ public abstract class ClusterManagerBase extends ManagerBase } protected void clone(ClusterManagerBase copy) { - copy.name = "Clone-from-" + getName(); - copy.cluster = getCluster(); + copy.setName("Clone-from-" + getName()); + copy.setCluster(getCluster()); copy.maxActiveSessions = getMaxActiveSessions(); - copy.notifyListenersOnReplication = isNotifyListenersOnReplication(); + copy.setNotifyListenersOnReplication(isNotifyListenersOnReplication()); copy.setSessionAttributeFilter(getSessionAttributeFilter()); } -- 2.11.0