From b4a73fd1a465e79c3be80e12e225f7cc6c268dcd Mon Sep 17 00:00:00 2001 From: Michael M Slusarz Date: Thu, 23 Sep 2010 13:06:16 -0600 Subject: [PATCH] Request #9219: Move pref saving logging to a more appropriate location --- framework/Prefs/lib/Horde/Prefs.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/framework/Prefs/lib/Horde/Prefs.php b/framework/Prefs/lib/Horde/Prefs.php index db6d687ce..bfab8ab68 100644 --- a/framework/Prefs/lib/Horde/Prefs.php +++ b/framework/Prefs/lib/Horde/Prefs.php @@ -253,10 +253,6 @@ class Horde_Prefs $result = $this->_setValue($pref, $val, true, $convert); - if ($this->_opts['logger']) { - $this->_opts['logger']->log(__CLASS__ . ': Storing preference value (' . $pref . ')', 'DEBUG'); - } - if ($result && $this->isDirty($pref)) { $scope = $this->_getPreferenceScope($pref); $this->_cacheUpdate($scope, array($pref)); @@ -296,8 +292,6 @@ class Horde_Prefs */ protected function _setValue($pref, $val, $dirty = true, $convert = true) { - global $conf; - if ($convert) { $val = $this->convertToDriver($val); } @@ -332,6 +326,10 @@ class Horde_Prefs // Finally, copy into the $_scopes array. $this->_scopes[$this->_getPreferenceScope($pref)][$pref] = $this->_prefs[$pref]; + if ($this->_opts['logger']) { + $this->_opts['logger']->log(__CLASS__ . ': Storing preference value (' . $pref . ')', 'DEBUG'); + } + return true; } -- 2.11.0