From c2f3c232e47ef4f2e2cf5e6e2b946ee7aa1f2f83 Mon Sep 17 00:00:00 2001 From: Michael M Slusarz Date: Wed, 23 Dec 2009 02:00:20 -0700 Subject: [PATCH] Better keyboard navigation Up on first item (or no selection) cancels the selection. Down on last item doesn't move selection. --- horde/js/KeyNavList.js | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/horde/js/KeyNavList.js b/horde/js/KeyNavList.js index 026aba658..4a41d1561 100644 --- a/horde/js/KeyNavList.js +++ b/horde/js/KeyNavList.js @@ -245,24 +245,18 @@ var KeyNavList = Class.create({ markPrevious: function() { - var elt; - - if (this.selected) { - elt = this.selected.previous(); - } - - this.markSelected((!this.selected || !elt) ? this.div.down().childElements().last() : elt); + this.markSelected(this.selected ? this.selected.previous() : null); }, markNext: function() { - var elt; + var elt = this.selected + ? this.selected.next() + : this.div.down().childElements().first(); - if (this.selected) { - elt = this.selected.next(); + if (elt) { + this.markSelected(elt); } - - this.markSelected((!this.selected || !elt) ? this.div.down().childElements().first() : elt); }, getCurrentEntry: function() -- 2.11.0