From c5e0dcadef475416aabf70bb495adc9f93591ab0 Mon Sep 17 00:00:00 2001 From: "Michael J. Rubinsky" Date: Fri, 31 Jul 2009 13:31:55 -0400 Subject: [PATCH] Simplify --- ansel/lib/View/EmbeddedRenderer/GalleryLink.php | 19 +------------------ ansel/lib/View/EmbeddedRenderer/Mini.php | 21 +-------------------- ansel/lib/View/EmbeddedRenderer/Slideshow.php | 9 +++------ 3 files changed, 5 insertions(+), 44 deletions(-) diff --git a/ansel/lib/View/EmbeddedRenderer/GalleryLink.php b/ansel/lib/View/EmbeddedRenderer/GalleryLink.php index 35bbe2472..973354e1c 100644 --- a/ansel/lib/View/EmbeddedRenderer/GalleryLink.php +++ b/ansel/lib/View/EmbeddedRenderer/GalleryLink.php @@ -24,28 +24,11 @@ class Ansel_View_EmbeddedRenderer_GalleryLink extends Ansel_View_Gallery { /** - * Create a new renderer. - * - * @see Ansel_View_Embedded - * - * @param array $params - * - * @return Ansel_View_EmbeddedRenderer The renderer object. - */ - function makeView($params = array()) - { - $view = new Ansel_View_EmbeddedRenderer_GalleryLink(); - $view->_params = $params; - - return $view; - } - - /** * Build the javascript that will render the view. * * @return string A string containing valid javascript. */ - function html() + public function html() { /* Read in parameters and set defaults */ diff --git a/ansel/lib/View/EmbeddedRenderer/Mini.php b/ansel/lib/View/EmbeddedRenderer/Mini.php index a8743d11b..6d6e804a3 100644 --- a/ansel/lib/View/EmbeddedRenderer/Mini.php +++ b/ansel/lib/View/EmbeddedRenderer/Mini.php @@ -13,31 +13,12 @@ class Ansel_View_EmbeddedRenderer_Mini extends Ansel_View_Gallery { /** - * Create a new renderer. - * - * @see Ansel_View_Embedded - * - * @param array $params - * - * @return Ansel_View_EmbeddedRenderer The renderer object. - */ - function makeView($params = array()) - { - $view = new Ansel_View_EmbeddedRenderer_Mini(); - $view->_params = $params; - - return $view; - } - - /** * Build the javascript that will render the view. * * @return string A string containing valid javascript. */ - function html() + public function html() { - /* Read in parameters and set defaults */ - /* Required */ $node = $this->_params['container']; if (empty($node)) { diff --git a/ansel/lib/View/EmbeddedRenderer/Slideshow.php b/ansel/lib/View/EmbeddedRenderer/Slideshow.php index 139b01728..8dd80849c 100644 --- a/ansel/lib/View/EmbeddedRenderer/Slideshow.php +++ b/ansel/lib/View/EmbeddedRenderer/Slideshow.php @@ -21,12 +21,9 @@ class Ansel_View_EmbeddedRenderer_Slideshow extends Ansel_View_Gallery * * @return Ansel_View_EmbeddedRenderer The renderer object. */ - function makeView($params = array()) + public function __construct($params = array()) { - $view = new Ansel_View_EmbeddedRenderer_Carousel(); - $view->_params = $params; - - return $view; + parent::__construct($params); } /** @@ -34,7 +31,7 @@ class Ansel_View_EmbeddedRenderer_Slideshow extends Ansel_View_Gallery * * @return string A string containing valid javascript. */ - function html() + public function html() { } -- 2.11.0