From c92729ed228294b9d29b8a0e73be90e06ff45ab7 Mon Sep 17 00:00:00 2001 From: Michael M Slusarz Date: Wed, 20 Jan 2010 12:16:21 -0700 Subject: [PATCH] Too many htmlspecialchars in link() for title attribute For example, things like '<' should be specified as '<', NOT '&<' --- framework/Core/lib/Horde.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/framework/Core/lib/Horde.php b/framework/Core/lib/Horde.php index f764f8b25..16aa95382 100644 --- a/framework/Core/lib/Horde.php +++ b/framework/Core/lib/Horde.php @@ -1293,9 +1293,8 @@ HTML; $old_error = error_reporting(0); $title = str_replace( array("\r", "\n"), '', - htmlspecialchars( - nl2br(htmlspecialchars($title, ENT_QUOTES, $charset)), - ENT_QUOTES, $charset)); + nl2br(htmlspecialchars($title, ENT_QUOTES, $charset)) + ); error_reporting($old_error); } $attributes['title.raw'] = $title; -- 2.11.0