From d6aaf4b4dcac5b3b769c70b0c2c02187beb335ef Mon Sep 17 00:00:00 2001 From: Chuck Hagenbuch Date: Sun, 24 May 2009 15:53:11 -0400 Subject: [PATCH] return Horde_Date objects instead of DateTime, and for date fields, set the default format to Y-m-d Horde_Date has a __toString() method, making it more compatible with the old non-casting behavior, and it's also more, well, Horde-ish. --- framework/Db/lib/Horde/Db/Adapter/Abstract/Column.php | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/framework/Db/lib/Horde/Db/Adapter/Abstract/Column.php b/framework/Db/lib/Horde/Db/Adapter/Abstract/Column.php index bbf60e9a8..4536f3034 100644 --- a/framework/Db/lib/Horde/Db/Adapter/Abstract/Column.php +++ b/framework/Db/lib/Horde/Db/Adapter/Abstract/Column.php @@ -211,10 +211,8 @@ class Horde_Db_Adapter_Abstract_Column } /** - * @TODO Return a Horde_Date object instead? - * * @param string $string - * @return DateTime + * @return Horde_Date */ public function stringToDate($string) { @@ -224,14 +222,15 @@ class Horde_Db_Adapter_Abstract_Column return null; } - return new DateTime($string); + $d = new Horde_Date($string); + $d->setDefaultFormat('Y-m-d'); + + return $d; } /** - * @TODO Return a Horde_Date object instead? - * * @param string $string - * @return DateTime + * @return Horde_Date */ public function stringToTime($string) { @@ -241,14 +240,14 @@ class Horde_Db_Adapter_Abstract_Column return null; } - return new DateTime($string); + return new Horde_Date($string); } /** * @TODO Return a Horde_Date object instead? * * @param string $string - * @return DateTime + * @return Horde_Date */ public function stringToDummyTime($value) { -- 2.11.0