From d80a637f1af7643e33582eb483ebb5954ea88513 Mon Sep 17 00:00:00 2001 From: Michael M Slusarz Date: Fri, 23 Jul 2010 16:46:00 -0600 Subject: [PATCH] Fix mailto: processing for link tags with pre-existing target attribute --- imp/lib/Mime/Viewer/Html.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/imp/lib/Mime/Viewer/Html.php b/imp/lib/Mime/Viewer/Html.php index 69fe92ec3..489b80749 100644 --- a/imp/lib/Mime/Viewer/Html.php +++ b/imp/lib/Mime/Viewer/Html.php @@ -283,12 +283,12 @@ class IMP_Horde_Mime_Viewer_Html extends Horde_Mime_Viewer_Html /* Convert links to open in new windows. Ignore * mailto: links, links that have an "#xyz" anchor, * and links that already have a target. */ - if (!$node->hasAttribute('target') && - $node->hasAttribute('href')) { + if ($node->hasAttribute('href')) { $url = parse_url($node->getAttribute('href')); if (isset($url['scheme']) && ($url['scheme'] == 'mailto')) { $node->setAttribute('href', IMP::composeLink($node->getAttribute('href'))); - } elseif (empty($url['fragment'])) { + } elseif (!$node->hasAttribute('target') && + empty($url['fragment'])) { $node->setAttribute('target', $this->_imptmp['target']); } } -- 2.11.0