From d9cdd828c3293ec11321cbeabb78ac3cbdcc4bdd Mon Sep 17 00:00:00 2001 From: Gunnar Wrobel Date: Wed, 28 Apr 2010 00:54:04 +0200 Subject: [PATCH] The namespace handler is part of the driver. --- .../lib/Horde/Kolab/Storage/Driver.php | 2 +- .../lib/Horde/Kolab/Storage/Driver/Base.php | 6 +-- .../Horde/Kolab/Storage/Driver/Decorator/Base.php | 2 +- .../Horde/Kolab/Storage/Driver/Decorator/Log.php | 2 +- .../lib/Horde/Kolab/Storage/Driver/Imap.php | 4 +- .../Horde/Kolab/Storage/{ => Driver}/Namespace.php | 12 ++--- .../Storage/{ => Driver}/Namespace/Config.php | 14 ++--- .../Storage/{ => Driver}/Namespace/Element.php | 2 +- .../{ => Driver}/Namespace/Element/Other.php | 8 +-- .../{ => Driver}/Namespace/Element/Personal.php | 8 +-- .../{ => Driver}/Namespace/Element/Shared.php | 8 +-- .../Namespace/Element/SharedWithPrefix.php | 4 +- .../Kolab/Storage/{ => Driver}/Namespace/Fixed.php | 14 ++--- .../Kolab/Storage/{ => Driver}/Namespace/Imap.php | 8 +-- .../lib/Horde/Kolab/Storage/Driver/Pear.php | 4 +- .../lib/Horde/Kolab/Storage/Folder/Base.php | 4 +- framework/Kolab_Storage/package.xml | 60 ++++++++++++---------- .../test/Horde/Kolab/Storage/AclTest.php | 6 +-- .../Kolab/Storage/Class/Driver/CclientTest.php | 2 +- .../Horde/Kolab/Storage/Class/Driver/ImapTest.php | 2 +- .../Horde/Kolab/Storage/Class/Driver/MockTest.php | 2 +- .../Horde/Kolab/Storage/Class/Driver/PearTest.php | 2 +- .../test/Horde/Kolab/Storage/FolderTest.php | 4 +- .../test/Horde/Kolab/Storage/NamespaceTest.php | 18 +++---- .../test/Horde/Kolab/Storage/PermissionTest.php | 8 +-- 25 files changed, 105 insertions(+), 101 deletions(-) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace.php (93%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Config.php (74%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Element.php (98%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Element/Other.php (80%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Element/Personal.php (61%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Element/Shared.php (62%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Element/SharedWithPrefix.php (88%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Fixed.php (69%) rename framework/Kolab_Storage/lib/Horde/Kolab/Storage/{ => Driver}/Namespace/Imap.php (82%) diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver.php index 1f5ef55df..8ae25f5de 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver.php @@ -219,7 +219,7 @@ interface Horde_Kolab_Storage_Driver /** * Retrieve the namespace information for this connection. * - * @return Horde_Kolab_Storage_Namespace The initialized namespace handler. + * @return Horde_Kolab_Storage_Driver_Namespace The initialized namespace handler. */ public function getNamespace(); diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Base.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Base.php index 33af192e4..08ee39591 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Base.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Base.php @@ -70,16 +70,16 @@ implements Horde_Kolab_Storage_Driver /** * Retrieve the namespace information for this connection. * - * @return Horde_Kolab_Storage_Namespace The initialized namespace handler. + * @return Horde_Kolab_Storage_Driver_Namespace The initialized namespace handler. */ public function getNamespace() { if (isset($this->_params['namespaces'])) { - return new Horde_Kolab_Storage_Namespace_Config( + return new Horde_Kolab_Storage_Driver_Namespace_Config( $this->_params['namespaces'] ); } - return new Horde_Kolab_Storage_Namespace_Fixed(); + return new Horde_Kolab_Storage_Driver_Namespace_Fixed(); } /** diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Base.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Base.php index 87b061ec6..e7aef4e5d 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Base.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Base.php @@ -258,7 +258,7 @@ implements Horde_Kolab_Storage_Driver /** * Retrieve the namespace information for this connection. * - * @return Horde_Kolab_Storage_Namespace The initialized namespace handler. + * @return Horde_Kolab_Storage_Driver_Namespace The initialized namespace handler. */ public function getNamespace() { diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Log.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Log.php index 0f118f9b9..1f9c8b938 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Log.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Decorator/Log.php @@ -258,7 +258,7 @@ extends Horde_Kolab_Storage_Driver_Decorator_Base /** * Retrieve the namespace information for this connection. * - * @return Horde_Kolab_Storage_Namespace The initialized namespace handler. + * @return Horde_Kolab_Storage_Driver_Namespace The initialized namespace handler. */ public function getNamespace() { diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Imap.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Imap.php index 1f1bf10fd..1dc0e8c51 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Imap.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Imap.php @@ -403,12 +403,12 @@ extends Horde_Kolab_Storage_Driver_Base /** * Retrieve the namespace information for this connection. * - * @return Horde_Kolab_Storage_Namespace The initialized namespace handler. + * @return Horde_Kolab_Storage_Driver_Namespace The initialized namespace handler. */ public function getNamespace() { if ($this->_imap->queryCapability('NAMESPACE') === true) { - return new Horde_Kolab_Storage_Namespace_Imap( + return new Horde_Kolab_Storage_Driver_Namespace_Imap( $this->_imap->getNamespaces(), $this->getParam('namespaces', array()) ); diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace.php similarity index 93% rename from framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace.php rename to framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace.php index d162881f5..a3a2639a2 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace.php @@ -1,6 +1,6 @@ _sharedPrefix = $element['prefix']; } else { - $class = 'Horde_Kolab_Storage_Namespace_Element_' . ucfirst($element['type']); + $class = 'Horde_Kolab_Storage_Driver_Namespace_Element_' . ucfirst($element['type']); $namespace_element = new $class($element['name'], $element['delimiter']); } if (empty($element['name'])) { diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace/Element.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace/Element.php similarity index 98% rename from framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace/Element.php rename to framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace/Element.php index fb1ab2e7c..86c6ecd9b 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace/Element.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace/Element.php @@ -1,6 +1,6 @@ _namespaces = array($personal, $other); $this->_any = $shared; diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace/Imap.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace/Imap.php similarity index 82% rename from framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace/Imap.php rename to framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace/Imap.php index b9f41aef0..20d0314c4 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Namespace/Imap.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Driver/Namespace/Imap.php @@ -1,6 +1,6 @@ getParam('namespaces', array()) ); diff --git a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Folder/Base.php b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Folder/Base.php index aba5f6f14..8e91fa57f 100644 --- a/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Folder/Base.php +++ b/framework/Kolab_Storage/lib/Horde/Kolab/Storage/Folder/Base.php @@ -496,10 +496,10 @@ implements Horde_Kolab_Storage_Folder * rather than in a module nearer to the applications. */ switch ($owner) { - case Horde_Kolab_Storage_Namespace::PERSONAL: + case Horde_Kolab_Storage_Driver_Namespace::PERSONAL: $this->_owner = $this->_driver->getAuth(); break; - case Horde_Kolab_Storage_Namespace::SHARED: + case Horde_Kolab_Storage_Driver_Namespace::SHARED: $this->_owner = 'anonymous'; break; default: diff --git a/framework/Kolab_Storage/package.xml b/framework/Kolab_Storage/package.xml index 4fa835795..4f28ea440 100644 --- a/framework/Kolab_Storage/package.xml +++ b/framework/Kolab_Storage/package.xml @@ -31,8 +31,8 @@ jan@horde.org yes - 2010-04-27 - + 2010-04-28 + 0.4.0 0.1.0 @@ -78,10 +78,23 @@ + + + + + + + + + + + + + @@ -112,24 +125,11 @@ - - - - - - - - - - - - - @@ -139,9 +139,7 @@ - - - + @@ -152,7 +150,10 @@ + + + @@ -260,14 +261,22 @@ - + + + + + + + + + @@ -286,14 +295,6 @@ - - - - - - - - @@ -308,7 +309,10 @@ + + + @@ -380,7 +384,7 @@ alpha alpha - 2010-04-27 + 2010-04-28 LGPL * Added namespace support (Bug #6691). diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/AclTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/AclTest.php index 109d8b28e..f115c1f50 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/AclTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/AclTest.php @@ -45,17 +45,17 @@ class Horde_Kolab_Storage_AclTest extends PHPUnit_Framework_TestCase array( array( 'name' => 'INBOX/', - 'type' => Horde_Kolab_Storage_Namespace::PERSONAL, + 'type' => Horde_Kolab_Storage_Driver_Namespace::PERSONAL, 'delimiter' => '/', ), array( 'name' => 'user/', - 'type' => Horde_Kolab_Storage_Namespace::OTHER, + 'type' => Horde_Kolab_Storage_Driver_Namespace::OTHER, 'delimiter' => '/', ), array( 'name' => '', - 'type' => Horde_Kolab_Storage_Namespace::SHARED, + 'type' => Horde_Kolab_Storage_Driver_Namespace::SHARED, 'delimiter' => '/', ) ) diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/CclientTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/CclientTest.php index 75e96f150..86963780c 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/CclientTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/CclientTest.php @@ -51,7 +51,7 @@ extends PHPUnit_Framework_TestCase array() ); $this->assertType( - 'Horde_Kolab_Storage_Namespace', + 'Horde_Kolab_Storage_Driver_Namespace', $driver->getNamespace() ); } diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/ImapTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/ImapTest.php index f52ae749c..754643420 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/ImapTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/ImapTest.php @@ -52,7 +52,7 @@ extends PHPUnit_Framework_TestCase array() ); $this->assertType( - 'Horde_Kolab_Storage_Namespace', + 'Horde_Kolab_Storage_Driver_Namespace', $driver->getNamespace() ); } diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/MockTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/MockTest.php index aaed02546..78a645f50 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/MockTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/MockTest.php @@ -67,7 +67,7 @@ extends PHPUnit_Framework_TestCase array() ); $this->assertType( - 'Horde_Kolab_Storage_Namespace', + 'Horde_Kolab_Storage_Driver_Namespace', $driver->getNamespace() ); } diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/PearTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/PearTest.php index 17d2224de..5607858e8 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/PearTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/Class/Driver/PearTest.php @@ -52,7 +52,7 @@ extends PHPUnit_Framework_TestCase array() ); $this->assertType( - 'Horde_Kolab_Storage_Namespace', + 'Horde_Kolab_Storage_Driver_Namespace', $driver->getNamespace() ); } diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/FolderTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/FolderTest.php index 5c6b9fef8..da160bff6 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/FolderTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/FolderTest.php @@ -66,7 +66,7 @@ class Horde_Kolab_Storage_FolderTest extends PHPUnit_Framework_TestCase $GLOBALS['language'] = 'de_DE'; $folder = new Horde_Kolab_Storage_Folder_Base( 'INBOX/Contacts', - new Horde_Kolab_Storage_Namespace_Fixed() + new Horde_Kolab_Storage_Driver_Namespace_Fixed() ); $this->assertEquals('INBOX/Contacts', $folder->name); $this->assertTrue(is_array($folder->_data)); @@ -84,7 +84,7 @@ class Horde_Kolab_Storage_FolderTest extends PHPUnit_Framework_TestCase $connection = $this->getMock('Horde_Kolab_Storage_Driver'); $connection->expects($this->once()) ->method('getNamespace') - ->will($this->returnValue(new Horde_Kolab_Storage_Namespace_Fixed())); + ->will($this->returnValue(new Horde_Kolab_Storage_Driver_Namespace_Fixed())); $folder = new Horde_Kolab_Storage_Folder_Base('INBOX/Contacts'); $folder->restore($storage, $connection); $folder->setName('TestAÖÜ'); diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/NamespaceTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/NamespaceTest.php index 9af29823a..bbdce741e 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/NamespaceTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/NamespaceTest.php @@ -266,43 +266,43 @@ class Horde_Kolab_Storage_NamespaceTest extends PHPUnit_Framework_TestCase private function _getNamespaces() { return array( - new Horde_Kolab_Storage_Namespace_Fixed(), - new Horde_Kolab_Storage_Namespace_Config( + new Horde_Kolab_Storage_Driver_Namespace_Fixed(), + new Horde_Kolab_Storage_Driver_Namespace_Config( array( array( - 'type' => Horde_Kolab_Storage_Namespace::PERSONAL, + 'type' => Horde_Kolab_Storage_Driver_Namespace::PERSONAL, 'name' => 'INBOX/', 'delimiter' => '/', 'add' => true, ), array( - 'type' => Horde_Kolab_Storage_Namespace::OTHER, + 'type' => Horde_Kolab_Storage_Driver_Namespace::OTHER, 'name' => 'user/', 'delimiter' => '/', ), array( - 'type' => Horde_Kolab_Storage_Namespace::SHARED, + 'type' => Horde_Kolab_Storage_Driver_Namespace::SHARED, 'name' => '', 'delimiter' => '/', 'prefix' => 'shared.' ), ) ), - new Horde_Kolab_Storage_Namespace_Imap( + new Horde_Kolab_Storage_Driver_Namespace_Imap( array( array( 'name' => 'INBOX/', - 'type' => Horde_Kolab_Storage_Namespace::PERSONAL, + 'type' => Horde_Kolab_Storage_Driver_Namespace::PERSONAL, 'delimiter' => '/', ), array( 'name' => 'user/', - 'type' => Horde_Kolab_Storage_Namespace::OTHER, + 'type' => Horde_Kolab_Storage_Driver_Namespace::OTHER, 'delimiter' => '/', ), array( 'name' => '', - 'type' => Horde_Kolab_Storage_Namespace::SHARED, + 'type' => Horde_Kolab_Storage_Driver_Namespace::SHARED, 'delimiter' => '/', ), ), diff --git a/framework/Kolab_Storage/test/Horde/Kolab/Storage/PermissionTest.php b/framework/Kolab_Storage/test/Horde/Kolab/Storage/PermissionTest.php index 47aec9e9d..8add6edd7 100644 --- a/framework/Kolab_Storage/test/Horde/Kolab/Storage/PermissionTest.php +++ b/framework/Kolab_Storage/test/Horde/Kolab/Storage/PermissionTest.php @@ -124,10 +124,10 @@ class Horde_Kolab_Storage_PermissionTest extends PHPUnit_Framework_TestCase ->method('getNamespace') ->will( $this->returnValue( - new Horde_Kolab_Storage_Namespace_Imap( + new Horde_Kolab_Storage_Driver_Namespace_Imap( array( array( - 'type' => Horde_Kolab_Storage_Namespace::PERSONAL, + 'type' => Horde_Kolab_Storage_Driver_Namespace::PERSONAL, 'name' => 'INBOX/', 'delimiter' => '/', 'add' => true, @@ -257,10 +257,10 @@ class Horde_Kolab_Storage_PermissionTest extends PHPUnit_Framework_TestCase ->method('getNamespace') ->will( $this->returnValue( - new Horde_Kolab_Storage_Namespace_Imap( + new Horde_Kolab_Storage_Driver_Namespace_Imap( array( array( - 'type' => Horde_Kolab_Storage_Namespace::PERSONAL, + 'type' => Horde_Kolab_Storage_Driver_Namespace::PERSONAL, 'name' => 'INBOX/', 'delimiter' => '/', 'add' => true, -- 2.11.0